From 7cd12e7dc537cd7d48df463cb1a0c81e8bf016a6 Mon Sep 17 00:00:00 2001 From: Olivier Goffart Date: Tue, 7 May 2013 17:16:11 +0200 Subject: [PATCH] remove some FIXME --- src/mirall/owncloudpropagator.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mirall/owncloudpropagator.cpp b/src/mirall/owncloudpropagator.cpp index f54b2ef91..b31f927a5 100644 --- a/src/mirall/owncloudpropagator.cpp +++ b/src/mirall/owncloudpropagator.cpp @@ -58,7 +58,8 @@ csync_instructions_e OwncloudPropagator::propagate(const SyncFileItem &item) } //fall trough case CSYNC_INSTRUCTION_SYNC: if (item._isDirectory) { - return CSYNC_INSTRUCTION_UPDATED; //FIXME + // Should we set the mtime? + return CSYNC_INSTRUCTION_UPDATED; } else { return item._dir == SyncFileItem::Down ? downloadFile(item) : uploadFile(item); } @@ -136,9 +137,6 @@ csync_instructions_e OwncloudPropagator::localRemove(const SyncFileItem& item) return CSYNC_INSTRUCTION_DELETED; _errorString = file.errorString(); } - //FIXME: we should update the md5 - _etag.clear(); - //FIXME: we should update the mtime return CSYNC_INSTRUCTION_NONE; // not ERROR so it is still written to the database } @@ -146,7 +144,7 @@ csync_instructions_e OwncloudPropagator::localMkdir(const SyncFileItem &item) { QDir d; if (!d.mkpath(_localDir + item._file)) { - //FIXME: errorString + _errorString = "could not create directory " + _localDir + item._file; return CSYNC_INSTRUCTION_ERROR; } return CSYNC_INSTRUCTION_UPDATED; @@ -194,8 +192,6 @@ csync_instructions_e OwncloudPropagator::uploadFile(const SyncFileItem &item) } QScopedPointer uri(ne_path_escape((_remoteDir + item._file).toUtf8())); - //TODO: FIXME: check directory - bool finished = true; int attempts = 0; /*