ardevd
ffb9ad4151
data: Added private constructor for the Injection utility class.
...
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.
Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
2018-05-02 16:15:46 +02:00
ardevd
ab6fa36f9b
activities: Use isEmpty() to check whether the list of activities is empty.
...
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant
2018-05-02 16:12:47 +02:00
ardevd
4d786a3f41
activities: Added @Override annotation above the onDestroy() method signature.
...
Using the @Override annotation is useful for two reasons:
It elicits a warning from the compiler if the annotated method doesn't actually override anything, as in the case of a misspelling.
It improves the readability of the source code by making it obvious that methods are overridden.
2018-05-02 16:11:11 +02:00
Andy Scherzinger
217d3c3bc8
Merge pull request #2504 from nextcloud/2474-feature-mvp-activities
...
[MVP] Refactored the Activities activity
2018-05-02 15:48:13 +02:00
Andy Scherzinger
66deeb7731
Merge branch 'master' into 2474-feature-mvp-activities
2018-05-02 15:39:15 +02:00
Andy Scherzinger
81b560cf5e
Merge pull request #2537 from nextcloud/passcodemanager-cleanup
...
PassCodeManager cleanup
2018-05-02 15:36:51 +02:00
ardevd
385bb429c7
passcodemanager: Reordered auth type check statements.
2018-05-02 14:45:15 +02:00
ardevd
2f0464d6e4
passcodemanager: Simplified passcode/fingerprint auth timeout check.
2018-05-02 14:37:06 +02:00
ardevd
40e3c050b2
authentication:passcodemanager: long literal '0l' should be 0L.
...
The suffix L is preferred, because the letter l (ell) is often hard to distinguish from the digit 1 (one).
2018-05-02 14:34:08 +02:00
ardevd
6fcfa840b7
authentication:passcodemanager: Cleaned up variable naming.
2018-05-02 14:19:36 +02:00
ardevd
b8cde0fa86
authentication:passcodemanager: Stricter variable declaration.
2018-05-02 13:56:28 +02:00
ardevd
2615926163
authentication:passcodemanager: Simplified if-statements.
2018-05-02 13:55:07 +02:00
ardevd
81f72a50c4
authentication:passcodemanager: Stricter access declaration.
2018-05-02 13:54:39 +02:00
ardevd
786ffd2c44
authentication:passcodemanager: Explicit argument type removed.
2018-05-02 13:53:56 +02:00
ardevd
c8b3f1e168
data:activities Added newline at the bottom.
2018-05-02 13:50:18 +02:00
ardevd
81f4f2a767
authentication: Cleaned up variable name in PassCodeManager.
2018-05-02 13:45:17 +02:00
ardevd
c079d8c285
data:files Properly return callback.onError if remoteOcFile is null.
2018-05-02 13:08:22 +02:00
ardevd
49d0ccac7d
data:files Cleaned up onPostExecute() if-statements.
2018-05-02 12:54:43 +02:00
ardevd
9efa675c2a
activities: Removed hungarian variable name notation.
2018-05-02 12:38:33 +02:00
Nextcloud bot
0556586232
[tx-robot] updated from transifex
2018-04-30 00:41:33 +00:00
eho
07770a2268
activities: Added copyright headers
2018-04-29 19:49:54 +02:00
Nextcloud bot
8a1cb0b37a
[tx-robot] updated from transifex
2018-04-29 00:44:16 +00:00
Nextcloud bot
f84db51efa
[tx-robot] updated from transifex
2018-04-28 00:42:16 +00:00
Nextcloud bot
cd48dd7335
[tx-robot] updated from transifex
2018-04-27 00:42:51 +00:00
Tobias Kaminsky
2963e1325e
daily dev 20180427
2018-04-27 00:32:12 +02:00
Andy Scherzinger
46d1d3bf68
Merge pull request #2509 from nextcloud/lintFixes
...
fix more lint issues
2018-04-26 21:01:46 +02:00
nextcloud-android-bot
de8a12400b
Drone: update Lint results to reflect reduced error/warning count [skip ci]
2018-04-26 18:01:41 +02:00
AndyScherzinger
e823a55c1c
svg file for account icon
2018-04-26 18:01:41 +02:00
AndyScherzinger
6f60447665
lint: fix implicitly using the default locale is a common source of bugs: Use toLowerCase(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault().
2018-04-26 18:01:40 +02:00
AndyScherzinger
9916aecfa9
lint: fix set android:baselineAligned="false" on this element for better performance
2018-04-26 18:01:39 +02:00
AndyScherzinger
b8a4c4e8d6
lint: fix the image ic_favorite.png varies significantly in its density-independent (dip) size across the various density versions (ic_ needs to comply with standard icon sizes)
2018-04-26 18:01:39 +02:00
AndyScherzinger
34e9b55632
lint: fix the image ic_account_circle.png varies significantly in its density-independent (dip) size across the various density versions
2018-04-26 18:01:38 +02:00
AndyScherzinger
ee736ce214
lint: fix This tag and its children can be replaced by one <TextView/> and a compound drawable _and_ unnecessary parent element
2018-04-26 18:01:37 +02:00
AndyScherzinger
4a8de18d49
lint: fix attribute networkSecurityConfig is only used in API level 24 and higher (current min is 14)
2018-04-26 18:01:37 +02:00
AndyScherzinger
6b6716dc72
lint: fix attribute splitTrack is only used in API level 21 and higher (current min is 14)
2018-04-26 18:01:36 +02:00
AndyScherzinger
ea2ed935f9
lint: Fix the resource R.string.upload_list_loading appears to be unused
2018-04-26 18:01:35 +02:00
AndyScherzinger
3e1d80af43
lint: fix the resource R.layout.list_fragment_expandable appears to be unused
2018-04-26 18:01:35 +02:00
AndyScherzinger
8ec30ad52f
lint: fix possible overdraw: Root element paints background @color/background_color with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar)
2018-04-26 18:01:30 +02:00
Andy Scherzinger
ab3230775a
Merge pull request #2512 from nextcloud/2507-bugfix-intentmode
...
Preferences: Don't start FileDisplayActivity when pressing the back button
2018-04-26 17:57:50 +02:00
Andy Scherzinger
f32cb018d8
Merge pull request #2511 from nextcloud/unknownErrorMessage
...
added more information on initial connection error
2018-04-26 14:13:41 +02:00
AndyScherzinger
bca8c493ab
Fix CR
2018-04-26 13:18:45 +02:00
AndyScherzinger
382f4942ae
Fix CR
2018-04-26 13:16:01 +02:00
AndyScherzinger
9ef32d8847
Fix CR
2018-04-26 13:16:01 +02:00
AndyScherzinger
1167d46d93
added more information on initial connection error
2018-04-26 13:16:00 +02:00
Tobias Kaminsky
957a1f7012
Update README.md
...
Add logcat filtering by process id.
2018-04-26 11:51:24 +02:00
eho
7982c08c13
Preferences: Don't launch a new intent when hitting the back button.
...
It doesn't really make sense to launch a hard coded activity when navigating back from the Preferences activity. The expected behavior is probably to return the user to the previous activity rather than always throwing them back to the FileDisplayActivity.
2018-04-26 11:24:55 +02:00
tobiasKaminsky
f6c650d046
Activites -> Activities
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-04-26 11:13:18 +02:00
ardevd
e4b20211ec
data: Removed unused private fields.
2018-04-26 10:18:20 +02:00
Tobias Kaminsky
f150929566
Update lint-results.txt
...
add 4 warnings due to firebase warnings
2018-04-26 09:56:42 +02:00
ardevd
da931e44dc
activities: Set nextPageUrl to null when manually refreshing activities.
...
When the user swipes the recycler view to refresh the list of activities we want the list to be cleared and populated with the newest activities without loading all the other paginated activities that might have been loaded up to that point. Therefore we set the nextPageUrl variable to null in the setOnRefreshListener for the swipeRefreshLayout.
2018-04-26 08:45:07 +02:00
