Commit graph

12206 commits

Author SHA1 Message Date
Andy Scherzinger
eaebc1235e
findbugs: MS_PKGPROTECT: Field should be package protected
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-07 19:21:22 +01:00
Andy Scherzinger
5b6ad9add1
findbug: SUI_CONTAINS_BEFORE_REMOVE: Method checks for an item in a set with contains, before using remove()
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-07 19:17:19 +01:00
Andy Scherzinger
e1feb49fe1
findbugs: SPP_EQUALS_ON_ENUM
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-07 19:14:53 +01:00
Andy Scherzinger
411bbd02cf
improve findbugs scoring
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-07 18:36:45 +01:00
Andy Scherzinger
2860d4cbed
remove unused class
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-07 18:20:58 +01:00
Andy Scherzinger
cb090dd2f1
Merge pull request #3583 from nextcloud/preventNPE
PreviewImageFragment: prevent NPE if activity is null
2019-02-07 14:25:39 +01:00
Andy Scherzinger
43323e1669
Merge pull request #3582 from nextcloud/showITurlOnError
Show IT Url on Error
2019-02-07 08:51:09 +01:00
tobiasKaminsky
50c951cbe7
prevent NPE if activity is null
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-07 08:25:54 +01:00
tobiasKaminsky
93f52c463d
Show failing test url as comment in github
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-07 08:10:56 +01:00
Andy Scherzinger
d9e3a83446
Merge pull request #3581 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-3.3.1
Bump gradle from 3.3.0 to 3.3.1
2019-02-07 07:47:31 +01:00
dependabot[bot]
89e92e276c
Bump gradle from 3.3.0 to 3.3.1
Bumps gradle from 3.3.0 to 3.3.1.

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-02-07 02:19:09 +00:00
Nextcloud bot
17cfcefae5
[tx-robot] updated from transifex 2019-02-07 01:54:17 +00:00
Tobias Kaminsky
97ec3464fe daily dev 20190207 2019-02-07 00:34:27 +01:00
Andy Scherzinger
3e79e4f026
Merge pull request #3578 from nextcloud/cleanupActivity
Use getter instead of direct access of Activity
2019-02-06 18:50:35 +01:00
Andy Scherzinger
a5af94d986
set lib to master
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-06 17:53:53 +01:00
tobiasKaminsky
2394230a7b
use getter instead of direct access of Activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-06 17:53:18 +01:00
Andy Scherzinger
ac4bcc7a72
Merge pull request #3573 from nextcloud/crashOnLoginURL
Remove exception
2019-02-06 14:19:03 +01:00
tobiasKaminsky
f92c6b9170
fix tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-06 12:39:11 +01:00
tobiasKaminsky
ca362c250d
remove exception
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-06 09:50:52 +01:00
Andy Scherzinger
8475a041fb
Merge pull request #3572 from nextcloud/smallThumbnails
Local file list: make image/videos properly sized again
2019-02-06 09:47:32 +01:00
Nextcloud bot
26e3c606b5
[tx-robot] updated from transifex 2019-02-06 08:18:27 +00:00
tobiasKaminsky
fe794f5a40
make image/videos great again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-06 09:06:43 +01:00
Tobias Kaminsky
5584ae8bd7 daily dev 20190206 2019-02-06 00:33:09 +01:00
Andy Scherzinger
fbdc024092
Merge pull request #3564 from nextcloud/moveThumbnailCache
Migrate thumbnail cache from external to internal cache location
2019-02-05 17:56:15 +01:00
nextcloud-android-bot
d0e9a86ca0 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-02-05 16:29:20 +00:00
Tobias Kaminsky
c5f0174016
Merge a90f71e600 into ee1886cc96 2019-02-05 16:25:49 +00:00
Andy Scherzinger
a90f71e600
improve findbugs score bug making literals the left part of string comparisons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-05 17:25:33 +01:00
tobiasKaminsky
3527b2b7f7
migrate thumbnail cache from external to internal cache location
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-05 16:40:23 +01:00
Andy Scherzinger
ee1886cc96
Merge pull request #3568 from nextcloud/exitOnFirstRun
back press on first run activity closes app
2019-02-05 16:35:48 +01:00
tobiasKaminsky
b7089df901
back press on first run activity closes app
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-05 16:15:51 +01:00
Andy Scherzinger
db8940f6f7
Merge pull request #3570 from nextcloud/shareLinkOnPreview
Copy link action on image/video preview
2019-02-05 16:08:35 +01:00
tobiasKaminsky
cc4d340bd5
copy link action on image/video preview
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-05 14:01:46 +01:00
Tobias Kaminsky
aae0eac155
Merge pull request #3567 from nextcloud/sortFavorites
sort files after set/unset favorite
2019-02-05 12:48:59 +01:00
tobiasKaminsky
c74130b89b
sort files after set/unset favorite
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-05 11:46:55 +01:00
Tobias Kaminsky
df847a3f38 daily dev 20190205 2019-02-05 00:34:03 +01:00
nextcloud-android-bot
6e91162494 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-02-04 15:55:45 +00:00
Andy Scherzinger
73411d5f09
remove unused classes 2019-02-04 16:52:54 +01:00
Andy Scherzinger
5fb2f37170
rename variable for actual naming pattern
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-04 14:17:45 +01:00
Andy Scherzinger
d29e120f31
use lombok for constructors and getter/setter methods
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-04 14:15:15 +01:00
Andy Scherzinger
6188e7e05d
remove unused class
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-02-04 14:15:14 +01:00
Andy Scherzinger
29478a394b
Merge pull request #3558 from nextcloud/dependabot/gradle/org.mockito-mockito-core-2.24.0
Bump mockito-core from 2.23.4 to 2.24.0
2019-02-04 07:01:26 +01:00
dependabot[bot]
79fb99febc
Bump mockito-core from 2.23.4 to 2.24.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 2.23.4 to 2.24.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](https://github.com/mockito/mockito/compare/v2.23.4...v2.24.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-02-04 02:15:36 +00:00
Tobias Kaminsky
41e20972e2 daily dev 20190202 2019-02-02 00:33:06 +01:00
Tobias Kaminsky
023cd0a549
Merge pull request #3537 from nextcloud/notificationButtonColor
enhance notification buttons
2019-02-01 13:19:01 +01:00
tobiasKaminsky
dc41a2f7f0
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-01 10:57:12 +01:00
tobiasKaminsky
a127eac5e6
changed grey
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-01 10:32:19 +01:00
Andy Scherzinger
454fb0a547
Merge pull request #3538 from nextcloud/abortSyncIfNoInternet
if no internet connection, abort sync
2019-02-01 10:18:48 +01:00
Andy Scherzinger
492d70345e
Merge pull request #3541 from nextcloud/crashOnLocalFolder
Fix crash when selecting local folder
2019-02-01 10:17:25 +01:00
tobiasKaminsky
0a27760872
fix crash when selecting local folder
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-02-01 08:39:24 +01:00
Tobias Kaminsky
55ea5b43bf daily dev 20190201 2019-02-01 00:33:08 +01:00