Commit graph

10696 commits

Author SHA1 Message Date
eho
d5b500559e fragment:util: Added private constructor to hide the inherit public one
Utility classes, which are collections of static members, are not meant to be instantiated.

Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.
2018-06-09 23:06:12 +02:00
Andy Scherzinger
9d963cec33
Merge pull request #2686 from nextcloud/correctException
Use correct exception
2018-06-09 18:55:48 +02:00
Andy Scherzinger
258aae1c8d
Merge pull request #2669 from nextcloud/codacy
Codacy fixes
2018-06-09 18:53:12 +02:00
AndyScherzinger
fb094e7628
renamed due to CR 2018-06-09 14:23:17 +02:00
AndyScherzinger
eb6821dc25
codacy: organize imports 2018-06-09 14:23:17 +02:00
AndyScherzinger
f863ea9adc
extract UI init and show/hide parts in separate methods for a better overview 2018-06-09 14:23:16 +02:00
AndyScherzinger
7fb487f717
remove unused import 2018-06-09 14:23:16 +02:00
AndyScherzinger
05a0167255
extract open file intent creation into a separate method 2018-06-09 14:23:15 +02:00
AndyScherzinger
7d4a2ecfa8
change call order to not create unneeded objects before the checks haven't succeeded 2018-06-09 14:23:15 +02:00
AndyScherzinger
015aa06d79
use a more specific input param 2018-06-09 14:23:14 +02:00
AndyScherzinger
d663535ce6
extract credentials update notification 2018-06-09 14:23:14 +02:00
Andy Scherzinger
080acb2f8e
Merge pull request #2694 from nextcloud/whiteBadge
Tint badge to element color
2018-06-09 14:22:33 +02:00
Andy Scherzinger
84776053ff
Merge pull request #2689 from nextcloud/fixAuth
Auth: Do not use context on static
2018-06-09 13:44:48 +02:00
AndyScherzinger
75c61b2407
upgrade Android gradle plugin 2018-06-09 13:35:15 +02:00
tobiasKaminsky
59f1253a86
do not use static context
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-09 13:35:15 +02:00
Nextcloud bot
fe4b113b80
[tx-robot] updated from transifex 2018-06-09 00:47:24 +00:00
Nextcloud bot
711dd895e2
[tx-robot] updated from transifex 2018-06-08 00:47:35 +00:00
tobiasKaminsky
537a3b7eb9
tint badge to element color
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-07 14:57:21 +02:00
Nextcloud bot
bc374c8741
[tx-robot] updated from transifex 2018-06-07 00:46:20 +00:00
Tobias Kaminsky
1b128faff2 daily dev 20180607 2018-06-07 00:32:04 +02:00
Andy Scherzinger
d90c2d99c3
Merge pull request #2620 from nextcloud/utils-overrides
Minor cleanup of FileSortOrderByName and FileSortOrderBySize
2018-06-06 14:45:35 +02:00
AndyScherzinger
c439e84880
make sort by date package private 2018-06-06 14:38:52 +02:00
AndyScherzinger
34568caba7
120character print margin 2018-06-06 14:37:46 +02:00
AndyScherzinger
9ce8b19aed
use method expression lambdas to further shorten the code 2018-06-06 14:37:00 +02:00
AndyScherzinger
379c461f33
Also use lambda for sorting 2018-06-06 14:33:05 +02:00
eho
51eab2457d
util: Use lambdas where applicable in the FileSortOrderByName/Size classes. 2018-06-06 14:27:51 +02:00
eho
754419090d
util: Made FileSortOrderByName and FileSortOrderBySize package private.
- Follows principle of least privilege.
2018-06-06 14:27:51 +02:00
Nextcloud bot
bb9a6a5364
[tx-robot] updated from transifex 2018-06-06 00:47:06 +00:00
Tobias Kaminsky
3fdd799086 daily dev 20180606 2018-06-06 00:32:09 +02:00
Andy Scherzinger
0b2c986c0f
Merge pull request #2648 from nextcloud/resumeDetailView
File detail view: store file/account when suspending fragments
2018-06-05 16:39:26 +02:00
tobiasKaminsky
60a0df7020
use correct exception
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 14:52:12 +02:00
Andy Scherzinger
4417123c5c
Merge pull request #2680 from nextcloud/accountTypeWithContext
Use context instead of static getAppContext
2018-06-05 13:43:44 +02:00
tobiasKaminsky
b4b1790ef6
Use context instead of static getAppContext 2018-06-05 13:19:17 +02:00
Andy Scherzinger
431386db85
Merge pull request #2550 from nextcloud/whiteTheming
White theming
2018-06-05 13:08:29 +02:00
AndyScherzinger
c5e5868eec
ignore restricted API lint error for tinting a spinner icon 2018-06-05 12:58:42 +02:00
AndyScherzinger
119b8a5943
fix zip icon tinting after rebase 2018-06-05 12:46:37 +02:00
tobiasKaminsky
7ae333635a
tint search view in upload activity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:02 +02:00
tobiasKaminsky
df01428150
tint spinner
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:02 +02:00
tobiasKaminsky
ebb04db951
tint action bar icon
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:01 +02:00
tobiasKaminsky
1c6fec7192
tint remove file dialog buttons
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:01 +02:00
tobiasKaminsky
8b2d082d32
tint pin elements
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:00 +02:00
tobiasKaminsky
9bb708dd08
tint "report button"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:35:00 +02:00
tobiasKaminsky
b13a3ae680
tint also upload file list
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:34:59 +02:00
tobiasKaminsky
c32e47f4ce
White theming
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-06-05 12:34:51 +02:00
Mario Đanić
b48a6e8d8e
Merge pull request #2626 from nextcloud/menuHelper
Shorten code and improve readability via a menu helper
2018-06-05 07:56:06 +02:00
Mario Đanić
c5bca087f2
Merge pull request #2631 from nextcloud/tintZip
tint zip icon same as folder icon
2018-06-05 07:55:00 +02:00
Mario Đanić
648b02ee8a
Merge pull request #2649 from nextcloud/finishPreferences
Explicitly finish preferences
2018-06-05 07:53:40 +02:00
Mario Đanić
f123c269f0
Merge pull request #2651 from nextcloud/resultOnStoppedAsync
Do not process result of async task if activity is stopped
2018-06-05 07:53:09 +02:00
Mario Đanić
2d4cb825f9
Merge pull request #2661 from nextcloud/rewordEmptyActivity
Reword empty activity message
2018-06-05 07:52:31 +02:00
Mario Đanić
e49b1706ff
Merge pull request #2683 from nextcloud/override-annotations
util: Added @Override annotation where applicable.
2018-06-05 07:49:46 +02:00