Commit graph

18056 commits

Author SHA1 Message Date
Álvaro Brey Vilas
bed01a2f0c
TestSorting: refactor and simplify since it's now only for OCFiles
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:12:52 +01:00
Álvaro Brey Vilas
e7e603f4d8
Move string sort tests from TestSorting to NaturalSortTest
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:02:42 +01:00
Álvaro Brey Vilas
d40fc88754
Move TestSorting to unit tests
No reason for it to be an instrumented test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 12:54:45 +01:00
Álvaro Brey Vilas
91297b7ce0
Test AlphanumComparator
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 10:49:08 +01:00
Nextcloud bot
927babb3bf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-04 03:55:25 +00:00
Álvaro Brey
b0848c23e7
Merge pull request #9796 from nextcloud/changelog-master-stable-3.19.0
Add changelog for 3.19.0
2022-02-03 13:19:53 +01:00
Álvaro Brey Vilas
1a7f81a47b
Add changelog for 3.19.0
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-03 13:17:13 +01:00
Nextcloud bot
c437db409e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 03:55:06 +00:00
Nextcloud bot
dba8da00f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-02 03:55:45 +00:00
Nextcloud bot
190332ceaa
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-01 03:55:35 +00:00
Álvaro Brey
1ecbf61cc7
Merge pull request #9776 from nextcloud/fix/activity-title
OCFileListFragment: set title when attached to activity
2022-01-31 15:42:16 +01:00
Álvaro Brey
0c5afce10e
Merge pull request #9770 from nextcloud/Valdnet-patch-1
i18n: Change to a capital letter
2022-01-31 13:43:46 +01:00
Álvaro Brey Vilas
d1d3a49a6b
OCFileListFragment: set title when attached to activity
This prevents wrong title while search isn't started yet (such as when returning to a search fragment from a preview fragment)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-28 16:32:46 +01:00
Nextcloud bot
204cd5a2c5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-28 03:54:54 +00:00
Valdnet
f28bc6f9f9
i18n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-27 17:12:02 +01:00
Álvaro Brey
88605985a0
Merge pull request #9743 from nextcloud/fix/media-dark-duplicated
Fix crashes and double loading in GalleryFragment when changing dark theme
2022-01-27 12:35:35 +01:00
Álvaro Brey
3e97e1e212
Merge pull request #9761 from nextcloud/fix/local-files-freeze
Improve freezes in local files screens when folder contains many files
2022-01-27 12:34:35 +01:00
Álvaro Brey
6ccd2f91de
Merge pull request #9760 from nextcloud/fix/passcode-cancel
PassCodeActivity: enable cancel button when re-created in confirmation step
2022-01-27 12:33:57 +01:00
Álvaro Brey
c2bdea7f74
Merge pull request #9762 from nextcloud/dependabot/gradle/androidx.fragment-fragment-ktx-1.4.1
Bump fragment-ktx from 1.4.0 to 1.4.1
2022-01-27 10:23:14 +01:00
Álvaro Brey Vilas
f3de5f9862
LocalFileListAdapter: fix case where directory==null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
dependabot[bot]
dc7f3f88e1
Bump fragment-ktx from 1.4.0 to 1.4.1
Bumps fragment-ktx from 1.4.0 to 1.4.1.

---
updated-dependencies:
- dependency-name: androidx.fragment:fragment-ktx
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-27 08:38:05 +00:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
2baf63d809
AlphaNumComparator: optimize usage and resolve signature problems
- Methods had ambiguous signatures (parameterized compare<T> overlapped the various typed compare()). This made the compiler very confused.
 - In several places throughout the app, AlphaNumComparator was getting repeatedly instantiated just to manually call a typed compare(). This was very wasteful

To solve both problems, the typed compare() methods have been been made static.

The performance gains of not instantiating the comparator repeatedly are very noticeable. In a test loading a local folder for upload with 1000 files in it,
time of load is reduced from 28 seconds to 17 seconds.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
462da35fdb
LocalFileList: load local files asynchronously
Loading a large list of files (especially the sorting part) is S L O W.
This ensures it doesn't block the UI while loading.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
c5ebc05964
PassCodeActivity: enable cancel button when re-created in confirmation step
Prevents a bug where the cancel button would stop working if the device was rotated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:20:00 +01:00
Álvaro Brey
618a770349
Merge pull request #9751 from nextcloud/fix/clear-data
Fix some crashes and weird behaviours when clearing data
2022-01-27 09:18:21 +01:00
Álvaro Brey
4a29c2e4c4
Merge pull request #9726 from nextcloud/fix/immutable-intents
Make PendingIntents immutable
2022-01-27 09:16:03 +01:00
nextcloud-android-bot
d51268d7b8
Drone: update FindBugs results to reflect reduced error/warning count
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 14:09:47 +01:00
nextcloud-android-bot
af2059660f Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-01-26 12:08:19 +00:00
Álvaro Brey Vilas
c01fa0b170
Make more PendingIntents immutable
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
27559efb79
Make PendingIntents immutable
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey
38c60b7618
Merge pull request #9758 from nextcloud/fix/analysis-again
Analysis: fix checkout and commit generation
2022-01-26 12:55:23 +01:00
Álvaro Brey Vilas
494cceab8e
Analysis: fix checkout and commit generation
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:54:24 +01:00
Álvaro Brey
7eaed66ebc
Merge pull request #9755 from nextcloud/dependabot/gradle/com.android.tools.build-gradle-7.1.0
Bump gradle from 7.0.4 to 7.1.0
2022-01-26 12:06:04 +01:00
Álvaro Brey Vilas
45fc831989
gplay/AndroidManifest: set exported value for service
picked up by lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9d5395c8fd
ezvcard/ContactOperations: suppress locale lint in third_party class
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
043d839d70
build.gradle: Disable some translation errors in lint
Translations are handled in Transifex

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
a9ec1de015
manifest: Remove unneeded labels
Trips up lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
00586a5bde
BackgroundJobFactory: fix lint due to unchecked build version for ContentObserverJob
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b6115a5fc1
lint: Fix getLayoutInflater calls
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b07716c0e5
screenshotTest: uninstall app before running
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9f2bdd5916
Analysis: use pull_request_target
Can't post reports otherwise as github token is readonly in pull_request

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
e35b6211f0
build.gradle: Run migrations for AGP 7.1.0
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:52 +01:00
dependabot[bot]
ae8752a4f7
Bump gradle from 7.0.4 to 7.1.0
Bumps gradle from 7.0.4 to 7.1.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 11:33:47 +01:00
Álvaro Brey
e6d64e5ed5
Merge pull request #9754 from nextcloud/dependabot/gradle/mockitoVersion-4.3.1
Bump mockitoVersion from 4.3.0 to 4.3.1
2022-01-26 10:45:40 +01:00
Álvaro Brey
41b3921643
Merge pull request #9744 from nextcloud/dependabot/gradle/com.karumi-shot-5.13.0
Bump shot from 5.11.2 to 5.13.0
2022-01-26 10:44:25 +01:00
Álvaro Brey Vilas
e1b41b5d77 ManageSpaceActivity: convert to Kotlin while we're here
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
db74d67168 ManageSpaceActivity: kill the app after finishing cleanup
This will prevent the file list still being on the Recents view and other stuff like that.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
83e56643f4 ManageSpaceActivity: remove user accounts when clearing data
This fixes crashes and unexpected states when restarting the app afterwards

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00