Commit graph

12516 commits

Author SHA1 Message Date
tobiasKaminsky
b2a2fa494c
check result also for 202 (accepted)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-01 08:21:24 +02:00
Nextcloud bot
52ab9b95b3
[tx-robot] updated from transifex 2019-04-01 00:53:38 +00:00
Nextcloud bot
7f523dfbcd
[tx-robot] updated from transifex 2019-03-31 01:52:59 +00:00
Nextcloud bot
83cdb1f28b
[tx-robot] updated from transifex 2019-03-30 01:52:07 +00:00
Tobias Kaminsky
7608587e87 daily dev 20190329 2019-03-29 03:34:19 +01:00
Nextcloud bot
789ccd9cea
[tx-robot] updated from transifex 2019-03-29 01:52:28 +00:00
Andy Scherzinger
3d5f74bfe5
Merge pull request #2796 from nextcloud/png2svg
Unify icons, remove png in favor of xml
2019-03-28 11:33:18 +01:00
tobiasKaminsky
816a10735a
- unify icons
- add svg, convert to android xml, removed png

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

fix after rebase

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

renamed user -> ic_user (icon)
make favorite mutable

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

replace further png resources with xml drawables

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

fixes after rebase

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

allow for vector compat

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

add missing icon

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

add yet another missing icon

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

lint: When using VectorDrawableCompat, you need to use app:srcCompat

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

lint: When using VectorDrawableCompat, you need to use app:srcCompat

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

fix lint

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Drone: update Lint results to reflect reduced error/warning count [skip ci]

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>

improve findbugs score

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

use correct icon for user account settings within drawer menu

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

icons needs to be grey600 by default, don't tint grey600 to not tint avatars

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

codacy: organize imports

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

programmatically set in-View drawables, in-view drawables can't be set via XML when supporting pre-lollipop

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

codacy: Useless parentheses & organize imports

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

organize imports

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

codacy: useless paranthesis

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

revert programmatically set
do not use vectorDrawables.useSupportLibrary

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

use 128dp for talk

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat"

This reverts commit 80068e7d37f3a8c6b7096c51543bda68443e4341.

Revert "lint: When using VectorDrawableCompat, you need to use app:srcCompat"

This reverts commit 0130e9a96d2602ad4b5d33aae67f34a458366d70.

revert srcCompat

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-28 10:14:01 +01:00
Tobias Kaminsky
49df3c14dc
Merge pull request #3796 from nextcloud/npeInOwnerId
Do not show avatar if ownerId is null
2019-03-28 07:35:49 +01:00
Andy Scherzinger
f91b4d22cd
Merge pull request #3795 from nextcloud/dependabot/gradle/com.h3xstream.findsecbugs-findsecbugs-plugin-1.9.0
Bump findsecbugs-plugin from 1.8.0 to 1.9.0
2019-03-28 07:22:37 +01:00
tobiasKaminsky
d14ce0218e
do not show avatar if ownerId is null
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-28 06:57:32 +01:00
Tobias Kaminsky
e6f32d794c daily dev 20190328 2019-03-28 03:33:31 +01:00
dependabot[bot]
f95f9fcb39
Bump findsecbugs-plugin from 1.8.0 to 1.9.0
Bumps [findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs) from 1.8.0 to 1.9.0.
- [Release notes](https://github.com/find-sec-bugs/find-sec-bugs/releases)
- [Changelog](https://github.com/find-sec-bugs/find-sec-bugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/find-sec-bugs/find-sec-bugs/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-03-28 02:15:17 +00:00
Tobias Kaminsky
505be99946
Merge pull request #3788 from nextcloud/filemenufilter-null-passed-to-method
files: avoid possible dereference of null pointer.
2019-03-27 10:53:32 +01:00
Tobias Kaminsky
3b88b7b464
Merge pull request #3787 from nextcloud/authtokentype_always_null
authentication: Added missing variable assignment.
2019-03-27 10:33:01 +01:00
ardevd
f1f3d74ce6
getCapability marked with @NonNull and associated npe check removed.
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-27 10:29:52 +01:00
Andy Scherzinger
d4c008188a
Merge pull request #3789 from nextcloud/try-with-resources-in-download-file-operation
operations: properly close FileOutputStream.
2019-03-27 10:11:23 +01:00
ardevd
c59b41d761
operations: properly close FileOutputStream.
Classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. try-with-resources does this for you automatically.

Signed-off-by: ardevd <edvard.holst@gmail.com>
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-27 09:34:19 +01:00
Andy Scherzinger
23c9ea0cf4
Merge pull request #3790 from nextcloud/private-constructor-in-util-classes
Added private constructors to hide implicit public ones.
2019-03-27 08:57:35 +01:00
Tobias Kaminsky
9b7a354c2e daily dev 20190327 2019-03-27 03:33:33 +01:00
Nextcloud bot
43ccc1f39f
[tx-robot] updated from transifex 2019-03-27 01:45:03 +00:00
ardevd
37165b2ac5
Added private constructors to hide implicit public ones.
Utility classes, which are collections of static members, are not meant to be instantiated. Even abstract utility classes, which can be extended, should not have public constructors.

Java adds an implicit public constructor to every class which does not define at least one explicitly. Hence, at least one non-public constructor should be defined.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-26 22:32:25 +01:00
ardevd
878de49381
Merge branch 'authtokentype_always_null' of github.com:nextcloud/android into authtokentype_always_null
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-26 14:35:09 +01:00
ardevd
b96414d794
files: avoid possible dereference of null pointer.
it seems the `capability` object can be null. In which case it is probably a bad idea to pass a null object into `getRichDocumentsDirectEditing()`.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-26 14:34:29 +01:00
ardevd
dd04bf9e93
authentication: Added missing variable assignment.
The `mAuthTokenType` variable is declared and assigned a null value but no value is subsequently assigned, making the null check later on redundant. The `AccountAuthenticator.KEY_AUTH_TOKEN_TYPE` extra value should therefore be assigned the `mAuthTokenType` value I'm assuming.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-26 14:31:59 +01:00
Andy Scherzinger
628c80fa9d
Merge pull request #3786 from nextcloud/trywith-resources
ui:activity: Properly close InputStreamReader.
2019-03-26 13:03:29 +01:00
ardevd
333bb0f0f3
authentication: Added missing variable assignment.
The `mAuthTokenType` variable is declared and assigned a null value but no value is subsequently assigned, making the null check later on redundant. The `AccountAuthenticator.KEY_AUTH_TOKEN_TYPE` extra value should therefore be assigned the `mAuthTokenType` value I'm assuming.
2019-03-26 11:28:59 +01:00
ardevd
1f11845d35
Revert auto-formatting fixes
Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-26 11:19:31 +01:00
ardevd
b1def8cae5
ui:activity: Properly close InputStreamReader.
The InputStreamReader needs to be closed after use. Ideally, use try-with-resources instead.

Signed-off-by: ardevd <edvard.holst@gmail.com>
2019-03-26 11:19:07 +01:00
Nextcloud bot
c739114c55
[tx-robot] updated from transifex 2019-03-26 01:43:09 +00:00
Nextcloud bot
8c066c99ff
[tx-robot] updated from transifex 2019-03-25 01:45:40 +00:00
Nextcloud bot
9c992d98ff
[tx-robot] updated from transifex 2019-03-24 01:46:58 +00:00
Tobias Kaminsky
10840d9e2c daily dev 20190323 2019-03-23 03:33:32 +01:00
Nextcloud bot
6acb39ed56
[tx-robot] updated from transifex 2019-03-23 01:45:08 +00:00
Nextcloud bot
272316512c
[tx-robot] updated from transifex 2019-03-22 08:45:00 +00:00
Andy Scherzinger
3f392964bf
Merge pull request #3771 from nextcloud/moveSharedPref
Combine sharedPreferences in MainApp
2019-03-22 08:55:11 +01:00
Andy Scherzinger
d29cd223d4
Merge pull request #3780 from nextcloud/firstRunWizard
UI improvement on first run
2019-03-22 08:51:20 +01:00
tobiasKaminsky
1b2c41b7e4
combine sharedPreferences in MainApp
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-22 08:47:36 +01:00
Andy Scherzinger
4ab17b5b7c
Merge pull request #3325 from nextcloud/codeFormatting
Export code style
2019-03-22 08:38:06 +01:00
Andy Scherzinger
5dc3faae90
Merge pull request #3768 from nextcloud/furtherHardening
further hardening of SSO
2019-03-22 08:32:30 +01:00
Tobias Kaminsky
32cad19a56
Merge pull request #3758 from nextcloud/ezaquarii/integrate-dagger-2
Integrate Dagger 2
2019-03-22 08:08:40 +01:00
tobiasKaminsky
65d8129971
removed two not-needed initializations for appPreferences
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-22 07:50:15 +01:00
nextcloud-android-bot
719012ff81
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-03-22 07:50:15 +01:00
Chris Narkiewicz
8fbe2ee38e
Integrate Dagger 2
Closes #3751

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-03-22 07:50:15 +01:00
Tobias Kaminsky
d26d56a853
Merge pull request #3778 from nextcloud/NC12minimumSupported
Increase minimum server version
2019-03-22 07:42:49 +01:00
tobiasKaminsky
96f4ba8c5a
use N12 for minimum
warn if older than NC14

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-22 07:30:36 +01:00
Nextcloud bot
6be7876c05
[tx-robot] updated from transifex 2019-03-22 01:46:44 +00:00
Andy Scherzinger
e2ae6298f1
Merge pull request #3779 from nextcloud/uploadAfterFolderCreation
ReceiveExternalFiles: fix no upload possible after creation new folder
2019-03-21 19:39:06 +01:00
tobiasKaminsky
f99c7f2ddd
ReceiveExternalFiles:
- fix no upload possible after creation new folder
- obey canWrite permission for folder creation

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-03-21 15:04:39 +01:00
Tobias Kaminsky
dbad1aa991
Merge pull request #3777 from nextcloud/allowStateLoss
Allowing state loss when closing dialog while stopping activity
2019-03-21 10:39:16 +01:00