Commit graph

17655 commits

Author SHA1 Message Date
Álvaro Brey Vilas
f18f72abcd
DownloadFileOperation: use moveFile instead of File.renameTo
File.renameTo fails if both files aren't under the same mountpoint.
As the tmp file is in internal storage now, it has to be move differently if the target dir is in external storage.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 16:31:46 +01:00
Álvaro Brey Vilas
1811d040f7
Use internalTemporalPath instead of temporalPath
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 12:59:06 +01:00
Álvaro Brey
578da09f05
Merge pull request #9179 from sryze/contact-settings-back-fix
Prevent duplicate Settings activity on back stack
2021-11-02 09:40:28 +01:00
tobiasKaminsky
4d99f62759 Use LeakCanary in debug mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-02 08:37:03 +00:00
Álvaro Brey
432f51b4ec
Merge pull request #9181 from nextcloud/dependabot/gradle/byteBuddyVersion-1.11.22
Bump byteBuddyVersion from 1.11.21 to 1.11.22
2021-11-02 09:23:06 +01:00
Álvaro Brey
07bc3f4f50
Merge pull request #9180 from nextcloud/dependabot/gradle/com.google.code.gson-gson-2.8.9
Bump gson from 2.8.8 to 2.8.9
2021-11-02 09:17:27 +01:00
Álvaro Brey Vilas
78aa89e1be
CONTRIBUTING: add indication that commits should be signed off.
Also add ToC entry for git hooks, which was missing

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 09:07:31 +01:00
Sergey Zolotarev
f08ad758cd Prevent duplicate Settings activity on back stack
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
2021-11-02 14:05:59 +06:00
Álvaro Brey Vilas
f2c81a9715
stale action: Add exempt label to mark issues that shouldn't be stale automatically
We've got some issues that are open since a long time ago but aren't resolved, and  there isn't some clear short term resolution to them.
As such these isues are kept open because they still affect users, but the users have to be "fighting" the stale bot, which
understandably generates confusion and frustration.

This PR adds a specific label we can add to those issues so that the stale action will ignore them.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:36:05 +01:00
Álvaro Brey Vilas
063ef4f8df
Fix PermissionUtil after rebase
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:44 +01:00
Álvaro Brey Vilas
0ad8c4350d
Fix storage permissions in debug manifest too
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
886c2574fb
MediaProvider: remove useless parens
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
95c31750a7
AbstractIT: adaptations to make integration tests work in sdk 30
- Use internal temporal path, as external temporal path is broken in sdk 30
- Don't take snapshots in sdk30 as they crash

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
c1316da717
Request READ_EXTERNAL_STORAGE in API >= 30
Although scoped storage is in effect and WRITE_EXTERNAL_STORAGE does not do anything,
we still need READ_EXTERNAL_STORAGE to read files from folders we don't own.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
2cb05a17a5
androidTest: Don't request WRITE_EXTERNAL_STORAGE on sdk>=30
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
1154b439fe
ContentResolverHelperTest: use mockitokotlin instead of mockk
MockK doesn't work properly on android < 27. Lesson learned.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
be830a66c8
COntentResolverHelper: sort column must be an array
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
8860bd4b52
Fix OCFIleListFragmentIT on sdk 30
Can no longer open /sdcard/ directly, let's use the external files dir

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
aa7b5617ab
ContentResolverHelper: add tests and proper copyright headers
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
0cccd80314
build.gradle: Bump mockK to fix test crashes in API 30 emulators
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
6e645f7f06
MediaProvider: solve crash on Android 11 due to invalid contentProvider queries
This manifested mostly when trying to open "auto upload"

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
d92e3cbfaa
Fix some type errors after sdk 30 bump
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
e655039559
Bump compileSdk and targetSdk to 30
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:33 +01:00
Álvaro Brey Vilas
ac9f516027 Unified search: skip local file check for non-file results
Fixes https://github.com/nextcloud/android/issues/9171

Needs https://github.com/nextcloud/android-library/pull/739

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 07:23:33 +00:00
Nextcloud bot
0558b25ee3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-02 03:49:39 +00:00
Nextcloud bot
346fc512a2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-01 03:48:17 +00:00
dependabot[bot]
957949101e
Bump byteBuddyVersion from 1.11.21 to 1.11.22
Bumps `byteBuddyVersion` from 1.11.21 to 1.11.22.

Updates `byte-buddy` from 1.11.21 to 1.11.22
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](https://github.com/raphw/byte-buddy/compare/byte-buddy-1.11.21...byte-buddy-1.11.22)

Updates `byte-buddy-android` from 1.11.21 to 1.11.22
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](https://github.com/raphw/byte-buddy/compare/byte-buddy-1.11.21...byte-buddy-1.11.22)

---
updated-dependencies:
- dependency-name: net.bytebuddy:byte-buddy
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: net.bytebuddy:byte-buddy-android
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 02:06:11 +00:00
dependabot[bot]
5b097431fb
Bump gson from 2.8.8 to 2.8.9
Bumps [gson](https://github.com/google/gson) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/gson/compare/gson-parent-2.8.8...gson-parent-2.8.9)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 02:05:37 +00:00
Nextcloud bot
3abf27f947
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-30 03:50:46 +00:00
Nextcloud bot
f9bfb044dc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-29 03:49:55 +00:00
Álvaro Brey
dd7b76ead4
Merge pull request #9150 from nextcloud/fix-fastlane-rc
fastlane: Restore version prompt for RC releases
2021-10-28 12:34:00 +02:00
Álvaro Brey
d74af1c35e
Merge pull request #9164 from nextcloud/fix/network-metered-security-exception
ConnectivityService: handle SecurityException in getNetworkCapabilities
2021-10-28 11:00:16 +02:00
Álvaro Brey Vilas
9a94ddc1cc
ConnectivityService: handle SecurityException in getNetworkCapabilities
Bug on Android implementation

See: https://stackoverflow.com/questions/66652819/getting-security-exception-while-trying-to-fetch-networkcapabilities-on-android

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-28 10:13:30 +02:00
Nextcloud bot
da095ddfb6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-28 03:51:04 +00:00
Tobias Kaminsky
0184bb7608
Merge pull request #9157 from nextcloud/AccountManagerService
AccountManagerService needs to be exported
2021-10-27 19:59:48 +02:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-27 08:49:05 +02:00
Nextcloud bot
8c0e77ae93
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-27 03:55:09 +00:00
Álvaro Brey
9b25979eb7
Merge pull request #9149 from nextcloud/obsoleteSDKchekcs
Remove unneeded checks for M build target
2021-10-26 09:03:54 +02:00
Álvaro Brey Vilas
e40d2910b9
fastlane: Restore version prompt for RC releases
Was lost in https://github.com/nextcloud/android/pull/9118,
so now RC releases didn't pause for version check.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-26 08:37:01 +02:00
drone
05d98ccc4b Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
2021-10-26 06:02:19 +00:00
tobiasKaminsky
bbcfdbe98d
Remove unneeded checks for M build target
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-26 07:57:01 +02:00
Nextcloud bot
a946385603
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-26 03:50:35 +00:00
Andy Scherzinger
1b87f68aed
Merge pull request #9142 from nextcloud/bumpMasterTo3.19
Bump master to 3.19 alpha
2021-10-25 18:42:22 +02:00
Nextcloud bot
2c7c571fca
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-25 14:25:18 +00:00
tobiasKaminsky
85d1f5bb0d
Bump master to 3.19 alpha
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 16:17:42 +02:00
Tobias Kaminsky
6176998a0e
Merge pull request #9141 from nextcloud/bump-outdated-server-version
Bump versions before RC
2021-10-25 16:13:56 +02:00
Tobias Kaminsky
6e76954fcf
Merge pull request #8848 from nextcloud/sharingDialog
Sharing dialog improvement
2021-10-25 16:08:23 +02:00
Tobias Kaminsky
cf8021059e
Merge pull request #7568 from nextcloud/unifiedSearch
Unified search
2021-10-25 16:07:08 +02:00
drone
16b37bcc05
Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: drone <drone@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 16:06:17 +02:00
Álvaro Brey Vilas
0984213b62
AndroidManifest: remove resources with maxSDK=22
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:44:36 +02:00