mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-23 01:00:26 +03:00
Code Issues Projects Releases Packages Wiki Activity
13596 commits 221 branches 1589 tags 640 MiB
Commit graph

4629 commits

Author SHA1 Message Date
tobiasKaminsky
750c0a7677
Fix possible IndexOutOfBoundsException if returned array is empty 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-21 08:27:10 +02:00
Nextcloud bot
148cef835f
[tx-robot] updated from transifex 2019-10-21 03:08:30 +00:00
Chris Narkiewicz
b7cdaf310b
Eliminate account status flags from BaseActivity 
onAccountSet(stateWasRecovered) is no longer used anywhere,
so the flag mAccountWasRestored can be safely removed.

This intermediary step opens path to eliminating
out of band calls to onAccountSet().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-20 23:27:41 +01:00
Tobias Kaminsky
954c76b11b
Merge pull request #4692 from nextcloud/markdownPreview 
Markdown rendering
 2019-10-18 10:21:01 +02:00
Tobias Kaminsky
2a8164acf1
Merge pull request #4700 from nextcloud/account-cleanup-receive-external-file-activity 
Remove onAccountSet from ReceiveExternalFilesActivity
 2019-10-18 10:17:48 +02:00
Nextcloud bot
76622c8861
[tx-robot] updated from transifex 2019-10-18 07:12:22 +00:00
Andy Scherzinger
95e14df1d7
Add markdown rendering to TextPreview 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-17 19:57:51 +02:00
Chris Narkiewicz
5d6e316570
Remove onAccountSet from ReceiveExternalFilesActivity 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-17 15:45:00 +01:00
Tobias Kaminsky
16cc46f4ed
Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity 
Remove onAccountSet from UploadFilesActivity
 2019-10-17 15:22:10 +02:00
Tobias Kaminsky
d9567a2bb6
Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview 
Remove onAccountSet from image and video preview activities
 2019-10-17 15:21:54 +02:00
Tobias Kaminsky
2d9afe36c9
Merge pull request #4688 from nextcloud/account-cleanup-share-activity 
Remove onAccountSet from ShareActivity
 2019-10-17 15:21:44 +02:00
Tobias Kaminsky
f4a27cc5dc
Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity 
Remove onAccountSet from FileDisplayActivity
 2019-10-17 14:58:13 +02:00
Tobias Kaminsky
d237a834b8
Merge pull request #4699 from nextcloud/removeUploadPathActivity 
We do not use UploadPathActivity anymore(?)
 2019-10-17 11:39:12 +02:00
Tobias Kaminsky
64c986eaf2
Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity 
Remove onAccountSet from FolderPickerActivity
 2019-10-17 11:38:08 +02:00
tobiasKaminsky
ab904e336b
We do not use UploadPathActivity anymore(?) 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-17 08:23:15 +02:00
Chris Narkiewicz
451cec9f3a
Remove onAccountSet from ConflictsResolveActivity 
Deprecated onAccountSet logic simply inlined in onStart.
No change of control flow.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-16 21:12:09 +01:00
Chris Narkiewicz
e5a6accf66
Remove onAccountSet from FileDisplayActivity 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-16 21:07:50 +01:00
Chris Narkiewicz
b199a62b78
Remove onAccountSet from image and video preview activities 
Both callbacks are directly called from onStart().
Since callback parameter is unused, inline the
callback code in onStart().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-16 19:57:11 +01:00
Chris Narkiewicz
f428fb5810
Remove onAccountSet from UploadFilesActivity 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-16 19:55:39 +01:00
Chris Narkiewicz
6a88a02f94
Remove onAccountSet from ShareActivity 
Since onAccountSet is called directly from onStart,
we can inline the code in onStart safely.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-16 19:54:30 +01:00
Chris Narkiewicz
3519d04eea
Remove onAccountSet from FolderPickerActivity 
Move onAccountSet body to onStart.
Unconditionally reset fragment state, since the
acctount restoration flag is no longer available.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-16 19:50:21 +01:00
Andy Scherzinger
e47daaffdc
Merge pull request #4684 from nextcloud/codacy2 
more codacy fixes
 2019-10-16 17:42:07 +02:00
Tobias Kaminsky
3ef96f8877
Merge pull request #4677 from nextcloud/deprecate-set-account-logic 
Deprecate setAccount logic and remove accounWasSet flag
 2019-10-16 14:57:46 +02:00
Andy Scherzinger
7f209618eb
codacy: shorten method length 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-15 16:38:01 +02:00
Andy Scherzinger
9beecfa184
codacy: Document empty constructor (rather make setting flag more explicit in this case) 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-15 15:57:53 +02:00
Andy Scherzinger
670e9d3a61
codacy: Ensure you override both equals() and hashCode() 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-15 15:57:45 +02:00
Andy Scherzinger
862e5d4776
Merge pull request #4537 from nextcloud/ezaquarii/migrate-ncontentobserverjob-to-workmanager 
Migrate NContentObserverJob to WorkManager
 2019-10-15 15:23:15 +02:00
Andy Scherzinger
54e5ce3ae0
Merge pull request #4683 from nextcloud/fixSorting 
fix sorting of synced folder: NPE if both enabled, but one has null folder name
 2019-10-15 13:36:49 +02:00
tobiasKaminsky
1b0d548c69
fix sorting of synced folder: NPE if both enabled, but one has null folder name 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-15 09:56:55 +02:00
Andy Scherzinger
2ab45a72ac
codacy: Deeply nested if..then statements are hard to read 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-14 14:59:28 +02:00
Andy Scherzinger
2dabd04aa9
codacy: These nested if statements could be combined 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-14 14:59:28 +02:00
Andy Scherzinger
e0802a0da4
codacy: Avoid using Literals in Conditional Statements 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-14 14:59:27 +02:00
Andy Scherzinger
638a5b9fc0
codacy: Avoid unused imports such as 'androidx.fragment.app.Fragment' 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-14 14:59:26 +02:00
Andy Scherzinger
ab6424701b
codacy: Avoid unused method parameters such as 'appVersion'. 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-10-14 14:59:26 +02:00
Nextcloud bot
26297005c9
[tx-robot] updated from transifex 2019-10-14 03:05:53 +00:00
Chris Narkiewicz
c90626aaf5
Deprecate setAccount logic and remove accounWasSet flag 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-13 16:02:46 +01:00
Nextcloud bot
d189867d36
[tx-robot] updated from transifex 2019-10-13 03:08:24 +00:00
Nextcloud bot
d3b0880e38
[tx-robot] updated from transifex 2019-10-12 03:07:28 +00:00
Andy Scherzinger
45f5b384db
Merge pull request #4655 from nextcloud/revertDisableException 
Revert disabling of exception handler
 2019-10-11 08:11:59 +02:00
Nextcloud bot
e333c88a08
[tx-robot] updated from transifex 2019-10-11 03:04:45 +00:00
tobiasKaminsky
8cc3ec7ad6
revert disabling of exception handler 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-10 17:15:08 +02:00
Tobias Kaminsky
f1cf050a81
Merge pull request #4626 from nextcloud/removeCustomEdit 
remove CustomEditTextField
 2019-10-10 17:07:26 +02:00
Andy Scherzinger
af7bf9b2f7
Merge pull request #4647 from nextcloud/fixVanishingImages 
Fix vanishing images
 2019-10-10 13:56:29 +02:00
tobiasKaminsky
a2f2da9c20
move logic completely into function 
prevent double subfolders

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-10 12:01:35 +02:00
tobiasKaminsky
73fc5e47ed
OCFiles can be retrieved also by photo search, which then do not have a parent, nor a fileId as the are only virtual files 
upon refreshing folder
- they were found in database, but only updated with fileId=-1.
- they were not found in parent folder, so we have to search them manually via file path

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-10 10:51:54 +02:00
tobiasKaminsky
cf74da7bda
- remove CustomEditTextField 
- do not use fancy material header for textInput, but regular TextView
- do not show QR button on legacy login
- fix layout in tablet mode

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-10 08:25:22 +02:00
Tobias Kaminsky
07d0abe87e
Merge pull request #4644 from nextcloud/detectAuth 
Allow broader check on CheckAuth
 2019-10-09 21:06:00 +02:00
Tobias Kaminsky
9be019ce4c
Merge pull request #4637 from nextcloud/fixSingleAccountMode 
Enhance single account mode
 2019-10-09 21:03:04 +02:00
tobiasKaminsky
140eb3b664
Allow broader check on CheckAuth 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-09 19:52:36 +02:00
tobiasKaminsky
3d6d396ba9
fix disappearing account list on resume 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-09 15:15:33 +02:00
tobiasKaminsky
baefe67ea9
enhance single account mode 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-09 14:06:14 +02:00
Tobias Kaminsky
bb81d2349b
Merge pull request #4632 from nextcloud/npeInDetail 
hardening on possible NPE due to null account/activity
 2019-10-09 13:58:14 +02:00
Tobias Kaminsky
ad9daacb25
Merge pull request #4629 from nextcloud/ezaquarii/remove-sticky-headers-code 
Remove sticky headers from activities list view
 2019-10-09 13:36:21 +02:00
tobiasKaminsky
832e525f09
hardening on possible NPE due to null account/activity 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-09 08:15:32 +02:00
Tobias Kaminsky
f321cedb24
Merge pull request #4623 from nextcloud/fixSyncedFolderNofications 
Fix recurring synced folder notifications
 2019-10-09 07:38:07 +02:00
Nextcloud bot
eb5f8e0177
[tx-robot] updated from transifex 2019-10-09 03:07:03 +00:00
Chris Narkiewicz
73658bcfe1
Remove sticky headers from activities list view 
This will prevent application from crashing on
adapter update.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-08 23:04:51 +01:00
Andy Scherzinger
1b6b909a8c
Merge pull request #4621 from nextcloud/gridCrash 
prevent crash when grid column is -1
 2019-10-08 09:43:15 +02:00
tobiasKaminsky
2a88933075
- fix wrong sql to detect already existing synced folder 
- remember every media folder where a notification was shown

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-08 09:19:16 +02:00
Tobias Kaminsky
58cac2ab2f
Merge pull request #4604 from nextcloud/ezaquarii/fix-npe-in-favorites 
Fix NPE in Favorites when file has no local storage path
 2019-10-08 08:23:38 +02:00
tobiasKaminsky
02eaa886ae
prevent crash when grid column is -1 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-08 08:00:36 +02:00
Nextcloud bot
d27c6a1abd
[tx-robot] updated from transifex 2019-10-08 03:05:28 +00:00
Nextcloud bot
2d663a5a4a
[tx-robot] updated from transifex 2019-10-07 03:05:00 +00:00
Nextcloud bot
89df63ab84
[tx-robot] updated from transifex 2019-10-06 03:07:56 +00:00
Nextcloud bot
d2ce78fafe
[tx-robot] updated from transifex 2019-10-05 03:06:32 +00:00
Nextcloud bot
1936d6fee4
[tx-robot] updated from transifex 2019-10-04 03:08:19 +00:00
Nextcloud bot
1ce86c2e3a
[tx-robot] updated from transifex 2019-10-03 03:05:30 +00:00
Chris Narkiewicz
88113c02df
Fix NPE in Favorites when file has no local storage path 
Fixes #4578

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-02 22:04:04 +01:00
Chris Narkiewicz
808c9098ea
Migrate NContentObserverJob to WorkManager 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-10-02 21:38:44 +01:00
Tobias Kaminsky
4f15e87412
Merge pull request #4592 from nextcloud/parentCheck 
if parent is null, then do a regular check, no early exit
 2019-10-02 09:03:07 +02:00
Tobias Kaminsky
b204db0f1a
Merge pull request #4577 from nextcloud/ezaquarii/fix-npe-in-preview-media-fragment 
Fix NPE in PreviewMediaFragment
 2019-10-02 09:02:35 +02:00
Tobias Kaminsky
9876c49001
Merge pull request #4415 from nextcloud/dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-gradle-plugin-1.0.1 
Bump detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1
 2019-10-02 08:26:25 +02:00
tobiasKaminsky
f6e24eb067
if parent is null, then do a regular check, no early exit 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-02 08:02:44 +02:00
Nextcloud bot
9133158fd0
[tx-robot] updated from transifex 2019-10-02 03:08:30 +00:00
tobiasKaminsky
37c6600d2e
Upload files into subfolder 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-01 11:37:16 +02:00
Tobias Kaminsky
a1c28f93d6
Merge pull request #4470 from stephanritscher/master 
Normalize local target path in auto upload
 2019-10-01 11:15:30 +02:00
tobiasKaminsky
9c1fedb14b
add test cases 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-01 10:46:22 +02:00
tobiasKaminsky
6184fcd5ae
add test cases 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-01 10:45:09 +02:00
dependabot-preview[bot]
6b4e90022f
Bump detekt-gradle-plugin from 1.0.0-RC14 to 1.0.1 
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-10-01 10:18:43 +02:00
Tobias Kaminsky
0f975647b6
Merge pull request #4208 from nextcloud/ezaquarii/new-media-player-service 
New audio media player service
 2019-10-01 07:45:36 +02:00
Nextcloud bot
d83792ef03
[tx-robot] updated from transifex 2019-09-30 03:14:58 +00:00
Chris Narkiewicz
488193a94e
Fix NPE in PreviewMediaFragment 
Fragment can be detached before async task finishes.
Detached fragment has no context and getString() fails with NPE.

Fixes #4412

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-09-28 23:41:27 +01:00
Nextcloud bot
9a2fc28b23
[tx-robot] updated from transifex 2019-09-28 03:06:19 +00:00
Chris Narkiewicz
2dab887782 New media player service 
Fixes #3061
Fixes #4412

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-09-27 20:13:51 +01:00
Tobias Kaminsky
5bcab439b4
Merge pull request #4538 from nextcloud/ezaquarii/fix-broken-account-registration 
Fix registration of second account on first run
 2019-09-27 09:47:55 +02:00
Tobias Kaminsky
8954aafb5f
Merge pull request #4545 from nextcloud/ezaquarii/speculative-fix-for-npe-in-log-d 
Fix for NPE caused by Log.d in ThumbnailsCacheManager
 2019-09-27 09:23:28 +02:00
Tobias Kaminsky
f64485f279
Merge pull request #4539 from nextcloud/ezaquarii/fix-npe-crash-in-ocfilelistfragment 
Fix NPE crash in OCFileListFragment when action mode is destroyed
 2019-09-27 09:08:24 +02:00
Nextcloud bot
b498e8eee6
[tx-robot] updated from transifex 2019-09-27 03:06:43 +00:00
Chris Narkiewicz
ed704c632e
Fix for NPE caused by Log.d in ThumbnailsCacheManager 
Log.d does not like null.

Fixes #4542

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-09-26 16:19:36 +01:00
Chris Narkiewicz
551c4d3f1a
Fix NPE crash in OCFileListFragment when action mode is destroyed 
Fixes #4438

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-09-26 16:17:49 +01:00
Chris Narkiewicz
953ee005e5
Fix registration of second account on first run 
Fixes #4234
Fixes #4529
Fixes #4462

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2019-09-26 16:17:15 +01:00
Nextcloud bot
11cd2cd390
[tx-robot] updated from transifex 2019-09-25 03:06:18 +00:00
Nextcloud bot
dfb616fcfe
[tx-robot] updated from transifex 2019-09-24 03:09:38 +00:00
Andy Scherzinger
7c1aae4c25
Merge pull request #4473 from nextcloud/dependabot/gradle/androidx.appcompat-appcompat-1.1.0 
Bump appcompat from 1.0.2 to 1.1.0
 2019-09-23 23:24:01 +02:00
Nextcloud bot
8429ba3f65
[tx-robot] updated from transifex 2019-09-23 03:05:42 +00:00
Nextcloud bot
a2d826e313
[tx-robot] updated from transifex 2019-09-22 03:07:24 +00:00
tobiasKaminsky
1d0dd21169
use Nextcloud UA 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2019-09-19 21:50:23 +02:00
Nextcloud bot
515cb981b9
[tx-robot] updated from transifex 2019-09-18 03:06:59 +00:00
Nextcloud bot
3c8cd4b2e0
[tx-robot] updated from transifex 2019-09-17 02:57:51 +00:00
Andy Scherzinger
fc86b57065
lint: Overriding method should call super 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2019-09-16 20:15:05 +02:00