Jens Mueller
8bb654b5ef
fix test & review comments
...
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-04-18 08:42:36 +02:00
Jens Mueller
d8b9d109b1
unify empty string compare
...
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-04-18 08:42:36 +02:00
jmue
2f23a30906
remove unused variable ( #3920 )
...
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-04-18 08:22:13 +02:00
Andy Scherzinger
92df32e664
Merge pull request #3918 from nextcloud/codacyCleanup
...
some cleanups
2019-04-18 08:12:44 +02:00
nextcloud-android-bot
091c003b5d
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-18 06:01:10 +00:00
nextcloud-android-bot
15ec4876d1
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-18 05:59:03 +00:00
drone
da3c497630
Merge commit '334155e707975e740a0a13b33d9b7bbedf40e9bc'
2019-04-18 05:56:04 +00:00
Tobias Kaminsky
b22f517029
Merge pull request #3915 from jmue/cleanup/ocfile
...
use path separator constant
2019-04-18 07:54:56 +02:00
Jens Mueller
c7c6a989b4
use constant
...
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-04-17 21:21:08 +02:00
Jens Mueller
e6604c8101
use constant
...
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-04-17 21:16:59 +02:00
Andy Scherzinger
caa2a91bfc
Merge pull request #3912 from nextcloud/libraryUsage
...
Setup.md: direct usage of library project
2019-04-17 15:41:47 +02:00
tobiasKaminsky
334155e707
some cleanups
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-17 14:26:25 +02:00
Tobias Kaminsky
28f80cd3ff
Merge pull request #3907 from nextcloud/ezaquarii/initialize-main-app-context-before-content-providers-start
...
Initialize global context before MainApp.onCreate()
2019-04-17 13:57:23 +02:00
nextcloud-android-bot
2afb934b41
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-17 09:10:13 +00:00
Tobias Kaminsky
8be1157e79
Merge pull request #3899 from jmue/cleanup/uriutils
...
cleanup unused code
2019-04-17 10:54:51 +02:00
tobiasKaminsky
52020a9bf3
direct usage of library project
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-17 10:07:53 +02:00
Tobias Kaminsky
4062d40aa6
Merge pull request #3908 from nextcloud/missingInjectable
...
Missing Injectable lead to half-stored account
2019-04-17 06:56:37 +02:00
Chris Narkiewicz
2a08cb47d9
Initialize global context before MainApp.onCreate()
...
Initialize global context just after attaching base
context.
ContentProvider depend on MainApp.getAppContext(),
but ContentProvider.onCreate() is called *before*
Application.onCreate().
This hack should improve stability of ContentProviders
at process bring-up time until we address this
with a proper DI.
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-04-16 19:07:02 +01:00
tobiasKaminsky
f02f482fb5
Missing Injectable lead to half-stored account
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-16 16:52:35 +02:00
Tobias Kaminsky
02cbafe59e
Merge pull request #3765 from nextcloud/showSharees
...
Show sharees
2019-04-16 10:31:27 +02:00
tobiasKaminsky
dc7a2c0e7e
show sharees
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-16 09:06:17 +02:00
Andy Scherzinger
03e04e516e
Merge pull request #3889 from nextcloud/checkUserId
...
Cleanup authentication
2019-04-15 22:51:08 +02:00
nextcloud-android-bot
585a3d0852
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-15 13:11:48 +00:00
tobiasKaminsky
533debfca0
- removed useNextcloudUserAgent -> we now use this everytime
...
- removed any oAuth and saml stuff, as we rely on weblogin flow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-15 15:07:59 +02:00
Tobias Kaminsky
d544fa5801
Merge pull request #3897 from nextcloud/ezaquarii/move-current-account-getter-to-user-account-manager
...
Migrate current account getter from AccountUtils to UserAccountManager
2019-04-15 15:01:23 +02:00
Andy Scherzinger
5b4ffba287
Merge pull request #3900 from nextcloud/codacyOnMaster
...
Show codacy count only on master
2019-04-15 14:11:41 +02:00
Jens Mueller
27572446cd
remove unused code
...
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-04-15 09:36:41 +02:00
tobiasKaminsky
428a8bbcc9
show codacy count only on master
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-15 09:33:53 +02:00
nextcloud-android-bot
6b44074d1e
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-14 20:06:30 +00:00
drone
c62e89b807
Merge commit '442394f949ff2de86bcccae172d2e9d997ab2ef8'
2019-04-14 20:03:09 +00:00
Chris Narkiewicz
442394f949
Migrate current account getter from AccountUtils to UserAccountManager
...
The implementation delegates calls to the old code, so there should
be no regressions in functionality.
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-04-14 21:02:43 +01:00
Tobias Kaminsky
182b65ed34
daily dev 20190414
...
4442d5a338
Merge pull request #3895 from nextcloud/ezaquarii/user-account-manager
cd9eea52bc
daily dev 20190413
2019-04-14 03:33:32 +02:00
Andy Scherzinger
4442d5a338
Merge pull request #3895 from nextcloud/ezaquarii/user-account-manager
...
Create UserAccountManager and move getAccounts()
2019-04-13 08:42:22 +02:00
Tobias Kaminsky
cd9eea52bc
daily dev 20190413
...
98a134f6ca
Merge pull request #3886 from nextcloud/ezaquarii/rename-preference-manager
75775ac34f
Merge pull request #3871 from nextcloud/showCodacy
82fc476962
Merge pull request #3890 from nextcloud/deleteTests
36937b2366
Merge pull request #3882 from nextcloud/NPECheckScanner
1275728182
Rename PreferenceManager to AppPreferencesImpl
0e17ebdabd
delete old tests
1074bcf46a
Merge pull request #3879 from nextcloud/pmdRuleset
09da127d29
- rename ruleset - add test_test to MainApp to test Codacy
8e1ebca9c5
daily dev 20190412
2019-04-13 03:33:40 +02:00
nextcloud-android-bot
a79c0a7785
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-04-12 23:09:49 +00:00
Chris Narkiewicz
bbaf355328
Create UserAccountManager and move getAccounts()
...
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-04-13 00:06:24 +01:00
Andy Scherzinger
98a134f6ca
Merge pull request #3886 from nextcloud/ezaquarii/rename-preference-manager
...
Rename PreferenceManager to AppPreferencesImpl
2019-04-12 22:49:34 +02:00
Andy Scherzinger
75775ac34f
Merge pull request #3871 from nextcloud/showCodacy
...
Show current codacy issue count
2019-04-12 22:08:58 +02:00
Andy Scherzinger
82fc476962
Merge pull request #3890 from nextcloud/deleteTests
...
Delete old tests
2019-04-12 22:03:22 +02:00
Andy Scherzinger
36937b2366
Merge pull request #3882 from nextcloud/NPECheckScanner
...
Fix #3881 by checking for result being null
2019-04-12 21:51:56 +02:00
Chris Narkiewicz
1275728182
Rename PreferenceManager to AppPreferencesImpl
...
PreferenceManager name conficts with platform PreferenceManager.
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-04-12 15:46:23 +01:00
tobiasKaminsky
0e17ebdabd
delete old tests
...
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-12 14:33:02 +02:00
Andy Scherzinger
1074bcf46a
Merge pull request #3879 from nextcloud/pmdRuleset
...
PMD ruleset
2019-04-12 07:52:31 +02:00
tobiasKaminsky
09da127d29
- rename ruleset
...
- add test_test to MainApp to test Codacy
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-04-12 07:44:25 +02:00
Tobias Kaminsky
8e1ebca9c5
daily dev 20190412
...
b52ce7e85c
Merge pull request #3873 from nextcloud/codacy
32b04cb07e
remove unused variable
35ff763950
codacy: combine statements
8353ef42bb
Merge pull request #3864 from nextcloud/connectivityutils-powermock-test
477bc797aa
removed placeholder test class
aa98015739
Merge branch 'connectivityutils-powermock-test' of github.com:nextcloud/android into connectivityutils-powermock-test
d760206654
Removed placeholder test class
3d9e379b43
Merge pull request #3841 from nextcloud/owncloudsession-unit-tests
a97eb3b45b
- use lombok - remove m prefix - correct assert output - add licence
7e38b60ca0
utils: Restricted access declarations for OwnCloudSession class.
8712c9e783
tests: added unit tests for the OwnCloudSession class
0013ee8309
Merge pull request #3878 from nextcloud/dependabot/gradle/org.mockito-mockito-core-2.27.0
a34761ba3a
code review changes
dac5897894
codacy: make newRemotePath a local variable
659775dc25
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
2ea4b352e3
combine statements
d19b7742d6
remove m/s-prefixes, make use of lombok
a05ba1a54f
reformatting var declarations
d41a8a9054
spotbugs: Exceptional return value ignored
38466e01d3
reformatting
47a74a13fd
remove unused HookActvity
c6498ae6b4
Use Butterknife for Log Activity
92219048da
remove unused method
b41cca2840
add log statement to parent class
a3c7e7b74a
use interface instead of implementation
88da903e59
daily dev 20190411
2019-04-12 03:34:47 +02:00
Andy Scherzinger
b52ce7e85c
Merge pull request #3873 from nextcloud/codacy
...
Further code improvements
2019-04-11 19:15:35 +02:00
Andy Scherzinger
4278f64e47
Fix #3881 by checking for result being null
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 18:08:16 +02:00
Andy Scherzinger
32b04cb07e
remove unused variable
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 17:32:48 +02:00
Andy Scherzinger
35ff763950
codacy: combine statements
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-04-11 14:44:09 +02:00
Andy Scherzinger
8353ef42bb
Merge pull request #3864 from nextcloud/connectivityutils-powermock-test
...
test: added PowerMocked unit tests for the ConnectivityUtils class.
2019-04-11 14:34:38 +02:00