mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-12-19 15:33:00 +03:00
Code Issues Projects Releases Packages Wiki Activity
25723 commits 223 branches 1586 tags 638 MiB
Commit graph

11441 commits

Author SHA1 Message Date
Álvaro Brey Vilas
724b75d5d3
FileContentProvider: Use SQLiteTokenizer for sortOrder verification too 
More reliable than just splitting by spaces.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-21 15:06:05 +01:00
Álvaro Brey Vilas
b3aeab9004
FileContentProvider: prevent injection through selection parameters (where) 
For this, I've backported the SQLiteTokenizer class from AOSP, use it to get tokens from the query,
and filter out invalid tokens.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-21 14:15:34 +01:00
Nextcloud bot
c479f2fdf6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-21 03:54:15 +00:00
Álvaro Brey Vilas
6aae8feeac
FileContentProvider: prevent injection in sortOrder argument for query() 
For this, allow strictly only valid grammar and column names

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 18:38:50 +01:00
Álvaro Brey Vilas
830ada4617
FileContentProvider: remove unused method 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 18:03:56 +01:00
Álvaro Brey Vilas
43adc856a4
FileContentProvider: don't verify projectionArray in query() 
query() is already using a projection map and strict mode for those cases, so we're just duplicating work here.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 17:58:54 +01:00
Álvaro Brey Vilas
05371be6d7
FileContentProvider: prevent injection through Uri arguments 
For this, ensure query arguments are used instead of segment concatenation

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 17:53:55 +01:00
tobiasKaminsky
72937cf341
FileContentProvider: prevent injection via ContentValues arguments 
For this, verify all column names for ContentValues keys. Values are safe by default.

Co-authored-by: Tobias Kaminsky <tobias.kaminsky@nextcloud.com>
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 17:40:11 +01:00
Álvaro Brey Vilas
87e859858b
SettingsActivityIT: fix showMnemonic running on wrong thread 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-20 15:24:21 +01:00
Nextcloud bot
4183ee59f8
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-20 03:56:38 +00:00
Nextcloud bot
14a6324c05
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-19 03:59:20 +00:00
Nextcloud bot
26f80ddcbf
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-18 03:53:54 +00:00
Álvaro Brey Vilas
37dfb5eb2c
Player: don't try to pause a non-running media player 
Fixes an issue triggered by pausing, and then minimizing and coming back to the app.

Right now state is still lost (file returns to the beginning) but as a stopgap it's OK.
In the future, the state machine and how it interacts with the fragment should be reworked.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-17 16:22:39 +01:00
Álvaro Brey Vilas
b1aa3dcdaf
Centralize creation of ACTION_SEND intents and explicitly grant READ_URI permission to them 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-16 15:22:16 +01:00
Álvaro Brey
3de9432651
Merge pull request #9534 from gabmert/naming-conflicts 
Change naming in conflicts to location instead of date
 2021-12-16 09:35:43 +01:00
Nextcloud bot
d3db0af0f5
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-16 03:53:43 +00:00
gabriel
5500585c1a naming in conflicts by location instead of date 
Signed-off-by: gabriel <74419649+gabmert@users.noreply.github.com>
 2021-12-15 23:13:42 +01:00
Álvaro Brey
6fc583b4cd
Merge pull request #9362 from nextcloud/dependabot/gradle/workRuntime-2.7.1 
Bump workRuntime from 2.5.0 to 2.7.1
 2021-12-15 19:49:17 +01:00
Álvaro Brey
369f62fc92
Merge pull request #9162 from nextcloud/dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-ktx-2.4.0 
Bump lifecycle-viewmodel-ktx from 2.3.1 to 2.4.0
 2021-12-15 19:23:03 +01:00
Álvaro Brey Vilas
8a445be869
Manifest: update code to disable WorkManagerInitializer 
See: https://developer.android.com/jetpack/androidx/releases/work#version_260_3

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 19:01:36 +01:00
Álvaro Brey Vilas
14fbc2ab78
ViewModelFactory: fix compile errors for viewmodel-ktx changes 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 18:45:06 +01:00
Álvaro Brey Vilas
f5132af345
Fix mockito imports 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 16:08:36 +01:00
Álvaro Brey
508c193dfa
Merge pull request #9448 from nextcloud/fix/share-open-in 
Sharing: better way to send files from file details view
 2021-12-15 13:48:42 +01:00
Álvaro Brey
3b947b981b
Merge pull request #9435 from nextcloud/fix/multi-tap-overflow 
OcFileListFragment: throttle overflow menu clicks
 2021-12-15 13:08:16 +01:00
Álvaro Brey
82a53642a9
Merge pull request #9528 from nextcloud/huaweiFlavor 
Huawei flavor
 2021-12-15 13:07:32 +01:00
Álvaro Brey Vilas
13ddc3ddc6
Delete unused string 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:59:58 +01:00
Álvaro Brey Vilas
a86aa19851
Fix tests 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:59:13 +01:00
Álvaro Brey Vilas
7d258f9793
FileMenuFilter: Allow "Send" for single files if in file detail fragment 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:33:26 +01:00
Álvaro Brey Vilas
038ac7b3c5
FileDetailSharingFragment: remove misleading "Open in..." option 
This only triggered the share file dialog, which should be opened elsewhere.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:33:15 +01:00
Álvaro Brey Vilas
23815a4b6d
Fix ktlint 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 12:21:04 +01:00
Álvaro Brey
587b371e76
Merge pull request #9545 from nextcloud/fix/autoupload-check-crash 
UploadFilesActivity: don't attempt to check selectAll if selectAll is not visible in menu
 2021-12-15 11:28:32 +01:00
Álvaro Brey
143455b42a
Merge pull request #9427 from nextcloud/fix/triplicated-search-events 
Fix issue where favorites where loaded by triplicate when opening from Media or other search
 2021-12-15 11:06:39 +01:00
Álvaro Brey
a9671d9e85
Merge pull request #9434 from nextcloud/fix/unified-search-no-connection 
Unified search: show error when there's no connection
 2021-12-15 11:05:34 +01:00
Álvaro Brey Vilas
e7d8870b07
Move Throttler to proper package 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 10:59:08 +01:00
Álvaro Brey Vilas
11b6420446
Write tests for Throttler 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

Write tests for Throttler

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-15 10:56:57 +01:00
Álvaro Brey
b5e36d25be
Merge pull request #9547 from nextcloud/fix/favorite-state-lost 
OCFileListFragment: don't delete search event if resuming a search fragment
 2021-12-15 09:43:50 +01:00
Nextcloud bot
3f8adc1016
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-15 03:53:06 +00:00
Álvaro Brey Vilas
d503623d1d
OCFileListFragment: don't delete search event if resuming a search fragment 
This fixes a bug where favorites screen seemed empty after coming back from a share fragment.

This took WAY too long to figure out, this class needs a big refactor.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-14 17:52:52 +01:00
tobiasKaminsky
40796f7612
Add huawei build flavor 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-14 08:42:01 +01:00
Álvaro Brey
157f62a775
Merge pull request #9541 from nextcloud/fixUploadFromApps 
"last modified" column might not exist, thus it shall never fail to upload
 2021-12-13 13:04:28 +01:00
Álvaro Brey Vilas
662f15d250
UploadFilesActivity: don't attempt to check selectAll if selectAll is not visible in menu 
This was crashing autoupload settings.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-13 12:50:17 +01:00
Álvaro Brey
e9b13fe45f
Merge pull request #9537 from nextcloud/fix-npe-in-file-uploader 
Do not set notification manager to null in uploader service
 2021-12-13 12:25:41 +01:00
Álvaro Brey
0e45a8611c
Merge pull request #9535 from nextcloud/prevent-player-service-stop-from-using-foreground-service-api 
When stopping PlayerService, do not use foreground service api
 2021-12-13 11:43:57 +01:00
Álvaro Brey
d9874c788c
Merge pull request #8730 from nextcloud/migrate-file-activity-extra-account-to-extra-user 
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER and use User model as well
 2021-12-13 11:37:44 +01:00
tobiasKaminsky
86a5c930b0
"last modified" column may not exist, thus it shall never fail to upload 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-13 09:47:49 +01:00
Nextcloud bot
45b591f3d2
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-13 03:52:57 +00:00
Chris Narkiewicz
0c087012d7
Do not set notification manager to null in uploader service 
NPE is most likely caused by a race condition, when
file upload update arrives after onDestroy().

Do not set notification manager to null - it does not
make any sense anyway, as it's a system service.

Fixes #9390

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-12-12 14:41:48 +00:00
Chris Narkiewicz
989b8aeddb
When stopping PlayerService, do not use foreground service api 
Sending async message to the service using foreground API
requires setting foreground flag. This won't happen if
the service is being stopped, so we must use startService()
API instead.

This API will throw IllegalStateException when app is banned
from running a service due to power management constraints.

Since stopping a service under such condition is not needed
anyway (it is not running), we can safely catch and ignore it.

This happens when app is woken up after long inactivity and
UI is recreated from cache.

Fixes #9491

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-12-12 13:15:20 +00:00
Nextcloud bot
a284b6fcde
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-12 03:54:58 +00:00
Chris Narkiewicz
883857db32
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER 
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER and pass
User model around instead of Account.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-12-12 00:23:40 +00:00
Nextcloud bot
06e1c41884
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-11 03:53:44 +00:00
Álvaro Brey
489eb75858
Merge pull request #9523 from nextcloud/fix/media-preview-navigation 
FileDisplayActivity: Preserve title bar after resume
 2021-12-10 10:33:31 +01:00
Álvaro Brey
8b63aaf2f9
Merge pull request #9522 from nextcloud/fix/search-landscape 
Unified search: clear focus from search view on open
 2021-12-10 10:26:35 +01:00
Nextcloud bot
9358e7d407
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-10 03:57:24 +00:00
Álvaro Brey Vilas
46669cc1d8
FileDisplayActivity: Preserve title bar after resume 
Fixes title bar reverting to searchbar even if the resumed fragment is the preview or the details fragments

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-09 18:32:59 +01:00
Álvaro Brey Vilas
30091a7aa4
Unified search: clear focus from search view on open 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-09 16:58:36 +01:00
Álvaro Brey
0edba984be
Merge pull request #9426 from nextcloud/fix/unified-search-apps 
UnifiedSearch: Fix opening non-file results with relative URLs
 2021-12-09 15:59:31 +01:00
Álvaro Brey
76210ada17
Merge pull request #9494 from nextcloud/fix/calendar-dialog-style 
DatePickerDialog: fix theme
 2021-12-09 15:59:11 +01:00
Álvaro Brey
451c629a44
Merge pull request #9418 from nextcloud/fix/sharing-note-mandatory 
Don't make note mandatory for sharing
 2021-12-09 15:58:46 +01:00
Álvaro Brey
515e3f7089
Merge pull request #9449 from nextcloud/fix/fdf-binding-npe 
FileDetailFragment: prevent NullPointerException if fileDetailSharingFragment is called too soon
 2021-12-09 15:57:52 +01:00
Álvaro Brey
301543455f
Merge pull request #9476 from nextcloud/storeFavoriteAfterFavoritingIt 
After favorite/unfavorite store this also in db, not only change it in UI
 2021-12-09 15:39:05 +01:00
Álvaro Brey
840ec88f57
Merge pull request #9475 from nextcloud/renameFix 
Rename remote path upon renaming
 2021-12-09 15:38:46 +01:00
Álvaro Brey
16d2aa2554
Merge pull request #9474 from nextcloud/fixGallerySearch 
Fix vanishing files after gallery search
 2021-12-09 15:38:28 +01:00
Álvaro Brey
b38905fff7
Merge pull request #9469 from nextcloud/darkModeBackgronud 
Explicitly set background for fragments
 2021-12-09 15:37:58 +01:00
Álvaro Brey
2872f8167e
Merge branch 'master' into translateError 2021-12-09 15:36:57 +01:00
Álvaro Brey
22c308f69a
Merge pull request #9467 from nextcloud/fileSizeInShareDialog 
update file size upon opening share dialog
 2021-12-09 15:36:00 +01:00
Álvaro Brey
4381f7e33c
Merge pull request #9478 from nextcloud/emptyNotCentered 
Empty list is not centered and in landscape cut off
 2021-12-09 15:35:11 +01:00
Álvaro Brey
739364dd63
Merge pull request #9466 from nextcloud/enhancePlayIcon 
Play button as overlay on videos is now more sharpe on large displays
 2021-12-09 15:34:22 +01:00
Álvaro Brey
ad781a4b34
Merge pull request #9465 from nextcloud/trashbinCount 
Update footer upon restore/delete of a deleted file
 2021-12-09 15:34:02 +01:00
Álvaro Brey
aa0914011d
Merge pull request #9464 from nextcloud/drawerHighlight 
highlight correct menu drawer icon
 2021-12-09 15:33:28 +01:00
Álvaro Brey
60aa2becf3
Merge pull request #9463 from nextcloud/highlightSortOrder 
Correctly highlight selected sort order
 2021-12-09 15:33:02 +01:00
Álvaro Brey
ad5c73f5ea
Merge pull request #9462 from nextcloud/expandSendShareDialog 
Expand send share dialog when in landscape mode
 2021-12-09 15:32:37 +01:00
Álvaro Brey
6a3dd84ba1
Merge branch 'master' into unifiedSearch_showNoResults 2021-12-09 15:31:32 +01:00
Álvaro Brey
42212e410e
Merge pull request #9460 from nextcloud/mediaEmpty 
Show correct empty screen if gallery search returns empty
 2021-12-09 15:30:20 +01:00
Álvaro Brey
e33419eb75
Merge pull request #9485 from nextcloud/fixSetPictureAs 
"set picture as" needs temporary read permission
 2021-12-09 15:27:23 +01:00
Álvaro Brey
98319b40d0
Merge pull request #9484 from nextcloud/fix401whenReloggingIn 
when re-logging in too fast, we stored an empty auth token
 2021-12-09 15:27:06 +01:00
Álvaro Brey
63cbb9f2d9
Merge pull request #9483 from nextcloud/audioCoverArt 
Better positioning of preview media fragment
 2021-12-09 15:26:47 +01:00
Álvaro Brey
d0038c6a3b
Merge pull request #9482 from nextcloud/fullscreenToggle 
Fullscreen toggle
 2021-12-09 15:26:13 +01:00
Álvaro Brey
7f6acfc590
Merge pull request #9480 from nextcloud/hideNextButton 
On video player hide next button, as it is always disabled
 2021-12-09 15:26:02 +01:00
Álvaro Brey
ad946c2f73
Merge pull request #9479 from nextcloud/uponMoveUpdateFolderSize 
Upon move update folder size
 2021-12-09 15:25:48 +01:00
Álvaro Brey
0fe6c436ab
Merge pull request #9459 from nextcloud/uploadAskForPermission 
Ask for permission in UploadFilesActivity
 2021-12-09 15:25:32 +01:00
Álvaro Brey Vilas
8a8c7a098f
Remove TODO 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-09 14:57:33 +01:00
Álvaro Brey Vilas
ded48ddba9 Don't make note mandatory for sharing 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-09 13:42:55 +00:00
Álvaro Brey Vilas
bcafbbbd5b
DatePickerDialog: fix theme 
Extend from Dialog, not Dialog.Alert.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-09 14:36:01 +01:00
Álvaro Brey Vilas
af32084d1e Fix upload button not active unless select all is clicked 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-09 08:16:59 +00:00
Nextcloud bot
694b8fda56
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-09 03:57:08 +00:00
tobiasKaminsky
76547ca06d
"set picture as" needs temporary read permission 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-08 15:31:39 +01:00
tobiasKaminsky
1036eaa01f
when re-logging in too fast, we stored an empty auth token 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-08 14:58:21 +01:00
tobiasKaminsky
57f21e50ce
Better positioning of preview media fragment 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-08 10:03:52 +01:00
tobiasKaminsky
09a02767bc
Better fullscreen toggle 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-08 08:44:35 +01:00
Nextcloud bot
b7de19236f
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-08 04:05:40 +00:00
tobiasKaminsky
c7bcc349d0
On video player hide next button, as it is always disabled 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-07 17:31:42 +01:00
tobiasKaminsky
7d3db7c9c3
Upon move update folder size 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-07 16:52:03 +01:00
tobiasKaminsky
e1399f0135
Empty list is not centered and in landscape cut off. 
Therefore as a quick win, moved all up, so that user does not think it should be centered.
This also then works in landscape.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-07 13:30:45 +01:00
tobiasKaminsky
dd366ec494
After favorite/unfavorite store this also in db, not only change it in UI 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-07 09:13:26 +01:00
tobiasKaminsky
ef25d41342
Rename remote path upon renaming 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-07 08:54:21 +01:00
tobiasKaminsky
036e339b07
Fix vanishing files after gallery search 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-07 08:15:49 +01:00
Nextcloud bot
a22e97db73
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-07 05:10:21 +00:00
tobiasKaminsky
40e8ac7c58
Explicitly set background for fragments 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 17:35:16 +01:00
tobiasKaminsky
417365f7ea
Extract string to get translated 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 16:57:52 +01:00
tobiasKaminsky
4a0ec4ece7
update file size upon opening share dialog 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 16:32:41 +01:00
tobiasKaminsky
c85a733190
Play button as overlay on videos is now more sharpe on large displays 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 16:04:11 +01:00
tobiasKaminsky
0996702fd9
Update footer upon restore/delete of a deleted file 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 15:12:27 +01:00
tobiasKaminsky
b557061410
highlight correct menu drawer icon 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 15:03:10 +01:00
tobiasKaminsky
8d94a44066
- correctly highlight selected sort order 
- combine uploadFilesView and localFilesListView enum, as both are the same

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 13:08:50 +01:00
tobiasKaminsky
9e1001a53c
Expand send share dialog when in landscape mode 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 12:45:45 +01:00
tobiasKaminsky
07ece764f9
If no search results from any provider, show it 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 12:21:31 +01:00
tobiasKaminsky
599956370a
fix tests 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 10:30:35 +01:00
tobiasKaminsky
70cb9367ae
Show correct empty screen if gallery search returns empty 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 10:10:29 +01:00
tobiasKaminsky
5ebf79697d
Ask for permission in UploadFilesActivity 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-06 08:34:23 +01:00
Nextcloud bot
b3b1b8dbc0
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-05 04:08:45 +00:00
Álvaro Brey Vilas
b7d51e573a FileDetailFragment: prevent NullPointerException if fileDetailSharingFragment is called too soon 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-03 16:50:37 +01:00
Álvaro Brey
53999c809c
Merge pull request #9433 from nextcloud/refresh 
Refresh on favorite/shared view does search again, not showing root folder content
 2021-12-03 15:31:40 +01:00
Álvaro Brey
fbfdfb02c9
Merge pull request #9431 from nextcloud/showMnemonic 
show mnemonic only if requested
 2021-12-03 15:17:04 +01:00
Álvaro Brey
8625ab9be2
Merge pull request #9425 from nextcloud/updateSelectMenu 
upload files activity: update select all button when selected files changed
 2021-12-03 12:24:14 +01:00
Álvaro Brey
6cb1578983
Merge pull request #9423 from nextcloud/rememberSelectedFilesInUpload 
Remember selected files in upload files activity upon screen rotation
 2021-12-03 12:19:37 +01:00
Álvaro Brey
540ca74eec
Merge pull request #9422 from nextcloud/uploadButtonOnSelectAll 
Upon select all in upload files activity, enable upload button
 2021-12-03 12:12:35 +01:00
Álvaro Brey
532f06a9a5
Merge pull request #9421 from nextcloud/removeUnfavoritedFile 
Remove unfavorited file from favorited search
 2021-12-03 12:00:56 +01:00
Álvaro Brey
fe18e9a710
Merge pull request #9420 from nextcloud/showTrashbinError 
Show trashbin error in a better way
 2021-12-03 11:40:22 +01:00
Álvaro Brey Vilas
42f995bb66 OcFileListFragment: throttle overflow menu clicks 
Fixes #9319

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-02 17:14:59 +01:00
Álvaro Brey Vilas
a94c151228 Unified search: show error when there's no connection 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-02 13:57:06 +01:00
tobiasKaminsky
69486a5428
Refresh on favorite/shared view does search again, not showing root folder content 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-02 13:11:39 +01:00
tobiasKaminsky
552d0a2d39
show mnemonic only if requested 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-02 11:10:59 +01:00
Nextcloud bot
5171d73285
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-01 18:48:41 +00:00
Álvaro Brey Vilas
62df4ff414 OCFileListFragment: Solve triplicated search events 
Most visible when going to Favorites from another search.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-01 18:03:42 +01:00
Álvaro Brey Vilas
8eb2567c78 DrawerActivity: extract duplicated search launch logic to a method 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-01 17:56:02 +01:00
Álvaro Brey Vilas
94e73ba716 UnifiedSearch: Fix opening non-file results with relative URLs 
Most notable in Apps results (Deck, Music...)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-12-01 16:33:37 +01:00
tobiasKaminsky
5511a23748
upload files activity: update select all button when selected files changed 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-01 16:28:38 +01:00
tobiasKaminsky
15674167fb
Remember selected files in upload files activity upon screen rotation 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-01 15:25:31 +01:00
tobiasKaminsky
5b18cf972e
Upon select all in upload files activity, enable upload button 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-01 15:03:17 +01:00
tobiasKaminsky
f4e7bf3ed5
Remove unfavorited file from favorited search 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-01 14:55:01 +01:00
tobiasKaminsky
729d053b9a
Show trashbin error in a better way 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-12-01 14:14:33 +01:00
Álvaro Brey
b17db63964
Merge pull request #9354 from nextcloud/fix/ip-port-login 
Fix crashes during scheme normalization on login
 2021-12-01 10:55:31 +01:00
Álvaro Brey
0f2011c16a
Merge pull request #9395 from nextcloud/fix/delete-media-refresh 
Refresh gallery screen when deleting a file
 2021-12-01 10:48:12 +01:00
Tobias Kaminsky
aa946dc311
Merge pull request #9385 from nextcloud/fix/side-menu-logo-crash 
DrawerActivity: resize server logo if it's too big
 2021-12-01 10:30:51 +01:00
Nextcloud bot
404ad2f9f0
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-12-01 04:01:35 +00:00
Nextcloud bot
3da0ad2027
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-30 03:59:11 +00:00
Álvaro Brey Vilas
63f1654ebf Refresh gallery screen when deleting a file 
Fixes #9370

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-29 17:48:17 +01:00
Álvaro Brey
77dfd96e91
Merge pull request #9286 from Toover/master 
Fix dialog template chooser when new file has no extension #9282
 2021-11-29 16:24:29 +01:00
Álvaro Brey
58828dbc8b
Merge pull request #9249 from nextcloud/compile-sdk-31 
Bump compileSDK to 31
 2021-11-29 14:12:41 +01:00
Nextcloud bot
1c911b15b4
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-29 03:53:31 +00:00
Nextcloud bot
2cee938227
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-27 03:55:21 +00:00
Álvaro Brey Vilas
ff0cb45c03
DrawerActivity: resize server logo if it's too big 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-26 21:03:04 +01:00
tobiasKaminsky
4c62ee6c5a
favorite/unfavorite in details view 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-26 12:29:14 +01:00
Nextcloud bot
ebaced6d34
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-26 04:16:06 +00:00
Álvaro Brey
a98bdd69ce
Merge pull request #9287 from liam-p-23/master 
File rename input warning message
 2021-11-25 14:14:37 +01:00
Álvaro Brey Vilas
8ee7bfd557
Fix lint issues with cursor indexes on compileSdk 31 
Ref: https://stackoverflow.com/a/69979270

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-25 12:57:17 +01:00
Álvaro Brey Vilas
dd07ea17dd Fix another NPE in FileDownloader 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-25 07:47:24 +00:00
Chris Narkiewicz
a84fc6297d Fix NPE regression in FileDownloader 
Fixes #9349

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-11-25 07:47:24 +00:00
Nextcloud bot
6361c19386
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-25 03:54:26 +00:00
Liam P
549750aa73 Changed error color of TextInputLayoutInputWarning 
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
 2021-11-24 15:11:06 -05:00
Nextcloud bot
9ebc2f2b9e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-24 03:56:08 +00:00
Álvaro Brey
f0cd5c2aec
Merge pull request #9335 from nextcloud/remove-account-from-arbitrary-data-provider 
Remove Account from ArbitraryDataProvider
 2021-11-23 10:08:42 +01:00
Álvaro Brey
1572ca7e00
Merge pull request #9342 from nextcloud/fix/davdroid-login 
AndroidManifest: allow querying for davdroid app.
 2021-11-23 10:03:29 +01:00
Nextcloud bot
0997251cd3
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-23 03:57:31 +00:00
Chris Narkiewicz
feb9d6a87f Remove Account from ArbitraryDataProvider 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-11-22 22:50:07 +00:00
Álvaro Brey
de79c93991
Merge pull request #9333 from nextcloud/migrate-ocupload-to-user 
Migate OCUpload to User
 2021-11-22 16:43:39 +01:00
Álvaro Brey
1e5b4604fb
Merge pull request #9330 from nextcloud/remove-account-from-file-data-storage-manager-implementation 
Remove platform Account from FileDataStorageManager implementation
 2021-11-22 16:37:58 +01:00
Álvaro Brey Vilas
cac884f6c2
AndroidManifest: allow querying for davdroid app. 
Fixes #9339

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-22 16:16:04 +01:00
Nextcloud bot
679b3ae029
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-22 04:13:44 +00:00
Nextcloud bot
fb10543c87
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-21 03:53:48 +00:00
Chris Narkiewicz
c8f61f76f5
Migate OCUpload to User 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-11-20 22:19:59 +00:00
Chris Narkiewicz
12e09e8c28
Remove platform Account from FileDataStorageManager implementation 
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
 2021-11-20 14:37:35 +00:00
Nextcloud bot
8eff4f7ddf
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-20 04:13:56 +00:00
Liam P
b0cf10b88a Changed input warning to use TextInputLayout setError 
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
 2021-11-19 19:24:48 -05:00
Liam P
8daf760107 Updated input warning message functionality 
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
 2021-11-19 19:24:36 -05:00
William Plefka
425966a7b8 Updated input warning message functionality 
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
 2021-11-19 19:23:38 -05:00
William Plefka
b3056188e5 Added Javadoc comments 
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
 2021-11-19 19:23:27 -05:00
William Plefka
8d5d7cccc8 Added hidden file warning message to the rename file dialog. Resolves #7722 
Signed-off-by: William Plefka <wplefka2@illinois.edu>
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
 2021-11-19 19:23:11 -05:00
tobiasKaminsky
66459bcfbc
fix FDSM call 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-19 09:00:05 +01:00
Nextcloud bot
38eeebf9ae
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-19 04:37:18 +00:00
Álvaro Brey
373fec8b45
Merge pull request #9073 from nextcloud/remove-deprecated-calls-to-storage-manager-constructor 
Remove deprecated calls to storage manager constructor
 2021-11-18 14:36:03 +01:00
Nextcloud bot
951377de46
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-18 03:50:24 +00:00
Andy Scherzinger
29846c718d
improve detekt score 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2021-11-17 18:15:01 +01:00
Andy Scherzinger
72d81ad06a
Merge pull request #9292 from nextcloud/bugfix/9291/brandedThemedPermissionDialog 
Make permission dialog brandable and themed
 2021-11-17 18:02:22 +01:00
Andy Scherzinger
abce95fd8c
make permission dialog brandable and themed 
Fixes #9291

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2021-11-17 16:23:56 +01:00
Andy Scherzinger
5fd8843c1d
use padding instead of margin for SSO dialog whitespace 
Fixes #9284

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2021-11-17 15:46:50 +01:00
Nextcloud bot
be72eb7429
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-17 05:59:22 +00:00
Toover
1b62ae6847 Fix dialog template chooser when new file has no extension #9282 2021-11-16 19:21:24 +01:00
Álvaro Brey
778736427d
Merge pull request #9248 from nextcloud/fix/unified_seach_crash 
Unified search: fix createNextcloudClient called from main thread
 2021-11-15 19:49:35 +01:00
Álvaro Brey
8646a625b6
Merge pull request #9127 from LisaKirchhofer/status-bar-bugfix 
Bugfix: Issue #9060 (Status bar with sorting/view mode disappears aft…
 2021-11-15 17:16:23 +01:00
Álvaro Brey Vilas
d720ae7f3f
Unified search: createNextcloudClient should not be called from main thread 
Fixes #9244

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-15 16:40:08 +01:00
Álvaro Brey Vilas
18c6baaff0
manifest: Even more intent queries 
Fixes #9270

These are hard to find, man

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-15 13:37:39 +01:00
Álvaro Brey Vilas
fa432834e7
Expand intent query declarations in AndroidManifest 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-15 13:37:29 +01:00
Álvaro Brey
f6a1f4a0f1
Merge pull request #9262 from gmotzespina/master 
Prevent app crash when listening to audio files.
 2021-11-15 11:41:07 +01:00
Álvaro Brey Vilas
a6f3bdceeb
Keep track of PlayerService state instead of restarting it before closing 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-15 10:31:20 +01:00
Guillermo Mtz Espina
12b75dce7b Starts foreground service before stopping it to avoid app crash when listening to an audio file 
Signed-off-by: Guillermo Mtz Espina <gmotzespina@icloud.com>
 2021-11-14 11:40:40 +00:00
tobiasKaminsky
9751de3934
Query Param needs serial uid 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-14 08:17:42 +01:00
Nextcloud bot
507f0ae9be
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-13 03:50:49 +00:00
Nextcloud bot
7a8845777c
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-12 03:45:57 +00:00
Nextcloud bot
a1ce4fd57e
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-11 03:50:41 +00:00
Tobias Kaminsky
cce56c4b2f
Merge pull request #9237 from nextcloud/fix/view-files 
Manifest: allow app to query for apps that can resolve VIEW or SEND intents
 2021-11-10 07:56:36 +01:00
Nextcloud bot
e25c82126f
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-10 03:54:32 +00:00
Álvaro Brey Vilas
80f3f09bd1
Manifest: allow app to query for apps that can resolve VIEW or SEND intents 
This is otherwise limited by default in sdk 30 and above

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-09 16:28:12 +01:00
Álvaro Brey Vilas
fc7f91add8
Remove some unused resources 
Slipped through on MANAGE_EXTERNAL_STORAGE pr

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-09 14:08:08 +01:00
Álvaro Brey
38e78b3f37
Merge pull request #9228 from nextcloud/manage-all-files 
Ditch scoped storage in favor of MANAGE_EXTERNAL_STORAGE
 2021-11-09 12:25:33 +01:00
Álvaro Brey
f0ee7d719e
Merge pull request #9186 from nextcloud/strictMode 
Enable StrictMode during development
 2021-11-09 09:59:03 +01:00
Álvaro Brey Vilas
361ed24bb4
Add dialog to inform the user of storage permission 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-09 09:46:38 +01:00
tobiasKaminsky
9b0db8a355
Enable StrictMode during development 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-09 09:04:25 +01:00
Nextcloud bot
6e9dc44e71
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-09 07:52:44 +00:00
Álvaro Brey
7bd0190c4b
Merge pull request #9225 from nextcloud/wording 
rename "read only" -> "view only"
 2021-11-09 08:30:19 +01:00
Álvaro Brey Vilas
7966fa7923
Re-try to get file management permission if user does not enable it, and show toast. 
Does not allow any usage of the app if permission is not granted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 16:56:22 +01:00
Álvaro Brey Vilas
44968b20ad
PermissionUtil: fix version conditional 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 16:26:44 +01:00
tobiasKaminsky
f4f0c22492
rename "read only" -> "view only" 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-08 14:05:45 +01:00
Álvaro Brey Vilas
3c80a05354
Revert "Use internalTemporalPath instead of temporalPath" 
This reverts commit 1811d040f7.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 13:50:43 +01:00
Álvaro Brey Vilas
41dbdaf3ed
Revert "DownloadFileOperation: use moveFile instead of File.renameTo" 
This reverts commit f18f72abcd.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 13:50:26 +01:00
Álvaro Brey Vilas
5eeb8c0343
Remove What's New screens for scoped storage 
Not needed if we get the manage permission

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 13:46:23 +01:00
Álvaro Brey Vilas
6a76372fde
GrantStoragePermissionRule: grant MANAGE_EXTERNAL_STORAGE on sdk >=30 
Feels a bit hacky but it's the actual recommended way:
https://developer.android.com/training/data-storage/manage-all-files#enable-manage-external-storage-for-testing

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 13:40:17 +01:00
Álvaro Brey Vilas
a0b85cac71
Ditch scoped storage, try MANAGE_EXTERNAL_STORAGE 
We _are_ a file-managing app, after all.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-08 13:13:02 +01:00
Valdnet
a638101359
i18n: Minor changes to sentence 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-11-08 09:02:27 +01:00
Nextcloud bot
dce7eb713a
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-08 06:34:35 +00:00
tobiasKaminsky
915b764f36
Translation files must be one line 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-08 07:04:59 +01:00
Álvaro Brey
518343c4e4
Merge pull request #9195 from nextcloud/whats-new-sdk-30 
Add What's New view to warn users of changes in storage after sdk 30
 2021-11-04 14:35:29 +01:00
Álvaro Brey
35a2324482
Merge pull request #9175 from nextcloud/fix/url-parse-search-result 
Unified search: skip local file check for non-file results
 2021-11-04 14:27:25 +01:00
Álvaro Brey
a994ebc3f4
Merge pull request #9044 from nextcloud/target-sdk-30 
Target SDK 30
 2021-11-04 13:46:16 +01:00
Álvaro Brey Vilas
cb6d9a6c07
What's new: add second page of info for sdk30 storage update 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-04 13:03:14 +01:00
Álvaro Brey Vilas
40860d98be
AppInfo: add getVersionName, remove getFormattedVersionCode 
Only used for WhatsNewActivity, and showing the human-readable string makes more sense.
Also convert the appinfo package to kotlin, since we're at it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-04 12:44:28 +01:00
tobiasKaminsky
c15f64308b Use package specific action 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-11-04 08:21:12 +00:00
Álvaro Brey Vilas
be43a629fd
Add What's New view to warn users of changes in storage after sdk 30 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-03 16:49:20 +01:00
Álvaro Brey Vilas
6d4b3b8444
Fix ktlint 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-03 10:30:10 +01:00
Álvaro Brey Vilas
5e00733912
Add missing copyright header to PermissionUtil 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-03 09:16:22 +01:00
Nextcloud bot
6822cfda6a
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-03 03:50:54 +00:00
Álvaro Brey Vilas
f18f72abcd
DownloadFileOperation: use moveFile instead of File.renameTo 
File.renameTo fails if both files aren't under the same mountpoint.
As the tmp file is in internal storage now, it has to be move differently if the target dir is in external storage.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 16:31:46 +01:00
Álvaro Brey Vilas
1811d040f7
Use internalTemporalPath instead of temporalPath 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 12:59:06 +01:00
Álvaro Brey
578da09f05
Merge pull request #9179 from sryze/contact-settings-back-fix 
Prevent duplicate Settings activity on back stack
 2021-11-02 09:40:28 +01:00
Sergey Zolotarev
f08ad758cd Prevent duplicate Settings activity on back stack 
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
 2021-11-02 14:05:59 +06:00
Álvaro Brey Vilas
063ef4f8df
Fix PermissionUtil after rebase 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:44 +01:00
Álvaro Brey Vilas
0ad8c4350d
Fix storage permissions in debug manifest too 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
886c2574fb
MediaProvider: remove useless parens 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
95c31750a7
AbstractIT: adaptations to make integration tests work in sdk 30 
- Use internal temporal path, as external temporal path is broken in sdk 30
- Don't take snapshots in sdk30 as they crash

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
c1316da717
Request READ_EXTERNAL_STORAGE in API >= 30 
Although scoped storage is in effect and WRITE_EXTERNAL_STORAGE does not do anything,
we still need READ_EXTERNAL_STORAGE to read files from folders we don't own.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
2cb05a17a5
androidTest: Don't request WRITE_EXTERNAL_STORAGE on sdk>=30 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
1154b439fe
ContentResolverHelperTest: use mockitokotlin instead of mockk 
MockK doesn't work properly on android < 27. Lesson learned.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
be830a66c8
COntentResolverHelper: sort column must be an array 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
8860bd4b52
Fix OCFIleListFragmentIT on sdk 30 
Can no longer open /sdcard/ directly, let's use the external files dir

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
aa7b5617ab
ContentResolverHelper: add tests and proper copyright headers 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
6e645f7f06
MediaProvider: solve crash on Android 11 due to invalid contentProvider queries 
This manifested mostly when trying to open "auto upload"

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
d92e3cbfaa
Fix some type errors after sdk 30 bump 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
ac9f516027 Unified search: skip local file check for non-file results 
Fixes https://github.com/nextcloud/android/issues/9171

Needs https://github.com/nextcloud/android-library/pull/739

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-11-02 07:23:33 +00:00
Nextcloud bot
0558b25ee3
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-02 03:49:39 +00:00
Nextcloud bot
346fc512a2
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-11-01 03:48:17 +00:00
Nextcloud bot
3abf27f947
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-10-30 03:50:46 +00:00
Nextcloud bot
f9bfb044dc
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-10-29 03:49:55 +00:00
Álvaro Brey Vilas
9a94ddc1cc
ConnectivityService: handle SecurityException in getNetworkCapabilities 
Bug on Android implementation

See: https://stackoverflow.com/questions/66652819/getting-security-exception-while-trying-to-fetch-networkcapabilities-on-android

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-28 10:13:30 +02:00
Nextcloud bot
da095ddfb6
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-10-28 03:51:04 +00:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-27 08:49:05 +02:00
Nextcloud bot
8c0e77ae93
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-10-27 03:55:09 +00:00
tobiasKaminsky
bbcfdbe98d
Remove unneeded checks for M build target 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-26 07:57:01 +02:00
Nextcloud bot
a946385603
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-10-26 03:50:35 +00:00
Nextcloud bot
2c7c571fca
[tx-robot] updated from transifex 
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
 2021-10-25 14:25:18 +00:00
Tobias Kaminsky
6176998a0e
Merge pull request #9141 from nextcloud/bump-outdated-server-version 
Bump versions before RC
 2021-10-25 16:13:56 +02:00
Tobias Kaminsky
6e76954fcf
Merge pull request #8848 from nextcloud/sharingDialog 
Sharing dialog improvement
 2021-10-25 16:08:23 +02:00
Álvaro Brey Vilas
0984213b62
AndroidManifest: remove resources with maxSDK=22 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:44:36 +02:00
Álvaro Brey Vilas
e99960c59d
TestPowerManagementService: Bump SDK version used for test 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:39:25 +02:00
Álvaro Brey Vilas
16b83131c8
Bump OUTDATED_SERVER_VERSION to 19 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:25:44 +02:00
tobiasKaminsky
0cdfd7a906
Optimize imports 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:18:31 +02:00
tobiasKaminsky
3965f22e7c
remove unused foreground (which was working only on API23+) 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
6fe72782fe
FileDisplayActivity: fix new spotbugs warning 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
d7d3157410
Unified search: solve RTL symmetry warnings 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
631db66da7
Unified search: show context leak in UnifiedSearchViewModel 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
8cadb2b5de
Unified search: add placeholder icon for Deck 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
c51df6fb5b
Unified search: better placeholder icons 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
16100677bb
Unified search: fix inverted success value for "load more" 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
f927cfe2d8
Unified search: Round thumbnails when requested by server 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
b6cd8af18a
GetRemoteFileTask: pass User directly instead of account 
Needed after model changes in master

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
2387545119
Unified search: Fix broken integration test 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:55 +02:00
Álvaro Brey Vilas
18cbdfa93c
Unified search: minor UI improvements 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:55 +02:00
Álvaro Brey Vilas
61c2242896
Unified search: cleanup viewmodel usage with interface 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:54 +02:00
Álvaro Brey Vilas
fdf1abd0fd
Unified search: fix opening non-file results (open in a browser) 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:54 +02:00
Álvaro Brey Vilas
c3a1656781
Unified search: fix existing tests to make CI happy 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:54 +02:00
tobiasKaminsky
73e4f3cf05
fix loading message 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
146650c0c6
Unified search: bind search view on US fragment to allow subsequent searches 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
361e81ea9c
Unified search: set toolbar title to search query 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
3fc6fc8bdf
Unified search: several UI and navigation improvements 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
fac2958788
Unified search: Show error messages, loading anim, click animations. Implement refresh. 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
e898965dc1
Unified search: transform results in ViewModel and fix "load more" behaviour 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
484a506688
Unified search: do not show "load more" if there are no more results 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
e8feb412a4
Unified search: basic "Load more" functionality 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:51 +02:00
Álvaro Brey Vilas
02d133a1c7
Unified search: always show files results first 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:51 +02:00
Álvaro Brey Vilas
6c98b4cb8d
Unified seach: allow querying different providers asynchronously, and get their IDs in the result 
First step towards getting "Load more" working for a single provider

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
b0b9d3a3e3
Unified search: get search to fetch and show multiple providers 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
decfc91d58
FileDisplayActivity: Restore showFile function that was lost in the rebase 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
7d3fbe47d0
Suppress detekt at UnifiedSearchItemViewHolder 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:49 +02:00
Álvaro Brey Vilas
276b8d7b28
Fix build errors after rebase 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:17:49 +02:00
Andy Scherzinger
57732aceb9
ktlint: proper code formatting 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2021-10-25 15:17:49 +02:00
tobiasKaminsky
1136aa3748
wip 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:17:48 +02:00
tobiasKaminsky
232ffe7d5c
wip 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:17:48 +02:00
tobiasKaminsky
96ea22525e
wip 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:17:48 +02:00
tobiasKaminsky
3a39b041de
wip 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:17:46 +02:00
Álvaro Brey Vilas
dc5756246a
Sharing dialog: fix spotbugs 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:13:08 +02:00
Álvaro Brey Vilas
295c24aa78
File sharing: remove unused background parameters that were triggering lint 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:13:07 +02:00
Álvaro Brey Vilas
80327fc3b9
Sharing dialog IT: add retries and sleeps 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:13:07 +02:00
Álvaro Brey Vilas
5afcad3fed
FileSharingFragmentIT: fix test and delete unused variables 
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:13:07 +02:00
tobiasKaminsky
891146eb8a
Reduce lint 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:13:06 +02:00
Álvaro Brey Vilas
b367684e21
Patch up integration tests for file sharing 
This requires a lot of dodgy code, unfortunately. A refactor is greatly needed here.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:13:06 +02:00
Álvaro Brey Vilas
42ac3bcb11
Sharing dialog: fix accessibility in bottom sheet 
Add min height for touchable area.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
 2021-10-25 15:13:06 +02:00
tobiasKaminsky
80b8173e45
fix ktlint 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:13:06 +02:00
A117870935
df6d590196
Sharing dialog improvement 
changed overflow menu items for sharing files and folders

completed NMCLOUD-350 for share permissions and fixed test cases as per new changes

permission menu code optimisation

added permission display to share fragment list items

fixed permission issue for files, added strings for german

changed sharing process for internal and external share by creating new full screen permission and note ui.
created new remote operation to share the file/folder with permissions

changed sharing menu options from popup to bottom sheet for all shares, modified options for link share

test cases written for updated sharing process

updated PR as per Tobias feedback:
1. Failed test cases reverted
2. Quick permissions sheet modified
3. Minor UI changes done.
4. Commented code removed

copyright header added

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2021-10-25 15:12:58 +02:00
Tobias Kaminsky
215c1c90db
Merge pull request #9015 from nextcloud/calendarSync 
Calendar backup/import
 2021-10-25 15:09:11 +02:00
Tobias Kaminsky
d544e18960
Merge pull request #9112 from nextcloud/profilePage 
Profile page
 2021-10-25 15:07:32 +02:00