Commit graph

8560 commits

Author SHA1 Message Date
Andy Scherzinger
cc2593cbdb
proper icon display for night theme for activities and notifications
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:29 +01:00
Andy Scherzinger
44020dcc76
make progress bar day/night aware
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:28 +01:00
Andy Scherzinger
375fb97c06
use day/night color
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:27 +01:00
Andy Scherzinger
9a88ee24d3
remove unused radio button preference code
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:25 +01:00
Andy Scherzinger
5554585348
make toolbar menu use the proper day/night popup theme
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:24 +01:00
Andy Scherzinger
1bdccebce8
use proper colors storage selector text
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:23 +01:00
Andy Scherzinger
e14dc52fa7
use correct color after rebase
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:22 +01:00
Daniel Bailey
6bb9a70603
Various improvements to dark theme
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-28 12:59:22 +01:00
Andy Scherzinger
6eb0744986
use proper color for storage location text
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:21 +01:00
Andy Scherzinger
8f8b67f57f
don't tint avatars within the drawer menu
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:59:20 +01:00
Daniel
689a0a216b
"Activities" drawer selection background colour.
Signed-off-by: Daniel <daniel.bailey@grappleit.co.uk>
2019-10-28 12:58:51 +01:00
Andy Scherzinger
b7e9d3f954
remove unused theme getter from interface
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:51 +01:00
Daniel Bailey
8d0ff8fecc
Corrects "Choose" button colour in FolderPickerActivity. Removes un-used import from NotificationListAdapter.
MaterialButtons.
SearchView highlight text colour.
First run activity, outlined button colour.

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:50 +01:00
Daniel Bailey
c7049788f7
DatePickerDialog theme and style.
Button styling.
Small improvements to layouts and correction of spelling errors.
Sets edittext highlight colour to theme colour.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:07 +01:00
Andy Scherzinger
30a5ec6ee1
improve codacy score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:07 +01:00
Andy Scherzinger
562338cad1
set background color for primary action buttons on upload and participate
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:06 +01:00
Andy Scherzinger
913d8276e1
use xml drawables for shared state icon including day/night state
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:05 +01:00
Andy Scherzinger
790e3fa2f8
findbugs: accesses list or array with constant index
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:04 +01:00
Andy Scherzinger
3d60c83ba2
use right colors for drawer menu item text and icons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:04 +01:00
Andy Scherzinger
55a32df928
use style instead of theme attribute for secondary action buttons
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:58:03 +01:00
Daniel
27b8ed4327
Dark theme v1
Fixing migration to androidx
Dark theme styling
File details fragment tab text colour
File list overflow menu background colour

Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-28 12:57:58 +01:00
Tobias Kaminsky
98487b501d
Merge pull request #4733 from nextcloud/codacy
Codacy
2019-10-28 11:17:13 +01:00
Daniel Bailey
bf0779a3ed
Update to Alert Dialogs in api 21 and upwards.
Signed-off-by: Daniel Bailey <daniel.bailey@grappleIT.co.uk>
2019-10-27 20:51:01 +00:00
Nextcloud bot
17709cc692
[tx-robot] updated from transifex 2019-10-27 03:06:49 +00:00
Andy Scherzinger
2bb13a1545
move suppress annotation to newly created method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 09:36:58 +02:00
Nextcloud bot
a098a5cf22
[tx-robot] updated from transifex 2019-10-26 03:08:29 +00:00
Andy Scherzinger
a6fdec8656
shorten method
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:33:03 +02:00
Andy Scherzinger
1d3fca653f
codacy: Avoid declaring a variable if it is unreferenced before a possible exit point.
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:22:34 +02:00
Andy Scherzinger
816991c172
codacy: avoid unused imports
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-26 04:20:27 +02:00
Tobias Kaminsky
ba3c2ca8bc daily dev 20191026
4f8fc49d1 Merge pull request #4730 from nextcloud/taskTwice
ea77b4497 Merge pull request #4731 from nextcloud/markdownPreview_cleanup
1ecd563b5 remove unused dependencies
0444d07b0 Merge pull request #4728 from nextcloud/markdownPreview_Theming
44fefe906 fix notification task, if it failed first
5ec79a9ff [tx-robot] updated from transifex
01c480f01 daily dev 20191025
2019-10-26 03:36:47 +02:00
Andy Scherzinger
4f8fc49d15
Merge pull request #4730 from nextcloud/taskTwice
fix notification task, if it failed first
2019-10-25 10:18:10 +02:00
Tobias Kaminsky
0444d07b02
Merge pull request #4728 from nextcloud/markdownPreview_Theming
Theming for rendering markdown
2019-10-25 09:18:42 +02:00
tobiasKaminsky
44fefe9064
fix notification task, if it failed first
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-25 09:16:58 +02:00
Nextcloud bot
5ec79a9ff5
[tx-robot] updated from transifex 2019-10-25 03:08:36 +00:00
Tobias Kaminsky
01c480f01f daily dev 20191025
272f6203b Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
75dd657ba Merge pull request #3905 from jmue/storageprovider
8a3ea78a5 Merge pull request #4701 from nextcloud/markdownPreview_SyntaxHighlighting
d5ff4f9a4 Fix spotbugs filter
7f0e6beb8 try to correct regex for spotbugs ignore
0e90952b5 increase spotbugs due to unfixable warning
669ad540e minor refactoring due to codacy
93f384817 proper spotbugs exclusion
f5ebba9ef use consistent dependency referencing style
587c8f74a Merge pull request #4716 from nextcloud/davX5loginFlow
9eb77178e Merge pull request #4726 from nextcloud/npeNote
1ef6f5820 ignore library code of markdown render dependencies
bf43a798d add syntax highlighting to markdown rendering * bump gradle memory due to GC mem limit during code generation (gradle.properties)
622cc45e7 use new login flow only when we have a server url
ccd6dfaec NPE in setting note
71bb3124f Merge pull request #4724 from nextcloud/dependabot/gradle/daggerVersion-2.25.2
99368fa3f [tx-robot] updated from transifex
1afb02567 daily dev 20191024
2019-10-25 03:36:52 +02:00
Andy Scherzinger
460b5a75cd
repect theming colors when rendering markdown
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-24 20:30:48 +02:00
Andy Scherzinger
75dd657ba8
Merge pull request #3905 from jmue/storageprovider
enhance DocumentsProvider
2019-10-24 19:18:59 +02:00
Andy Scherzinger
8a3ea78a55
Merge pull request #4701 from nextcloud/markdownPreview_SyntaxHighlighting
Markdown preview syntax highlighting
2019-10-24 16:11:04 +02:00
tobiasKaminsky
669ad540e5
minor refactoring due to codacy
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 13:24:14 +02:00
Andy Scherzinger
587c8f74a1
Merge pull request #4716 from nextcloud/davX5loginFlow
DavX5: support login flow
2019-10-24 10:36:15 +02:00
Andy Scherzinger
bf43a798df
add syntax highlighting to markdown rendering
* bump gradle memory due to GC mem limit during code generation (gradle.properties)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-24 09:29:41 +02:00
tobiasKaminsky
622cc45e72
use new login flow only when we have a server url
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 09:10:48 +02:00
tobiasKaminsky
ccd6dfaec0
NPE in setting note
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-24 08:47:11 +02:00
Nextcloud bot
99368fa3f7
[tx-robot] updated from transifex 2019-10-24 03:08:02 +00:00
Tobias Kaminsky
1afb02567f daily dev 20191024
3dcbfa123 Merge pull request #4712 from nextcloud/fetchRemoteFile
3e34679dc Bump daggerVersion from 2.24 to 2.25 (#4721)
e9cf6be69 [tx-robot] updated from transifex
59c3690c8 [tx-robot] updated from transifex
5fe1835b1 daily dev 20191022
2019-10-24 03:36:25 +02:00
Jens Mueller
62f7c479fa
fix file creation time
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
332e67c72d
refactor/cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
8d24d80fdc
Revert "reduce contentresolver/sql queries"
This reverts commit ec5a73142dee30cd909db9e68b97ef65456f7c48.

Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:36 +02:00
Jens Mueller
5de451fa98
fix initialization of storage manager collection
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
fa5e5dd8cd
notify storageprovider on account creation/removal
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
cfd3aab952
reduce contentresolver/sql queries
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:34 +02:00
Jens Mueller
a2350598da
fix isChildDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:33 +02:00
tobiasKaminsky
b2eacc46b4
- fix error when temp folder does not yet exist
- do not use FileUploader for uploads

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 17:27:32 +02:00
Jens Mueller
a14747623d
move checks into toDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:32 +02:00
Jens Mueller
65655c5753
fix build
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:31 +02:00
Jens Mueller
3693ad88c1
remove unused imports
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
fbff63bb02
fix lint warnings
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
dddffce2a1
fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:29 +02:00
Jens Mueller
e62879ac91
cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
fe43e503a3
cleanup/fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
7f157a9ff1
enhance documents storage provider
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:24 +02:00
Andy Scherzinger
3dcbfa1236
Merge pull request #4712 from nextcloud/fetchRemoteFile
Fix possible IndexOutOfBoundsException if returned array is empty
2019-10-23 14:24:52 +02:00
tobiasKaminsky
2911a86263
DavX5: support login flow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 13:47:33 +02:00
Nextcloud bot
e9cf6be691
[tx-robot] updated from transifex 2019-10-23 03:07:48 +00:00
Nextcloud bot
59c3690c87
[tx-robot] updated from transifex 2019-10-22 03:08:34 +00:00
Tobias Kaminsky
5fe1835b14 daily dev 20191022
adc74c1e4 Bump fb-contrib from 7.4.6 to 7.4.7 (#4711)
123e708b7 Merge pull request #4710 from nextcloud/ezaquarii/eliminate-account-status-flags-from-base-activity
148cef835 [tx-robot] updated from transifex
b7cdaf310 Eliminate account status flags from BaseActivity
17a6ba2d2 daily dev 20191019
2019-10-22 03:37:17 +02:00
Tobias Kaminsky
123e708b7a
Merge pull request #4710 from nextcloud/ezaquarii/eliminate-account-status-flags-from-base-activity
Eliminate account status flags from BaseActivity
2019-10-21 16:02:12 +02:00
tobiasKaminsky
750c0a7677
Fix possible IndexOutOfBoundsException if returned array is empty
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-21 08:27:10 +02:00
Nextcloud bot
148cef835f
[tx-robot] updated from transifex 2019-10-21 03:08:30 +00:00
Chris Narkiewicz
b7cdaf310b
Eliminate account status flags from BaseActivity
onAccountSet(stateWasRecovered) is no longer used anywhere,
so the flag mAccountWasRestored can be safely removed.

This intermediary step opens path to eliminating
out of band calls to onAccountSet().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-20 23:27:41 +01:00
Tobias Kaminsky
17a6ba2d2f daily dev 20191019
954c76b11 Merge pull request #4692 from nextcloud/markdownPreview
2a8164acf Merge pull request #4700 from nextcloud/account-cleanup-receive-external-file-activity
76622c886 [tx-robot] updated from transifex
8fa348f80 Bump findsecbugs-plugin from 1.9.0 to 1.10.0 (#4703)
e31ff9901 daily dev 20191018
2019-10-19 03:38:21 +02:00
Tobias Kaminsky
954c76b11b
Merge pull request #4692 from nextcloud/markdownPreview
Markdown rendering
2019-10-18 10:21:01 +02:00
Tobias Kaminsky
2a8164acf1
Merge pull request #4700 from nextcloud/account-cleanup-receive-external-file-activity
Remove onAccountSet from ReceiveExternalFilesActivity
2019-10-18 10:17:48 +02:00
Nextcloud bot
76622c8861
[tx-robot] updated from transifex 2019-10-18 07:12:22 +00:00
Tobias Kaminsky
e31ff9901f daily dev 20191018
16cc46f4e Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity
d9567a2bb Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview
2d9afe36c Merge pull request #4688 from nextcloud/account-cleanup-share-activity
f4a27cc5d Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity
d237a834b Merge pull request #4699 from nextcloud/removeUploadPathActivity
64c986eaf Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity
56d188086 Bump powermock-core from 2.0.2 to 2.0.4 (#4695)
ca77c7a2d Bump powermock-api-mockito2 from 2.0.2 to 2.0.4 (#4696)
baaf5d4f4 Bump powermock-module-junit4 from 2.0.2 to 2.0.4 (#4697)
ab904e336 We do not use UploadPathActivity anymore(?)
9773dc43c Merge pull request #4694 from nextcloud/account-cleanup-conflicts-resolve-activity
ae6cfb34c daily dev 20191017
2019-10-18 03:36:24 +02:00
Andy Scherzinger
95e14df1d7
Add markdown rendering to TextPreview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-17 19:57:51 +02:00
Chris Narkiewicz
5d6e316570
Remove onAccountSet from ReceiveExternalFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-17 15:45:00 +01:00
Tobias Kaminsky
16cc46f4ed
Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity
Remove onAccountSet from UploadFilesActivity
2019-10-17 15:22:10 +02:00
Tobias Kaminsky
d9567a2bb6
Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview
Remove onAccountSet from image and video preview activities
2019-10-17 15:21:54 +02:00
Tobias Kaminsky
2d9afe36c9
Merge pull request #4688 from nextcloud/account-cleanup-share-activity
Remove onAccountSet from ShareActivity
2019-10-17 15:21:44 +02:00
Tobias Kaminsky
f4a27cc5dc
Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity
Remove onAccountSet from FileDisplayActivity
2019-10-17 14:58:13 +02:00
Tobias Kaminsky
d237a834b8
Merge pull request #4699 from nextcloud/removeUploadPathActivity
We do not use UploadPathActivity anymore(?)
2019-10-17 11:39:12 +02:00
Tobias Kaminsky
64c986eaf2
Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity
Remove onAccountSet from FolderPickerActivity
2019-10-17 11:38:08 +02:00
tobiasKaminsky
ab904e336b
We do not use UploadPathActivity anymore(?)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-17 08:23:15 +02:00
Tobias Kaminsky
9773dc43cf
Merge pull request #4694 from nextcloud/account-cleanup-conflicts-resolve-activity
Remove onAccountSet from ConflictsResolveActivity
2019-10-17 07:48:30 +02:00
Tobias Kaminsky
ae6cfb34ce daily dev 20191017
e47daaffd Merge pull request #4684 from nextcloud/codacy2
3ef96f887 Merge pull request #4677 from nextcloud/deprecate-set-account-logic
4f815e47b daily dev 20191016
2019-10-17 03:36:14 +02:00
Chris Narkiewicz
451cec9f3a
Remove onAccountSet from ConflictsResolveActivity
Deprecated onAccountSet logic simply inlined in onStart.
No change of control flow.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:12:09 +01:00
Chris Narkiewicz
e5a6accf66
Remove onAccountSet from FileDisplayActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:07:50 +01:00
Chris Narkiewicz
b199a62b78
Remove onAccountSet from image and video preview activities
Both callbacks are directly called from onStart().
Since callback parameter is unused, inline the
callback code in onStart().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:57:11 +01:00
Chris Narkiewicz
f428fb5810
Remove onAccountSet from UploadFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:55:39 +01:00
Chris Narkiewicz
6a88a02f94
Remove onAccountSet from ShareActivity
Since onAccountSet is called directly from onStart,
we can inline the code in onStart safely.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:54:30 +01:00
Chris Narkiewicz
3519d04eea
Remove onAccountSet from FolderPickerActivity
Move onAccountSet body to onStart.
Unconditionally reset fragment state, since the
acctount restoration flag is no longer available.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:50:21 +01:00
Andy Scherzinger
e47daaffdc
Merge pull request #4684 from nextcloud/codacy2
more codacy fixes
2019-10-16 17:42:07 +02:00
Tobias Kaminsky
3ef96f8877
Merge pull request #4677 from nextcloud/deprecate-set-account-logic
Deprecate setAccount logic and remove accounWasSet flag
2019-10-16 14:57:46 +02:00
Tobias Kaminsky
4f815e47bc daily dev 20191016
862e5d477 Merge pull request #4537 from nextcloud/ezaquarii/migrate-ncontentobserverjob-to-workmanager
8cbabf08e add license header
54e5ce3ae Merge pull request #4683 from nextcloud/fixSorting
2286981db Merge pull request #4681 from nextcloud/codacy
1b0d548c6 fix sorting of synced folder: NPE if both enabled, but one has null folder name
31b62a863 Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
2ab45a72a codacy: Deeply nested if..then statements are hard to read
2dabd04aa codacy: These nested if statements could be combined
e0802a0da codacy: Avoid using Literals in Conditional Statements
638a5b9fc codacy: Avoid unused imports such as 'androidx.fragment.app.Fragment'
ab6424701 codacy: Avoid unused method parameters such as 'appVersion'.
a73031148 Merge pull request #4679 from nextcloud/dependabot/gradle/com.pinterest-ktlint-0.35.0
26297005c [tx-robot] updated from transifex
df6504e6b Bump ktlint from 0.34.2 to 0.35.0
d189867d3 [tx-robot] updated from transifex
d3b0880e3 [tx-robot] updated from transifex
fc355d169 daily dev 20191012
2019-10-16 03:36:36 +02:00
Andy Scherzinger
7f209618eb
codacy: shorten method length
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 16:38:01 +02:00
Andy Scherzinger
9beecfa184
codacy: Document empty constructor (rather make setting flag more explicit in this case)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 15:57:53 +02:00
Andy Scherzinger
670e9d3a61
codacy: Ensure you override both equals() and hashCode()
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-15 15:57:45 +02:00
Andy Scherzinger
862e5d4776
Merge pull request #4537 from nextcloud/ezaquarii/migrate-ncontentobserverjob-to-workmanager
Migrate NContentObserverJob to WorkManager
2019-10-15 15:23:15 +02:00
tobiasKaminsky
8cbabf08e5
add license header
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-15 13:41:27 +02:00