Commit graph

11859 commits

Author SHA1 Message Date
Álvaro Brey Vilas
bfffad6bf4
DocumentsStorageProvider: clean up download threading
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-08 11:33:24 +01:00
akallabeth
a8c85a376d
Fix #9842: Run DocumentProvider.openDocument network operations in async task
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-08 11:33:19 +01:00
Álvaro Brey Vilas
b5f727f945 RetryTestRule: don't modify in scripts, use buildConfigField instead
Modifying code in scripts is bad

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-08 09:43:38 +00:00
Álvaro Brey
fb6d8f8263
Merge pull request #9898 from nextcloud/chore/no-more-second-fragment
FileDisplayActivity: finally get rid of secondFragment
2022-03-08 10:23:26 +01:00
Nextcloud bot
4a9338d4fe
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-08 03:58:09 +00:00
Álvaro Brey Vilas
6b3742a131
SyncedFoldersActivity: cancel loading when activity stops
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-07 14:47:18 +01:00
Nextcloud bot
02dbe46d78
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-05 03:54:31 +00:00
Álvaro Brey Vilas
dc4f4bc512
SyncedFolderAdapter: load thumbnails in parallel instead of sequentially
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-04 17:29:51 +01:00
Álvaro Brey Vilas
c488b0b330
SyncedFoldersActivity: load content asynchronously
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-04 17:21:32 +01:00
Álvaro Brey Vilas
6b67362b7b
SyncedFoldersActivity: convert to Kotlin (step 2)
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-04 17:09:50 +01:00
Álvaro Brey Vilas
aad327de21
SyncedFoldersActivity: conver to Kotlin (step 1)
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-03-04 16:23:45 +01:00
Nextcloud bot
c08cfd9c8f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-03 03:55:42 +00:00
Álvaro Brey
3383a6781a
Merge pull request #9884 from nextcloud/creationTime
Correct handling of creation timestamp
2022-03-02 12:52:16 +01:00
Álvaro Brey
263413d53f
Merge pull request #9881 from nextcloud/customCertInEditorWebView
Allow accessing URLs with custom cert in editor
2022-03-02 10:32:09 +01:00
Álvaro Brey
d9c605e425
Merge pull request #9896 from nextcloud/fix/preview-shared
PreviewImageActivity: don't try to use virtual folder is type is NONE
2022-03-01 16:56:15 +01:00
Álvaro Brey
4dfd837257
Merge pull request #9897 from nextcloud/fix/selection-clear-titlebar
OCFileListFragment: don't reset title after clearing action mode (multiselect)
2022-03-01 16:55:27 +01:00
Unpublished
3c002fa0c3
Allow EditorWebView accessing URLs with custom certificate
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>

Drone: update Lint results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>

Drone: update FindBugs results to reflect reduced error/warning count

Signed-off-by: nextcloud-android-bot <drone@nextcloud.com>
2022-03-01 16:26:37 +01:00
Álvaro Brey Vilas
39094c0ef7
UploadFileOperation: fix creationTimestamp type
Thanks, spotbugs

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 17:48:34 +01:00
Álvaro Brey Vilas
7ff1d0d7d3
GalleryFragment: restore title and fab on resume
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 17:33:08 +01:00
Álvaro Brey Vilas
eeee11e427 PreviewImageActivity: don't try to use virtual folder is type is NONE
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 14:11:09 +00:00
Álvaro Brey Vilas
967327e321 OCFileListFragment: don't reset title after clearing action mode (multiselect)
This breaks the title when in a virtual folder. There's no need for this, as the title is preserved anyway

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 14:10:57 +00:00
tobiasKaminsky
6d6339ebf6 Correct handling of creation timestamp
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-28 14:10:39 +00:00
Álvaro Brey Vilas
dd4770669f FileDisplayActivity: finally get rid of secondFragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 14:10:19 +00:00
Álvaro Brey Vilas
ba21b3a43f
OCFile: fix NPE in getLocalId when remoteID is null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-28 12:51:05 +01:00
Nextcloud bot
b8aa447056
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-28 04:13:54 +00:00
Nextcloud bot
76c5dded8f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-26 03:53:55 +00:00
tobiasKaminsky
8401427d96
Remove not needed toString() call
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Update src/main/java/com/owncloud/android/db/OCUpload.java

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-02-25 14:46:27 +01:00
tobiasKaminsky
7c7e7e845d remoteId not needed when deleting a file
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-25 12:49:47 +00:00
Nextcloud bot
5d943ad24b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-25 03:53:59 +00:00
Álvaro Brey Vilas
1a0d3ed65b
Cleanup
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-24 11:49:20 +01:00
Álvaro Brey Vilas
5d07c4c6e4
Better exception report template
With markdown now

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-24 11:42:55 +01:00
Álvaro Brey Vilas
4cc4418bec
ExceptionHandler: format entire stack trace recursively
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-24 11:03:32 +01:00
tobiasKaminsky
53a04af735
Add stacktrace directly to github issue
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-24 11:03:26 +01:00
Álvaro Brey
9b3c08efcd
Merge pull request #9880 from nextcloud/fixLoggerImpl
Fix LoggerImpl to also log throwable
2022-02-24 10:15:58 +01:00
Nextcloud bot
b124793817
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-24 03:56:56 +00:00
Unpublished
f50def5e0d Fix LoggerImpl to also log throwable
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-23 22:02:59 +01:00
Unpublished
fcd1ab88b5 Migrate from Parceler to kotlin-parcelize
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-23 17:08:32 +01:00
Álvaro Brey
00009680a3
Merge pull request #9859 from nextcloud/fix/video-stacking
Misc fixes for video player
2022-02-22 12:09:26 +01:00
Nextcloud bot
8f6e8f4927
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-22 03:56:19 +00:00
Álvaro Brey Vilas
71c0f657e2
PreviewVideoActivity: improve button UX
- Add ripple on button click
 - Only show play OR pause button depending on playback state

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:43 +01:00
Álvaro Brey Vilas
87e508d2b1
Restore fast forward/rewind buttons in fullscreen video
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
7d89d68df6
PreviewVideoActivity: convert to Kotlin
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
329dea57a3
PreviewMediaFragment: fix restoring seek position when returning from fullscreen stream
The stream asynctask was just ignoring the saved time

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
11e472b18b
PreviewVideoActivity: fix control buttons
For some reason only previous/next were working.

Manually bind play and pause, and remove the rest

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
22555a901a
PreviewVideoActivity: pause player when activity stops
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
e419144456
PreviewVideoActivity: ensure player is stopped when closing fullscreen
This already worked for onBackPressed

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey Vilas
686748dda2
PreviewMediaFragment: stop video when stopping activity, and don't recreate existing player
This avoids multiple instances of the player opening when minimizing the app, for example.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-21 17:39:42 +01:00
Álvaro Brey
c9018f8ba6
Merge pull request #9862 from nextcloud/fixLeakedCloseableViolation
Fix LeakedCloseableViolations in getScaledBitmap
2022-02-21 11:36:38 +01:00
Álvaro Brey
cb9d9ff1a2
Merge pull request #9858 from nextcloud/fix/preview-share
Fix UX issues with toolbar in preview media fragment when using the "share" option
2022-02-21 09:46:28 +01:00
Nextcloud bot
e4da58cfd2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-21 03:55:57 +00:00
Unpublished
67397a4d7b Fix LeakedCloseableViolations in getScaledBitmap
Signed-off-by: Unpublished <unpublished@users.noreply.github.com>
2022-02-20 12:56:28 +01:00
Nextcloud bot
5250b7380c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-20 03:55:24 +00:00
Nextcloud bot
c704f59b37
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-19 03:55:54 +00:00
Álvaro Brey Vilas
7625275b07
Fix toolbar in PreviewMediaFragment after coming back from sharing fragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-18 13:48:17 +01:00
Álvaro Brey Vilas
66125d6a27
FileDisplayActivity: fix coordinator scrolling when opening share details from media preview
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-18 13:31:15 +01:00
thelittlefireman
9e7a9b410f
Add scan document feature
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-17 10:10:36 +01:00
Nextcloud bot
ee000f7b4e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-17 03:55:25 +00:00
Tobias Kaminsky
1e33020f80
Merge pull request #9783 from nextcloud/mediaEnhancement
Enhance media tab
2022-02-16 10:42:33 +01:00
Álvaro Brey
f9febe24ad
Fallback pdf viewer (#9806)
* Basic PDF preview

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Preview pdf: add dividers between pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Prefer third-party pdf viewers over fallback viewer

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Zoomable view for pdf pages

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

pdf preview: Show tip to indicate that zooming on images is possible

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Fix spotbugs and lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix toolbar when resuming

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewBitmapActivity: add screenshot test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* PreviewPdfFragment: fix crash in screenshot tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: rename tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* pdf preview: Update copyright headers

Oops

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: use grey for background instead of black

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: add scrollbar

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: show zoom tip 3 times instead of only once

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

* Pdf preview: fix lint and improve styling

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 15:04:16 +01:00
Tobias Kaminsky
9723c0458e
Merge pull request #9816 from nextcloud/pin
Improve PIN lockout handling
2022-02-15 14:54:08 +01:00
tobiasKaminsky
ea863cd04c
Fix test, satisfy spotbugs
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 14:52:55 +01:00
Álvaro Brey Vilas
df3c98a0c4
PassCodeManager: use abstracted Clock implementation rather than system clock directly
Improves testability

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 11:23:36 +01:00
Álvaro Brey Vilas
aafa7780f6
PassCodeActivity: update lock timestamp when lock has just been set
Prevents asking for pass immediately after setting it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-15 10:27:11 +01:00
tobiasKaminsky
607d008a75
Make use of upload and creation timestamp
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:43:32 +01:00
tobiasKaminsky
3584b90bc6
Show empty message if no results
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:36:52 +01:00
tobiasKaminsky
b2bfd985da
Remove not needed check
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 09:23:50 +01:00
tobiasKaminsky
0624e7eef3
Satisfy CI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-15 08:37:25 +01:00
Nextcloud bot
ac68a9269e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-15 05:33:30 +00:00
Álvaro Brey Vilas
8b03556f71
PassCodeManager: convert to Kotlin, clean up, use injection
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-14 18:28:56 +01:00
Álvaro Brey Vilas
579af4ab30
PassCodeManager: don't count passcode/credentials activity towards activity counter
This prevents repetition attacks

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-14 17:28:46 +01:00
Álvaro Brey
6d6183b3b0
Merge pull request #9208 from nextcloud/flaky-tests-again
Add RetryTestRule to DrawerActivityIT
2022-02-14 11:16:18 +01:00
Álvaro Brey
69033e25e9
Merge pull request #9823 from nextcloud/chore/mockitokotlin2
Chore: replace `com.nhaarman.mockitokotlin2` with `org.mockito.kotlin`
2022-02-14 11:09:47 +01:00
Tobias Kaminsky
b81027d057
Merge pull request #9791 from nextcloud/fix/shares-downloading-crash
FileActivity: fix crash on share operations when FileDetailFragment is second fragment
2022-02-14 09:06:22 +01:00
Tobias Kaminsky
c41f87d281
Merge pull request #9822 from nextcloud/chore/conflicts-dialog-logs
ConflictsResolveActivity: Add log messages when dialog can't be created
2022-02-14 09:00:28 +01:00
Tobias Kaminsky
1d4bc98de7
Merge pull request #9812 from nextcloud/avatarSize
Use 512px for avatar
2022-02-14 08:47:33 +01:00
Tobias Kaminsky
8b0674e29f
Merge pull request #9808 from nextcloud/resumeText
resuming TextEditor after splitting screens works now again
2022-02-14 08:40:09 +01:00
Tobias Kaminsky
541e55ff1c
Merge pull request #9821 from nextcloud/fix/db-upgrade-crash
FileContentProvider: fix crash on certain upgrades
2022-02-14 08:30:47 +01:00
tobiasKaminsky
fa73725815 Pin: use activity paused also, as stopped is sometimes too slow
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:30:00 +00:00
tobiasKaminsky
556f856ac3
Update adapter after finish search (success/failure)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
e17beb00ad
Do not show meta info (favorite, download status) in media view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
256656af5d
correctly return result
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
307a407631
fix reloading bug
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
07885c3a18
refactor/ clean up
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
5140d8d99f
sql typo
fix not showing images

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:51 +01:00
tobiasKaminsky
3bfc373e50
Enhance media tab
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-14 07:35:50 +01:00
Nextcloud bot
6b8ce02a2e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-14 03:55:09 +00:00
Nextcloud bot
bbf1032845
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-12 03:55:56 +00:00
Álvaro Brey Vilas
2a6398adda
Chore: replace com.nhaarman.mockitokotlin2 with org.mockito.kotlin
It has been integrated into the main mockito org, and the old ID no longer receives updates

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 18:32:15 +01:00
tobiasKaminsky
e20555f5d0 resuming TextEditor after splitting screens works now again
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 16:59:13 +00:00
Álvaro Brey Vilas
c506cda8a6 FileDisplayActivity: ditch secondFragment for FileDetailsFragment, use leftFragment instead
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
d82a989378 FileActivity: fix crash on share operations when FileDetailFragment is second fragment
When a file is downloaded, FileDetailFragment is opened as SECOND_FRAGMENT instead of LIST_OF_FILES, which breaks this logic.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 16:49:57 +00:00
Álvaro Brey Vilas
9cf0f1d6fa
ConflictsResolveActivity: Add log messages when dialog can't be created
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 17:33:58 +01:00
Álvaro Brey Vilas
b5d338fb8d
FileContentProvider: fix crash on certain upgrades
checkIfColumnExists should not use getColumnIndexOrThrow, as it's supposed to check if the index doesn't exist

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-11 13:57:03 +01:00
tobiasKaminsky
7ddbb65ca2 Use 512px for avatar
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 11:09:23 +00:00
tobiasKaminsky
1c9a3e0208 For display with >= 600dp use higher file icon resolution
use this resolution also default thumbnails

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-02-11 11:09:20 +00:00
Álvaro Brey
4d9c878d4f
Merge pull request #9801 from nextcloud/chore/test-sort-order
Update sorting tests
2022-02-07 09:21:24 +01:00
Nextcloud bot
73c01d1ef4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-07 03:54:38 +00:00
Nextcloud bot
559c41d880
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-05 03:54:13 +00:00
Álvaro Brey Vilas
08e7a761dc
NaturalSortTest: shuffle instead of duplicating parameters
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
64d386786c
Rename TestSorting to OCFileSortTest, conver to Kotlin, parameterize
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:55:07 +01:00
Álvaro Brey Vilas
bed01a2f0c
TestSorting: refactor and simplify since it's now only for OCFiles
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:12:52 +01:00
Álvaro Brey Vilas
e7e603f4d8
Move string sort tests from TestSorting to NaturalSortTest
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 13:02:42 +01:00
Álvaro Brey Vilas
d40fc88754
Move TestSorting to unit tests
No reason for it to be an instrumented test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 12:54:45 +01:00
Álvaro Brey Vilas
91297b7ce0
Test AlphanumComparator
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-02-04 10:49:08 +01:00
Nextcloud bot
927babb3bf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-04 03:55:25 +00:00
Nextcloud bot
c437db409e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 03:55:06 +00:00
Nextcloud bot
dba8da00f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-02 03:55:45 +00:00
Nextcloud bot
190332ceaa
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-01 03:55:35 +00:00
Álvaro Brey
1ecbf61cc7
Merge pull request #9776 from nextcloud/fix/activity-title
OCFileListFragment: set title when attached to activity
2022-01-31 15:42:16 +01:00
Álvaro Brey
0c5afce10e
Merge pull request #9770 from nextcloud/Valdnet-patch-1
i18n: Change to a capital letter
2022-01-31 13:43:46 +01:00
Álvaro Brey Vilas
d1d3a49a6b
OCFileListFragment: set title when attached to activity
This prevents wrong title while search isn't started yet (such as when returning to a search fragment from a preview fragment)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-28 16:32:46 +01:00
Nextcloud bot
204cd5a2c5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-28 03:54:54 +00:00
Valdnet
f28bc6f9f9
i18n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-27 17:12:02 +01:00
Álvaro Brey
88605985a0
Merge pull request #9743 from nextcloud/fix/media-dark-duplicated
Fix crashes and double loading in GalleryFragment when changing dark theme
2022-01-27 12:35:35 +01:00
Álvaro Brey
3e97e1e212
Merge pull request #9761 from nextcloud/fix/local-files-freeze
Improve freezes in local files screens when folder contains many files
2022-01-27 12:34:35 +01:00
Álvaro Brey Vilas
f3de5f9862
LocalFileListAdapter: fix case where directory==null
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
96c55a6d9f
FileSortOrder*: convert to Kotlin
Need more kotlin in the codebase and these were simple enough

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:49:07 +01:00
Álvaro Brey Vilas
7baa0f8da4
LocalFileListAdapter: Also change sort order asynchronously
Changing sort  order is also slow.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
2baf63d809
AlphaNumComparator: optimize usage and resolve signature problems
- Methods had ambiguous signatures (parameterized compare<T> overlapped the various typed compare()). This made the compiler very confused.
 - In several places throughout the app, AlphaNumComparator was getting repeatedly instantiated just to manually call a typed compare(). This was very wasteful

To solve both problems, the typed compare() methods have been been made static.

The performance gains of not instantiating the comparator repeatedly are very noticeable. In a test loading a local folder for upload with 1000 files in it,
time of load is reduced from 28 seconds to 17 seconds.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
462da35fdb
LocalFileList: load local files asynchronously
Loading a large list of files (especially the sorting part) is S L O W.
This ensures it doesn't block the UI while loading.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:33:50 +01:00
Álvaro Brey Vilas
c5ebc05964
PassCodeActivity: enable cancel button when re-created in confirmation step
Prevents a bug where the cancel button would stop working if the device was rotated

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-27 09:20:00 +01:00
Álvaro Brey
618a770349
Merge pull request #9751 from nextcloud/fix/clear-data
Fix some crashes and weird behaviours when clearing data
2022-01-27 09:18:21 +01:00
Álvaro Brey Vilas
c01fa0b170
Make more PendingIntents immutable
This should be all of them. Picked up by lint.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
27559efb79
Make PendingIntents immutable
Good practice for security

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 12:56:05 +01:00
Álvaro Brey Vilas
45fc831989
gplay/AndroidManifest: set exported value for service
picked up by lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
9d5395c8fd
ezvcard/ContactOperations: suppress locale lint in third_party class
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
a9ec1de015
manifest: Remove unneeded labels
Trips up lint

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
00586a5bde
BackgroundJobFactory: fix lint due to unchecked build version for ContentObserverJob
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
b6115a5fc1
lint: Fix getLayoutInflater calls
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 11:33:53 +01:00
Álvaro Brey Vilas
e1b41b5d77 ManageSpaceActivity: convert to Kotlin while we're here
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
db74d67168 ManageSpaceActivity: kill the app after finishing cleanup
This will prevent the file list still being on the Recents view and other stuff like that.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Álvaro Brey Vilas
83e56643f4 ManageSpaceActivity: remove user accounts when clearing data
This fixes crashes and unexpected states when restarting the app afterwards

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-26 08:32:49 +00:00
Nextcloud bot
750864d951
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-26 03:55:40 +00:00
Álvaro Brey Vilas
80928a2799 GalleryFragment: force refresh on create, prevent unneeded refresh animations
This fixes bugs with double-loading and weird animations

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 08:50:29 +00:00
Álvaro Brey Vilas
7181249667 GalleryFragment: prevent NPE when recreating fragment
getStorageManager() is not available in onCreate

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-25 08:50:29 +00:00
Álvaro Brey Vilas
1a735f1840
Fix default visibility of recently modified
Should be visible unless setup.xml disables is (which it does by default)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:01 +01:00
Álvaro Brey Vilas
c45dd9f5ff
Remove recently added search
Was never fully implemented. Discarding in favor of recently modified.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:01 +01:00
Álvaro Brey Vilas
63c780999d
OCFileListFragment: restore search event on view restored
Partially reverts https://github.com/nextcloud/android/pull/9427, which deleted too much stuff

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:00 +01:00
Álvaro Brey Vilas
6a45a90019
OCFileListFragment: add recently modified to the list of valid search events
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-24 13:14:00 +01:00
Nextcloud bot
43610aedba
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-24 03:52:57 +00:00
Nextcloud bot
d8cbde9105
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-21 03:52:14 +00:00
Álvaro Brey
717ad59140
Merge pull request #9651 from nextcloud/gallerySearch
Use capability in SearchRemoteOperation
2022-01-20 10:59:29 +01:00
Tobias Kaminsky
84507a39aa
Merge pull request #9719 from nextcloud/fix/ipv4-cache
Clear DNS cache on network changes
2022-01-20 09:42:56 +01:00
tobiasKaminsky
a9cec44b1f
Use capability in SearchRemoteOperation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-20 09:10:33 +01:00
Nextcloud bot
2956fafabc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-20 03:54:30 +00:00
Álvaro Brey Vilas
7299b598d4
Clear DNS cache on network changes
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-19 16:34:09 +01:00
redgloboli
0f62399615
Remove IRC info from app and docs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-18 16:26:58 +01:00
Álvaro Brey
c6b9da0ee3
Merge pull request #9694 from nextcloud/fix/sqlite-row-too-big
FileContentProvider: use projections for helper queries
2022-01-18 14:48:40 +01:00
Álvaro Brey Vilas
2d544486d3
Add integration test for folders with large amounts of files
This test reproduces the SQLiteCursor crashes.

Co-authored-by: Tobias Kaminsky <tobias@kaminsky.me>
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-18 14:14:11 +01:00
Tobias Kaminsky
b80baef535
remove not used videos drawer entry (#9708)
* remove not used videos drawer entry

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

* Remove unused resource

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

Co-authored-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-18 09:05:02 +01:00
Tobias Kaminsky
e091a15089
Merge pull request #9710 from nextcloud/fix/crash-on-remove-all-accounts
SessionMixin: set currentAccount to null when no accounts are available
2022-01-18 08:38:29 +01:00
Nextcloud bot
8d868c3fff
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-18 04:11:52 +00:00
Álvaro Brey
92f3b6df87
Merge pull request #9691 from nextcloud/fix/sync-conflict
Improvements in sync conflict resolution
2022-01-17 20:03:24 +01:00
Álvaro Brey Vilas
107dcd35c4
SessionMixin: set currentAccount to null when no accounts are available
Prevents a crash when removing the last account

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-17 16:02:05 +01:00
Álvaro Brey
1419406cd2
Merge pull request #9606 from nextcloud/fix/backup-fragment-crash
Fix NPE in BackupFragment when fragment exits while refresh is happening
2022-01-17 14:53:35 +01:00
Álvaro Brey Vilas
c5b75f68b0 ConflictsResolveActivity: remove upload is KEEP_SERVER and shouldDeleteLocal
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-17 13:30:47 +00:00
wknds
b4c1620aed removed a check in KEEP_SERVER switch clause. 1) The check prevents solving file conflicts (keep server) correctly. 2) The check involves FileUploader.LOCAL_BEHAVIOUR_DELETE, intended use is for media file uploads. 2022-01-17 13:30:47 +00:00
wknds
e6b6c6ff56 :Conflict files are removed from the upload storage manager after downloaded successfully. 2022-01-17 13:30:47 +00:00
Álvaro Brey
60e44986a0
Merge pull request #9692 from nextcloud/chore/screenshot-test-activities
Screenshot tests: Improve Activities activity tests
2022-01-17 14:29:31 +01:00
Álvaro Brey Vilas
6f1d434e80 DocumentsStorageProviderIT: add timeout to testServerChangedFileContent()
This test sometimes hangs forever, resulting in (for example) CI builds being killed.
This way, only this test fails and the rest of the suite continues.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-17 08:57:45 +00:00
Nextcloud bot
e13dc5db81
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-17 03:49:57 +00:00
Nextcloud bot
1b948c35e0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-16 03:53:38 +00:00
Nextcloud bot
2623be496d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-15 03:52:25 +00:00
Álvaro Brey Vilas
62218fbb16
Add RetryTestRule to DrawerActivityIT
Flaky test

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-14 13:28:49 +01:00
Álvaro Brey Vilas
f83ccb781d Fix NPE in BackupFragment when fragment exits while refresh is happening
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-14 10:48:16 +00:00
Álvaro Brey Vilas
23a67aea4a
FileContentProvider: make projection map unmodifiable
Just in case

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-14 08:54:33 +01:00
Álvaro Brey Vilas
94533fd8aa
FileContentProvider: fix formatting
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-14 08:51:54 +01:00
Álvaro Brey Vilas
45b7c222e6
FileContentProvider: make projection arrays and map static
This improves performance as they aren't created on every call

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 16:12:03 +01:00
Álvaro Brey Vilas
405789dc9b
FileContentProvider: use projections for queries
This limits the amount of data in the resulting cursor and helps prevent CursorTooBig exceptions.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 15:47:40 +01:00
Álvaro Brey Vilas
d7d029b6ad
ActivitiesActivityIT: add waitForIdleSync() after sleeps
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 12:48:16 +01:00
Álvaro Brey Vilas
5631d79b41
Screenshot tests: Improve Activities activity tests
Force-close snackbar to not have the timing break tests

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 11:07:47 +01:00
Álvaro Brey
010942f0a2
Merge pull request #9677 from nextcloud/fix/send-multiple-files
Fix sending multiple files
2022-01-13 09:34:04 +01:00
Álvaro Brey Vilas
53feb14714
SendFilesDialogTest: assert adapter is not null
Just in case

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-13 09:06:09 +01:00
Nextcloud bot
ab23c04def
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-13 03:53:34 +00:00
Álvaro Brey Vilas
9d856da33a
Improve testing for SendFilesDialog
* Add tests for mixed type files
 * Add integration tests, not only screenshot

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-12 15:50:20 +01:00
Álvaro Brey Vilas
61f8115d79
SendFilesDialog: Show error if no app can send multiple files
Otherwise an empty bottom fragment shows up, which is not good UX

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-12 13:08:48 +01:00
Álvaro Brey Vilas
93d7c7f9f7
IntentUtil: fix sending multiple files
- Use `ACTION_SEND_MULTIPLE`
 - Set type to `*/*` if not all files share a type
 - Use use a `ParcelableArrayListExtra` for `EXTRA_STREAM`

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-12 13:08:42 +01:00
Tobias Kaminsky
a639e8441c
Merge pull request #9043 from nextcloud/updateScreenshotsTests
Update screenshots tests
2022-01-12 08:57:22 +01:00
Nextcloud bot
ae9bd40427
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-12 03:52:57 +00:00
Álvaro Brey
0d46d951e7
Merge pull request #9622 from sandeep021/sandeepBranch
Fix sliders theming for calendar backup settings
2022-01-11 10:13:55 +01:00
Nextcloud bot
e4d26e44d4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-11 03:53:46 +00:00
sandeepyadav
333b844878 removed redundant changes
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
2022-01-10 23:10:54 +05:30
sandeepyadav
ce11af238f removed redundant changes
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
2022-01-10 23:10:54 +05:30
sandeepyadav
10d44368db made all the suggested changes - removed xml unnecessary lines
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
2022-01-10 23:10:54 +05:30
sandeepyadav
fb26ddd88f made all the suggested changes
Signed-off-by: sandeepyadav <sandeep.yadav@hummingwave.com>
2022-01-10 23:10:54 +05:30
Tobias Kaminsky
e8ce558a4e
Merge pull request #9642 from nextcloud/fix/9640
ChooseTemplateDialog: Fix crash on prefillFilenameIfEmpty
2022-01-10 12:03:51 +01:00
Álvaro Brey
c9246210de
Merge pull request #9674 from nextcloud/fixUploadingFailingScreenshots
Fix failing username/password upon uploading failing screenshots
2022-01-10 11:30:26 +01:00
tobiasKaminsky
719551505e
Fix DialogFragmentIT test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-10 10:12:44 +01:00
Álvaro Brey
a037786328
Merge pull request #9667 from nextcloud/rakekniven-patch-2
l10n: fixed grammar
2022-01-10 10:04:46 +01:00
Tobias Kaminsky
879286d05f
Merge pull request #9666 from nextcloud/fix/favorites-selection-breaking
FileOperationsHelper: fix aliasing when toggling favorite files
2022-01-10 07:44:54 +01:00
Nextcloud bot
67da5e0a6f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-08 03:50:50 +00:00
rakekniven
065d19163f
l10n: fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-01-07 21:33:51 +01:00
Álvaro Brey Vilas
0f9e4feb79
FileOperationsHelper: fix aliasing when toggling favorite files
Don't modify the original collection of files. Instead filter a clone.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-07 18:27:55 +01:00
Nextcloud bot
6faceec5a5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-07 14:05:13 +00:00
Álvaro Brey
d3502b7bba
Merge pull request #9572 from nextcloud/provider-uri-permissions
URI permissions
2022-01-07 13:26:03 +01:00
Álvaro Brey
afaa537a45
Merge pull request #9646 from nextcloud/run-contacts-backup-only-when-network-is-connected
Run contacts backup job only when network is connected
2022-01-07 11:07:59 +01:00
Álvaro Brey
3a72604a78
Merge pull request #9591 from nextcloud/fix/settings-activity-it
SettingsActivityIT: fix showMnemonic running on wrong thread
2022-01-07 09:40:06 +01:00
Álvaro Brey
ebd608c179
Merge pull request #9607 from nextcloud/fix/accesing-result-data
AuthenticatorAsyncTask: check if user info result is success before proceeding
2022-01-07 08:47:48 +01:00
Nextcloud bot
e9029b28ed
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-07 03:53:42 +00:00
Nextcloud bot
8acf55d0f1
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-06 03:53:53 +00:00
Chris Narkiewicz
b6ceec7904
Run contacts backup job only when network is connected
Apply network constrains to prevent daily backup
job being started without network.

Backup job restart is required to apply new constraints.

Similar migration has been applied in the past, but migration
manager does not support re-applying steps again.

Migrations manager has been refactored to make migration
step re-applying easier, as more job restarts can be
required in the future.

Fixes #9632

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2022-01-05 22:01:41 +00:00
Tobias Kaminsky
7d4fa2994c
Merge pull request #9644 from nextcloud/cleanUpAccountRemoval
Clean up AccountRemovalWork
2022-01-05 15:05:32 +01:00
Álvaro Brey Vilas
4265f06160
FileOperationsHelper: remove duplicated flags in openFile
Already set for all intents a bit below

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-04 15:32:32 +01:00
tobiasKaminsky
90d66c4339
Clean up AccountRemovalWork
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-01-04 13:08:44 +01:00
Nextcloud bot
6d6445a1f6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-04 03:52:56 +00:00
Álvaro Brey Vilas
29d9ba4e52 AuthenticatorAsyncTask: check if user info result is success before proceeding
This will not fix failed logins but at least it will not crash the app.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-03 18:32:11 +00:00
Álvaro Brey
a3a8170151
Merge pull request #9582 from nextcloud/fix/media-return-after-pause
Player: don't try to pause a non-running media player
2022-01-03 16:56:37 +01:00
Álvaro Brey Vilas
1a7ee3e179
ChooseTemplateDialog: Fix crash on prefillFilenameIfEmpty
Don't do anything if the filename is not empty.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2022-01-03 09:43:24 +01:00
Nextcloud bot
a3b3f18abd
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-01 03:52:26 +00:00
sandeepyadav
eaf605b2be fixed the visibility of slider of dark theme
issue# 9170
2021-12-27 13:35:40 +05:30
Nextcloud bot
042b93766e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-27 03:52:10 +00:00
Nextcloud bot
5d32890848
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-25 03:52:43 +00:00
Nextcloud bot
552a657350
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-24 03:55:33 +00:00
Nextcloud bot
afc83b8310
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-23 03:53:42 +00:00
Álvaro Brey Vilas
130c004945
FileDataStorageManager: remove obsolete TODO
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-22 09:52:09 +01:00
Álvaro Brey
98465ab3fb
Merge pull request from GHSA-vjp2-f63v-w479
Harden FileContentProvider's public Uri paths
2021-12-22 09:43:11 +01:00
Álvaro Brey Vilas
9c7d212d52
Fix for too many thumbnails in autoupload settings
This patch is twofold:
- Keep using SQL limit until android 11 (which is where it becomes mandatory to not use it)
- Force MediaProvider to stop querying images after limit has been reached, even if cursor contains more.
This handles the edge case of Android versions over 11 which don't properly implement the limit argument

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-21 17:22:10 +01:00
Álvaro Brey Vilas
bc90eb3db1
Remove obsolete TODO
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-21 16:02:50 +01:00
Álvaro Brey Vilas
724b75d5d3
FileContentProvider: Use SQLiteTokenizer for sortOrder verification too
More reliable than just splitting by spaces.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-21 15:06:05 +01:00
Álvaro Brey Vilas
b3aeab9004
FileContentProvider: prevent injection through selection parameters (where)
For this, I've backported the SQLiteTokenizer class from AOSP, use it to get tokens from the query,
and filter out invalid tokens.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-21 14:15:34 +01:00
Nextcloud bot
c479f2fdf6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-21 03:54:15 +00:00
Álvaro Brey Vilas
6aae8feeac
FileContentProvider: prevent injection in sortOrder argument for query()
For this, allow strictly only valid grammar and column names

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-20 18:38:50 +01:00
Álvaro Brey Vilas
830ada4617
FileContentProvider: remove unused method
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-20 18:03:56 +01:00
Álvaro Brey Vilas
43adc856a4
FileContentProvider: don't verify projectionArray in query()
query() is already using a projection map and strict mode for those cases, so we're just duplicating work here.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-20 17:58:54 +01:00
Álvaro Brey Vilas
05371be6d7
FileContentProvider: prevent injection through Uri arguments
For this, ensure query arguments are used instead of segment concatenation

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-20 17:53:55 +01:00
tobiasKaminsky
72937cf341
FileContentProvider: prevent injection via ContentValues arguments
For this, verify all column names for ContentValues keys. Values are safe by default.

Co-authored-by: Tobias Kaminsky <tobias.kaminsky@nextcloud.com>
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-20 17:40:11 +01:00
Álvaro Brey Vilas
87e859858b
SettingsActivityIT: fix showMnemonic running on wrong thread
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-20 15:24:21 +01:00
Nextcloud bot
4183ee59f8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-20 03:56:38 +00:00
Nextcloud bot
14a6324c05
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-19 03:59:20 +00:00
Nextcloud bot
26f80ddcbf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-18 03:53:54 +00:00
Álvaro Brey Vilas
37dfb5eb2c
Player: don't try to pause a non-running media player
Fixes an issue triggered by pausing, and then minimizing and coming back to the app.

Right now state is still lost (file returns to the beginning) but as a stopgap it's OK.
In the future, the state machine and how it interacts with the fragment should be reworked.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-17 16:22:39 +01:00
Álvaro Brey Vilas
b1aa3dcdaf
Centralize creation of ACTION_SEND intents and explicitly grant READ_URI permission to them
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-16 15:22:16 +01:00
Álvaro Brey
3de9432651
Merge pull request #9534 from gabmert/naming-conflicts
Change naming in conflicts to location instead of date
2021-12-16 09:35:43 +01:00
Nextcloud bot
d3db0af0f5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-16 03:53:43 +00:00
gabriel
5500585c1a naming in conflicts by location instead of date
Signed-off-by: gabriel <74419649+gabmert@users.noreply.github.com>
2021-12-15 23:13:42 +01:00
Álvaro Brey
6fc583b4cd
Merge pull request #9362 from nextcloud/dependabot/gradle/workRuntime-2.7.1
Bump workRuntime from 2.5.0 to 2.7.1
2021-12-15 19:49:17 +01:00
Álvaro Brey
369f62fc92
Merge pull request #9162 from nextcloud/dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-ktx-2.4.0
Bump lifecycle-viewmodel-ktx from 2.3.1 to 2.4.0
2021-12-15 19:23:03 +01:00
Álvaro Brey Vilas
8a445be869
Manifest: update code to disable WorkManagerInitializer
See: https://developer.android.com/jetpack/androidx/releases/work#version_260_3

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 19:01:36 +01:00
Álvaro Brey Vilas
14fbc2ab78
ViewModelFactory: fix compile errors for viewmodel-ktx changes
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 18:45:06 +01:00
Álvaro Brey Vilas
f5132af345
Fix mockito imports
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 16:08:36 +01:00
Álvaro Brey
508c193dfa
Merge pull request #9448 from nextcloud/fix/share-open-in
Sharing: better way to send files from file details view
2021-12-15 13:48:42 +01:00
Álvaro Brey
3b947b981b
Merge pull request #9435 from nextcloud/fix/multi-tap-overflow
OcFileListFragment: throttle overflow menu clicks
2021-12-15 13:08:16 +01:00
Álvaro Brey
82a53642a9
Merge pull request #9528 from nextcloud/huaweiFlavor
Huawei flavor
2021-12-15 13:07:32 +01:00
Álvaro Brey Vilas
13ddc3ddc6
Delete unused string
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:59:58 +01:00
Álvaro Brey Vilas
a86aa19851
Fix tests
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:59:13 +01:00
Álvaro Brey Vilas
7d258f9793
FileMenuFilter: Allow "Send" for single files if in file detail fragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:33:26 +01:00
Álvaro Brey Vilas
038ac7b3c5
FileDetailSharingFragment: remove misleading "Open in..." option
This only triggered the share file dialog, which should be opened elsewhere.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:33:15 +01:00
Álvaro Brey Vilas
23815a4b6d
Fix ktlint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:21:04 +01:00
Álvaro Brey
587b371e76
Merge pull request #9545 from nextcloud/fix/autoupload-check-crash
UploadFilesActivity: don't attempt to check selectAll if selectAll is not visible in menu
2021-12-15 11:28:32 +01:00
Álvaro Brey
143455b42a
Merge pull request #9427 from nextcloud/fix/triplicated-search-events
Fix issue where favorites where loaded by triplicate when opening from Media or other search
2021-12-15 11:06:39 +01:00
Álvaro Brey
a9671d9e85
Merge pull request #9434 from nextcloud/fix/unified-search-no-connection
Unified search: show error when there's no connection
2021-12-15 11:05:34 +01:00
Álvaro Brey Vilas
e7d8870b07
Move Throttler to proper package
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 10:59:08 +01:00
Álvaro Brey Vilas
11b6420446
Write tests for Throttler
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>

Write tests for Throttler

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 10:56:57 +01:00
Álvaro Brey
b5e36d25be
Merge pull request #9547 from nextcloud/fix/favorite-state-lost
OCFileListFragment: don't delete search event if resuming a search fragment
2021-12-15 09:43:50 +01:00
Nextcloud bot
3f8adc1016
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-15 03:53:06 +00:00
Álvaro Brey Vilas
d503623d1d
OCFileListFragment: don't delete search event if resuming a search fragment
This fixes a bug where favorites screen seemed empty after coming back from a share fragment.

This took WAY too long to figure out, this class needs a big refactor.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-14 17:52:52 +01:00
tobiasKaminsky
40796f7612
Add huawei build flavor
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-14 08:42:01 +01:00
Álvaro Brey
157f62a775
Merge pull request #9541 from nextcloud/fixUploadFromApps
"last modified" column might not exist, thus it shall never fail to upload
2021-12-13 13:04:28 +01:00
Álvaro Brey Vilas
662f15d250
UploadFilesActivity: don't attempt to check selectAll if selectAll is not visible in menu
This was crashing autoupload settings.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-13 12:50:17 +01:00
Álvaro Brey
e9b13fe45f
Merge pull request #9537 from nextcloud/fix-npe-in-file-uploader
Do not set notification manager to null in uploader service
2021-12-13 12:25:41 +01:00
Álvaro Brey
0e45a8611c
Merge pull request #9535 from nextcloud/prevent-player-service-stop-from-using-foreground-service-api
When stopping PlayerService, do not use foreground service api
2021-12-13 11:43:57 +01:00
Álvaro Brey
d9874c788c
Merge pull request #8730 from nextcloud/migrate-file-activity-extra-account-to-extra-user
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER and use User model as well
2021-12-13 11:37:44 +01:00
tobiasKaminsky
86a5c930b0
"last modified" column may not exist, thus it shall never fail to upload
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-13 09:47:49 +01:00
Nextcloud bot
45b591f3d2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-13 03:52:57 +00:00
Chris Narkiewicz
0c087012d7
Do not set notification manager to null in uploader service
NPE is most likely caused by a race condition, when
file upload update arrives after onDestroy().

Do not set notification manager to null - it does not
make any sense anyway, as it's a system service.

Fixes #9390

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-12-12 14:41:48 +00:00
Chris Narkiewicz
989b8aeddb
When stopping PlayerService, do not use foreground service api
Sending async message to the service using foreground API
requires setting foreground flag. This won't happen if
the service is being stopped, so we must use startService()
API instead.

This API will throw IllegalStateException when app is banned
from running a service due to power management constraints.

Since stopping a service under such condition is not needed
anyway (it is not running), we can safely catch and ignore it.

This happens when app is woken up after long inactivity and
UI is recreated from cache.

Fixes #9491

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-12-12 13:15:20 +00:00
Nextcloud bot
a284b6fcde
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-12 03:54:58 +00:00
Chris Narkiewicz
883857db32
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER and pass
User model around instead of Account.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-12-12 00:23:40 +00:00
Nextcloud bot
06e1c41884
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-11 03:53:44 +00:00
Álvaro Brey
489eb75858
Merge pull request #9523 from nextcloud/fix/media-preview-navigation
FileDisplayActivity: Preserve title bar after resume
2021-12-10 10:33:31 +01:00
Álvaro Brey
8b63aaf2f9
Merge pull request #9522 from nextcloud/fix/search-landscape
Unified search: clear focus from search view on open
2021-12-10 10:26:35 +01:00
Nextcloud bot
9358e7d407
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-10 03:57:24 +00:00
Álvaro Brey Vilas
46669cc1d8
FileDisplayActivity: Preserve title bar after resume
Fixes title bar reverting to searchbar even if the resumed fragment is the preview or the details fragments

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 18:32:59 +01:00
Álvaro Brey Vilas
30091a7aa4
Unified search: clear focus from search view on open
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 16:58:36 +01:00
Álvaro Brey
0edba984be
Merge pull request #9426 from nextcloud/fix/unified-search-apps
UnifiedSearch: Fix opening non-file results with relative URLs
2021-12-09 15:59:31 +01:00
Álvaro Brey
76210ada17
Merge pull request #9494 from nextcloud/fix/calendar-dialog-style
DatePickerDialog: fix theme
2021-12-09 15:59:11 +01:00
Álvaro Brey
451c629a44
Merge pull request #9418 from nextcloud/fix/sharing-note-mandatory
Don't make note mandatory for sharing
2021-12-09 15:58:46 +01:00
Álvaro Brey
515e3f7089
Merge pull request #9449 from nextcloud/fix/fdf-binding-npe
FileDetailFragment: prevent NullPointerException if fileDetailSharingFragment is called too soon
2021-12-09 15:57:52 +01:00
Álvaro Brey
301543455f
Merge pull request #9476 from nextcloud/storeFavoriteAfterFavoritingIt
After favorite/unfavorite store this also in db, not only change it in UI
2021-12-09 15:39:05 +01:00
Álvaro Brey
840ec88f57
Merge pull request #9475 from nextcloud/renameFix
Rename remote path upon renaming
2021-12-09 15:38:46 +01:00
Álvaro Brey
16d2aa2554
Merge pull request #9474 from nextcloud/fixGallerySearch
Fix vanishing files after gallery search
2021-12-09 15:38:28 +01:00
Álvaro Brey
b38905fff7
Merge pull request #9469 from nextcloud/darkModeBackgronud
Explicitly set background for fragments
2021-12-09 15:37:58 +01:00
Álvaro Brey
2872f8167e
Merge branch 'master' into translateError 2021-12-09 15:36:57 +01:00
Álvaro Brey
22c308f69a
Merge pull request #9467 from nextcloud/fileSizeInShareDialog
update file size upon opening share dialog
2021-12-09 15:36:00 +01:00
Álvaro Brey
4381f7e33c
Merge pull request #9478 from nextcloud/emptyNotCentered
Empty list is not centered and in landscape cut off
2021-12-09 15:35:11 +01:00
Álvaro Brey
739364dd63
Merge pull request #9466 from nextcloud/enhancePlayIcon
Play button as overlay on videos is now more sharpe on large displays
2021-12-09 15:34:22 +01:00
Álvaro Brey
ad781a4b34
Merge pull request #9465 from nextcloud/trashbinCount
Update footer upon restore/delete of a deleted file
2021-12-09 15:34:02 +01:00
Álvaro Brey
aa0914011d
Merge pull request #9464 from nextcloud/drawerHighlight
highlight correct menu drawer icon
2021-12-09 15:33:28 +01:00
Álvaro Brey
60aa2becf3
Merge pull request #9463 from nextcloud/highlightSortOrder
Correctly highlight selected sort order
2021-12-09 15:33:02 +01:00
Álvaro Brey
ad5c73f5ea
Merge pull request #9462 from nextcloud/expandSendShareDialog
Expand send share dialog when in landscape mode
2021-12-09 15:32:37 +01:00
Álvaro Brey
6a3dd84ba1
Merge branch 'master' into unifiedSearch_showNoResults 2021-12-09 15:31:32 +01:00
Álvaro Brey
42212e410e
Merge pull request #9460 from nextcloud/mediaEmpty
Show correct empty screen if gallery search returns empty
2021-12-09 15:30:20 +01:00
Álvaro Brey
e33419eb75
Merge pull request #9485 from nextcloud/fixSetPictureAs
"set picture as" needs temporary read permission
2021-12-09 15:27:23 +01:00
Álvaro Brey
98319b40d0
Merge pull request #9484 from nextcloud/fix401whenReloggingIn
when re-logging in too fast, we stored an empty auth token
2021-12-09 15:27:06 +01:00
Álvaro Brey
63cbb9f2d9
Merge pull request #9483 from nextcloud/audioCoverArt
Better positioning of preview media fragment
2021-12-09 15:26:47 +01:00
Álvaro Brey
d0038c6a3b
Merge pull request #9482 from nextcloud/fullscreenToggle
Fullscreen toggle
2021-12-09 15:26:13 +01:00
Álvaro Brey
7f6acfc590
Merge pull request #9480 from nextcloud/hideNextButton
On video player hide next button, as it is always disabled
2021-12-09 15:26:02 +01:00
Álvaro Brey
ad946c2f73
Merge pull request #9479 from nextcloud/uponMoveUpdateFolderSize
Upon move update folder size
2021-12-09 15:25:48 +01:00
Álvaro Brey
0fe6c436ab
Merge pull request #9459 from nextcloud/uploadAskForPermission
Ask for permission in UploadFilesActivity
2021-12-09 15:25:32 +01:00
Álvaro Brey Vilas
8a8c7a098f
Remove TODO
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 14:57:33 +01:00
Álvaro Brey Vilas
ded48ddba9 Don't make note mandatory for sharing
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 13:42:55 +00:00
Álvaro Brey Vilas
bcafbbbd5b
DatePickerDialog: fix theme
Extend from Dialog, not Dialog.Alert.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 14:36:01 +01:00
Álvaro Brey Vilas
af32084d1e Fix upload button not active unless select all is clicked
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 08:16:59 +00:00
Nextcloud bot
694b8fda56
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-09 03:57:08 +00:00
tobiasKaminsky
76547ca06d
"set picture as" needs temporary read permission
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-08 15:31:39 +01:00
tobiasKaminsky
1036eaa01f
when re-logging in too fast, we stored an empty auth token
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-08 14:58:21 +01:00
tobiasKaminsky
57f21e50ce
Better positioning of preview media fragment
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-08 10:03:52 +01:00
tobiasKaminsky
09a02767bc
Better fullscreen toggle
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-08 08:44:35 +01:00
Nextcloud bot
b7de19236f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-08 04:05:40 +00:00
tobiasKaminsky
c7bcc349d0
On video player hide next button, as it is always disabled
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-07 17:31:42 +01:00
tobiasKaminsky
7d3db7c9c3
Upon move update folder size
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-07 16:52:03 +01:00
tobiasKaminsky
e1399f0135
Empty list is not centered and in landscape cut off.
Therefore as a quick win, moved all up, so that user does not think it should be centered.
This also then works in landscape.

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-07 13:30:45 +01:00
tobiasKaminsky
dd366ec494
After favorite/unfavorite store this also in db, not only change it in UI
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-07 09:13:26 +01:00
tobiasKaminsky
ef25d41342
Rename remote path upon renaming
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-07 08:54:21 +01:00
tobiasKaminsky
036e339b07
Fix vanishing files after gallery search
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-07 08:15:49 +01:00
Nextcloud bot
a22e97db73
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-07 05:10:21 +00:00
tobiasKaminsky
40e8ac7c58
Explicitly set background for fragments
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 17:35:16 +01:00
tobiasKaminsky
417365f7ea
Extract string to get translated
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 16:57:52 +01:00
tobiasKaminsky
4a0ec4ece7
update file size upon opening share dialog
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 16:32:41 +01:00
tobiasKaminsky
c85a733190
Play button as overlay on videos is now more sharpe on large displays
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 16:04:11 +01:00
tobiasKaminsky
0996702fd9
Update footer upon restore/delete of a deleted file
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 15:12:27 +01:00
tobiasKaminsky
b557061410
highlight correct menu drawer icon
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 15:03:10 +01:00
tobiasKaminsky
8d94a44066
- correctly highlight selected sort order
- combine uploadFilesView and localFilesListView enum, as both are the same

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 13:08:50 +01:00
tobiasKaminsky
9e1001a53c
Expand send share dialog when in landscape mode
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 12:45:45 +01:00
tobiasKaminsky
07ece764f9
If no search results from any provider, show it
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 12:21:31 +01:00
tobiasKaminsky
599956370a
fix tests
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 10:30:35 +01:00
tobiasKaminsky
70cb9367ae
Show correct empty screen if gallery search returns empty
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 10:10:29 +01:00
tobiasKaminsky
5ebf79697d
Ask for permission in UploadFilesActivity
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-06 08:34:23 +01:00
Nextcloud bot
b3b1b8dbc0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-05 04:08:45 +00:00
Álvaro Brey Vilas
b7d51e573a FileDetailFragment: prevent NullPointerException if fileDetailSharingFragment is called too soon
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-03 16:50:37 +01:00
Álvaro Brey
53999c809c
Merge pull request #9433 from nextcloud/refresh
Refresh on favorite/shared view does search again, not showing root folder content
2021-12-03 15:31:40 +01:00
Álvaro Brey
fbfdfb02c9
Merge pull request #9431 from nextcloud/showMnemonic
show mnemonic only if requested
2021-12-03 15:17:04 +01:00
Álvaro Brey
8625ab9be2
Merge pull request #9425 from nextcloud/updateSelectMenu
upload files activity: update select all button when selected files changed
2021-12-03 12:24:14 +01:00
Álvaro Brey
6cb1578983
Merge pull request #9423 from nextcloud/rememberSelectedFilesInUpload
Remember selected files in upload files activity upon screen rotation
2021-12-03 12:19:37 +01:00
Álvaro Brey
540ca74eec
Merge pull request #9422 from nextcloud/uploadButtonOnSelectAll
Upon select all in upload files activity, enable upload button
2021-12-03 12:12:35 +01:00
Álvaro Brey
532f06a9a5
Merge pull request #9421 from nextcloud/removeUnfavoritedFile
Remove unfavorited file from favorited search
2021-12-03 12:00:56 +01:00
Álvaro Brey
fe18e9a710
Merge pull request #9420 from nextcloud/showTrashbinError
Show trashbin error in a better way
2021-12-03 11:40:22 +01:00
Álvaro Brey Vilas
42f995bb66 OcFileListFragment: throttle overflow menu clicks
Fixes #9319

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-02 17:14:59 +01:00
Álvaro Brey Vilas
a94c151228 Unified search: show error when there's no connection
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-02 13:57:06 +01:00
tobiasKaminsky
69486a5428
Refresh on favorite/shared view does search again, not showing root folder content
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-02 13:11:39 +01:00
tobiasKaminsky
552d0a2d39
show mnemonic only if requested
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-02 11:10:59 +01:00
Nextcloud bot
5171d73285
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-01 18:48:41 +00:00
Álvaro Brey Vilas
62df4ff414 OCFileListFragment: Solve triplicated search events
Most visible when going to Favorites from another search.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-01 18:03:42 +01:00
Álvaro Brey Vilas
8eb2567c78 DrawerActivity: extract duplicated search launch logic to a method
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-01 17:56:02 +01:00
Álvaro Brey Vilas
94e73ba716 UnifiedSearch: Fix opening non-file results with relative URLs
Most notable in Apps results (Deck, Music...)

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-01 16:33:37 +01:00
tobiasKaminsky
5511a23748
upload files activity: update select all button when selected files changed
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-01 16:28:38 +01:00
tobiasKaminsky
15674167fb
Remember selected files in upload files activity upon screen rotation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-01 15:25:31 +01:00
tobiasKaminsky
5b18cf972e
Upon select all in upload files activity, enable upload button
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-01 15:03:17 +01:00
tobiasKaminsky
f4e7bf3ed5
Remove unfavorited file from favorited search
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-01 14:55:01 +01:00
tobiasKaminsky
729d053b9a
Show trashbin error in a better way
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-01 14:14:33 +01:00
Álvaro Brey
b17db63964
Merge pull request #9354 from nextcloud/fix/ip-port-login
Fix crashes during scheme normalization on login
2021-12-01 10:55:31 +01:00
Álvaro Brey
0f2011c16a
Merge pull request #9395 from nextcloud/fix/delete-media-refresh
Refresh gallery screen when deleting a file
2021-12-01 10:48:12 +01:00
Tobias Kaminsky
aa946dc311
Merge pull request #9385 from nextcloud/fix/side-menu-logo-crash
DrawerActivity: resize server logo if it's too big
2021-12-01 10:30:51 +01:00
Nextcloud bot
404ad2f9f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-01 04:01:35 +00:00
Nextcloud bot
3da0ad2027
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-30 03:59:11 +00:00
Álvaro Brey Vilas
63f1654ebf Refresh gallery screen when deleting a file
Fixes #9370

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-29 17:48:17 +01:00
Álvaro Brey
77dfd96e91
Merge pull request #9286 from Toover/master
Fix dialog template chooser when new file has no extension #9282
2021-11-29 16:24:29 +01:00
Álvaro Brey
58828dbc8b
Merge pull request #9249 from nextcloud/compile-sdk-31
Bump compileSDK to 31
2021-11-29 14:12:41 +01:00
Nextcloud bot
1c911b15b4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-29 03:53:31 +00:00
Nextcloud bot
2cee938227
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-27 03:55:21 +00:00
Álvaro Brey Vilas
ff0cb45c03
DrawerActivity: resize server logo if it's too big
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-26 21:03:04 +01:00
tobiasKaminsky
4c62ee6c5a
favorite/unfavorite in details view
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-26 12:29:14 +01:00
Nextcloud bot
ebaced6d34
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-26 04:16:06 +00:00
Álvaro Brey
a98bdd69ce
Merge pull request #9287 from liam-p-23/master
File rename input warning message
2021-11-25 14:14:37 +01:00
Álvaro Brey Vilas
8ee7bfd557
Fix lint issues with cursor indexes on compileSdk 31
Ref: https://stackoverflow.com/a/69979270

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-25 12:57:17 +01:00
Álvaro Brey Vilas
dd07ea17dd Fix another NPE in FileDownloader
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-25 07:47:24 +00:00
Chris Narkiewicz
a84fc6297d Fix NPE regression in FileDownloader
Fixes #9349

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-11-25 07:47:24 +00:00
Nextcloud bot
6361c19386
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-25 03:54:26 +00:00
Liam P
549750aa73 Changed error color of TextInputLayoutInputWarning
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
2021-11-24 15:11:06 -05:00
Nextcloud bot
9ebc2f2b9e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-24 03:56:08 +00:00
Álvaro Brey
f0cd5c2aec
Merge pull request #9335 from nextcloud/remove-account-from-arbitrary-data-provider
Remove Account from ArbitraryDataProvider
2021-11-23 10:08:42 +01:00
Álvaro Brey
1572ca7e00
Merge pull request #9342 from nextcloud/fix/davdroid-login
AndroidManifest: allow querying for davdroid app.
2021-11-23 10:03:29 +01:00
Nextcloud bot
0997251cd3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-23 03:57:31 +00:00
Chris Narkiewicz
feb9d6a87f Remove Account from ArbitraryDataProvider
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-11-22 22:50:07 +00:00
Álvaro Brey
de79c93991
Merge pull request #9333 from nextcloud/migrate-ocupload-to-user
Migate OCUpload to User
2021-11-22 16:43:39 +01:00
Álvaro Brey
1e5b4604fb
Merge pull request #9330 from nextcloud/remove-account-from-file-data-storage-manager-implementation
Remove platform Account from FileDataStorageManager implementation
2021-11-22 16:37:58 +01:00
Álvaro Brey Vilas
cac884f6c2
AndroidManifest: allow querying for davdroid app.
Fixes #9339

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-22 16:16:04 +01:00
Nextcloud bot
679b3ae029
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-22 04:13:44 +00:00
Nextcloud bot
fb10543c87
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-21 03:53:48 +00:00
Chris Narkiewicz
c8f61f76f5
Migate OCUpload to User
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-11-20 22:19:59 +00:00
Chris Narkiewicz
12e09e8c28
Remove platform Account from FileDataStorageManager implementation
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-11-20 14:37:35 +00:00
Nextcloud bot
8eff4f7ddf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-20 04:13:56 +00:00
Liam P
b0cf10b88a Changed input warning to use TextInputLayout setError
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
2021-11-19 19:24:48 -05:00
Liam P
8daf760107 Updated input warning message functionality
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
2021-11-19 19:24:36 -05:00
William Plefka
425966a7b8 Updated input warning message functionality
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
2021-11-19 19:23:38 -05:00
William Plefka
b3056188e5 Added Javadoc comments
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
2021-11-19 19:23:27 -05:00
William Plefka
8d5d7cccc8 Added hidden file warning message to the rename file dialog. Resolves #7722
Signed-off-by: William Plefka <wplefka2@illinois.edu>
Signed-off-by: Liam P <89549210+liam-p-23@users.noreply.github.com>
2021-11-19 19:23:11 -05:00
tobiasKaminsky
66459bcfbc
fix FDSM call
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-19 09:00:05 +01:00
Nextcloud bot
38eeebf9ae
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-19 04:37:18 +00:00
Álvaro Brey
373fec8b45
Merge pull request #9073 from nextcloud/remove-deprecated-calls-to-storage-manager-constructor
Remove deprecated calls to storage manager constructor
2021-11-18 14:36:03 +01:00
Nextcloud bot
951377de46
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-18 03:50:24 +00:00
Andy Scherzinger
29846c718d
improve detekt score
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-17 18:15:01 +01:00
Andy Scherzinger
72d81ad06a
Merge pull request #9292 from nextcloud/bugfix/9291/brandedThemedPermissionDialog
Make permission dialog brandable and themed
2021-11-17 18:02:22 +01:00
Andy Scherzinger
abce95fd8c
make permission dialog brandable and themed
Fixes #9291

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-17 16:23:56 +01:00
Andy Scherzinger
5fd8843c1d
use padding instead of margin for SSO dialog whitespace
Fixes #9284

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-11-17 15:46:50 +01:00
Nextcloud bot
be72eb7429
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-17 05:59:22 +00:00
Toover
1b62ae6847 Fix dialog template chooser when new file has no extension #9282 2021-11-16 19:21:24 +01:00
Álvaro Brey
778736427d
Merge pull request #9248 from nextcloud/fix/unified_seach_crash
Unified search: fix createNextcloudClient called from main thread
2021-11-15 19:49:35 +01:00
Álvaro Brey
8646a625b6
Merge pull request #9127 from LisaKirchhofer/status-bar-bugfix
Bugfix: Issue #9060 (Status bar with sorting/view mode disappears aft…
2021-11-15 17:16:23 +01:00
Álvaro Brey Vilas
d720ae7f3f
Unified search: createNextcloudClient should not be called from main thread
Fixes #9244

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 16:40:08 +01:00
Álvaro Brey Vilas
18c6baaff0
manifest: Even more intent queries
Fixes #9270

These are hard to find, man

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 13:37:39 +01:00
Álvaro Brey Vilas
fa432834e7
Expand intent query declarations in AndroidManifest
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 13:37:29 +01:00
Álvaro Brey
f6a1f4a0f1
Merge pull request #9262 from gmotzespina/master
Prevent app crash when listening to audio files.
2021-11-15 11:41:07 +01:00
Álvaro Brey Vilas
a6f3bdceeb
Keep track of PlayerService state instead of restarting it before closing
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 10:31:20 +01:00
Guillermo Mtz Espina
12b75dce7b Starts foreground service before stopping it to avoid app crash when listening to an audio file
Signed-off-by: Guillermo Mtz Espina <gmotzespina@icloud.com>
2021-11-14 11:40:40 +00:00
tobiasKaminsky
9751de3934
Query Param needs serial uid
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-14 08:17:42 +01:00
Nextcloud bot
507f0ae9be
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-13 03:50:49 +00:00
Nextcloud bot
7a8845777c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-12 03:45:57 +00:00
Nextcloud bot
a1ce4fd57e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-11 03:50:41 +00:00
Tobias Kaminsky
cce56c4b2f
Merge pull request #9237 from nextcloud/fix/view-files
Manifest: allow app to query for apps that can resolve VIEW or SEND intents
2021-11-10 07:56:36 +01:00
Nextcloud bot
e25c82126f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-10 03:54:32 +00:00
Álvaro Brey Vilas
80f3f09bd1
Manifest: allow app to query for apps that can resolve VIEW or SEND intents
This is otherwise limited by default in sdk 30 and above

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-09 16:28:12 +01:00
Álvaro Brey Vilas
fc7f91add8
Remove some unused resources
Slipped through on MANAGE_EXTERNAL_STORAGE pr

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-09 14:08:08 +01:00
Álvaro Brey
38e78b3f37
Merge pull request #9228 from nextcloud/manage-all-files
Ditch scoped storage in favor of MANAGE_EXTERNAL_STORAGE
2021-11-09 12:25:33 +01:00
Álvaro Brey
f0ee7d719e
Merge pull request #9186 from nextcloud/strictMode
Enable StrictMode during development
2021-11-09 09:59:03 +01:00
Álvaro Brey Vilas
361ed24bb4
Add dialog to inform the user of storage permission
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-09 09:46:38 +01:00
tobiasKaminsky
9b0db8a355
Enable StrictMode during development
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-09 09:04:25 +01:00
Nextcloud bot
6e9dc44e71
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-09 07:52:44 +00:00
Álvaro Brey
7bd0190c4b
Merge pull request #9225 from nextcloud/wording
rename "read only" -> "view only"
2021-11-09 08:30:19 +01:00
Álvaro Brey Vilas
7966fa7923
Re-try to get file management permission if user does not enable it, and show toast.
Does not allow any usage of the app if permission is not granted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 16:56:22 +01:00
Álvaro Brey Vilas
44968b20ad
PermissionUtil: fix version conditional
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 16:26:44 +01:00
tobiasKaminsky
f4f0c22492
rename "read only" -> "view only"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-08 14:05:45 +01:00
Álvaro Brey Vilas
3c80a05354
Revert "Use internalTemporalPath instead of temporalPath"
This reverts commit 1811d040f7.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:50:43 +01:00
Álvaro Brey Vilas
41dbdaf3ed
Revert "DownloadFileOperation: use moveFile instead of File.renameTo"
This reverts commit f18f72abcd.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:50:26 +01:00
Álvaro Brey Vilas
5eeb8c0343
Remove What's New screens for scoped storage
Not needed if we get the manage permission

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:46:23 +01:00
Álvaro Brey Vilas
6a76372fde
GrantStoragePermissionRule: grant MANAGE_EXTERNAL_STORAGE on sdk >=30
Feels a bit hacky but it's the actual recommended way:
https://developer.android.com/training/data-storage/manage-all-files#enable-manage-external-storage-for-testing

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:40:17 +01:00
Álvaro Brey Vilas
a0b85cac71
Ditch scoped storage, try MANAGE_EXTERNAL_STORAGE
We _are_ a file-managing app, after all.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:13:02 +01:00
Valdnet
a638101359
i18n: Minor changes to sentence
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-11-08 09:02:27 +01:00
Nextcloud bot
dce7eb713a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-08 06:34:35 +00:00
tobiasKaminsky
915b764f36
Translation files must be one line
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-08 07:04:59 +01:00
Álvaro Brey
518343c4e4
Merge pull request #9195 from nextcloud/whats-new-sdk-30
Add What's New view to warn users of changes in storage after sdk 30
2021-11-04 14:35:29 +01:00
Álvaro Brey
35a2324482
Merge pull request #9175 from nextcloud/fix/url-parse-search-result
Unified search: skip local file check for non-file results
2021-11-04 14:27:25 +01:00
Álvaro Brey
a994ebc3f4
Merge pull request #9044 from nextcloud/target-sdk-30
Target SDK 30
2021-11-04 13:46:16 +01:00
Álvaro Brey Vilas
cb6d9a6c07
What's new: add second page of info for sdk30 storage update
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 13:03:14 +01:00
Álvaro Brey Vilas
40860d98be
AppInfo: add getVersionName, remove getFormattedVersionCode
Only used for WhatsNewActivity, and showing the human-readable string makes more sense.
Also convert the appinfo package to kotlin, since we're at it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 12:44:28 +01:00
tobiasKaminsky
c15f64308b Use package specific action
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-04 08:21:12 +00:00
Álvaro Brey Vilas
be43a629fd
Add What's New view to warn users of changes in storage after sdk 30
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 16:49:20 +01:00
Álvaro Brey Vilas
6d4b3b8444
Fix ktlint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 10:30:10 +01:00
Álvaro Brey Vilas
5e00733912
Add missing copyright header to PermissionUtil
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 09:16:22 +01:00
Nextcloud bot
6822cfda6a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-03 03:50:54 +00:00
Álvaro Brey Vilas
f18f72abcd
DownloadFileOperation: use moveFile instead of File.renameTo
File.renameTo fails if both files aren't under the same mountpoint.
As the tmp file is in internal storage now, it has to be move differently if the target dir is in external storage.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 16:31:46 +01:00
Álvaro Brey Vilas
1811d040f7
Use internalTemporalPath instead of temporalPath
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 12:59:06 +01:00
Álvaro Brey
578da09f05
Merge pull request #9179 from sryze/contact-settings-back-fix
Prevent duplicate Settings activity on back stack
2021-11-02 09:40:28 +01:00
Sergey Zolotarev
f08ad758cd Prevent duplicate Settings activity on back stack
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
2021-11-02 14:05:59 +06:00
Álvaro Brey Vilas
063ef4f8df
Fix PermissionUtil after rebase
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:44 +01:00
Álvaro Brey Vilas
0ad8c4350d
Fix storage permissions in debug manifest too
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
886c2574fb
MediaProvider: remove useless parens
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
95c31750a7
AbstractIT: adaptations to make integration tests work in sdk 30
- Use internal temporal path, as external temporal path is broken in sdk 30
- Don't take snapshots in sdk30 as they crash

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
c1316da717
Request READ_EXTERNAL_STORAGE in API >= 30
Although scoped storage is in effect and WRITE_EXTERNAL_STORAGE does not do anything,
we still need READ_EXTERNAL_STORAGE to read files from folders we don't own.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
2cb05a17a5
androidTest: Don't request WRITE_EXTERNAL_STORAGE on sdk>=30
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
1154b439fe
ContentResolverHelperTest: use mockitokotlin instead of mockk
MockK doesn't work properly on android < 27. Lesson learned.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
be830a66c8
COntentResolverHelper: sort column must be an array
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
8860bd4b52
Fix OCFIleListFragmentIT on sdk 30
Can no longer open /sdcard/ directly, let's use the external files dir

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
aa7b5617ab
ContentResolverHelper: add tests and proper copyright headers
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
6e645f7f06
MediaProvider: solve crash on Android 11 due to invalid contentProvider queries
This manifested mostly when trying to open "auto upload"

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
d92e3cbfaa
Fix some type errors after sdk 30 bump
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
ac9f516027 Unified search: skip local file check for non-file results
Fixes https://github.com/nextcloud/android/issues/9171

Needs https://github.com/nextcloud/android-library/pull/739

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 07:23:33 +00:00
Nextcloud bot
0558b25ee3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-02 03:49:39 +00:00
Nextcloud bot
346fc512a2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-01 03:48:17 +00:00
Nextcloud bot
3abf27f947
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-30 03:50:46 +00:00
Nextcloud bot
f9bfb044dc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-29 03:49:55 +00:00
Álvaro Brey Vilas
9a94ddc1cc
ConnectivityService: handle SecurityException in getNetworkCapabilities
Bug on Android implementation

See: https://stackoverflow.com/questions/66652819/getting-security-exception-while-trying-to-fetch-networkcapabilities-on-android

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-28 10:13:30 +02:00
Nextcloud bot
da095ddfb6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-28 03:51:04 +00:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-27 08:49:05 +02:00
Nextcloud bot
8c0e77ae93
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-27 03:55:09 +00:00
tobiasKaminsky
bbcfdbe98d
Remove unneeded checks for M build target
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-26 07:57:01 +02:00
Nextcloud bot
a946385603
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-26 03:50:35 +00:00
Nextcloud bot
2c7c571fca
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-25 14:25:18 +00:00
Tobias Kaminsky
6176998a0e
Merge pull request #9141 from nextcloud/bump-outdated-server-version
Bump versions before RC
2021-10-25 16:13:56 +02:00
Tobias Kaminsky
6e76954fcf
Merge pull request #8848 from nextcloud/sharingDialog
Sharing dialog improvement
2021-10-25 16:08:23 +02:00
Álvaro Brey Vilas
0984213b62
AndroidManifest: remove resources with maxSDK=22
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:44:36 +02:00
Álvaro Brey Vilas
e99960c59d
TestPowerManagementService: Bump SDK version used for test
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:39:25 +02:00
Álvaro Brey Vilas
16b83131c8
Bump OUTDATED_SERVER_VERSION to 19
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:25:44 +02:00
tobiasKaminsky
0cdfd7a906
Optimize imports
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:18:31 +02:00
tobiasKaminsky
3965f22e7c
remove unused foreground (which was working only on API23+)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
6fe72782fe
FileDisplayActivity: fix new spotbugs warning
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
d7d3157410
Unified search: solve RTL symmetry warnings
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
631db66da7
Unified search: show context leak in UnifiedSearchViewModel
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
8cadb2b5de
Unified search: add placeholder icon for Deck
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
c51df6fb5b
Unified search: better placeholder icons
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
16100677bb
Unified search: fix inverted success value for "load more"
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
f927cfe2d8
Unified search: Round thumbnails when requested by server
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
b6cd8af18a
GetRemoteFileTask: pass User directly instead of account
Needed after model changes in master

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
2387545119
Unified search: Fix broken integration test
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:55 +02:00
Álvaro Brey Vilas
18cbdfa93c
Unified search: minor UI improvements
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:55 +02:00
Álvaro Brey Vilas
61c2242896
Unified search: cleanup viewmodel usage with interface
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:54 +02:00
Álvaro Brey Vilas
fdf1abd0fd
Unified search: fix opening non-file results (open in a browser)
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:54 +02:00
Álvaro Brey Vilas
c3a1656781
Unified search: fix existing tests to make CI happy
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:54 +02:00
tobiasKaminsky
73e4f3cf05
fix loading message
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
146650c0c6
Unified search: bind search view on US fragment to allow subsequent searches
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
361e81ea9c
Unified search: set toolbar title to search query
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
3fc6fc8bdf
Unified search: several UI and navigation improvements
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
fac2958788
Unified search: Show error messages, loading anim, click animations. Implement refresh.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
e898965dc1
Unified search: transform results in ViewModel and fix "load more" behaviour
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
484a506688
Unified search: do not show "load more" if there are no more results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
e8feb412a4
Unified search: basic "Load more" functionality
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:51 +02:00
Álvaro Brey Vilas
02d133a1c7
Unified search: always show files results first
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:51 +02:00
Álvaro Brey Vilas
6c98b4cb8d
Unified seach: allow querying different providers asynchronously, and get their IDs in the result
First step towards getting "Load more" working for a single provider

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
b0b9d3a3e3
Unified search: get search to fetch and show multiple providers
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
decfc91d58
FileDisplayActivity: Restore showFile function that was lost in the rebase
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:50 +02:00