Commit graph

17761 commits

Author SHA1 Message Date
Álvaro Brey Vilas
7d258f9793
FileMenuFilter: Allow "Send" for single files if in file detail fragment
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:33:26 +01:00
Álvaro Brey Vilas
038ac7b3c5
FileDetailSharingFragment: remove misleading "Open in..." option
This only triggered the share file dialog, which should be opened elsewhere.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-15 12:33:15 +01:00
Álvaro Brey
587b371e76
Merge pull request #9545 from nextcloud/fix/autoupload-check-crash
UploadFilesActivity: don't attempt to check selectAll if selectAll is not visible in menu
2021-12-15 11:28:32 +01:00
Álvaro Brey
143455b42a
Merge pull request #9427 from nextcloud/fix/triplicated-search-events
Fix issue where favorites where loaded by triplicate when opening from Media or other search
2021-12-15 11:06:39 +01:00
Álvaro Brey
a9671d9e85
Merge pull request #9434 from nextcloud/fix/unified-search-no-connection
Unified search: show error when there's no connection
2021-12-15 11:05:34 +01:00
Álvaro Brey
b5e36d25be
Merge pull request #9547 from nextcloud/fix/favorite-state-lost
OCFileListFragment: don't delete search event if resuming a search fragment
2021-12-15 09:43:50 +01:00
Nextcloud bot
3f8adc1016
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-15 03:53:06 +00:00
Álvaro Brey Vilas
d503623d1d
OCFileListFragment: don't delete search event if resuming a search fragment
This fixes a bug where favorites screen seemed empty after coming back from a share fragment.

This took WAY too long to figure out, this class needs a big refactor.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-14 17:52:52 +01:00
Álvaro Brey
157f62a775
Merge pull request #9541 from nextcloud/fixUploadFromApps
"last modified" column might not exist, thus it shall never fail to upload
2021-12-13 13:04:28 +01:00
Álvaro Brey Vilas
662f15d250
UploadFilesActivity: don't attempt to check selectAll if selectAll is not visible in menu
This was crashing autoupload settings.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-13 12:50:17 +01:00
Álvaro Brey
e9b13fe45f
Merge pull request #9537 from nextcloud/fix-npe-in-file-uploader
Do not set notification manager to null in uploader service
2021-12-13 12:25:41 +01:00
Álvaro Brey
0e45a8611c
Merge pull request #9535 from nextcloud/prevent-player-service-stop-from-using-foreground-service-api
When stopping PlayerService, do not use foreground service api
2021-12-13 11:43:57 +01:00
Álvaro Brey
d9874c788c
Merge pull request #8730 from nextcloud/migrate-file-activity-extra-account-to-extra-user
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER and use User model as well
2021-12-13 11:37:44 +01:00
tobiasKaminsky
86a5c930b0
"last modified" column may not exist, thus it shall never fail to upload
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-12-13 09:47:49 +01:00
Nextcloud bot
45b591f3d2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-13 03:52:57 +00:00
Chris Narkiewicz
0c087012d7
Do not set notification manager to null in uploader service
NPE is most likely caused by a race condition, when
file upload update arrives after onDestroy().

Do not set notification manager to null - it does not
make any sense anyway, as it's a system service.

Fixes #9390

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-12-12 14:41:48 +00:00
Chris Narkiewicz
989b8aeddb
When stopping PlayerService, do not use foreground service api
Sending async message to the service using foreground API
requires setting foreground flag. This won't happen if
the service is being stopped, so we must use startService()
API instead.

This API will throw IllegalStateException when app is banned
from running a service due to power management constraints.

Since stopping a service under such condition is not needed
anyway (it is not running), we can safely catch and ignore it.

This happens when app is woken up after long inactivity and
UI is recreated from cache.

Fixes #9491

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-12-12 13:15:20 +00:00
Nextcloud bot
a284b6fcde
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-12 03:54:58 +00:00
Chris Narkiewicz
883857db32
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER
Migrate FileActivity.EXTRA_ACCOUNT to EXTRA_USER and pass
User model around instead of Account.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-12-12 00:23:40 +00:00
Nextcloud bot
06e1c41884
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-11 03:53:44 +00:00
Álvaro Brey Vilas
f81779285e Drone: update Lint results to reflect reduced error/warning count [skip ci]
Signed-off-by: Álvaro Brey Vilas <drone@nextcloud.com>
2021-12-10 13:05:22 +00:00
Álvaro Brey Vilas
3b023e9be5
Update analysis results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-10 13:08:06 +01:00
Álvaro Brey
489eb75858
Merge pull request #9523 from nextcloud/fix/media-preview-navigation
FileDisplayActivity: Preserve title bar after resume
2021-12-10 10:33:31 +01:00
Álvaro Brey
8b63aaf2f9
Merge pull request #9522 from nextcloud/fix/search-landscape
Unified search: clear focus from search view on open
2021-12-10 10:26:35 +01:00
Tobias Kaminsky
67b922dfe0
Merge pull request #9493 from nextcloud/codestyle-remove
Code style: remove autowrap false option
2021-12-10 10:26:06 +01:00
Nextcloud bot
9358e7d407
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-12-10 03:57:24 +00:00
Álvaro Brey Vilas
46669cc1d8
FileDisplayActivity: Preserve title bar after resume
Fixes title bar reverting to searchbar even if the resumed fragment is the preview or the details fragments

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 18:32:59 +01:00
Álvaro Brey Vilas
30091a7aa4
Unified search: clear focus from search view on open
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-12-09 16:58:36 +01:00
Álvaro Brey
0edba984be
Merge pull request #9426 from nextcloud/fix/unified-search-apps
UnifiedSearch: Fix opening non-file results with relative URLs
2021-12-09 15:59:31 +01:00
Álvaro Brey
76210ada17
Merge pull request #9494 from nextcloud/fix/calendar-dialog-style
DatePickerDialog: fix theme
2021-12-09 15:59:11 +01:00
Álvaro Brey
451c629a44
Merge pull request #9418 from nextcloud/fix/sharing-note-mandatory
Don't make note mandatory for sharing
2021-12-09 15:58:46 +01:00
Álvaro Brey
515e3f7089
Merge pull request #9449 from nextcloud/fix/fdf-binding-npe
FileDetailFragment: prevent NullPointerException if fileDetailSharingFragment is called too soon
2021-12-09 15:57:52 +01:00
Álvaro Brey
301543455f
Merge pull request #9476 from nextcloud/storeFavoriteAfterFavoritingIt
After favorite/unfavorite store this also in db, not only change it in UI
2021-12-09 15:39:05 +01:00
Álvaro Brey
840ec88f57
Merge pull request #9475 from nextcloud/renameFix
Rename remote path upon renaming
2021-12-09 15:38:46 +01:00
Álvaro Brey
16d2aa2554
Merge pull request #9474 from nextcloud/fixGallerySearch
Fix vanishing files after gallery search
2021-12-09 15:38:28 +01:00
Álvaro Brey
b38905fff7
Merge pull request #9469 from nextcloud/darkModeBackgronud
Explicitly set background for fragments
2021-12-09 15:37:58 +01:00
Álvaro Brey
0620d0a574
Merge pull request #9468 from nextcloud/translateError
Extract string to get translated
2021-12-09 15:37:07 +01:00
Álvaro Brey
2872f8167e
Merge branch 'master' into translateError 2021-12-09 15:36:57 +01:00
Álvaro Brey
22c308f69a
Merge pull request #9467 from nextcloud/fileSizeInShareDialog
update file size upon opening share dialog
2021-12-09 15:36:00 +01:00
Álvaro Brey
4381f7e33c
Merge pull request #9478 from nextcloud/emptyNotCentered
Empty list is not centered and in landscape cut off
2021-12-09 15:35:11 +01:00
Álvaro Brey
739364dd63
Merge pull request #9466 from nextcloud/enhancePlayIcon
Play button as overlay on videos is now more sharpe on large displays
2021-12-09 15:34:22 +01:00
Álvaro Brey
ad781a4b34
Merge pull request #9465 from nextcloud/trashbinCount
Update footer upon restore/delete of a deleted file
2021-12-09 15:34:02 +01:00
Álvaro Brey
aa0914011d
Merge pull request #9464 from nextcloud/drawerHighlight
highlight correct menu drawer icon
2021-12-09 15:33:28 +01:00
Álvaro Brey
60aa2becf3
Merge pull request #9463 from nextcloud/highlightSortOrder
Correctly highlight selected sort order
2021-12-09 15:33:02 +01:00
Álvaro Brey
ad5c73f5ea
Merge pull request #9462 from nextcloud/expandSendShareDialog
Expand send share dialog when in landscape mode
2021-12-09 15:32:37 +01:00
Álvaro Brey
41f650586f
Merge pull request #9461 from nextcloud/unifiedSearch_showNoResults
If no search results from any provider, show it
2021-12-09 15:31:46 +01:00
Álvaro Brey
6a3dd84ba1
Merge branch 'master' into unifiedSearch_showNoResults 2021-12-09 15:31:32 +01:00
Álvaro Brey
42212e410e
Merge pull request #9460 from nextcloud/mediaEmpty
Show correct empty screen if gallery search returns empty
2021-12-09 15:30:20 +01:00
Álvaro Brey
e33419eb75
Merge pull request #9485 from nextcloud/fixSetPictureAs
"set picture as" needs temporary read permission
2021-12-09 15:27:23 +01:00
Álvaro Brey
98319b40d0
Merge pull request #9484 from nextcloud/fix401whenReloggingIn
when re-logging in too fast, we stored an empty auth token
2021-12-09 15:27:06 +01:00