Commit graph

10444 commits

Author SHA1 Message Date
eho
0bc74d79f2 Merge branch '2583-feature-photoview' of github.com:nextcloud/android into 2583-feature-photoview 2018-05-19 18:49:22 +02:00
eho
0231972869 ui:preview Correctly load svg files into PhotoView. 2018-05-19 18:46:55 +02:00
nextcloud-android-bot
5dd55e8a62 Drone: update Lint results to reflect reduced error/warning count [skip ci] 2018-05-19 16:43:48 +00:00
ardevd
d51f1206a3
Merge c52f8e25b3 into 9430466823 2018-05-19 16:23:58 +00:00
eho
c52f8e25b3 ui: Correctly load and display downloaded gif's. 2018-05-19 18:23:49 +02:00
Andy Scherzinger
9430466823
Merge pull request #2594 from nextcloud/libToMaster
Ignore "unused quantity"
2018-05-19 14:50:38 +02:00
tobiasKaminsky
6128422817
ignore "unused quantity"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-19 13:19:32 +02:00
Nextcloud bot
b9023355f8
[tx-robot] updated from transifex 2018-05-19 00:47:14 +00:00
Andy Scherzinger
94afb0f4e0
Merge pull request #2590 from nextcloud/libToMaster
Lib refers always to master
2018-05-18 22:10:45 +02:00
eho
534ae55fd3 ui:preview Replaced TouchImageViewCustom objects with PhotoView equivalents.
- Removed call to setPreviewImageFragment() as this is method no longer exists and doesnt seem to be required.
- Since PhotoView supports gif's out of the box, we should include that mimetype in the relevant if statement.
- Simplified the mime-type check.
2018-05-18 20:26:26 +02:00
eho
9937ac1c7e res: Replaced TouchImageViewCustom widget with PhotoView widget 2018-05-18 20:16:13 +02:00
eho
5998a642ad Removed ImageViewCustom class. Replaced with PhotoView 2018-05-18 20:15:23 +02:00
eho
bc53e48c47 Removde TouchImageViewCustom class.
It's being replaced by PhotoView.
2018-05-18 20:14:25 +02:00
eho
ed405e94e1 ui:preview Updated resetZoom() method to properly reset zoom level on the PhotoView object.
By calling setDisplayMatrix and setSuppMatrix, passing a new Matrix object to them, the original zoom level is restored.
2018-05-18 20:11:56 +02:00
eho
3f1c724f42 ui:preview Replace deprecated setOnPageChangeListener() method with addOnPageChangeListener(). 2018-05-18 20:10:11 +02:00
eho
5147f09d6c ui:preview Replaced ExtendedViewPager references with their ViewPager equivalents. 2018-05-18 20:05:26 +02:00
eho
2e8c395037 res: Replace the custom ExtendedViewPager widget with stock ViewPager. 2018-05-18 20:02:36 +02:00
eho
ea905884d6 gradle: Added PhotoView dependency.
Latest version is 2.1.3.
2018-05-18 20:01:40 +02:00
eho
c9c65ad6bc Removed ortiz.touch.* classes.
They are being replaced by PhotoView and the stock Android View Pager API.
2018-05-18 20:00:04 +02:00
tobiasKaminsky
5e6af05bc7
lib refers always to master
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-18 09:15:16 +02:00
Nextcloud bot
5769ba55fd
[tx-robot] updated from transifex 2018-05-18 00:51:13 +00:00
Nextcloud bot
3ae3052fd4
[tx-robot] updated from transifex 2018-05-17 00:51:37 +00:00
Andy Scherzinger
b11cb72dbc
Merge pull request #2570 from nextcloud/2569-mimetype-contextbug
Verify context before getting file type icon.
2018-05-16 14:26:00 +02:00
Andy Scherzinger
3aa1716d7e
Merge pull request #2582 from nextcloud/accountutils-cleanup
Cleanup of the AccountUtils class.
2018-05-16 14:23:44 +02:00
Andy Scherzinger
e344d28e67
Merge pull request #2579 from nextcloud/activities-cleanup
Housekeeping of Activities Presenter and associated repository classes.
2018-05-16 14:23:05 +02:00
Nextcloud bot
f8987af4f7
[tx-robot] updated from transifex 2018-05-16 00:47:31 +00:00
Tobias Kaminsky
e2f34e6c0a
Merge pull request #2581 from nextcloud/mainapp-cleanup
Mainapp cleanup
2018-05-15 15:47:16 +02:00
Andy Scherzinger
b0f890f2fa
Merge pull request #2580 from nextcloud/touchimageview-cleanup
Cleanup of the TouchViewImage class
2018-05-15 11:54:33 +02:00
ardevd
8919321eea authentication: Make the anonymous inner class a lambda.
With Java 8, most uses of anonymous inner classes should be replaced by lambdas to highly increase the readability of the source code.
2018-05-15 09:03:38 +02:00
ardevd
e5a1de5e50 authentication: Use single quotes around single character "lastIndexOf" calls.
An indexOf or lastIndexOf call with a single letter String can be made more performant by switching to a call with a char argument.
2018-05-15 09:02:55 +02:00
ardevd
75d10d6afb authentication: Use equalsIgnoreCase() instead of convoluted toLowerCase()
Using toLowerCase() or toUpperCase() to make case insensitive comparisons is inefficient because it requires the creation of temporary, intermediate String objects.

In this case, it also made the fi statement complex and difficult to read.
2018-05-15 09:01:56 +02:00
ardevd
21a4d56a44 authentication: Use a string constant instead of duplicating "select_oc_account" three times.
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
2018-05-15 08:58:39 +02:00
ardevd
27999b5b2c authentication: Added empty private constructor to AccountUtils.
The private constructor hides the implicit public one
2018-05-15 08:55:59 +02:00
ardevd
e2c0ccda6f mainapp: Add @Override annotation to onCreate() 2018-05-15 08:50:15 +02:00
ardevd
13a6adfbc1 mainapp: Removed unused import. 2018-05-15 08:48:42 +02:00
ardevd
5ecbd68667 touchimageview: Variable declaration should be separate.
Declaring multiple variable on one line is difficult to read.
2018-05-15 08:46:32 +02:00
ardevd
3485cbe3fb touchimageview: Removed empty statement.
; has no meaning here.
2018-05-15 08:44:15 +02:00
ardevd
89f985fccb touchimageview: Removed redundant static qualifier.
Nested enum types are implicitly static
2018-05-15 08:43:45 +02:00
Nextcloud bot
3b93315193
[tx-robot] updated from transifex 2018-05-15 00:46:24 +00:00
eho
fcd900021f util: Annotate getFileTypeIcon with Nullable.
If context is null the drawable passed back will be null as well.
2018-05-14 21:50:48 +02:00
ardevd
00badca7b3 ui:activities Fixed license header formatting. 2018-05-14 15:58:20 +02:00
ardevd
d0a4374646 data:activities Declare context before initializing Account object so that we can re-use the context variable. 2018-05-14 15:57:05 +02:00
ardevd
dd16750742 data:activities: Removed hard coded error message for no results.
Reference the file_list_empty_headline_server_search string resource instead using the context passed from MainApp.
2018-05-14 15:56:18 +02:00
ardevd
e80cef5be5 ui:activities ActivitiesPresenter formatting cleanup.
- Fixed indentation and removed redundant newlines.
2018-05-14 15:52:19 +02:00
ardevd
00d94c022b ui:activities Make ActivitiesPresenter package private. 2018-05-14 15:51:20 +02:00
Andy Scherzinger
4d2dc56e82
Merge pull request #2578 from nextcloud/nullContextAgain
fix again a null context
2018-05-14 14:29:54 +02:00
tobiasKaminsky
b5bed7874e
fix again a null context
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2018-05-14 14:09:53 +02:00
Nextcloud bot
d094946b2d
[tx-robot] updated from transifex 2018-05-14 00:46:08 +00:00
Nextcloud bot
700d3bf7f3
[tx-robot] updated from transifex 2018-05-12 00:45:52 +00:00
ardevd
e705206ca6 utils: Replace deprecated getResources().getDrawable() with ContextCompat.getDrawable()
Resources#getDrawable(int) method was deprecated in Marshmallow in favor of the new, Theme-aware replacement.
2018-05-11 12:06:22 +02:00