Commit graph

45337 commits

Author SHA1 Message Date
Michael Telatynski
f152613f83
Apply strictNullChecks to src/components/auth/* (#10484
* Apply `strictNullChecks` to `src/components/auth/*`

* fix

* strict types
2023-03-31 09:26:15 +01:00
Michael Weimann
af151700c9
Strictify src/components/structures/Space* (#10481) 2023-03-31 10:20:15 +02:00
Michael Weimann
dddef858f1
Fix detection of encryption for all users in a room (#10487) 2023-03-31 09:43:47 +02:00
Eric Eastwood
ff1468b6d3
Replace newTranslatableError with UserFriendlyError (#10440
* Introduce UserFriendlyError

* Replace newTranslatableError with UserFriendlyError

* Remove ITranslatableError

* Fix up some strict lints

* Document when we/why we can remove

* Update matrix-web-i18n

Includes changes to find `new UserFriendlyError`,
see https://github.com/matrix-org/matrix-web-i18n/pull/6

* Include room ID in error

* Translate fallback error

* Translate better

* Update i18n strings

* Better re-use

* Minor comment fixes
2023-03-31 08:30:43 +01:00
Michael Telatynski
567248d5c5
Add aria labels to message search bar to improve accessibility (#10476) 2023-03-30 10:26:19 +01:00
David Baker
15523cde36
Update test interface to add call object (#10477)
Compatibility with https://github.com/matrix-org/matrix-js-sdk/pull/3237
2023-03-30 10:22:27 +01:00
Suguru Hirahara
232daaff68
Fix decryption failure bar covering the timeline (#10360)
* Use grid layout instead

- BEM naming style
- Increase block gap from 4px to 8px
- Use flexbox inside 'header' grid-area to let the buttons wrapped
- Use variables
- Remove 4px gap when one of the buttons is not rendered
- Change 'body' to 'message'
- Set 'align-self: start' to the icon and spinner

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Unset height of spinner

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Break lines at newline characters with white-space: pre-line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Edit tests to check decryption failure bars on narrow timeline

- checkTimelineNarrow() looks for buttons by default
- Test indicator as well

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Edit the test to have it check mx_EventTile_last only inside mx_RoomView_body

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix double underscores

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix double underscores - pcss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Iterate - buttons at the bottom

- Set common spacing to buttons with variables
- Remove line breaks, yarn run i18n
- Set data-testid for headlines and buttons in case the tested strings would be displayed elsewhere simultaneously

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Check waiting headline as well

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Increase spacing between the message and the buttons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* lint

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Increase block gap between wrapped buttons for clickability

Apply 8px between wrapped buttons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Revert bottom margin of buttons which are not expected to be wrapped

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Check visibility instead of existence

This commit removes data-testid from headlines and data-testid-button and checks whether the elements are really visible, not overflowing the viewport.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant gap between 'mx_DecryptionFailureBar_start' and the bottom edge

This commit adds '.mx_DecryptionFailureBar--withEnd' class name to have it applied to the bar only if it has button(s). This way the bar is rendered with a flexbox and the row-gap declaration is respected only if there is a 'mx_DecryptionFailureBar--withEnd' element. The element  currently includes the button(s) only.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* lint - prettier

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Have Percy take a snapshot of the bar loading spinner before checkTimelineNarrow()

The loading spinner is likely to disappear while checking the bar on the narrow timeline.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Kerry <kerrya@element.io>
2023-03-30 10:11:16 +01:00
Andy Balaam
bebfbacded
Update changelog for v3.69.0 now the security issue is public (#10468) 2023-03-30 09:10:04 +00:00
Michael Weimann
052c7e6d27
Strictify components/structures/Thread* (#10478)
* Strictify `components/structures/Thread*`

* Fix ThreadView event Id
2023-03-30 09:44:28 +01:00
Suguru Hirahara
beb8861df6
Add E2E test of MessageEditHistoryDialog (#10406) 2023-03-30 10:32:02 +02:00
Michael Weimann
9aef1874db
Strictify stores/room-list (#10474) 2023-03-30 09:06:50 +01:00
Michael Telatynski
9848cdf4e7
Apply strictNullChecks to src/components/structures/Space* (#10475) 2023-03-30 08:28:08 +01:00
Kerry
9a733a6444
Apply strictNullChecks to src/utils/exportUtils (#10379)
* Apply `strictNullChecks` to `src/utils/exportUtils`

* strict fix

* test coverage

* lint

* test coverage

* one more test
2023-03-29 21:47:07 +00:00
Michael Telatynski
1447829543
Improve profile picture settings accessibility (#10470) 2023-03-29 14:00:45 +00:00
Michael Weimann
968b6fc5df
Implement permalink end-2-end test (#10434) 2023-03-29 13:52:57 +02:00
Michael Telatynski
a47b3eb0ee
Apply strictNullChecks to src/components/views/elements/* (#10462
* Apply `strictNullChecks` to `src/components/views/elements/*`

* Iterate

* Iterate

* Iterate

* Apply `strictNullChecks` to `src/components/views/elements/*`

* Iterate

* Iterate

* Iterate

* Update snapshot
2023-03-29 08:23:54 +01:00
Michael Telatynski
cefd94859c
Conform src/components/views/messages/* code to strictNullChecks (#10461) 2023-03-29 08:22:35 +01:00
Michael Weimann
7cb90d0f78
Add Cypress Testing Library (#10446) 2023-03-29 08:47:05 +02:00
Kerry
6eda1fa6e2
replace Polls history strings with Poll history (#10454)
Co-authored-by: Michael Weimann <michaelw@matrix.org>
2023-03-28 22:13:51 +00:00
RiotRobot
f5115e047e Reset matrix-js-sdk back to develop branch 2023-03-28 14:33:05 +01:00
RiotRobot
0475e7107f Merge branch 'master' into develop 2023-03-28 14:30:52 +01:00
RiotRobot
500a543662 v3.69.0 2023-03-28 14:23:32 +01:00
RiotRobot
ef46e9a94e Prepare changelog for v3.69.0 2023-03-28 14:23:29 +01:00
RiotRobot
0d8a1eb850 Upgrade matrix-js-sdk to 24.0.0 2023-03-28 14:21:30 +01:00
Robin
edef4cc52e
Handle group call redaction (#10465)
Redacted group call events should be interpreted as terminated calls.
2023-03-28 13:16:30 +00:00
Michael Weimann
c30b2637c5 Changes for v3.69.0 2023-03-28 11:23:16 +01:00
Suguru Hirahara
f1667870a0
Change the category of a test from message displaying to configure room (#10449) 2023-03-28 08:57:17 +01:00
Kerry
ae50eee135
Apply strictNullChecks to src/utils/pillify.tsx (#10456)
* apply strictNullChecks to src/utils/pillify.tsx

* include change to utility

* apply strictNullChecks to src/utils/permalinks
2023-03-28 10:07:49 +13:00
Kerry
cd700e20fc
Display relative timestamp for threads on the same calendar day (#10399)
* add test cases for <24 different day time formatting

* use day instead of <24h ago to format relative date
2023-03-27 20:22:46 +00:00
maheichyk
68fa9aed9d
Show "Invite" menu option if "UIComponent.sendInvites" is enabled. (#10363)
* Show "Invite" menu option if "UIComponent.sendInvites" is enabled.

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>

* Update test names

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>

---------

Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
Co-authored-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
2023-03-28 09:10:18 +13:00
Richard van der Hoff
d821323e5c
Prevent rust-crypto setting from leaking to other tests (#10464)
Follow-up to #9759.

Because the MatrixClientPeg pushes the use_rust_crypto setting back into the SettingsStore, the setting was leaking out to other tests despite getValue's mock being restored.

The solution is to mock out setValue as well.
2023-03-27 18:03:17 +00:00
Suguru Hirahara
513eb0f83d
Improve Percy snapshot stability more - await inline spinners to vanish (#10452)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-03-27 18:02:34 +00:00
alunturner
0fcb9d6a3e
Remove css causing list and paragraph issues (#10424) 2023-03-27 18:16:37 +01:00
Michael Weimann
b0de7b3bb6
Use unique keys for voice broadcast pips (#10457) 2023-03-27 18:19:42 +02:00
devonh
d33e416fc7
Enable running cypress tests with dendrite & pinecone (#10418) 2023-03-27 14:53:48 +01:00
Michael Telatynski
065e970325
Conform src/hooks/* code to strictNullChecks (#10460) 2023-03-27 14:45:46 +01:00
Suguru Hirahara
afb2cb93f2
Fix flaky Percy tests of ReplyChain (#10450)
* Fix flaky Percy tests of ReplyChain

- Add media query for percy on _ReplyChain.pcss to apply the same color to vertical strokes (border-left)of ReplyChain
- Use CSS variables for visibility
- Manage those variables on _common.pcss for maintainability

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Check receptSent as well for consistency

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add a comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Specify zero spacing and remove list-style

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-03-27 12:13:25 +00:00
Suguru Hirahara
cc0f38d5b4
Hide mx_TopUnreadMessagesBar for now on Percy because flaky (#10453)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2023-03-27 11:51:50 +00:00
Janne Mareike Koschinski
63678603e0
Revert "Mentions as links rte (#10422)" (#10458)
This reverts commit 1af71089dd.
2023-03-27 12:57:05 +02:00
Michael Telatynski
58a4003a59
Fix "show read receipts sent by other users" not applying to threads (#10445) 2023-03-27 09:56:31 +01:00
Michael Weimann
aec454dd6f
Add UserProfilesStore, LruCache and cache for user permalink profiles (#10425) 2023-03-27 10:07:43 +02:00
Michael Telatynski
1c039fcd38
Fix joining public rooms without aliases in search dialog (#10437)
Co-authored-by: Andy Balaam <andy.balaam@matrix.org>
2023-03-27 07:39:34 +00:00
Andy Balaam
45525480ef
Update docs about Percy now they run nightly (#10442)
* Update docs about Percy now they run nightly

* Fix paths

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2023-03-27 07:18:11 +00:00
Michael Telatynski
c225b8ec29
Conform more code to strictNullChecks (#10444
* Conform more code to `strictNullChecks`

* Fix tests

* Fix tests
2023-03-27 08:01:09 +01:00
Michael Weimann
ba2608ec74
Add m.direct filter / validation (#10436) 2023-03-27 08:37:35 +02:00
Eric Eastwood
e5f06df3f7
Better error handling in jump to date (#10405)
- Friendly error messages with details
 - Add a way to submit debug logs for actual errors (non-networking errors)
 - Don't jump someone back to a room they already navigated away from. Fixes bug mentioned in https://github.com/vector-im/element-web/issues/21263#issuecomment-1056809714
2023-03-24 14:39:24 -05:00
alunturner
1af71089dd
Mentions as links rte (#10422)
* bumps the RTE dependency to introduce user/room mention handling
* adds autocomplete behaviour to allow users to insert user and room mentions as links
* sets up tests for the autocomplete behaviour
2023-03-24 17:07:24 +00:00
Suguru Hirahara
8e1b9f46d4
Set expected value of line-height to expanded generic event list summary (GELS) spacer on IRC layout (#10211)
* Set expected line height to an expanded GELS line on IRC layout, add a test
* Add a test for compact modern/group layout
* Create a new test category on timeline.spec.ts
* Rename the class name as 'spacer'
* Add a test for GELS' spacer on bubble layout
---------

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Co-authored-by: Germain <germain@souquet.com>
2023-03-24 12:57:32 +00:00
Andy Balaam
75f31defd6
Disable flaky Percy tests that relate to focus (#10438) 2023-03-24 09:25:48 +00:00
Justin Carlson
332d1268a4
Fix creatorUserId is required error when opening sticker picker (#10423)
* Use sender if sticker picker widget does not have creatorUserId

* Add creatorUserId when creating sticker picker widgets

* Add e2e test for stickerpicker widget missing creatorUserId

* Fix stickerpicker widget event data in e2e tests

* Fix userId in stickerpicker e2e tests

* Fix linter errors
2023-03-23 17:25:16 +00:00