Michael Telatynski
201d7fb448
Merge branches 'develop' and 't3chguy/prop-types' of github.com:matrix-org/matrix-react-sdk into t3chguy/prop-types
...
# Conflicts:
# test/components/structures/MessagePanel-test.js
2019-07-31 12:21:00 +01:00
Michael Telatynski
1087e04bb5
Replace React.PropTypes with usage of the prop-types
package
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-07-31 12:19:29 +01:00
Michael Telatynski
4517fea496
Introduce RoomContext for sharing state between RoomView and children
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-07-31 00:47:38 +01:00
Bruno Windels
e73690439f
Merge pull request #3239 from matrix-org/bwindels/redirectpastetocomposer
...
Redirect paste to composer when event target can't receive input
2019-07-23 16:38:55 +00:00
Bruno Windels
82d7617287
add comments
2019-07-23 09:44:17 +02:00
Bruno Windels
ceb53dc0bb
Revert "remove unnessary manual focussing of composer"
...
This reverts commit 57abbc4273
.
2019-07-23 09:13:51 +02:00
Bruno Windels
023130bb4b
Redirect paste to composer when event target can't receive input
2019-07-19 17:49:04 +02:00
Bruno Windels
84e2333105
Merge pull request #3226 from matrix-org/bwindels/readmarker-invisble-events
...
Move read marker past invisible events
2019-07-19 15:10:03 +00:00
Bruno Windels
77f5274cd8
don't focus composer on keydown with modifier
...
this breaks shortcuts like copy, ...
2019-07-19 09:10:20 +02:00
Bruno Windels
4fa7302f69
Merge pull request #3224 from matrix-org/bwindels/focus-composer-on-type
...
Focus composer when typing anywhere in the app
2019-07-18 16:10:23 +00:00
J. Ryan Stinnett
674f33917f
Remove editing feature flag
...
Part of https://github.com/vector-im/riot-web/issues/10282
2019-07-17 16:56:15 +01:00
Bruno Windels
4bde0c08ad
make sure we don't break any A or BUTTON keyboard handling
2019-07-17 16:53:12 +02:00
Bruno Windels
10a74696b3
hack around React having its own bubbling phase
2019-07-17 16:50:05 +02:00
Bruno Windels
3d4cd8aa1c
local echos should always be ignored (for both RM and RR),so remove flag
...
pending events won't be in liveEvents (where we look) anyway
2019-07-17 10:19:44 +02:00
Bruno Windels
c94715150d
as both RM and RR move past invisible events, remove the flag
2019-07-17 10:18:51 +02:00
Bruno Windels
741ae9957b
also put read marker past (like RR) invisible events
2019-07-17 10:15:09 +02:00
Travis Ralston
2471f92331
Merge pull request #3218 from matrix-org/travis/check-when-dead
...
Check for liveliness on submission when the server was previously dead
2019-07-15 14:46:55 -06:00
Travis Ralston
2bc0e8e151
Don't rely on React being fast
2019-07-15 10:51:08 -06:00
Bruno Windels
57abbc4273
remove unnessary manual focussing of composer
...
now that composer is focused automatically when no other shortcuts
apply, remove the manual focusing we have in place where it's not needed
2019-07-15 18:21:10 +02:00
Bruno Windels
4adea67eb3
focus the composer in the body keydown handler if not other shortcuts apply
...
this allows the user to start typing a message even if the composer is not focused.
2019-07-15 18:12:45 +02:00
Bruno Windels
7e25e1b2fc
remove unneeded else
2019-07-15 14:02:41 +02:00
Bruno Windels
034883dc7e
improve comments
2019-07-15 14:01:28 +02:00
Bruno Windels
8ac54661be
take adjacent no-tile events in combination with ignored events into account when determining the last displayed event
2019-07-15 12:53:39 +02:00
Travis Ralston
c6a18b11f0
Check for liveliness on submission when the server was previously dead
...
Fixes https://github.com/vector-im/riot-web/issues/10017
Specifically the `return` at the end of the diff fixes the problem, but it seems worthwhile to check for liveliness when we know the server has been dead in previous attempts.
2019-07-14 23:23:48 -06:00
Travis Ralston
000d545ffd
Remove misleading text about admins logging people out from soft logout
2019-07-11 09:18:33 -06:00
Travis Ralston
ce11eff1b8
Simplify parameter check
2019-07-10 08:01:32 -06:00
Travis Ralston
2ca6633fda
Update copy as per design
2019-07-09 23:55:20 -06:00
Travis Ralston
041379fa3c
Don't refuse the soft logout page if the user is soft logged out
2019-07-09 23:44:14 -06:00
Travis Ralston
1eb60ef1c4
Support SSO for rehydrating a soft-logged-out session.
...
Fixes https://github.com/vector-im/riot-web/issues/10238
2019-07-09 20:16:44 -06:00
Travis Ralston
4b1d78e04d
Merge branch 'develop' into travis/soft-logout-design
2019-07-09 11:35:49 -06:00
Travis Ralston
a33e5f1918
Merge pull request #3188 from matrix-org/travis/soft-logout-non-default-hs
...
Fix React crash when using a non-default homeserver on soft logout
2019-07-09 11:32:31 -06:00
Travis Ralston
ab63e8bd04
Remove backwards compat function
2019-07-08 11:55:00 -06:00
Travis Ralston
d2ab0a5ca7
Move key backup init to componentDidMount
2019-07-08 11:53:26 -06:00
Travis Ralston
3e0be640fd
Merge branch 'travis/soft-logout-rehydrate' into travis/soft-logout-keys
2019-07-08 11:52:58 -06:00
Travis Ralston
c3383e9315
Move _initLogin to componentDidMount
2019-07-08 11:51:22 -06:00
Travis Ralston
ae79ce97f3
Dress up the soft logout page to look like the design
...
Fixes https://github.com/vector-im/riot-web/issues/10262
Also fixes showing the user ID twice. We might have a User object which helpfully sets the display name to the user ID, so check for that.
2019-07-05 15:05:31 -06:00
Travis Ralston
ca6563dce4
Merge branch 'travis/soft-logout-rehydrate' into t1
2019-07-05 15:03:24 -06:00
Travis Ralston
1f1a5b2aac
Fix React crash when using a non-default homeserver on soft logout
...
The function used exists on the peg, not the client. This commit also fixes the name of the function in a backwards compatible way.
2019-07-05 14:35:21 -06:00
Travis Ralston
55b4ef2169
Change soft logout rehydrate text if there's pending key backups
...
Fixes https://github.com/vector-im/riot-web/issues/10263
Requires https://github.com/matrix-org/matrix-js-sdk/pull/982
2019-07-05 13:52:14 -06:00
Travis Ralston
d39b4e9c7c
Merge branch 'travis/soft-logout-rehydrate' into travis/soft-logout-keys
2019-07-05 13:41:04 -06:00
J. Ryan Stinnett
017fc84862
Merge pull request #3184 from matrix-org/jryans/reactions-send-marks-unread
...
Track live events in timeline and use for read receipts and read markers
2019-07-05 17:55:59 +01:00
J. Ryan Stinnett
3c3426d97e
Update copyright header
2019-07-05 15:08:55 +01:00
J. Ryan Stinnett
0ae98a5a4d
Track live events in timeline and use for read receipts and read markers
...
This changes the `TimelinePanel` to track live events (that have committed to
the server and been remote echoed) as well as the full list of events (which
includes pending events).
The code paths that advance read receipt and read markers are then changed to
only use the live events so that these cannot advance into pending events.
Fixes https://github.com/vector-im/riot-web/issues/9952
2019-07-05 14:37:19 +01:00
Travis Ralston
00973a1ee8
Appease the linter
2019-07-04 17:00:09 -06:00
Travis Ralston
03cbd7e8bb
Ensure links off the forgot password page land you at soft logout
2019-07-04 16:51:55 -06:00
Travis Ralston
93872e6fa5
Ask for the user's password to rehydrate their soft logged out session
...
Fixes https://github.com/vector-im/riot-web/issues/10236
The changes to the MatrixClientPeg (assign/start) are to permit the SoftLogout page to access the MatrixClientPeg reliably. This is why assign() is called by Lifecycle as an alternative to start().
Minimal design work has been done here. The majority is deferred to https://github.com/vector-im/riot-web/issues/10262
2019-07-04 16:51:16 -06:00
Travis Ralston
89131be438
Require that users go to the soft logout page if they're soft logged out
...
Fixes https://github.com/vector-im/riot-web/issues/10234
2019-07-04 15:14:00 -06:00
Travis Ralston
8ea46a8c4d
Remove unneeded page types
2019-07-04 09:59:20 -06:00
Travis Ralston
5e5bf21281
Remove irrelevant debugging
2019-07-04 09:59:07 -06:00
Travis Ralston
521bc90b5f
Appease the linter
2019-07-03 16:51:09 -06:00
Travis Ralston
42e6287bdb
Implement basic soft logout handling
...
Fixes https://github.com/vector-im/riot-web/issues/10235
CSS and copy are left as an exercise for a later iteration.
Login page handling is left for https://github.com/vector-im/riot-web/issues/10236
This implementation reuses as much of the Lifecycle flow as it can without causing problems. Most importantly, it requires https://github.com/matrix-org/matrix-js-sdk/pull/975 to be able to detect a soft logout and react to it. When it comes time to starting/stopping the Lifecycle, additional parameters are provided so that the auxiliary services can (re)start themselves without the client starting to sync.
2019-07-03 16:46:37 -06:00
David Baker
668d24111c
Merge pull request #3173 from matrix-org/t3chguy/MELS_3pid
...
MELS handle m.room.third_party_invite
2019-07-03 16:02:10 +01:00
Bruno Windels
353f5a205c
Merge pull request #3170 from matrix-org/bwindels/handle-associated-failures
...
Handle associated event send failures
2019-07-03 09:02:58 +00:00
Michael Telatynski
429b8e94df
MELS handle m.room.third_party_invite
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-07-03 08:58:34 +01:00
Bruno Windels
14caed62d0
make sure scrollpanel is mounted before checking scroll
...
have seen errors in this direction, so hope this will fix it,
as this is invoked from any EventTile's onHeightChanged callback,
which is often called after some async operation (by when the
timeline can be unmounted already).
doesn't hurt in any case.
2019-07-02 17:29:37 +02:00
Michael Telatynski
46a6043e9b
Use title prop instead to minimize changes
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-06-30 11:00:21 +01:00
Michael Telatynski
8ed336ea08
Add AccessibleTooltipButton and use it for RoomSubList buttons
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-06-30 10:58:59 +01:00
J. Ryan Stinnett
2d1325686d
Merge pull request #3148 from matrix-org/matthew/fix-horizontal-scrolling
...
If on trackpad, don't mess with horizontal scrolling.
2019-06-28 15:21:22 +01:00
J. Ryan Stinnett
00dfdfe7f1
Fix linter warning
2019-06-28 15:16:44 +01:00
Travis Ralston
7f2ab39609
Merge pull request #3142 from matrix-org/travis/preview-loading
...
Show a loading state for slow peeks
2019-06-27 09:24:25 -06:00
Matthew Hodgson
3873dc724a
stupid linter >:(
2019-06-26 21:47:55 +01:00
Matthew Hodgson
7fc5d229d6
fix stuff as per review
2019-06-26 21:13:17 +01:00
Matthew Hodgson
3d11eb430b
oops, remove old code
2019-06-26 18:38:46 +01:00
Matthew Hodgson
debcafd760
if on trackpad, don't mess with horizontal scrolling.
...
trackpad heuristic is 'if 15 minutes of no horizontal scrollwheel events, assume user may have switched to mousewheel'
2019-06-26 18:38:03 +01:00
Travis Ralston
838ef7fa40
Merge pull request #3141 from matrix-org/travis/fix-guest-experience
...
Supply oobData to RoomPreviewBar
2019-06-26 07:14:00 -06:00
Travis Ralston
5f242f0285
Supply oobData instead of erroring
2019-06-25 20:57:07 -06:00
Travis Ralston
ca6ddf324f
Show a loading state for slow peeks
2019-06-25 20:56:33 -06:00
Travis Ralston
7b00d29ea6
Don't boost trackpad users in breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/10005
2019-06-25 16:08:11 -06:00
Travis Ralston
9771ce1e04
Merge pull request #3136 from matrix-org/t3chguy/room_directory_autojoin
...
When joining from room directory, use auto_join
2019-06-25 12:28:41 -06:00
Michael Telatynski
7391796eab
Only autojoin using the search box enter/join btn
2019-06-25 10:18:47 +01:00
Bruno Windels
8394e162ad
cache setting where it's easy
2019-06-24 16:53:31 +02:00
Michael Telatynski
9e7a70b9d5
When joining from room directory, use auto_join
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-06-23 22:39:04 +01:00
Bruno Windels
5fa3f70fb4
feature flag for displaying edits as well
2019-06-21 18:32:15 +02:00
J. Ryan Stinnett
b16a3c53cd
Merge pull request #3122 from matrix-org/jryans/slim-contextualmenu
...
Remove unused ContextualMenu features
2019-06-19 19:18:37 +01:00
J. Ryan Stinnett
78b0f61efe
Merge pull request #3119 from matrix-org/jryans/rename-tooltip-button
...
Fix casing of TooltipButton
2019-06-19 19:18:15 +01:00
J. Ryan Stinnett
dc9282c539
Remove unused ContextualMenu features
2019-06-19 14:47:15 +01:00
David Baker
6eddce8c32
lint
2019-06-19 12:13:17 +01:00
David Baker
edd43a2706
Fix favicon/title badge count
...
This was using a separate function (in MatrixChat) that didn't
take into account whether we were supposed to be hiding the badge
for rooms so would include notifs that were hidden everywhere else.
Also make it a function & put it in RoomNotifs with all its friends.
Fixes https://github.com/vector-im/riot-web/issues/3060
2019-06-19 12:06:32 +01:00
J. Ryan Stinnett
4ec7a8ddff
Fix casing of TooltipButton
...
My brain can't deal with two different ways to write "Tooltip", so this
converges the naming to match the rest of the code base. Separate commits will
fix up the file names for case-insensitive file systems.
2019-06-19 11:26:13 +01:00
David Baker
c8e121dc70
Restore warning for if you're already logged in
...
...when clicking an email link. Although now we can complete the
registration because we can do so without replacing your session.
2019-06-18 18:43:14 +01:00
Bruno Windels
c4fc2a8089
remove redundant localecho part from method name
2019-06-18 14:57:58 +02:00
Bruno Windels
02c9e29937
use renamed method that also takes local redactions into account now
2019-06-18 13:47:33 +02:00
Bruno Windels
32840fc274
Merge pull request #3098 from matrix-org/t3chguy/restore_composer_history
...
Restore Composer History under shift-up & down
2019-06-18 08:59:11 +00:00
David Baker
10f6abfe17
Allow changing server if validation has failed
...
Show the server config section if there's an error and fix an if
case where we forgot to un-set the busy flag
2019-06-17 18:47:20 +01:00
David Baker
e3bf4a0b8e
Re-enable register button on change to working HS
...
Register button disabling is done via serverErrorIsFatal so we need
to reset this on a successful validation.
https://github.com/vector-im/riot-web/issues/10029
2019-06-17 16:27:35 +01:00
David Baker
4c036c98ee
Fix double-spinner
...
On registering, we showed a spinner, and then another spinner on
top of the spinner, which led to an interesting spinner-in-box
effect.
Suppress the second type of spinner when we know we already have one.
2019-06-14 17:21:07 +01:00
David Baker
794b04b89a
take the debugging out
2019-06-14 16:41:30 +01:00
David Baker
30726d6cf9
Pull out welcome user chat code to a separate function
...
also expand on comment
2019-06-14 16:29:26 +01:00
David Baker
929e9dc653
Don't forget to show the homepage if no welcome user
2019-06-14 16:04:09 +01:00
David Baker
8fa50b26a6
Fix welcome user
...
https://github.com/matrix-org/matrix-react-sdk/pull/3101 meant we
don't get logged straight in after registering if using an email
address, but this was the point at which we made a chat with the
welcome user. Instead, set a flag in memory that we should try &
make a chat with the welcome user for that user ID if we get a
session for them.
Of course, if the user logs in on both tabs, this would mean each
would make a chat with the welcome user (although actually this
was a problem with the old code too). Check our m.direct to see if
we've started a chat with the welcome user before making one (which
also means we have to make sure the cached sync is up to date...
see comments).
2019-06-14 15:31:19 +01:00
Michael Telatynski
6a10f0068d
Use Alt-UP/DOWN for Composer History instead of random room change
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-06-14 12:26:52 +01:00
David Baker
446b20c454
Merge pull request #3101 from matrix-org/dbkr/simplify_email_reg
...
Simplify email registration
2019-06-13 18:22:30 +01:00
David Baker
81327264f7
Remove unused inhibitlogin param
...
and fix docs.
2019-06-13 17:44:00 +01:00
David Baker
048d8d2ec7
Simplify email registration
...
You now don't get automatically logged in after finishing
registration. This makes a whole class of failures involving race
conditions and multiple devices impossible.
https://github.com/vector-im/riot-web/issues/9586
2019-06-13 16:24:09 +01:00
Bruno Windels
3d944b715e
Merge pull request #3097 from matrix-org/bwindels/edit-unsent
...
Edit unsent messages
2019-06-13 14:00:46 +00:00
David Baker
1139f68de8
Pass in object of the right type
2019-06-12 18:11:58 +01:00
Bruno Windels
41e41269dc
use EditorStateTransfer to pass on state to newly mounted editor
2019-06-12 18:52:34 +02:00
David Baker
10377b42e9
Fix registration with email + non-default HS
...
We were ignoring the hs/is from the query parameters so after
clicking the link, the new client tried to use the wrong server.
Broken by https://github.com/matrix-org/matrix-react-sdk/pull/2941
Fixes https://github.com/vector-im/riot-web/issues/9659
2019-06-12 17:42:09 +01:00
J. Ryan Stinnett
413bff084c
Merge pull request #3087 from matrix-org/jryans/context-menu-clipping
...
Align message context menu to right and vertically where space available
2019-06-12 10:19:47 +01:00
J. Ryan Stinnett
b8ed731c89
Allow registration to submit for non-fatal errors
...
This allows you to proceed with registration even if the IS is down, for
example.
Fixes https://github.com/vector-im/riot-web/issues/10018
2019-06-11 18:01:27 +01:00
J. Ryan Stinnett
21099052fc
Clear the login busy state after .well-known discovery
...
This always clear the login busy state after .well-known discovery without
waiting for the resulting server config. This is important for the case where
the HS that a full MXID resolves to matches the default HS, as without it we'd
be stuck in a busy state forever.
Fixes https://github.com/vector-im/riot-web/issues/10014
2019-06-11 15:41:47 +01:00
David Baker
a6c5ac669b
Don't show spinner once liveness check has failed
...
We're not doing anything at that point so it's a lie
2019-06-11 12:10:44 +01:00
David Baker
5eccd14120
Fix registration after fail-fast
...
The lineness checks meant that we could no longer assume we always
had a matrix client, so don't assume we do.
Fixes https://github.com/vector-im/riot-web/issues/10011
2019-06-11 12:02:14 +01:00
David Baker
e1a1492f6f
Merge pull request #3085 from matrix-org/dbkr/one_request_at_a_time_two
...
Use setBusy interface of js-sdk interactive auth
2019-06-11 10:42:27 +01:00
David Baker
7b3d1ad08d
Typo
2019-06-11 10:29:00 +01:00
Travis Ralston
bd3237500f
Fix submit disabled condition
2019-06-10 20:24:06 -06:00
Travis Ralston
aacb942d57
Don't handle identity server failure as fatal, and use the right message
...
Fixes https://github.com/vector-im/riot-web/issues/10002
2019-06-10 19:28:32 -06:00
David Baker
db867d1a58
s/setBusy/busyChanged/
2019-06-10 16:27:27 +01:00
David Baker
cb4af9d043
Fix test fail
2019-06-10 16:18:58 +01:00
J. Ryan Stinnett
3126880345
Extend context menu alignment without chevrons
...
For context menus without chevrons, this changes the menu components to still
set default styles that align the menu based on the edges used to specify the
menu's position. This is not intended to change the positioning of any existing
menus.
2019-06-10 16:07:28 +01:00
David Baker
4597dcd221
Fix exception on logout
...
Don't try to unregister if we never registered
2019-06-10 15:27:59 +01:00
David Baker
a8a4ca2ed1
Use setBusy interface of js-sdk interactive auth
...
This helps to make sure we only do one auth request at a time.
https://github.com/matrix-org/matrix-js-sdk/pull/951
2019-06-10 15:22:53 +01:00
David Baker
2c10557f26
Don't NPE if no third party invite
2019-06-10 12:32:53 +01:00
David Baker
80812db466
Remember we were trying to accept an invite
...
When the user was on an invite page and clicked the sign up/sign in
buttons, remember that invite so we can show it again after they're
done signing up/in.
https://github.com/vector-im/riot-web/issues/9816
2019-06-10 10:24:06 +01:00
Travis Ralston
795a273e26
Merge pull request #3067 from matrix-org/travis/fail-fast-but-not-too-fast
...
Fail more softly on homeserver liveliness errors
2019-06-07 07:43:45 -06:00
Travis Ralston
59ba5fe62a
Don't block submit if the server is dead
...
But still check so we can clear any errors, maybe
2019-06-07 07:36:46 -06:00
Travis Ralston
120123bcb1
Allow submit on forgot password page
2019-06-07 07:27:15 -06:00
Michael Telatynski
3f6b266256
Merge pull request #3077 from matrix-org/t3chguy/change_keybind
...
change profile keybind to backtick from i due to italics conflict
2019-06-07 00:16:54 +01:00
Michael Telatynski
bea4f557a1
change profile keybind to backtick from i due to italics conflict
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-06-07 00:08:51 +01:00
David Baker
aba329cab5
Look busy whilst requesting the email token
...
We need to wait for it to finish before letting the user start
completing the steps since if it fails, we can't complete the auth.
2019-06-06 19:41:57 +01:00
Travis Ralston
d59ad605a6
Allow the login form to be submitted, and clarify other things
2019-06-06 12:18:41 -06:00
David Baker
b365c9dfe6
Merge pull request #3074 from matrix-org/dbkr/fix_email_invite_address_match_check
...
Fix email invites address-match checking
2019-06-06 15:06:36 +01:00
David Baker
9816fe0ed7
Fix email invites address-match checking
...
Riot was always saying the email address that the invite was sent
to was not associated with your account.
Two fixes here:
1. We mounted RoomPreviewBar with no invitedEmail prop and then
changed the prop later, but RoomPreviewBar only checked for it
on mount. Make sure we re-check when the props change.
2. Pass oobData through RoomPreviewBar because we need to pass it
to the RoomAvatar for 3pid invites.
https://github.com/vector-im/riot-web/issues/9816
2019-06-06 14:34:57 +01:00
Travis Ralston
ace1bde238
Implement design and copy for errors
2019-06-05 11:32:02 -06:00
Travis Ralston
38a4031299
Merge pull request #3066 from matrix-org/travis/no-button-guest
...
Add a logged in class to EmbeddedPage and react to MatrixClient changes
2019-06-05 07:23:45 -06:00
Bruno Windels
940b2a7ef2
Merge pull request #3058 from matrix-org/bwindels/redactions-local-echo
...
Don't show "can't redact" dialog on network error, with redaction having local echo & queuing now.
2019-06-05 07:49:51 +00:00
Travis Ralston
e2fdeec71a
Fail more softly on homeserver liveliness errors
...
This performs liveliness checks on the auth pages to try and show a friendlier error. Earlier checks in the app startup are expected to not block the app from loading on such failures.
See https://github.com/vector-im/riot-web/issues/9828
2019-06-04 23:42:38 -06:00
Travis Ralston
4fc054e1c9
Add a logged in class to EmbeddedPage and react to MatrixClient changes
...
See https://github.com/vector-im/riot-web/pull/9957
The two hacks introduced here are for different reasons, mostly related to the welcome page. If you land directly on the welcome page, the app's lifecycle is highly unlikely to have a bootstrapped client. This results in the loggedIn class being false. When the client is later set up (loaded from session, new guest account registered, etc) the context fails to update for the EmbeddedPage, and we need to give it a kick to re-render. It's arguable if we should even keep using the context here.
2019-06-04 16:08:32 -06:00
Bruno Windels
ef7b7628ac
use Room.redactionCancelled event
2019-06-04 21:37:57 +02:00
David Baker
b412103f21
Merge pull request #3062 from matrix-org/dbkr/dont_break_on_wrong_password
...
Fix login page breaking on wrong password
2019-06-04 18:02:22 +01:00
J. Ryan Stinnett
4956dcf45e
Merge pull request #3056 from matrix-org/jryans/read-receipts-relations-review
...
Ensure we always show read receipts even with hidden events
2019-06-04 16:24:05 +01:00
J. Ryan Stinnett
8e811fc78e
Use the existing room object
...
For some reason, we were getting the room object for every event during read
receipt processing, even though it has been passed in as a prop already.
2019-06-04 16:01:02 +01:00
J. Ryan Stinnett
06547ef5b3
Cache hidden events setting
...
Settings is too expensive to query in a hot code path, so this caches the value
on the MessagePanel component instead.
2019-06-04 16:01:02 +01:00
J. Ryan Stinnett
bea845a80d
Merge pull request #3059 from matrix-org/jryans/read-receipts-relations-send-review
...
Advance read receipts into trailing events without tiles
2019-06-04 14:35:14 +01:00
David Baker
9897e99195
Fix login page breaking on wrong password
...
Fixes https://github.com/vector-im/riot-web/issues/9942
2019-06-04 13:51:33 +01:00
David Baker
e1fa53e5d4
Remove unused errorText prop
...
Login is only used from MatrixChat and that doesn't specify it
2019-06-04 13:30:36 +01:00
J. Ryan Stinnett
e5abb2e089
Add more read receipt comments
2019-06-04 11:12:52 +01:00
J. Ryan Stinnett
96b213e7cb
Advance read receipts into trailing events without tiles
...
This changes read receipt sending logic to allow it advance further into events
without tiles (such as edits or reactions) that may exist after the last
displayed event.
By allowing the read receipt to advance past such events, this also marks as
read any related notifications. For example, edits trigger notifications by
default since they are `m.room.message` events, and with this change, such edit
notifications can finally be marked read.
Part of https://github.com/vector-im/riot-web/issues/9745
2019-06-03 18:25:35 +01:00
J. Ryan Stinnett
4cea2f0af1
Ensure we always have receipts for users we've seen
...
This adds additional receipt storage to so that we can handle cases where the
receipts and events lists get out of sync. If we ever find a user who previously
had a receipt but momentarily no longer does, we recover their previous receipt
and go with that until we hear something new.
Part of https://github.com/vector-im/riot-web/issues/9745
2019-06-03 15:05:03 +01:00
J. Ryan Stinnett
f8eb449dd7
Show read receipts for hidden events on last shown event
...
This changes how we determine read receipts for the entire message panel. We now
calculate read receipts for all events up front, which makes it easier to handle
hidden events by moving their read receipts up to the last shown event for
display purposes.
Part of https://github.com/vector-im/riot-web/issues/9745
2019-06-03 15:05:03 +01:00
J. Ryan Stinnett
91e86d2b02
Fix linting in MessagePanel
2019-06-03 15:03:59 +01:00
Travis Ralston
ad84144543
Merge pull request #3053 from matrix-org/travis/bc-labs
...
Convert breadcrumbs from labs to real setting
2019-06-03 07:10:51 -06:00
Travis Ralston
7f0282a2e8
Convert breadcrumbs from labs to real setting
...
Fixes https://github.com/vector-im/riot-web/issues/9391
2019-06-03 00:15:33 -06:00
Travis Ralston
8c414a9333
Counteract smooth scrolling on breadcrumbs
...
Smooth scrolling browsers (Firefox) use the relative area to determine how much scroll to apply. Because breadcrumbs are short vertically, the scroll amount is minimal (3 units) in the Y direction. On browsers which don't smooth scroll the units are usually much higher (100 in Chrome on Win 10). Users seem to expect the scrolling to be quicker due to the horizontal space on breadcrumbs, so we add a bit more power to their scroll when it looks small.
Fixes https://github.com/vector-im/riot-web/issues/9394
2019-06-02 23:59:02 -06:00
Travis Ralston
1c41629376
Merge pull request #3043 from matrix-org/travis/check-login-for-config
...
Accept JSX into the GenericErrorPage and expose local session vars
2019-05-31 11:03:41 -06:00
Travis Ralston
d81804e0fe
Merge branch 'develop' into matthew/low_bandwidth
2019-05-30 19:42:09 -06:00
Travis Ralston
5c85f4609e
Accept JSX into the GenericErrorPage and expose local session vars
2019-05-29 12:09:04 -06:00
Bruno Windels
4626581dbe
scroll event into view when starting to edit
2019-05-24 15:38:51 +02:00
Travis Ralston
14dc4b47fa
Merge branch 'develop' into travis/feature/wellknown2
2019-05-22 23:05:54 -06:00
Travis Ralston
f7ba8ffbd0
Translate scroll movement if the deltaX is the same as the threshold
...
Because the threshold is zero and the X movement is zero, we were not translating vertical movement to horizontal scrolling.
Fixes https://github.com/vector-im/riot-web/issues/9804
2019-05-22 10:19:38 -06:00
David Baker
03d092c574
Merge pull request #3010 from matrix-org/dbkr/uiauth_send_email
...
js-sdk interactive auth now sends email token
2019-05-22 14:24:14 +01:00
David Baker
90eb3ce9ec
js-sdk interactive auth now sends email token
...
We previously sent it in componentWillMount of the email token
auth component which definitely gets us on react's naughtly list.
We now pass the js-sdk a callback it can call at the appropriate
time to send the token (https://github.com/matrix-org/matrix-js-sdk/pull/926 ).
We should make password reset and adding email addresses work the
same way, but currently they don't even use the interactive-auth
helpers(!) so they're unaffected.
https://github.com/vector-im/riot-web/issues/9586
2019-05-22 11:51:26 +01:00
Bruno Windels
038cc45ee1
Merge pull request #3008 from matrix-org/matthew/fontmanager
...
load twemoji dynamically as colr or sbix; fix monospace
2019-05-22 09:36:15 +00:00
J. Ryan Stinnett
2648dbd221
Guard against null rooms in onEventDecrypted
...
Timeline sets may have a null room, such as with the notification timeline set.
Here we check that case when events are decrypted to avoid throw an error.
Fixes https://github.com/vector-im/riot-web/issues/9798
2019-05-22 10:08:16 +01:00
J. Ryan Stinnett
4b4d09266e
Merge pull request #3005 from matrix-org/jryans/notif-error
...
Only show reactions in main message timeline
2019-05-22 09:15:04 +01:00
Matthew Hodgson
4ae652e5c3
load twemoji dynamically as colr or sbix; fix monospace
2019-05-22 02:31:24 +01:00
Travis Ralston
c2c55e06e6
Add voice labels for quick add room buttons
...
See https://github.com/vector-im/riot-web/issues/9747
2019-05-21 12:16:34 -06:00
J. Ryan Stinnett
238e967470
Only show reactions in main message timeline
...
This fixes an error that crashed that notifications panel because it was trying
to read reactions, even though we currently don't aggregate them there. This
change is more explicit about exactly which views should try to show reactions.
Fixes https://github.com/vector-im/riot-web/issues/9713
2019-05-21 18:27:10 +01:00
Travis Ralston
907c7ed119
Merge pull request #2994 from matrix-org/travis/screenreader/topleftmenu
...
Update TopLeftMenu for accessibility: Keyboard shortcut, reduced screen reader noise
2019-05-21 09:52:26 -06:00
J. Ryan Stinnett
b4ca586431
Fix lint errors in NotificationPanel
2019-05-21 16:38:48 +01:00
Matthew Hodgson
30a485bddd
Merge pull request #2995 from matrix-org/matthew/twemoji
...
Replace emojione with twemoji + emojibase
2019-05-21 11:32:53 +01:00
Travis Ralston
aac87c4635
Move focusing to the context menu create call
2019-05-20 21:07:55 -06:00
Travis Ralston
52b0f285c6
Add some clarifying comments
2019-05-20 21:07:12 -06:00
Travis Ralston
7ecab35062
Add a null guard for serverConfig
...
This is often null while the component is on its first render, and is called during that render. It is eventually populated by React, and the function re-called - we just have to be patient.
2019-05-20 20:10:10 -06:00
Travis Ralston
595b490fd7
Don't act busy on the login page for moving your cursor
...
If you were in the username field and simply tabbed out without entering anything, the form would become "busy" and not let you submit. We should only be doing this if we have work to do, like .well-known discovery of the homeserver.
2019-05-20 20:10:10 -06:00
Travis Ralston
3476be3327
Merge branch 'develop' into travis/feature/wellknown2
2019-05-20 19:50:02 -06:00
Michael Telatynski
868c99d140
Hide WhoIsTyping component if the MessagePanel is shaped e.g file grid
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-05-20 21:53:15 +01:00
Matthew Hodgson
d3f06763b3
Merge branch 'develop' into matthew/twemoji
2019-05-20 16:38:44 +01:00
Bruno Windels
1368a5eb80
Merge pull request #2996 from matrix-org/bwindels/composerdesign
...
Message editing: apply design
2019-05-20 08:42:41 +00:00
Matthew Hodgson
c63419f8a2
typos
2019-05-19 16:31:25 +01:00
Matthew Hodgson
dc72641264
replace emojione with twemoji. completely untested & debugged & unoptimised
2019-05-19 15:23:43 +01:00
Travis Ralston
c5757d8303
Support CTRL+I for opening TopLeftMenu
2019-05-17 15:29:16 -06:00
J. Ryan Stinnett
45cdf880b1
Change setting style
2019-05-17 17:43:08 +01:00
J. Ryan Stinnett
3a405701a3
Debug: Show all events
2019-05-17 16:34:01 +01:00
Bruno Windels
9a3752c571
show message editor in textual body instead of replacing event tile
2019-05-17 15:30:07 +01:00
Travis Ralston
bc5227a191
Fix some source strings noticed as incorrect by translators
2019-05-16 14:35:56 -06:00
Travis Ralston
0c7aa39273
Merge branch 'develop' into travis/feature/wellknown2
2019-05-16 12:59:50 -06:00
Travis Ralston
1ea5b42cf5
Merge branch 'travis/feature/wellknown2' into travis/wk/mxid
2019-05-16 12:47:37 -06:00
Travis Ralston
f75dc9c804
Merge pull request #2971 from matrix-org/travis/wk/fallback_hs
...
Only expose the fallback_hs_url if the homeserver is the default homeserver
2019-05-16 12:46:52 -06:00
Travis Ralston
8c326bff9e
Merge pull request #2964 from matrix-org/travis/wk/simplify-phases
...
Refactor "Next" button into ServerConfig components
2019-05-16 12:46:35 -06:00
Bruno Windels
3ef631191b
show sending status for replacements as well on local echo
2019-05-16 14:44:00 +01:00
Bruno Windels
f7de8d4f58
use new events to find out about replacements
2019-05-16 14:43:32 +01:00
Travis Ralston
60a13652df
Merge pull request #2965 from matrix-org/travis/wk/tooltip
...
Render underlines and tooltips on custom server names in auth pages
2019-05-15 14:13:44 -06:00
Travis Ralston
6e3b06f364
Human de-linting
2019-05-15 13:56:15 -06:00
Bruno Windels
5805a88ab9
adjust to js-sdk changes of marking original event as replaced
2019-05-15 11:54:26 +01:00
Travis Ralston
9b5830bb08
Restore use of full mxid login
...
See https://github.com/vector-im/riot-web/issues/9290
2019-05-14 15:01:22 -06:00
Travis Ralston
34719b9a2e
Only expose the fallback_hs_url if the homeserver is the default HS
...
See https://github.com/vector-im/riot-web/issues/9290
2019-05-14 13:10:02 -06:00
Travis Ralston
4c1ac38dd4
Merge branch 'develop' into travis/feature/wellknown2
2019-05-14 10:53:01 -06:00
Bruno Windels
15df72e629
reload events when event gets replaced in the timeline
2019-05-14 15:39:24 +01:00
Bruno Windels
6599d605cd
wire up editor component (somewhat hacky)
2019-05-14 15:38:16 +01:00
David Baker
c11d26d809
Fix email registration, pt. 2
...
Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/2768
where we check for an existing stored account first and restore that
instead if it exist, telling the user. We usually make a guest account
when the user first hits the page though, so this just restored this
guest account.
Don't restore the account if it's just a guest account (which, as per
comment, is not perfect, but is definitely better than the current
behaviour).
Fixes https://github.com/vector-im/riot-web/issues/9581
2019-05-14 11:59:38 +01:00
David Baker
a0ecd89c94
Fix email registration: pt. 1
...
We look to see if there's already a user logged in and if there is,
restore that session instead of logging the user in as their new
account. We still set this 'is_registered' flag though, even though
in that case it's not a newly registered account that's being restored,
so don't set in that case.
2019-05-14 11:44:00 +01:00
Travis Ralston
e4576dac28
Render underlines and tooltips on custom server names in auth pages
...
See https://github.com/vector-im/riot-web/issues/9290
2019-05-13 17:16:40 -06:00
Travis Ralston
ee33a4e9ba
Refactor "Next" button into ServerConfig components
...
TODO still remains about making ModularServerConfig extend ServerConfig instead of duplicating everything.
See https://github.com/vector-im/riot-web/issues/9290
2019-05-13 16:30:34 -06:00
Travis Ralston
83737654ff
Merge branch 'develop' into travis/feature/wellknown2
2019-05-13 09:20:10 -06:00
Travis Ralston
6a941aca91
Merge pull request #2941 from matrix-org/travis/guests/block-ui
...
Use validated server config for login, registration, and password reset
2019-05-10 11:21:21 -06:00
J. Ryan Stinnett
8fdb59a909
Use basic read path from JS SDK for reactions
...
This displays existing reactions correctly in the action bar and reaction row,
but it doesn't yet update after a new reaction is sent.
2019-05-10 17:19:27 +01:00
J. Ryan Stinnett
74189b2164
Fix indentation in MessagePanel
2019-05-10 17:19:27 +01:00
J. Ryan Stinnett
3beb70814c
Fix indentation in TimelinePanel
2019-05-10 17:19:27 +01:00
Léo Mora
2342eb5426
Update 'Rooms' import
2019-05-09 16:17:54 +02:00
Travis Ralston
eab209a26b
Log in to the right homeserver when changing the homeserver
2019-05-06 12:00:48 -06:00
Travis Ralston
58b9eb4cb2
Add a serverConfig property to MatrixChat for unit tests
2019-05-03 16:25:54 -06:00
Travis Ralston
a4b6464902
Appease the linter
2019-05-03 11:34:30 -06:00
Travis Ralston
1f527e71b1
Bring server config juggling into MatrixChat
...
This way the server config is consistent across login, password reset, and registration. This also brings the code into a more generic place for all 3 duplicated efforts.
2019-05-03 11:34:30 -06:00
Travis Ralston
0b1a0c77b7
Make login pass around server config objects
...
Very similar to password resets and registration, the components pass around a server config for usage by other components. Login is a bit more complicated and needs a few more changes to pull the logic out to a more generic layer.
2019-05-03 11:33:36 -06:00
Travis Ralston
b6e027f5cb
Make password resets use server config objects
...
Like registration, the idea is that the object is passed around between components so they can take details they need.
2019-05-03 11:33:36 -06:00
Travis Ralston
00ebb5e1fd
Make registration work with server configs
...
The general idea is that we throw the object around between components so they can pull off the details they care about.
2019-05-03 11:33:36 -06:00
Travis Ralston
6b45e60314
Update ServerTypeSelector for registration to use a server config
2019-05-03 11:32:59 -06:00
Travis Ralston
35ad68751b
Remove unused skipServerDetails prop from registration
2019-05-03 11:13:36 -06:00
Travis Ralston
1620ccac53
Always default to the registration form
...
Fixes https://github.com/vector-im/riot-web/issues/8886
2019-05-02 23:55:40 -06:00
Travis Ralston
5a204edf90
Remove timeline explosion rageshake prompt
...
Concludes https://github.com/vector-im/riot-web/issues/8593
We are no longer seeing this error being triggered, and are considering it fixed. As a result, the dialog can be removed to reduce the amount of dead code in the project.
2019-05-01 13:37:57 -06:00
J. Ryan Stinnett
f4b783e802
Fix lint errors in TimelinePanel
2019-05-01 14:30:50 +01:00
J. Ryan Stinnett
a20d23daf3
Remove older password length check
...
Now that we have a fancier password complexity check, remove the older minimum
length to avoid the feeling of two password style guides fighting each other.
2019-04-25 14:29:10 +01:00
J. Ryan Stinnett
008ca3543b
Migrate passwords on registration to new validation
...
In addition to migrating password fields, this also removes the remaining
support for old-style validation in registration now that all checks have been
converted.
2019-04-25 14:29:10 +01:00
J. Ryan Stinnett
aaf745ae2a
Migrate phone number on registration to new validation
2019-04-25 14:29:09 +01:00
J. Ryan Stinnett
9064875312
Migrate email on registration to new validation
2019-04-25 14:29:09 +01:00
J. Ryan Stinnett
1cbb4be6f7
Add support for validating more strictly at submit time
...
When submitting a form, we want to validate more strictly to check for empty
values that might be required. A separate mode is used since we want to ignore
this issue when visiting a field one by one to enter data.
As an example, we convert the pre-existing logic for the username requirement
using this new support.
2019-04-25 14:29:09 +01:00
Bruno Windels
0fbe10a816
Merge pull request #2925 from matrix-org/bwindels/stylepreviewbar
...
Redesigned room preview bar
2019-04-18 08:50:56 +00:00
Bruno Windels
dd911d18cb
dont show right panel when previewing a room without invite, as its empty
2019-04-17 19:29:39 +02:00
Bruno Windels
190143ca6c
dispatch for user screen
2019-04-17 18:26:07 +02:00
Bruno Windels
d5cc835a93
PR feedback
2019-04-17 18:23:49 +02:00
Bruno Windels
22874f62ab
Merge branch 'develop' into bwindels/stylepreviewbar
2019-04-17 11:06:21 +02:00
Bruno Windels
86620839ae
make username clickable
2019-04-17 10:57:45 +02:00
J. Ryan Stinnett
adc23faf4b
Test defaultServerName
before showing it on forgot password
...
The Forgot Password screen wasn't checking the default server name for a value
before showing it, leading to a possible "Your Matrix account on <blank>"
message.
Fixes https://github.com/vector-im/riot-web/issues/9507
2019-04-17 09:35:45 +01:00
Travis Ralston
f6154bc7cd
Merge pull request #2921 from eyetime-international-ltd/hotfix/fix_static_title
...
use SdkConfig brand name instead of static "Riot"
2019-04-15 11:46:15 -06:00
Travis Ralston
26928a48e3
Merge pull request #2898 from matrix-org/travis/upgrades/permalinks
...
Use dedicated permalink creators in search results with multiple rooms
2019-04-15 11:27:58 -06:00
Bruno Windels
36951dd7b7
cleanup spinner props and use always preview bar when room operation is in progress
2019-04-15 18:49:00 +02:00
Bruno Windels
fd6c594a8f
put auth buttons in preview bar
2019-04-15 17:52:17 +02:00
Thomas Karner
e256dd6b05
use SdkConfig brand name instead of static "Riot"
...
Signed-off-by: Thomas Karner <thomas.karner@bytepoets.com>
2019-04-15 09:13:18 +02:00
Travis Ralston
9478ccc683
Add missing newline
2019-04-14 20:46:32 -06:00
Travis Ralston
0479901daa
Load data for permalink creators once
2019-04-12 10:38:39 -06:00
Travis Ralston
58ff5dc846
Merge pull request #2915 from matrix-org/travis/guests/block-ui
...
Add a generic error page element for startup errors
2019-04-12 10:21:20 -06:00
Bruno Windels
16ed06cebb
dont show room header and timeline when room cant be peeked (just preview bar)
2019-04-12 12:47:52 +02:00
Travis Ralston
9d55d0c897
Add strings for js-sdk autodiscovery errors
...
For https://github.com/matrix-org/matrix-js-sdk/pull/894
2019-04-11 15:54:37 -06:00
Travis Ralston
aadc1a8d75
Add a generic error page element for startup errors
...
Used by Riot to communicate configuration problems.
2019-04-11 15:52:37 -06:00
Travis Ralston
934ca6908f
Remove breadcrumb scroll tolerances and use sensible defaults
...
Fixes https://github.com/vector-im/riot-web/issues/9394
Fixes https://github.com/vector-im/riot-web/issues/9400
Numbers chosen based on user feedback. The setting has also been removed because it isn't really needed anymore.
2019-04-11 11:07:31 -06:00
Travis Ralston
ccf292f053
Load permalink creators to get proper state of the room
2019-04-11 10:59:00 -06:00
Bruno Windels
4e8b3c34c0
move room preview bar below timeline
2019-04-10 17:49:45 +02:00
Bruno Windels
6ca1a879c9
remove hacks, now that emitting show_right_panel is centralized
2019-04-10 13:22:31 +02:00
J. Ryan Stinnett
687b43f7b4
Merge pull request #2903 from jryans/rm-bottom-left-menu
...
Remove BottomLeftMenu and supporting bits
2019-04-09 19:09:07 +01:00
Travis Ralston
e4a9d4f5c8
Cache permalink creators out of the component's state
2019-04-09 12:01:09 -06:00
J. Ryan Stinnett
12f7d1715b
Remove BottomLeftMenu and supporting bits
...
The `BottomLeftMenu` component is not used in the new design. This removes the
component and also any images and sub-components that were only used by it.
2019-04-09 17:38:32 +01:00
Travis Ralston
44e33ba5f1
Merge pull request #2892 from matrix-org/travis/breadcrumbs/scrolling
...
Add some tolerances to breadcrumb scrolling
2019-04-09 09:41:07 -06:00
Travis Ralston
12a9416741
Merge pull request #2895 from matrix-org/travis/return-client
...
Always return a client from onRegistered
2019-04-09 09:06:33 -06:00
David Baker
babed3e5ee
Merge pull request #2891 from matrix-org/dbkr/simplify_settings_dialog_css
...
Simplify settings dialog CSS
2019-04-09 09:21:21 +01:00
Travis Ralston
c49afe4d72
Use dedicated permalink creators in search results with multiple rooms
...
Fixes https://github.com/vector-im/riot-web/issues/9376
This also would have happened in "All Rooms" searches.
2019-04-08 16:23:00 -06:00
Travis Ralston
7407950c75
Always return a client from onRegistered
...
Fixes https://github.com/vector-im/riot-web/issues/9406
The return value of onRegistered eventually ends up in the pusher setup, which means we were passing undefined through the stack.
2019-04-08 12:49:14 -06:00
David Baker
a04c15d131
consistent comments
2019-04-08 19:10:20 +01:00
Travis Ralston
aa96fd27cc
Add some tolerances to breadcrumb scrolling
...
See https://github.com/vector-im/riot-web/issues/9400
See https://github.com/vector-im/riot-web/issues/9394
Tolerances are defined as a device-only setting to give advanced users an option to override the values. No UI is exposed for this.
The default values are picked for assumptions on comfort, however as people change the tolerances themselves the defaults may need to change.
2019-04-08 10:56:44 -06:00
David Baker
59210564b7
Fix upload cancel in e2e rooms
...
This is a bit of a mess of passing promises around - we weren't
taking the right promise to pass to cancelUpload.
Also e2e uploads take time to read into memory & encrypt, so allow
cancelling them during those phases too, even though we can't abort
those phases before they're done - we do mark the upload as cancelled
though so filter the current uploads for cancelled ones.
Fixes https://github.com/vector-im/riot-web/issues/4891
2019-04-08 17:53:39 +01:00
David Baker
670f6e4f99
Simplify settings dialog CSS
...
Stop the settings dialogs from requiring special styles on the
mx_Dialog which required passing in a classname from anywhere the
settings dialogs were opened (although this still requires
static=true). Some of the things have now been adopted for all dialogs
(border-radius), others have been moved to within the dialog content.
2019-04-08 16:48:42 +01:00
J. Ryan Stinnett
20c31082b5
Set E2E room status to warning when crypto is disabled
...
When crypto is disabled for the current device, we can't tell whether there are
unverified devices since we aren't tracking devices at all.
Let's be safe and default to the warning state.
See also https://github.com/matrix-org/matrix-js-sdk/pull/889
2019-04-08 16:28:19 +01:00
Travis Ralston
650185e578
Remove 'try the app' link from login
...
Fixes https://github.com/vector-im/riot-web/issues/8384
This will be re-addressed in https://github.com/vector-im/riot-web/issues/9388 or similar. Because the implementation is undefined, the dead code is being removed instead of just left dead.
2019-04-05 10:35:11 -06:00
Travis Ralston
6a8b98eb71
Merge pull request #2877 from matrix-org/travis/breadcrumbs/scroll-left
...
Translate vertical scrolling to horizontal movement in breadcrumbs
2019-04-05 09:51:13 -06:00
Travis Ralston
17a57eb3e5
Bind the onWheel listener directly to props
...
React doesn't seem to care if this is null/undefined.
2019-04-05 09:43:29 -06:00
Travis Ralston
1c41c3dd63
Only update analytics when there's a change
...
Also, the arguments are the previous state, not the new state.
2019-04-05 09:40:21 -06:00
Travis Ralston
e2edae3383
Merge branch 'develop' into travis/breadcrumbs/telemetry
2019-04-05 09:35:38 -06:00
David Baker
41c403c9a6
Merge pull request #2879 from matrix-org/dbkr/file_upload_fallout
...
Fix a few bugs introduced in file upload rework
2019-04-05 15:48:45 +01:00
David Baker
c8ba7d3434
Fix a few bugs introduced in file upload rework
...
* Fix the widget picture_snapshot command (not that I can find
anything that uses it)
* Remove unused prop
* Fix plural on ContentMessages
2019-04-05 15:09:07 +01:00
Travis Ralston
04b521c48b
Scroll breadcrumbs to the left when they change
...
Fixes https://github.com/vector-im/riot-web/issues/9355
2019-04-04 17:03:06 -06:00
Travis Ralston
138fd4ec87
Translate vertical scrolling to horizontal movement in breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/9314
2019-04-04 16:43:04 -06:00
Travis Ralston
035f6b14c0
Add telemetry for how many people use breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/9207
2019-04-04 14:17:15 -06:00
Travis Ralston
2496ee3b66
Merge branch 'travis/breadcrumbs/livereload' into travis/breadcrumbs/telemetry
2019-04-04 13:55:22 -06:00
Travis Ralston
5066d68875
Merge pull request #2861 from matrix-org/travis/breadcrumbs/badges
...
Add badges to breadcrumb rooms
2019-04-04 08:24:41 -06:00
J. Ryan Stinnett
fea9b009b3
Track life buoy dialog
2019-04-04 11:28:13 +01:00
Travis Ralston
f5600fd4d7
Add badges to breadcrumb rooms
...
Fixes https://github.com/vector-im/riot-web/issues/8606
2019-04-03 15:29:15 -06:00
Bruno Windels
a11786884e
Merge pull request #2865 from matrix-org/bwindels/smallscrollfixes
...
Small scroll fixes
2019-04-03 07:29:13 +00:00
Bruno Windels
fee8d79267
comment for PAGE_SIZE
2019-04-03 09:16:30 +02:00
Travis Ralston
8225b91179
Merge pull request #2863 from matrix-org/travis/stickerpicker/lower-z
...
Put the stickerpicker below dialogs
2019-04-02 10:23:17 -06:00
Bruno Windels
86c13b97ce
increase PAGE_SIZE so users can scroll up already while waiting for pag.
2019-04-02 17:54:14 +02:00
Bruno Windels
726e91101a
allow fractional values for scrollTop above and below expected value
2019-04-02 17:53:53 +02:00
David Baker
b6faaf419c
PR feedback
2019-04-02 10:50:17 +01:00
Travis Ralston
3f9d088667
Put the stickerpicker below dialogs
...
Fixes https://github.com/vector-im/riot-web/issues/9353
The ContextualMenu now accepts a zIndex parameter which can be used to control its level. Dialogs are at around 4000 in the z-index, and the context menu defaults to 5000 for the things that need tooltips and such in a dialog.
2019-04-01 20:34:33 -06:00
Travis Ralston
842e19280d
Apply changes to breadcrumbs setting live
2019-04-01 11:49:58 -06:00
David Baker
5b2cee2fc1
Implement redesigned upload confirmation screens
...
Also fairly significant refactor of the uploading code: there are
a number of different ways of triggerring a file upload and each
went through a different code path (the media config size limit
worked on one of those paths). Basically take a lot of code out
of the views and put it into ContentMessages.
Sorry about the size of this patch.
https://github.com/vector-im/riot-web/issues/7565
2019-04-01 16:42:41 +01:00
Travis Ralston
86e4d29582
Merge remote-tracking branch 'origin/develop' into travis/cancel-3pid
2019-03-29 11:47:46 -06:00
Bruno Windels
e7852ad1b4
Merge pull request #2846 from matrix-org/bwindels/atbottomfix
...
round scrollTop upwards to prevent never detecting bottom
2019-03-29 15:57:24 +00:00
Bruno Windels
8e4a06db77
round scrollTop upwards to prevent never detecting bottom
2019-03-29 16:41:10 +01:00
J. Ryan Stinnett
6e79cbc092
Delay Notifier
check until we have push rules
...
The `Notifier` class expects push rules to be available, so it can explode in
strange ways if called too early. This changes to wait until the sync is in the
`PREPARED` state (when push rules should be ready) before using the `Notifier`.
Fixes https://github.com/vector-im/riot-web/issues/9323
2019-03-29 15:19:39 +00:00
Bruno Windels
a326c83016
Merge pull request #2842 from matrix-org/bwindels/bacat-scrolling-merged-develop
...
BACAT Scrolling
2019-03-29 14:02:15 +00:00
Bruno Windels
f157838864
dispatch supports async dispatching on its own
2019-03-29 14:32:26 +01:00
Travis Ralston
99dc2c4738
Add MemberInfo for 3pid invites and support revoking those invites
...
Fixes https://github.com/vector-im/riot-web/issues/625
Fixes https://github.com/vector-im/riot-web/issues/6411
Fixes https://github.com/vector-im/riot-web/issues/5490
2019-03-28 21:02:24 -06:00
Bruno Windels
1a264006f7
turn off debug logging
2019-03-28 18:42:49 +01:00
Travis Ralston
6eb8368aa7
Merge pull request #2827 from matrix-org/travis/v3-room-permalink
...
Handle all the segments of a v3 event ID
2019-03-28 11:38:47 -06:00
Travis Ralston
acb33e1aa0
Merge pull request #2839 from matrix-org/travis/breadcrumbs/visual
...
Add custom tooltips and scrolling to breadcrumbs
2019-03-28 11:29:48 -06:00
Travis Ralston
a0e3182e47
Merge pull request #2829 from matrix-org/travis/unread-button
...
Check if the message panel is at the end of the timeline on init
2019-03-28 11:26:48 -06:00
Bruno Windels
41c5582a7b
make resizeNotifier optional so tests don't fail
2019-03-28 17:56:12 +01:00
Travis Ralston
87ca3069bb
Misc code cleanup
2019-03-28 10:43:01 -06:00
Travis Ralston
6a840a56d6
Add a comment to explain the state of affairs for refs.messagePanel
2019-03-28 09:50:17 -06:00
Travis Ralston
9b64dd0cd7
Support horizontal scrolling on breadcrumbs
...
Fixes https://github.com/vector-im/riot-web/issues/8714
Fixes https://github.com/vector-im/riot-web/issues/8890
Fixes https://github.com/vector-im/riot-web/issues/9034
Fixes https://github.com/vector-im/riot-web/issues/8954
This turned out to be much more complicated than it needed to be. We use an IndicatorScrollbar to do all the math for us and some minor changes have been made so it can flag left/right overflow. The complicated part is the css changes which make the gradients work: unlike the RoomSubList, we have to calculate the offset of the indicators (gradients) on our own because position:sticky doesn't work horizontally.
The changes to the css (well, mostly pointer-events:none) make it so the gradient doesn't interfere with the room avatars.
9034 and 8954 are fixed by this because they represent an overflow-x:none style breakage where browsers won't let you scroll without a scrollbar. The gradient offset problem is also demonstrated in 8954.
2019-03-27 17:52:05 -06:00
Travis Ralston
64a6b47692
Merge pull request #2831 from matrix-org/travis/hidden-bing
...
Alert the user to unread notifications in prior versions of rooms
2019-03-27 13:23:57 -06:00
Travis Ralston
c94ae6401b
Use an AccessibleButton for the clickable element
2019-03-27 13:14:31 -06:00
Bruno Windels
82e44249ff
make resizeNotifier optional in MainSplit for GroupView
2019-03-27 16:38:17 +01:00
J. Ryan Stinnett
055f833042
Change loading errors in room directory to inline instead of modal
...
This changes errors that may occur when loading the room directory so that the
message appears inline with the overall directory UI instead of in a new modal.
This is important so that the new room button remains on screen even if the
directory is down.
Fixes https://github.com/vector-im/riot-web/issues/9046
2019-03-27 14:57:41 +00:00
J. Ryan Stinnett
0466e0a306
Reorganise room directory code so new room is always available
...
This reorganises the room directory so that the new room buttons is always
available no matter what state the overall directory is in.
Part of https://github.com/vector-im/riot-web/issues/9046
2019-03-27 14:17:24 +00:00
J. Ryan Stinnett
8d27cfde36
Remove unused import
2019-03-27 13:57:48 +00:00
Bruno Windels
adf263c4af
Merge branch 'develop' into bwindels/bacat-scrolling-merged-develop
2019-03-27 11:46:28 +01:00
Bruno Windels
5d53913e35
fix filling conditions
2019-03-27 11:35:38 +01:00
Travis Ralston
04a9038a05
Alert the user to unread notifications in prior versions of rooms
...
Fixes https://github.com/vector-im/riot-web/issues/8161
2019-03-26 19:22:41 -06:00
Travis Ralston
4eb9fa6922
Check if the message panel is at the end of the timeline on init
...
Fixes https://github.com/vector-im/riot-web/issues/8503
componentDidUpdate is called a lot, and we don't really want to keep checking the messagePanel, so this introduces a new flag to check if the init is even needed.
2019-03-26 14:22:48 -06:00
Bruno Windels
f2f3661b7e
more debug logging
2019-03-26 17:40:24 +01:00
Bruno Windels
46f5f872c4
implement scrolling to a token (best effort)
2019-03-26 15:51:02 +01:00
Bruno Windels
805539fdc7
remove timestamp logging in profiler
2019-03-26 13:44:39 +01:00
Bruno Windels
82a9b348c0
add some comments and initialization for async filling
2019-03-26 13:39:18 +01:00
Bruno Windels
18b5041ed2
try filling async instead of sync in scroll handler
...
see if that avoids jumps
2019-03-26 12:19:30 +01:00
Travis Ralston
d8edf2e3fb
Handle all the segments of a v3 event ID
...
They may contain slashes, so it is not suitable to just pull the first segment after the room ID. Instead, we just recompile the event ID from known source, assuming everything afterwards is an event ID.
Fixes https://github.com/vector-im/riot-web/issues/8315
This will need adapting to support https://github.com/vector-im/riot-web/issues/9149
2019-03-25 23:02:49 -06:00
Travis Ralston
79ea873717
Merge pull request #2820 from matrix-org/travis/timeline-explosion-workaround
...
Ask the user for debug logs when the timeline explodes
2019-03-25 12:09:16 -06:00
Bruno Windels
8f7170a4a1
add timeline profiling markers when updateheight and onscroll run
2019-03-25 12:47:08 +01:00
Travis Ralston
e5f7563dec
Ask the user for debug logs when the timeline explodes
...
Fixes https://github.com/vector-im/riot-web/issues/9260
Workaround for https://github.com/vector-im/riot-web/issues/8593
Requires https://github.com/matrix-org/matrix-js-sdk/pull/869
We check if any dialogs are open before moving forward because we don't want to risk showing so many dialogs that the user is unable to click a button. We're also not overly concerned if the dialog being shown is irrelevant because whatever the user is doing will likely be unaffected, and we can scream in pain when they're finished.
2019-03-22 20:23:35 -06:00
Travis Ralston
389abed574
Define a title for generic error
2019-03-22 19:03:52 -06:00
Travis Ralston
4fd48988e9
Check for any errors leaving the room, not just the top level
2019-03-22 17:39:42 -06:00
Travis Ralston
a34a8bb425
Use leaveRoomChain when leaving a room
...
Requires https://github.com/matrix-org/matrix-js-sdk/pull/868
Fixes https://github.com/vector-im/riot-web/issues/8539
We don't need to use leaveRoomChain when rejecting invites because we won't have the references needed. This leaves the couple spots where we do actually leave a room, and use the new function for that.
2019-03-22 17:36:54 -06:00
Bruno Windels
c9c2519240
log scroll events
2019-03-22 15:47:04 +01:00
Bruno Windels
4bfdbe3094
fix jumping when unfilling the top while scrolling down
2019-03-22 15:23:21 +01:00
Bruno Windels
ab49bc4fcf
fix comment typo
2019-03-21 15:37:35 +01:00
Bruno Windels
680afc5ce0
fix scrollToToken alignment
2019-03-21 15:37:06 +01:00
Bruno Windels
494779393f
Merge branch 'develop' into bwindels/bacat-scrolling
2019-03-21 13:50:32 +01:00
Bruno Windels
44f3cac5eb
Merge branch 'master' into develop
2019-03-21 11:28:35 +01:00
Bruno Windels
817fe1a520
disable typing notifs jumping prevention for now
2019-03-21 11:01:47 +01:00
Bruno Windels
3e13a11372
restore scroll position after hiding typing notifs with checkScroll
2019-03-20 17:38:05 +01:00
Bruno Windels
85d305430f
no need for forceUpdate here
2019-03-20 17:37:34 +01:00
Bruno Windels
02a5aa3b1f
more logging cleanup
2019-03-20 17:15:43 +01:00
Bruno Windels
9da13fe430
small cleanup
2019-03-20 17:13:09 +01:00
Bruno Windels
a8b149cfbb
cleanup scrollpanel logging
2019-03-20 17:12:49 +01:00
Bruno Windels
460f9a5959
comment typo
2019-03-20 17:10:38 +01:00
Bruno Windels
f164a78eaa
reimplement typing notif timeline shrinking prevention
...
instead of setting a min-height on the whole timeline,
track how much height we need to add to prevent shrinking
and set paddingBottom on the container element of the timeline.
2019-03-20 17:10:30 +01:00
David Baker
1a8fe4dd43
Go back to using mainine velocity
...
We moved off to our own fork of velocity many moons ago to fix
a memory leak bug when velocity was being barely maintained. They
have now merged the bugfix, so go back to mainline.
2019-03-20 10:54:06 +00:00
Bruno Windels
1e372aad47
only log when node was found
2019-03-20 11:10:04 +01:00
Bruno Windels
c306181fcd
take into account that node might not be in DOM while updating height
2019-03-20 11:00:27 +01:00
Bruno Windels
88f039fe44
keep track of current updateHeight request outside of method
...
it's only called from one place
2019-03-20 10:59:55 +01:00
Bruno Windels
2bcced72ad
take (potentially clipped) content height into account for filling
2019-03-19 16:51:39 +01:00
Bruno Windels
469511aa44
correctly calculate last node in viewport
...
these variables are now relative to bottom of timeline,
before it was the top
2019-03-19 16:50:55 +01:00
Bruno Windels
71f6b08b26
first impl of new scrolling, still a bit broken
2019-03-19 13:42:22 +01:00
Bruno Windels
d84003ac44
dont break room directory and search
2019-03-18 14:05:56 +01:00
David Baker
591a968368
Update CustomRoomTagPanel.js
2019-03-16 12:37:34 +00:00
Travis Ralston
6ad2bb515f
Merge branch 'develop' into travis/browser-support-docs
2019-03-15 11:44:46 -06:00
Travis Ralston
e70ac5330e
Improve links to firefox and safari
2019-03-15 11:39:10 -06:00
Bruno Windels
bab2730d40
use ResizeNotifier as well to relayout room list
2019-03-15 10:16:21 +01:00
Bruno Windels
4795625cee
emit resize event when banners are shown/hidden to restore scroll pos
2019-03-15 10:16:21 +01:00
Bruno Windels
1bdbf3086f
emit timeline_resize in MatrixChat based on ResizeNotifier
...
as it's used in PersistentElement which could be used at various places
2019-03-15 10:16:21 +01:00
Bruno Windels
891e343df6
create ResizeNotifier to derive which areas of the app resize and emit
2019-03-15 10:16:21 +01:00
Bruno Windels
f71a9f10dd
remove onChildResize in RoomView as it's unused
2019-03-15 10:16:21 +01:00
Bruno Windels
30d848b86e
use AutoHideScrollbar in ScrollPanel
2019-03-15 10:16:21 +01:00
David Baker
346919ed57
Fix the custom tag panel
...
https://github.com/matrix-org/matrix-react-sdk/pull/2780 renamed
RoomTooltip (to Tooltip) but missed the references in the custom
tag panel.
2019-03-15 09:02:24 +00:00
Travis Ralston
278b2ab633
Update CompatibilityPage to match officially supported browsers
...
See https://github.com/vector-im/riot-web/pull/9177
2019-03-14 13:03:32 -06:00
Travis Ralston
5409db418c
Merge pull request #2786 from matrix-org/travis/you-are-not-alone
...
Ensure freshly invited members don't count towards the alone warning
2019-03-14 13:00:31 -06:00
Travis Ralston
a551bf4a46
Only use exactly as many newlines as we need
2019-03-14 12:44:14 -06:00
Travis Ralston
f2421d9af4
Merge pull request #2787 from matrix-org/travis/forgot-password-e2e
...
Fix 'forgot password' warning to represent the reality of e2ee
2019-03-14 08:40:22 -06:00
J. Ryan Stinnett
45063cad4a
Merge pull request #2780 from jryans/auth-validation
...
Initial portions of support for Field validation
2019-03-14 10:19:21 +00:00
Travis Ralston
3d2b0f861c
Clean up unused imports
...
For the almighty linter
2019-03-13 15:33:14 -06:00