Commit graph

27246 commits

Author SHA1 Message Date
Bruno Windels
71a9fef491 fix InviteDialog crash 2020-08-03 17:42:54 +02:00
J. Ryan Stinnett
76293970f4
Merge pull request #5070 from matrix-org/travis/room-list/regressions
Fix various small regressions in the room list's behaviour
2020-07-31 11:46:30 +01:00
J. Ryan Stinnett
0404c7d9ae
Merge pull request #5059 from matrix-org/jryans/cleanup-lint-deps
Remove redundant lint dependencies
2020-07-31 11:42:29 +01:00
David Baker
d1bf333cce
Merge pull request #5069 from matrix-org/dbkr/fix_soft_logout_warning
Fix key backup warning on soft logout page
2020-07-30 22:46:28 +01:00
Travis Ralston
409f65de7b
Merge pull request #5066 from matrix-org/dependabot/npm_and_yarn/elliptic-6.5.3
Bump elliptic from 6.5.2 to 6.5.3
2020-07-30 15:21:05 -06:00
Travis Ralston
49abfc1fb2 Ensure sublists are updated when rooms are removed from them
Fixes https://github.com/vector-im/riot-web/issues/14798 (part 2)

This is in two parts itself: The `RoomSublist` needs to break its references to the `RoomListStore`, so it now clones the room arrays. The `Algorithm` is the other part, which is slightly more complicated.

It turns out that we weren't handling splicing as a change in the `ImportanceAlgorithm`, therefore the `Algorithm` wasn't really feeling like it needed to change anything. Further, the `Algorithm` was using the wrong reference to where it should be dumping rooms (`this.cachedRooms` is a getter which returns a different object depending on conditions), so having fixed that we need to ensure that the filtered and sticky maps are also updated when we remove a room. Because we send the new tag through a Timeline update, we'll end up updating the tag later on and don't need to update the filter and sticky collections.
2020-07-30 15:06:04 -06:00
Travis Ralston
da05cac1b6 Listen for our own membership changes on notification states
Fixes https://github.com/vector-im/riot-web/issues/14798 (part 1)

When we transition from invite to not-invite we need to ensure we clear the invite notification state.
2020-07-30 14:33:38 -06:00
Travis Ralston
5b15d12865 Ensure list visibility changes get counted as list changes
Fixes https://github.com/vector-im/riot-web/issues/14799

We were checking to see if the tags were visible at render time, but we needed to ensure that they were(n't) included when checking for diffs. This introduces a new kind of object cloning for semantic reasons.

This also fixes the selection indicator being a bit off on custom tags.
2020-07-30 14:18:54 -06:00
Travis Ralston
e953bfbf88 Replace flawed objectHasValueChange usage with objectHasDiff
Fixes https://github.com/vector-im/riot-web/issues/14782

We need to check if the keys changed, not just the values.
2020-07-30 14:08:18 -06:00
David Baker
e810a31fe3
Merge pull request #5068 from matrix-org/dbkr/fix_soft_logout_crash
Fix crash on logging in again after soft logout
2020-07-30 20:02:42 +01:00
David Baker
aaf0c7d269 Put back code
with comment hopefully explaining why it's necessary
2020-07-30 19:46:27 +01:00
David Baker
f3320f5041 Fix key backup warning on soft logout page
It always showed the warning (if you had at least one session key
in your store) because flagAllGroupSessionsForBackup returns the
number of keys pending backup after flagging them all for backup,
ie. all of them. Seems like the intention was to only show the
warning if there were keys that had not yet been backed up.

Fixes https://github.com/vector-im/riot-web/issues/14829
Requires https://github.com/matrix-org/matrix-js-sdk/pull/1429
2020-07-30 19:09:47 +01:00
David Baker
9d247321f5 Fix crash on logging in again after soft logout
Fixes https://github.com/vector-im/riot-web/issues/14834
2020-07-30 18:52:47 +01:00
dependabot[bot]
8610760288
Bump elliptic from 6.5.2 to 6.5.3
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>
2020-07-30 12:52:17 +00:00
Jorik Schellekens
b1f8fe40d6
Merge pull request #5036 from swapnilraj/swapnilraj/right-panel-ts
Convert right_panel to TS
2020-07-30 13:37:01 +01:00
Swapnil Raj
1b4b594f92 Change public to protected for onAction 2020-07-30 16:13:13 +05:30
Swapnil Raj
d0e2695114 Add access specifier to class methods 2020-07-30 15:58:07 +05:30
J. Ryan Stinnett
52a1bbd8b3
Merge pull request #5063 from matrix-org/jryans/adjust-chevrons
Remove all unreferenced images
2020-07-30 10:31:13 +01:00
Bruno Windels
0526fcdf44
Merge pull request #5061 from matrix-org/bwindels/noknownserverserror
Provide nicer error for no known servers error when accepting an invite
2020-07-30 08:53:43 +00:00
Bruno Windels
a281c617be string order changed 2020-07-30 10:42:46 +02:00
Bruno Windels
bb685cd37a change message priority 2020-07-30 10:33:36 +02:00
Swapnil Raj
fbc341a2f5 Clean up types properly 2020-07-30 11:51:10 +05:30
Swapnil Raj
9aa128a6e8 Revert "Cleanup types"
This reverts commit 97cef335e8.
2020-07-30 11:45:49 +05:30
Swapnil Raj
97cef335e8 Cleanup types 2020-07-30 11:27:53 +05:30
Swapnil Raj
b8e51076a8 Fix private functions for RoomHeaderButtons 2020-07-29 23:58:32 +05:30
J. Ryan Stinnett
2f20cbd5ad Remove all unreferenced images
This removes all images we no longer reference in the app. This should be safe,
as Webpack only adds images to the build output if they are referenced.
2020-07-29 17:52:41 +01:00
Hubert Chathi
6a9fe35fa8
Merge pull request #5057 from matrix-org/uhoreg/keytar_logging
add logging for keytar/pickle key
2020-07-29 12:08:30 -04:00
Bruno Windels
d8baad31da provide nicer error for no known servers error when accepting an invite 2020-07-29 16:51:37 +02:00
Swapnil Raj
8120a26135 A bit more cleanup 2020-07-29 17:35:55 +05:30
Swapnil Raj
aa160095fa Cleanup 2020-07-29 17:26:51 +05:30
Swapnil Raj
bf450ad075 Fix the type for SetRightPanelPhasePayload
Fix uses of it as well
2020-07-29 16:59:29 +05:30
J. Ryan Stinnett
50bc7fc62f Remove redundant lint dependencies
These are no longer needed with the new standard lint repo.
2020-07-29 12:00:42 +01:00
Hubert Chathi
0cf10bb69a Merge branch 'develop' into uhoreg/keytar_logging 2020-07-28 17:45:39 -04:00
Hubert Chathi
fbea8c61bb add logging for keytar/pickle key
and remember when we had key, so that we know that we should expect one
2020-07-28 17:31:27 -04:00
J. Ryan Stinnett
79348b44cb
Merge pull request #4075 from MarcoZehe/SuppressSpeechWhenSending
Don't speak the outgoing message if it is in the Sending state.
2020-07-28 16:24:28 +01:00
Michael Telatynski
2d918a6dfc
Merge pull request #5052 from matrix-org/t3chguy/fix/14501
Remove poorly contrasted "dark style" heading in Room Preview Bar
2020-07-28 16:13:43 +01:00
Michael Telatynski
05332124ee
Merge pull request #5050 from matrix-org/t3chguy/fix/14774
Fix Query Matcher regression with certain unhomoglyph'd characters
2020-07-28 16:13:03 +01:00
Jorik Schellekens
4f55ef685d
Merge pull request #4989 from matrix-org/joriks/resize-handlebars-2.0
Fix handlebar interaction
2020-07-28 14:30:00 +01:00
Travis Ralston
3561de3f8a
Merge pull request #5054 from matrix-org/travis/perf6
Minor improvements to filtering performance
2020-07-28 06:37:27 -06:00
Travis Ralston
1573c88b47
Update src/utils/arrays.ts
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-28 06:37:19 -06:00
Michael Telatynski
0ee30a07a8
Merge pull request #5055 from matrix-org/t3chguy/fix/14700
Fix TextWithTooltip "leaking" tooltip wrappers
2020-07-28 10:40:52 +01:00
Michael Telatynski
e7ec34e61e Fix TextWithTooltip "leaking" tooltip wrappers
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-07-28 10:13:13 +01:00
Travis Ralston
2a8881f753 Fix typing error 2020-07-27 17:41:23 -06:00
Travis Ralston
900c234434 Internalize notification state handling for lists
This reduces the update cost of rooms changing, and fixes a bug where when a sublist became filtered it would change the notification count of the sublist.

This does change the expected usage of the state store to ensuring that only one place updates the rooms on the list states, which is currently the room list store. Ideally the state store could listen to the room list store to update itself, however due to a complicated require() loop it is not possible.
2020-07-27 17:33:27 -06:00
Travis Ralston
b91026fa89 Ensure CustomRoomTagStore doesn't fire useless updates
This could in theory cause double rendering of the room list under some conditions.
2020-07-27 17:18:01 -06:00
Travis Ralston
5f034ee4ed Ensure arrayHasDiff returns a boolean
This is just maintenance noticed while debugging.
2020-07-27 17:17:27 -06:00
Travis Ralston
51592ccfb6 Remove watch notifications from SettingsStore
It slows things down a bit, and in practice is more unlikely to be a problem than a savior.
2020-07-27 17:17:08 -06:00
Travis Ralston
a15aae4daf Apply a throttle to filter condition updates 2020-07-27 16:35:48 -06:00
Travis Ralston
517c93a7d5 Move expand-on-filter into the sublist
It's a bit more complicated this way, but helps reduce some of the latency involved in remounting the entire room list.
2020-07-27 16:35:48 -06:00
Travis Ralston
c6033b9410 Move search out of RoomList and LeftPanel, into RoomSearch
This prevents the entire left panel from having to re-mount whenever the search query changes.
2020-07-27 16:35:48 -06:00