Commit graph

42757 commits

Author SHA1 Message Date
Will Hunt
4faacdaec0
Allow integration managers to validate user identity after opening (#8782)
* Add getOpenIdToken function

* tidy up

* tidy up

* log an error

Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-06-16 17:19:04 -06:00
Suguru Hirahara
43f2ee4283
Fix reactions row overflow and gap between reactions (#8813) 2022-06-16 17:47:37 +00:00
Suguru Hirahara
3b28b1100f
Include mx_MessageActionBar_maskButton in mx_MessageActionBar (#8792)
* Include mx_MessageActionBar_maskButton in mx_MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-16 14:34:56 +01:00
Suguru Hirahara
fe8c267a14
Create a common header on right panel cards on BaseCard (#8808)
* Remove duplicate declarations and add height and overflow properties

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move mx_TimelineCard__header under mx_BaseCard_header for normalization

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Normalize mx_BaseCard_close position

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Normalize className of header

- mx_BaseCard_header__ThreadPanel
- mx_BaseCard_header__TimelineCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Normalize header's button size

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Normalize inline start header margin

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* normalize header bottom margin for PinnedMessagesCard and TimelineCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Normalize header declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add mixin RightPanelCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move common declarations - top level

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move common declarations - mx_BaseCard_header

Remove specific declarations on PinnedMessagesCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move common declarations - mx_BaseCard_back and mx_BaseCard_close

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Create a common class name - mx_BaseCard_header_title

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Create a common class name - mx_BaseCard_header_title - ThreadPanel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move common declarations - mx_BaseCard_header_title

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move common declarations - span:first-of-type

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Rename a variable to remove --ThreadPanel_header-button-size

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove class name - mx_BaseCard_header_title

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove mx_BaseCard_header_title--ThreadPanel and h2 declarations from PinnedMessagesCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Headers need Heading

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move common style rules of mx_ContextualMenu inside mx_BaseCard_header_title to BaseCard

leaving style rules specific to ThreadPanel.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Hide long header title with ellipsis

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules - BaseCard_header-button-size

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules - BaseCard_header margin-bottom

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules - BaseCard back and close margin

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules - BaseCard back ~ mx_BaseCard_header_title

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules - mx_BaseCard_header_title

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Return special declarations to _ThreadPanel.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove the mixin

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add mx_BaseCard_header_title_button--option

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant margin from AppTileFullWidth

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Header on mx_RoomSummaryCard - remove default declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove default declarations from mx_UserInfo

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables - _BaseCard.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-16 09:22:45 +02:00
Suguru Hirahara
81c894f2d9
Stop using mx_GroupLayout for styling (#8711) 2022-06-15 17:26:24 +00:00
Janne Mareike Koschinski
f9100d5fb6
Fix issues with the Create new room button in Spotlight (#8851)
* Correct label of create new room button
* Capitalize suggested name for new room
2022-06-15 16:16:40 +00:00
Suguru Hirahara
1188f1a508
Remove margin from E2E icon between avatar and hidden event (#8584)
* Remove margin from warning E2E icon between an avatar and a hidden event

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a variable to ensure the same spacing around the E2E icon

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply the style to E2E icon

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Rename variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-15 09:50:35 -06:00
Suguru Hirahara
1b426ce0c8
Organize style rules of AccessSecretStorageDialog to avoid visual bugs (#8395)
* .mx_AccessSecretStorageDialog

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* .mx_AccessSecretStorageDialog_primaryContainer

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* .mx_AccessSecretStorageDialog_titleWithIcon

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Adopt BEM style

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-15 09:47:25 -06:00
Suguru Hirahara
78ba5e35a3
Fix waveform on a message bubble (#8852)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-15 15:37:08 +00:00
Michael Weimann
aac97e01e3
Reload map on reconnect (#8848)
PSD-282
2022-06-15 16:38:35 +02:00
Janne Mareike Koschinski
9333e609b0
Update the avatar mask so it doesn’t cut off spaces’ avatars anymore (#8849)
* Update the avatar mask so it doesn’t cut off spaces’ avatars anymore
* Remove unused mask
* Remove unused class
2022-06-15 14:32:25 +00:00
Janne Mareike Koschinski
5096e7b992
Integrate searching public rooms and people into the new search experience (#8707)
* Implement searching for public rooms and users in new search experience
* Implement loading indicator for spotlight results
* Moved spotlight dialog into own subfolder
* Extract search result avatar into separate component
* Build generic new dropdown menu component
* Build new network menu based on new network dropdown component
* Switch roomdirectory to use new network dropdown
* Replace old networkdropdown with new networkdropdown
* Added component for public room result details
* Extract hooks and subcomponents from SpotlightDialog
* Create new hook to get profile info based for an mxid
* Add hook to automatically re-request search results
* Add hook to prevent out-of-order search results
* Extract member sort algorithm from InviteDialog
* Keep sorting for non-room results stable
* Sort people suggestions using sort algorithm from InviteDialog
* Add copy/copied tooltip for invite link option in spotlight
* Clamp length of topic for public room results
* Add unit test for useDebouncedSearch
* Add unit test for useProfileInfo
* Create cypress test cases for spotlight dialog
* Add test for useLatestResult to prevent out-of-order results
2022-06-15 16:14:05 +02:00
Suguru Hirahara
37298d7b1b
Remove Riot-era media query declarations of event tile on mobile UI (#8814)
* Apply style declarations for mobile UI to modern layout, which breaks the current layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove the style declarations to restore the current layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Readd zero margin for event tile content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-15 08:44:39 +02:00
Travis Ralston
44b2667f73
Add a bit of safety around timestamp handling for threads (#8845) 2022-06-14 22:43:20 -06:00
Travis Ralston
39f2bbaaf4
Bring back waveform for voice messages and retain seeking (#8843)
* Crude way of layering the waveform and seek bar

Not intended for production.

* Use a layout prop instead of something less descriptive

* Fix alignment properly, and play with styles

* Convert back to a ball

* Use `transparent` which makes NVDA happy enough

* Allow keyboards in the seek bar

* Try to make the clock behave more correctly with screen readers

MIDNIGHT

* Remove legacy export

* Remove redundant attr

* Appease the linter
2022-06-14 18:13:13 -06:00
Michael Telatynski
d81e2cea14
Remove unused sessionStorage layer (#8834)
* Remove unused sessionStorage layer

* Update global.d.ts

* Fix tests
2022-06-14 21:29:24 +01:00
Šimon Brandner
7da8c51c6b
Improve colors in settings (#7283) 2022-06-14 18:17:10 +00:00
Michael Telatynski
3c5c2bef6d
Remove Piwik support (#8835)
* Remove all mentions of Piwik

* Kill off all consumer of the old Piwik Analytics module

* Simplify ModalManager interface

* i18n

* Attempt to fix old e2e tests

* Remove unused component

* Iterate PR
2022-06-14 17:51:51 +01:00
RiotRobot
7d14d15ba6 Merge remote-tracking branch 'origin/develop' into develop 2022-06-14 14:21:33 +01:00
Suguru Hirahara
1dee39f419
Improve help user settings tab styling (#8838)
* Set the default margin between the debug button and the subsection texts

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete style rule for AccessibleButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove the special block margin setting from the reload button

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete class name - mx_HelpUserSettingsTab_versions

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace <br>s for spacing with a margin style declaration

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace <br> for spacing with a margin style declaration

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove <br>s for spacing

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply mx_SettingsTab_subsectionText to the credits list

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply spacing-16 instead of spacing-12

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-14 15:20:54 +02:00
RiotRobot
045d895f1c Merge branch 'master' into develop 2022-06-14 14:20:17 +01:00
RiotRobot
7ed87092c9 v3.47.0 2022-06-14 14:05:11 +01:00
RiotRobot
985f9e353c Prepare changelog for v3.47.0 2022-06-14 14:05:10 +01:00
Michael Weimann
6e786d6cd5
Prevent level order to be modified (#8821)
(cherry picked from commit b87c537885)
2022-06-14 13:54:17 +01:00
Michael Telatynski
d6c162a5cf
Abstract electron settings properly to avoid boilerplate-hell (#8798)
* Remove unused method `BasePlatform::screenCaptureErrorString`

* Improve platform typescripting

* Remove redundant awaits

* Abstract electron settings properly to avoid boilerplate-hell

* i18n

* Fix stray semi-colons

* Fix setting level order for Platform settings

(cherry picked from commit ba2ce5ecba)
2022-06-14 13:54:08 +01:00
Šimon Brandner
ec9117dbd1
Improve Typescript in BasePlatform (#8768)
* Improve Typescript in `BasePlatform`

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* `installUpdate()` should not be abstract

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
(cherry picked from commit 125a265806)
2022-06-14 13:53:46 +01:00
Šimon Brandner
0841aca2a4
Fix CallView crash (#8735)
(cherry picked from commit 6574c5c3e2)
2022-06-14 13:51:44 +01:00
Suguru Hirahara
d1b95e5491
Remove obsolete style rules for "Show my Communities" which has been removed (#8839)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-14 13:43:51 +01:00
Michael Telatynski
79195dea8b
Skip running jobs on fork develop where they lack secrets (#8837)
* Skip running jobs on fork `develop` where they lack secrets

* Fix contexts
2022-06-14 11:37:07 +01:00
Suguru Hirahara
2c751a4fa6
Remove unique settings from labs user settings tab (#8828)
* Remove redundant style declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete float setting

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove special margin setting

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove unnecessary specificity

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Reset the margin with a variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-14 09:05:43 +02:00
Michael Telatynski
b03aa2ebf5
Move room directory Puppeteer tests over to Cypress (#8832)
* Fix user view percy test by sticking the user avatar colour

* Move room directory Puppeteer tests over to Cypress

* Consolidate import

* Fix tests

* Grab default widths

* Tweak Percy CSS mechanism
2022-06-13 19:25:39 +01:00
Suguru Hirahara
dfdba46d57
Remove _NotificationUserSettingsTab.scss (#8831) 2022-06-13 17:30:07 +02:00
Suguru Hirahara
95e8a9e419
Fix keyboard shortcuts on settings tab being wrapped (#8825)
* Fix keyboard shortcuts being wrapped

Setting $spacing-8 gap between the labels and the shortcuts

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add the block margin to the rows, not to the keys

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add the inline margin to the shortcuts, not to the keys

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-13 16:12:48 +02:00
Michael Telatynski
f10d35cb18
Add try-catch around blurhash loading (#8830) 2022-06-13 13:25:32 +01:00
Janne Mareike Koschinski
57dff8131c
Prevent new composer from overflowing from non-breakable text (#8829) 2022-06-13 13:05:41 +02:00
Suguru Hirahara
cda18a3dfb
Improve CSS rules of zoom buttons on live location (#8728)
* Use flex to stop redundant margin-top from appearing

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove ButtonResetDefault which resets nothing

It should be avoided to use ButtonResetDefault where there is nothing to be reset, in order to prevent resources from being wasted.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Ensure that unexpected regressions will never happen on the buttons and their icons

Rules can be extracted when needed. Until then there is no point of exposing elements to possible regressions, which could easily happen on the current architecture.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use SASS variables and remove a redundant declaration

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-13 09:23:49 +02:00
Suguru Hirahara
68ce7bf35e
Remove an obsolete style declaration of .mx_ReplyChain_show (#8743)
It was added with https://github.com/matrix-org/matrix-react-sdk/pull/6291/files#diff-11808ff6468e6efa5982f414119fcc8a3a3eea4090b1a4ebda8ed6eae732418aR163

It has not been effective for unknown period, and since the layout of the area has changed, it should be able to be safely removed.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-13 09:17:48 +02:00
Michael Weimann
b87c537885
Prevent level order to be modified (#8821) 2022-06-13 08:03:16 +02:00
Suguru Hirahara
18d7f7c525
Use mx_SettingsTab_subsectionText for the text under the top header of appearance user settings tab (#8822) 2022-06-12 14:52:55 +00:00
Suguru Hirahara
d1d4cc42bc
Use common subheading on sidebar user settings tab (#8823) 2022-06-12 15:12:34 +02:00
Suguru Hirahara
6b40c0b2e3
Tidy _AppearanceUserSettingsTab.scss (#8824) 2022-06-12 15:11:33 +02:00
Suguru Hirahara
89743c9321
Fix clickable area of advanced toggle on appearance user settings tab (#8820) 2022-06-12 13:13:41 +02:00
Travis Ralston
b5e18064ab
Import React to appease IDE linter (#8817)
Apparently we shouldn't be using global references to React, so import it.
2022-06-11 21:17:55 +00:00
Michael Telatynski
ba2ce5ecba
Abstract electron settings properly to avoid boilerplate-hell (#8798)
* Remove unused method `BasePlatform::screenCaptureErrorString`

* Improve platform typescripting

* Remove redundant awaits

* Abstract electron settings properly to avoid boilerplate-hell

* i18n

* Fix stray semi-colons

* Fix setting level order for Platform settings
2022-06-10 22:38:50 +01:00
Šimon Brandner
9b8b1d193e
Disable redacting reactions if we don't have sufficient permissions (#8767) 2022-06-10 18:41:05 +00:00
Michael Telatynski
3f99f594de
Keep draft in composer when a slash command syntax errors (#8811) 2022-06-10 17:16:31 +01:00
Travis Ralston
4171c008a4
Convert sticker end-to-end tests to Cypress (#8807)
* Convert sticker end-to-end tests to Cypress

Reference materials:
* https://www.cypress.io/blog/2020/02/12/working-with-iframes-in-cypress/
* https://github.com/cypress-io/cypress/issues/136
* https://docs.cypress.io/api/commands/origin#Other-limitations

Ideally we'd be able to use `cy.origin()` to jump into the iframe, but it's explicitly not supported. Instead we disable web security as instructed by cypress because it's our only reasonable option here. Thankfully, disabling web security doesn't appear to remove the crypto libraries from the browser so we can still function in that respect.

Rationale for why we can't just serve the sticker picker off the app domain is included in the code.

* Appease the linter

* More linter appeasement
2022-06-10 09:24:15 -06:00
Michael Telatynski
5b149bcffd
Use a fixed matrix-org/github-action-benchmark (#8810) 2022-06-10 15:42:51 +01:00
Robin
53340db5e9
Update the live timeline when the JS SDK resets it (#8806) 2022-06-10 08:59:07 -04:00
Suguru Hirahara
1b7e9d95da
Fix flex blowout on image reply (#8809)
* Set min-width to prevent a flex blowout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a native spacing property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set max-width: 100% to display name inside the image reply

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-10 12:36:17 +01:00