bitwarden-android/.github/PULL_REQUEST_TEMPLATE.md
2023-07-14 11:56:49 -05:00

2 KiB
Raw Blame History

🎟️ Tracking

🚧 Type of change

  • 🐛 Bug fix
  • 🚀 New feature development
  • 🧹 Tech debt (refactoring, code cleanup, dependency upgrades, etc.)
  • 🤖 Build/deploy pipeline (DevOps)
  • 🎂 Other

📔 Objective

📋 Code changes

  • file.ext: Description of what was changed and why.

📸 Screenshots

Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or (:information_source:) for notes or general info
  • (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes