Commit graph

17824 commits

Author SHA1 Message Date
Benoit Marty
bd2cd3ad96
Merge pull request #6183 from SpiritCroc/persist-image-notification
Fix some notifications never getting dismissed
2022-05-30 20:24:11 +02:00
Benoit Marty
16554bf351
Merge pull request #6189 from vector-im/dependabot/gradle/androidx.activity-activity-1.4.0
Bump activity from 1.2.4 to 1.4.0
2022-05-30 20:23:17 +02:00
Johannes Marbach
5b64946dfb Remove empty default implementation 2022-05-30 20:18:56 +02:00
Onuray Sahin
4ccd242cbf
Merge pull request #6170 from vector-im/feature/ons/live_location_bottom_sheet
Live Location Sharing - User List Bottom Sheet [PSF-890]
2022-05-30 21:07:25 +03:00
networkException
fedc637dee
Changelog: Add .feature entry for pull request #6166
Signed-off-by: networkException <git@nwex.de>
2022-05-30 20:05:26 +02:00
networkException
b138ac8601
MessageImageVideoItem: Hide play button for autoplaying animated images
This patch updates the logic checking whether to show the
playContentView to not show it when an animated image message would
autoplay its animation.

Signed-off-by: networkException <git@nwex.de>
2022-05-30 20:05:26 +02:00
networkException
9d0fe46723
ImageContentRenderer: Enable image animation if enabled in preferences
This patch removes dontAnimate() in the createGlideRequest() builder
conditionally depending on the user's animated image autoplay
preferences.

Resolves #1160, #5094

Signed-off-by: networkException <git@nwex.de>
2022-05-30 20:05:26 +02:00
networkException
9b60ee70c5
MessageInformationData: Add messageType field
This patch adds the messageType field to MessageInformationData,
containing a nullable string representation of the message event's type.

Signed-off-by: networkException <git@nwex.de>
2022-05-30 20:05:26 +02:00
networkException
f86362f065
VectorPreferences: Add switch for autoplaying animated images
This patch adds a new switch to VectorPreferences, the vector settings
preferences view and various classes propergating the set value of the
switch into parts of the application touched by the following patches.

Signed-off-by: networkException <git@nwex.de>
2022-05-30 20:05:26 +02:00
Benoit Marty
2f983d46b7
Merge pull request #6188 from vector-im/dependabot/gradle/com.autonomousapps.dependency-analysis-1.4.0
Bump com.autonomousapps.dependency-analysis from 1.2.1 to 1.4.0
2022-05-30 18:42:16 +02:00
Benoit Marty
ae94f45f34
Merge pull request #5952 from vector-im/feature/bma/sdk_user_story
Sdk user story
2022-05-30 18:30:56 +02:00
Onuray Sahin
353f290f0c Fix unit tests. 2022-05-30 19:21:57 +03:00
Benoit Marty
afaa89ad42
Merge pull request #6186 from vector-im/feature/bma/knit_toc
Generate toc in md files using knit
2022-05-30 18:14:51 +02:00
SpiritCroc
0393dd51c9 Bring back downstream "Update room previews once we have decryption keys"
This reverts commit 130fe7f887.
Also update to some newer decryption logic, and disable the new upstream
logic, to avoid duplicate decryption attempts.

Change-Id: Ibcea8b825d94284dfcf2d305b5f57423366601e5
2022-05-30 17:39:20 +02:00
SpiritCroc
73feba72f5 Fix some notifications never getting dismissed
Persisting notification info fails for non-null Uris:

E NotificationEventPersistence: ## Failed to save cached notification info
E NotificationEventPersistence: java.io.NotSerializableException: android.net.Uri$HierarchicalUri
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1240)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1604)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1565)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1488)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1234)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:354)
E NotificationEventPersistence: 	at java.util.ArrayList.writeObject(ArrayList.java:762)
E NotificationEventPersistence: 	at java.lang.reflect.Method.invoke(Native Method)
E NotificationEventPersistence: 	at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1036)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1552)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1488)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1234)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:354)
E NotificationEventPersistence: 	at org.matrix.android.sdk.internal.session.securestorage.SecretStoringUtils.saveSecureObjectM(SecretStoringUtils.kt:283)
E NotificationEventPersistence: 	at org.matrix.android.sdk.internal.session.securestorage.SecretStoringUtils.securelyStoreObject(SecretStoringUtils.kt:150)
E NotificationEventPersistence: 	at org.matrix.android.sdk.internal.session.securestorage.DefaultSecureStorageService.securelyStoreObject(DefaultSecureStorageService.kt:27)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationEventPersistence.persistEvents(NotificationEventPersistence.kt:58)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager$persistEvents$1.invoke(NotificationDrawerManager.kt:183)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager$persistEvents$1.invoke(NotificationDrawerManager.kt:182)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationState.queuedEvents(NotificationState.kt:55)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager.persistEvents(NotificationDrawerManager.kt:182)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager.refreshNotificationDrawerBg(NotificationDrawerManager.kt:177)

Accordingly, if a notification for an image is shown, and the
notification state is loaded from storage later, none of the previously
shown notifications will get dismissed once read.

Change-Id: I2d6be497e8b92e770b680e16e42b3610add57323
2022-05-30 17:39:16 +02:00
SpiritCroc
3e58f2c254 Developer quick setting for theming
Closes https://github.com/SchildiChat/SchildiChat-android/issues/117

Change-Id: Ie8fab9b7842e695b9e59a65d2cbf09c7edfd1dd8
2022-05-30 17:39:10 +02:00
Johannes Marbach
75da9887be Move test to the right folder 2022-05-30 17:09:28 +02:00
dependabot[bot]
41a37ae83f
Bump com.autonomousapps.dependency-analysis from 1.2.1 to 1.4.0
Bumps com.autonomousapps.dependency-analysis from 1.2.1 to 1.4.0.

---
updated-dependencies:
- dependency-name: com.autonomousapps.dependency-analysis
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-30 14:58:14 +00:00
Johannes Marbach
769b217c7e Remove unused imports 2022-05-30 16:53:59 +02:00
Onuray Sahin
84b3d5520c Fix unit tests. 2022-05-30 17:41:26 +03:00
Johannes Marbach
d757914225 Unsuppress lint rule 2022-05-30 16:35:44 +02:00
Johannes Marbach
73d78646ea Turn test into normal unit test 2022-05-30 16:34:19 +02:00
Auri B. P
a10e67c594 Translated using Weblate (Catalan)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ca/
2022-05-30 14:32:30 +00:00
Mr.Narsus
1e5b378fbf Translated using Weblate (Arabic)
Currently translated at 44.0% (979 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ar/
2022-05-30 14:32:10 +00:00
dependabot[bot]
cb3e2b6a0c
Bump activity from 1.2.4 to 1.4.0
Bumps activity from 1.2.4 to 1.4.0.

---
updated-dependencies:
- dependency-name: androidx.activity:activity
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-30 14:23:11 +00:00
Benoit Marty
0806e7358a
Merge pull request #5780 from ofalvai/dependency-cleanup
Remove unused dependencies
2022-05-30 15:41:10 +02:00
Onuray Sahin
04679ea21d Merge branch 'develop' into feature/ons/live_location_bottom_sheet
* develop: (114 commits)
  Docs: Fix various formatting and spelling issues in notifications.md
  Fixing non necessary breaking line
  continuing to the originally supplied url when a rtl override character is detected
  splitting url detection condition into separate branches
  Cleaner code
  Create extension `String?.toActiveSpaceOrOrphanRooms()` to reduce noise.
  Add changelog
  Fix test compilation
  Add some Kdoc
  Add some Kdoc
  Create SpaceFilter.OrphanRooms to improve the API. Not 100% of the side effect. There is probably some (fixed?) bugs here.
  Rename ActiveSpaceFilter to SpaceFilter
  Remove `ActiveSpaceFilter.None` Prefer nullability for API coherency of `RoomSummaryQueryParams`
  Add some Kdoc
  Remove duplicated lines of code (the same code is done a few lines later)
  Remove `RoomCategoryFilter.ALL` Prefer nullability for API coherency of `RoomSummaryQueryParams`
  `displayName` default value is now `QueryStringValue.NoCondition`. It was working fine since in the DB we always have a name using `RoomDisplayNameFallbackProvider`, which in our current implementation always return a non empty String.
  Small rework for nicer code
  Remove duplicated code lines
  Remove `roomId` from `RoomSummaryQueryParams.Builder()`. Create a new API in RoomService to observe a room summary from a roomId.
  ...

# Conflicts:
#	vector/src/main/java/im/vector/app/features/location/live/map/LocationLiveMapViewFragment.kt
2022-05-30 16:27:11 +03:00
Aris Kotsomitopoulos
9a756f2b7a
Merge pull request #6168 from vector-im/feature/aris/threads_update_icons
Fix wrong rendered vector icon
2022-05-30 15:59:18 +03:00
SpiritCroc
0670c3c6ee Update unit test for imageUriString 2022-05-30 14:55:08 +02:00
Benoit Marty
fb884e29b5 Update the title, since knit is not clever enough to handle &.
And run `.gradlew knit` again to update the toc.
2022-05-30 14:41:41 +02:00
Onuray Sahin
21abc3fa77 Code review fixes. 2022-05-30 15:40:36 +03:00
Benoit Marty
aa9b5ce0bd Call ./gradlew knit to generate the TOC 2022-05-30 14:35:11 +02:00
Benoit Marty
bc7a50124f Setup knit TOC.
Only ## and more heading will be listed, so add a "h" level.
2022-05-30 14:34:32 +02:00
Benoit Marty
3d437f94f1 Call ./gradlew knit to regenerate the TOC 2022-05-30 14:31:31 +02:00
Benoit Marty
b3a5812a61 Setup knit TOC.
Only ## and more heading will be listed, so add a "h" level.
2022-05-30 14:30:28 +02:00
Benoit Marty
828e13f9be
Merge pull request #6182 from networkException/notification-documentation-fixes
Docs: Fix various formatting and spelling issues in notifications.md
2022-05-30 14:26:57 +02:00
Benoit Marty
a94bea3b91
Merge pull request #6173 from vector-im/dependabot/gradle/kotlinCoroutines-1.6.2
Bump kotlinCoroutines from 1.6.1 to 1.6.2
2022-05-30 14:23:22 +02:00
Benoit Marty
816be72386
Merge pull request #6181 from vector-im/dependabot/gradle/vanniktechEmoji-0.15.0
Bump vanniktechEmoji from 0.13.0 to 0.15.0
2022-05-30 14:08:12 +02:00
Benoit Marty
ab651cbe50
Merge pull request #6164 from vector-im/bug/adm/link-checking
Ask the user to confirm urls which contain unicode direction overrides
2022-05-30 14:07:23 +02:00
networkException
609cdf72ae
Docs: Fix various formatting and spelling issues in notifications.md
Signed-off-by: networkException <git@nwex.de>
2022-05-30 13:38:53 +02:00
SpiritCroc
292020e95d Fix some notifications never getting dismissed
Persisting notification info fails for non-null Uris:

E NotificationEventPersistence: ## Failed to save cached notification info
E NotificationEventPersistence: java.io.NotSerializableException: android.net.Uri$HierarchicalUri
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1240)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1604)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1565)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1488)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1234)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:354)
E NotificationEventPersistence: 	at java.util.ArrayList.writeObject(ArrayList.java:762)
E NotificationEventPersistence: 	at java.lang.reflect.Method.invoke(Native Method)
E NotificationEventPersistence: 	at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1036)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1552)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1488)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1234)
E NotificationEventPersistence: 	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:354)
E NotificationEventPersistence: 	at org.matrix.android.sdk.internal.session.securestorage.SecretStoringUtils.saveSecureObjectM(SecretStoringUtils.kt:283)
E NotificationEventPersistence: 	at org.matrix.android.sdk.internal.session.securestorage.SecretStoringUtils.securelyStoreObject(SecretStoringUtils.kt:150)
E NotificationEventPersistence: 	at org.matrix.android.sdk.internal.session.securestorage.DefaultSecureStorageService.securelyStoreObject(DefaultSecureStorageService.kt:27)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationEventPersistence.persistEvents(NotificationEventPersistence.kt:58)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager$persistEvents$1.invoke(NotificationDrawerManager.kt:183)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager$persistEvents$1.invoke(NotificationDrawerManager.kt:182)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationState.queuedEvents(NotificationState.kt:55)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager.persistEvents(NotificationDrawerManager.kt:182)
E NotificationEventPersistence: 	at im.vector.app.features.notifications.NotificationDrawerManager.refreshNotificationDrawerBg(NotificationDrawerManager.kt:177)

Accordingly, if a notification for an image is shown, and the
notification state is loaded from storage later, none of the previously
shown notifications will get dismissed once read.

Likely addresses https://github.com/vector-im/element-android/issues/4862.

Change-Id: I2d6be497e8b92e770b680e16e42b3610add57323
2022-05-30 13:06:09 +02:00
Onuray Sahin
aa344b1ecd Code documentation. 2022-05-30 13:56:17 +03:00
Maxime NATUREL
eeaf9fd616
Merge pull request #6129 from vector-im/feature/mna/PSF-1019-user-pins
[Location sharing] - Show user live location pins in map view (PSF-1019)
2022-05-30 12:32:09 +02:00
Onuray Sahin
b262aad3a8 Remove unused layout. 2022-05-30 13:24:31 +03:00
Benoit Marty
17ccccc6e6
Merge pull request #6143 from vector-im/feature/bma/cleanup_RoomSummaryQueryParams
Cleanup room summary query params
2022-05-30 12:22:26 +02:00
Maxime NATUREL
538c099913 Fixing non necessary breaking line 2022-05-30 11:44:03 +02:00
Adam Brown
67f1929784 continuing to the originally supplied url when a rtl override character is detected 2022-05-30 10:42:42 +01:00
Adam Brown
e6198d7bf6 splitting url detection condition into separate branches 2022-05-30 10:38:42 +01:00
Benoit Marty
ec498cf054 Cleaner code 2022-05-30 11:38:31 +02:00
Benoit Marty
c071dc502e Create extension String?.toActiveSpaceOrOrphanRooms() to reduce noise. 2022-05-30 11:38:31 +02:00