From 8b6877b91f0daebd3253d275bd949fbb82b87d68 Mon Sep 17 00:00:00 2001 From: Stefan Melmuk Date: Tue, 14 May 2024 20:43:12 +0200 Subject: [PATCH] update web-vault to v2024.5.0 --- Dockerfile | 4 +- patches/v2024.5.0.patch | 834 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 836 insertions(+), 2 deletions(-) create mode 100644 patches/v2024.5.0.patch diff --git a/Dockerfile b/Dockerfile index 5efb1fa..5bb37b6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -26,8 +26,8 @@ USER node # Can be a tag, release, but prefer a commit hash because it's not changeable # https://github.com/bitwarden/clients/commit/${VAULT_VERSION} # -# Using https://github.com/bitwarden/clients/releases/tag/web-v2024.4.2 -ARG VAULT_VERSION=128c9093b0e40effb82830189b27caf5a096f12c +# Using https://github.com/bitwarden/clients/releases/tag/web-v2024.5.0 +ARG VAULT_VERSION=431e909f9b2c046e90aa50fde1907ae6ccf25ee9 WORKDIR /vault RUN git -c init.defaultBranch=main init && \ diff --git a/patches/v2024.5.0.patch b/patches/v2024.5.0.patch new file mode 100644 index 0000000..d963f6a --- /dev/null +++ b/patches/v2024.5.0.patch @@ -0,0 +1,834 @@ +diff --git a/apps/web/src/app/admin-console/organizations/create/organization-information.component.html b/apps/web/src/app/admin-console/organizations/create/organization-information.component.html +index e0a8006081..789efd9264 100644 +--- a/apps/web/src/app/admin-console/organizations/create/organization-information.component.html ++++ b/apps/web/src/app/admin-console/organizations/create/organization-information.component.html +@@ -12,7 +12,7 @@ + + + +- {{ "billingEmail" | i18n }} ++ {{ "email" | i18n }} + + + +diff --git a/apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts b/apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts +index 7de0c98cd5..f842ad907b 100644 +--- a/apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts ++++ b/apps/web/src/app/admin-console/organizations/layouts/organization-layout.component.ts +@@ -120,6 +120,7 @@ export class OrganizationLayoutComponent implements OnInit, OnDestroy { + } + + canShowBillingTab(organization: Organization): boolean { ++ return false; // disable billing tab in Vaultwarden + return canAccessBillingTab(organization); + } + +diff --git a/apps/web/src/app/admin-console/organizations/members/people.component.ts b/apps/web/src/app/admin-console/organizations/members/people.component.ts +index af04d83c34..2ae49ea968 100644 +--- a/apps/web/src/app/admin-console/organizations/members/people.component.ts ++++ b/apps/web/src/app/admin-console/organizations/members/people.component.ts +@@ -190,11 +190,7 @@ export class PeopleComponent extends BasePeopleComponent { + .find((p) => p.organizationId === this.organization.id); + this.orgResetPasswordPolicyEnabled = resetPasswordPolicy?.enabled; + +- const billingMetadata = await this.billingApiService.getOrganizationBillingMetadata( +- this.organization.id, +- ); +- +- this.orgIsOnSecretsManagerStandalone = billingMetadata.isOnSecretsManagerStandalone; ++ this.orgIsOnSecretsManagerStandalone = false; // don't get billing metadata + + await this.load(); + +diff --git a/apps/web/src/app/admin-console/organizations/organization-routing.module.ts b/apps/web/src/app/admin-console/organizations/organization-routing.module.ts +index 7abee6b0d0..2e3b789b23 100644 +--- a/apps/web/src/app/admin-console/organizations/organization-routing.module.ts ++++ b/apps/web/src/app/admin-console/organizations/organization-routing.module.ts +@@ -68,13 +68,6 @@ const routes: Routes = [ + (m) => m.OrganizationReportingModule, + ), + }, +- { +- path: "billing", +- loadChildren: () => +- import("../../billing/organizations/organization-billing.module").then( +- (m) => m.OrganizationBillingModule, +- ), +- }, + ], + }, + ]; +diff --git a/apps/web/src/app/admin-console/organizations/settings/account.component.html b/apps/web/src/app/admin-console/organizations/settings/account.component.html +index 082fe7eb80..32feab6f4d 100644 +--- a/apps/web/src/app/admin-console/organizations/settings/account.component.html ++++ b/apps/web/src/app/admin-console/organizations/settings/account.component.html +@@ -17,7 +17,7 @@ + + + +- {{ "billingEmail" | i18n }} ++ {{ "email" | i18n }} + + + +diff --git a/apps/web/src/app/admin-console/organizations/settings/account.component.ts b/apps/web/src/app/admin-console/organizations/settings/account.component.ts +index d8091e46ae..7e4947c4bb 100644 +--- a/apps/web/src/app/admin-console/organizations/settings/account.component.ts ++++ b/apps/web/src/app/admin-console/organizations/settings/account.component.ts +@@ -93,7 +93,7 @@ export class AccountComponent { + ) {} + + async ngOnInit() { +- this.selfHosted = this.platformUtilsService.isSelfHost(); ++ this.selfHosted = false; // set to false so we can rename organizations + + this.route.params + .pipe( +@@ -195,6 +195,7 @@ export class AccountComponent { + } + + submitCollectionManagement = async () => { ++ return; // flexible collections are not supported by Vaultwarden + // Early exit if self-hosted + if (this.selfHosted) { + return; +diff --git a/apps/web/src/app/app.component.ts b/apps/web/src/app/app.component.ts +index 6e2761a9c4..307c54104a 100644 +--- a/apps/web/src/app/app.component.ts ++++ b/apps/web/src/app/app.component.ts +@@ -2,7 +2,7 @@ import { DOCUMENT } from "@angular/common"; + import { Component, Inject, NgZone, OnDestroy, OnInit } from "@angular/core"; + import { NavigationEnd, Router } from "@angular/router"; + import * as jq from "jquery"; +-import { Subject, filter, firstValueFrom, map, switchMap, takeUntil, timeout, timer } from "rxjs"; ++import { Subject, filter, firstValueFrom, map, takeUntil, timeout } from "rxjs"; + + import { EventUploadService } from "@bitwarden/common/abstractions/event/event-upload.service"; + import { NotificationsService } from "@bitwarden/common/abstractions/notifications.service"; +@@ -14,7 +14,6 @@ import { AccountService } from "@bitwarden/common/auth/abstractions/account.serv + import { AuthService } from "@bitwarden/common/auth/abstractions/auth.service"; + import { KeyConnectorService } from "@bitwarden/common/auth/abstractions/key-connector.service"; + import { AuthenticationStatus } from "@bitwarden/common/auth/enums/authentication-status"; +-import { PaymentMethodWarningsServiceAbstraction as PaymentMethodWarningService } from "@bitwarden/common/billing/abstractions/payment-method-warnings-service.abstraction"; + import { BroadcasterService } from "@bitwarden/common/platform/abstractions/broadcaster.service"; + import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service"; + import { CryptoService } from "@bitwarden/common/platform/abstractions/crypto.service"; +@@ -46,7 +45,6 @@ import { + + const BroadcasterSubscriptionId = "AppComponent"; + const IdleTimeout = 60000 * 10; // 10 minutes +-const PaymentMethodWarningsRefresh = 60000; // 1 Minute + + @Component({ + selector: "app-root", +@@ -57,7 +55,6 @@ export class AppComponent implements OnDestroy, OnInit { + private idleTimer: number = null; + private isIdle = false; + private destroy$ = new Subject(); +- private paymentMethodWarningsRefresh$ = timer(0, PaymentMethodWarningsRefresh); + + constructor( + @Inject(DOCUMENT) private document: Document, +@@ -86,7 +83,6 @@ export class AppComponent implements OnDestroy, OnInit { + private dialogService: DialogService, + private biometricStateService: BiometricStateService, + private stateEventRunnerService: StateEventRunnerService, +- private paymentMethodWarningService: PaymentMethodWarningService, + private organizationService: InternalOrganizationServiceAbstraction, + private accountService: AccountService, + ) {} +@@ -207,6 +203,10 @@ export class AppComponent implements OnDestroy, OnInit { + break; + } + case "showToast": ++ if (typeof message.text === "string" && typeof crypto.subtle === "undefined") { ++ message.title = "This browser requires HTTPS to use the web vault"; ++ message.text = "Check the Vaultwarden wiki for details on how to enable it"; ++ } + this.toastService._showToast(message); + break; + case "convertAccountToKeyConnector": +@@ -240,21 +240,6 @@ export class AppComponent implements OnDestroy, OnInit { + new DisableSendPolicy(), + new SendOptionsPolicy(), + ]); +- +- this.paymentMethodWarningsRefresh$ +- .pipe( +- switchMap(() => this.organizationService.memberOrganizations$), +- switchMap( +- async (organizations) => +- await Promise.all( +- organizations.map((organization) => +- this.paymentMethodWarningService.update(organization.id), +- ), +- ), +- ), +- takeUntil(this.destroy$), +- ) +- .subscribe(); + } + + ngOnDestroy() { +@@ -287,7 +272,6 @@ export class AppComponent implements OnDestroy, OnInit { + this.collectionService.clear(userId), + this.passwordGenerationService.clear(), + this.biometricStateService.logout(userId), +- this.paymentMethodWarningService.clear(), + ]); + + await this.stateEventRunnerService.handleEvent("logout", userId); +diff --git a/apps/web/src/app/auth/emergency-access/accept/accept-emergency.component.html b/apps/web/src/app/auth/emergency-access/accept/accept-emergency.component.html +index 4690a4e63a..9d297671d2 100644 +--- a/apps/web/src/app/auth/emergency-access/accept/accept-emergency.component.html ++++ b/apps/web/src/app/auth/emergency-access/accept/accept-emergency.component.html +@@ -1,6 +1,6 @@ +
+
+- ++ +

+

+ {{ "loading" | i18n }} + +- ++ +

{{ "uploadLicenseFileOrg" | i18n }}

+
+
+@@ -28,7 +28,7 @@ + (ngSubmit)="submit()" + [appApiAction]="formPromise" + ngNativeValidate +- *ngIf="!loading && !selfHosted && this.passwordManagerPlans && this.secretsManagerPlans" ++ *ngIf="!loading" + class="tw-pt-6" + > + !!plan.PasswordManager); +@@ -187,6 +188,7 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + this.plan = providerDefaultPlan.type; + this.product = providerDefaultPlan.product; + } ++ end of asking /api/plans in Vaultwarden */ + + if (!this.createOrganization) { + this.upgradeFlowPrefillForm(); +@@ -258,6 +260,7 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + } + + get selectableProducts() { ++ return null; // there are no products to select in Vaultwarden + if (this.acceptingSponsorship) { + const familyPlan = this.passwordManagerPlans.find( + (plan) => plan.type === PlanType.FamiliesAnnually, +@@ -289,6 +292,7 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + } + + get selectablePlans() { ++ return null; // no plans to select in Vaultwarden + const selectedProductType = this.formGroup.controls.product.value; + const result = + this.passwordManagerPlans?.filter( +@@ -430,10 +434,12 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + } + + get planOffersSecretsManager() { ++ return false; // no support for secrets manager in Vaultwarden + return this.selectedSecretsManagerPlan != null; + } + + changedProduct() { ++ return; // no choice of products in Vaultwarden + const selectedPlan = this.selectablePlans[0]; + + this.setPlanType(selectedPlan.type); +@@ -546,7 +552,7 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + const orgKeys = await this.cryptoService.makeKeyPair(orgKey[1]); + + if (this.selfHosted) { +- orgId = await this.createSelfHosted(key, collectionCt, orgKeys); ++ orgId = await this.createCloudHosted(key, collectionCt, orgKeys, orgKey[1]); + } else { + orgId = await this.createCloudHosted(key, collectionCt, orgKeys, orgKey[1]); + } +@@ -645,7 +651,9 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + request.billingEmail = this.formGroup.controls.billingEmail.value; + request.initiationPath = "New organization creation in-product"; + request.keys = new OrganizationKeysRequest(orgKeys[0], orgKeys[1].encryptedString); ++ request.planType = PlanType.Free; // always select the free plan in Vaultwarden + ++ /* there is no plan to select in Vaultwarden + if (this.selectedPlan.type === PlanType.Free) { + request.planType = PlanType.Free; + } else { +@@ -672,6 +680,7 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + + // Secrets Manager + this.buildSecretsManagerRequest(request); ++ end plan selection and no support for secret manager in Vaultwarden */ + + if (this.hasProvider) { + const providerRequest = new ProviderOrganizationCreateRequest( +@@ -753,6 +762,7 @@ export class OrganizationPlansComponent implements OnInit, OnDestroy { + } + + private upgradeFlowPrefillForm() { ++ return; // Vaultwarden only supports free plan + if (this.acceptingSponsorship) { + this.formGroup.controls.product.setValue(ProductType.Families); + this.changedProduct(); +diff --git a/apps/web/src/app/core/router.service.ts b/apps/web/src/app/core/router.service.ts +index caebb22733..b64392a944 100644 +--- a/apps/web/src/app/core/router.service.ts ++++ b/apps/web/src/app/core/router.service.ts +@@ -45,7 +45,7 @@ export class RouterService { + .subscribe((event: NavigationEnd) => { + this.currentUrl = event.url; + +- let title = i18nService.t("bitWebVault"); ++ let title = "Vaultwarden Web"; + + if (this.currentUrl.includes("/sm/")) { + title = i18nService.t("bitSecretsManager"); +diff --git a/apps/web/src/app/core/web-platform-utils.service.ts b/apps/web/src/app/core/web-platform-utils.service.ts +index 02c7c29e34..9fd100024a 100644 +--- a/apps/web/src/app/core/web-platform-utils.service.ts ++++ b/apps/web/src/app/core/web-platform-utils.service.ts +@@ -133,14 +133,17 @@ export class WebPlatformUtilsService implements PlatformUtilsService { + } + + isDev(): boolean { ++ return false; // treat Vaultwarden as production ready + return process.env.NODE_ENV === "development"; + } + + isSelfHost(): boolean { ++ return true; // treat Vaultwarden as self hosted + return WebPlatformUtilsService.isSelfHost(); + } + + static isSelfHost(): boolean { ++ return true; // treat Vaultwarden as self hosted + return process.env.ENV.toString() === "selfhosted"; + } + +diff --git a/apps/web/src/app/layouts/frontend-layout.component.html b/apps/web/src/app/layouts/frontend-layout.component.html +index 72f0f1f1da..cea0867131 100644 +--- a/apps/web/src/app/layouts/frontend-layout.component.html ++++ b/apps/web/src/app/layouts/frontend-layout.component.html +@@ -1,6 +1,11 @@ + +
+- +- © {{ year }} Bitwarden Inc.
++ Vaultwarden Web
+ {{ "versionNumber" | i18n: version }} ++

++
++ A modified version of the Bitwarden® Web Vault for Vaultwarden (an unofficial rewrite of the ++ Bitwarden® server).
++ Vaultwarden is not associated with the Bitwarden® project nor Bitwarden Inc. ++
+
+diff --git a/apps/web/src/app/layouts/header/web-header.component.html b/apps/web/src/app/layouts/header/web-header.component.html +index e2b3e7910a..fda32e9257 100644 +--- a/apps/web/src/app/layouts/header/web-header.component.html ++++ b/apps/web/src/app/layouts/header/web-header.component.html +@@ -89,7 +89,12 @@ + + {{ "accountSettings" | i18n }} + +- ++ + + {{ "getHelp" | i18n }} + +diff --git a/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html b/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html +index 62d8b6a075..ec8a14c115 100644 +--- a/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html ++++ b/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html +@@ -30,7 +30,7 @@ + + +
+ {{ "moreFromBitwarden" | i18n }} +diff --git a/apps/web/src/app/layouts/user-layout.component.html b/apps/web/src/app/layouts/user-layout.component.html +index 15a01fa07b..719b9ba7f3 100644 +--- a/apps/web/src/app/layouts/user-layout.component.html ++++ b/apps/web/src/app/layouts/user-layout.component.html +@@ -35,8 +35,5 @@ + + + +- + + +diff --git a/apps/web/src/app/layouts/user-layout.component.ts b/apps/web/src/app/layouts/user-layout.component.ts +index eb507bd997..480ae62cb8 100644 +--- a/apps/web/src/app/layouts/user-layout.component.ts ++++ b/apps/web/src/app/layouts/user-layout.component.ts +@@ -1,7 +1,7 @@ + import { CommonModule } from "@angular/common"; + import { Component, OnInit } from "@angular/core"; + import { RouterModule } from "@angular/router"; +-import { Observable, combineLatest, concatMap } from "rxjs"; ++import { Observable, of } from "rxjs"; + + import { JslibModule } from "@bitwarden/angular/jslib.module"; + import { ApiService } from "@bitwarden/common/abstractions/api.service"; +@@ -13,8 +13,6 @@ import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/pl + import { SyncService } from "@bitwarden/common/vault/abstractions/sync/sync.service.abstraction"; + import { IconModule, LayoutComponent, NavigationModule } from "@bitwarden/components"; + +-import { PaymentMethodWarningsModule } from "../billing/shared"; +- + import { PasswordManagerLogo } from "./password-manager-logo"; + import { ToggleWidthComponent } from "./toggle-width.component"; + +@@ -29,7 +27,6 @@ import { ToggleWidthComponent } from "./toggle-width.component"; + LayoutComponent, + IconModule, + NavigationModule, +- PaymentMethodWarningsModule, + ToggleWidthComponent, + ], + }) +@@ -56,26 +53,7 @@ export class UserLayoutComponent implements OnInit { + + await this.syncService.fullSync(false); + +- this.hasFamilySponsorshipAvailable$ = this.organizationService.canManageSponsorships$; +- +- // We want to hide the subscription menu for organizations that provide premium. +- // Except if the user has premium personally or has a billing history. +- this.showSubscription$ = combineLatest([ +- this.billingAccountProfileStateService.hasPremiumPersonally$, +- this.billingAccountProfileStateService.hasPremiumFromAnyOrganization$, +- ]).pipe( +- concatMap(async ([hasPremiumPersonally, hasPremiumFromOrg]) => { +- const isCloud = !this.platformUtilsService.isSelfHost(); +- +- let billing = null; +- if (isCloud) { +- // TODO: We should remove the need to call this! +- billing = await this.apiService.getUserBillingHistory(); +- } +- +- const cloudAndBillingHistory = isCloud && !billing?.hasNoHistory; +- return hasPremiumPersonally || !hasPremiumFromOrg || cloudAndBillingHistory; +- }), +- ); ++ this.hasFamilySponsorshipAvailable$ = of(false); // disable family Sponsorships in Vaultwarden ++ this.showSubscription$ = of(false); // always hide subscriptions in Vaultwarden + } + } +diff --git a/apps/web/src/app/oss-routing.module.ts b/apps/web/src/app/oss-routing.module.ts +index 066ed5db10..1a0ac5ebd3 100644 +--- a/apps/web/src/app/oss-routing.module.ts ++++ b/apps/web/src/app/oss-routing.module.ts +@@ -229,13 +229,6 @@ const routes: Routes = [ + component: DomainRulesComponent, + data: { titleId: "domainRules" }, + }, +- { +- path: "subscription", +- loadChildren: () => +- import("./billing/individual/individual-billing.module").then( +- (m) => m.IndividualBillingModule, +- ), +- }, + { + path: "emergency-access", + children: [ +diff --git a/apps/web/src/app/platform/web-environment.service.ts b/apps/web/src/app/platform/web-environment.service.ts +index c2eb37eea5..2b5ac93392 100644 +--- a/apps/web/src/app/platform/web-environment.service.ts ++++ b/apps/web/src/app/platform/web-environment.service.ts +@@ -27,8 +27,17 @@ export class WebEnvironmentService extends DefaultEnvironmentService { + super(stateProvider, accountService); + + // The web vault always uses the current location as the base url +- const urls = process.env.URLS as Urls; +- urls.base ??= this.win.location.origin; ++ // If the base URL is `https://vaultwarden.example.com/base/path/`, ++ // `window.location.href` should have one of the following forms: ++ // ++ // - `https://vaultwarden.example.com/base/path/` ++ // - `https://vaultwarden.example.com/base/path/#/some/route[?queryParam=...]` ++ // ++ // We want to get to just `https://vaultwarden.example.com/base/path`. ++ let baseUrl = this.win.location.href; ++ baseUrl = baseUrl.replace(/#.*/, ""); // Strip off `#` and everything after. ++ baseUrl = baseUrl.replace(/\/+$/, ""); // Trim any trailing `/` chars. ++ const urls = { base: baseUrl }; + + // Find the region + const domain = Utils.getDomain(this.win.location.href); +diff --git a/apps/web/src/app/shared/loose-components.module.ts b/apps/web/src/app/shared/loose-components.module.ts +index b511f5d766..25c26f5e39 100644 +--- a/apps/web/src/app/shared/loose-components.module.ts ++++ b/apps/web/src/app/shared/loose-components.module.ts +@@ -62,7 +62,6 @@ import { UpdatePasswordComponent } from "../auth/update-password.component"; + import { UpdateTempPasswordComponent } from "../auth/update-temp-password.component"; + import { VerifyEmailTokenComponent } from "../auth/verify-email-token.component"; + import { VerifyRecoverDeleteComponent } from "../auth/verify-recover-delete.component"; +-import { PaymentMethodWarningsModule } from "../billing/shared"; + import { DynamicAvatarComponent } from "../components/dynamic-avatar.component"; + import { SelectableAvatarComponent } from "../components/selectable-avatar.component"; + import { FrontendLayoutComponent } from "../layouts/frontend-layout.component"; +@@ -116,7 +115,6 @@ import { SharedModule } from "./shared.module"; + HeaderModule, + OrganizationLayoutComponent, + UserLayoutComponent, +- PaymentMethodWarningsModule, + ], + declarations: [ + AcceptFamilySponsorshipComponent, +diff --git a/apps/web/src/app/tools/send/access.component.html b/apps/web/src/app/tools/send/access.component.html +index 6fef7d361d..1deb1164ff 100644 +--- a/apps/web/src/app/tools/send/access.component.html ++++ b/apps/web/src/app/tools/send/access.component.html +@@ -2,7 +2,7 @@ +
+- ++ +
+

View Send

+
+@@ -66,19 +66,6 @@ +
+

+ {{ "sendAccessTaglineProductDesc" | i18n }} +- {{ "sendAccessTaglineLearnMore" | i18n }} +- Bitwarden Send +- {{ "sendAccessTaglineOr" | i18n }} +- {{ +- "sendAccessTaglineSignUp" | i18n +- }} +- {{ "sendAccessTaglineTryToday" | i18n }} +

+
+
+diff --git a/apps/web/src/app/tools/send/add-edit.component.html b/apps/web/src/app/tools/send/add-edit.component.html +index 3225b61350..2a192514bf 100644 +--- a/apps/web/src/app/tools/send/add-edit.component.html ++++ b/apps/web/src/app/tools/send/add-edit.component.html +@@ -227,7 +227,12 @@ + {{ "password" | i18n }} + {{ "newPassword" | i18n }} + +- ++ + + {{ "sendPasswordDesc" | i18n }} + +diff --git a/apps/web/src/index.html b/apps/web/src/index.html +index c3a2c03ed9..1a326771a6 100644 +--- a/apps/web/src/index.html ++++ b/apps/web/src/index.html +@@ -5,7 +5,7 @@ + + + +- Bitwarden Web Vault ++ Vaultwarden Web + + + +@@ -17,7 +17,7 @@ + +
+
+- ++ +

+