From 73b338bba6e4d5861f4a38baa31c72398c17f47a Mon Sep 17 00:00:00 2001
From: Janik Schumacher <rndmb0t@gmail.com>
Date: Wed, 30 Mar 2022 12:09:38 +0200
Subject: [PATCH 1/2] feat: Favicon is updated based on satus page logo
---
src/pages/StatusPage.vue | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/pages/StatusPage.vue b/src/pages/StatusPage.vue
index 2695b10d..1fe17069 100644
--- a/src/pages/StatusPage.vue
+++ b/src/pages/StatusPage.vue
@@ -67,7 +67,7 @@
<h1 class="mb-4 title-flex">
<!-- Logo -->
<span class="logo-wrapper" @click="showImageCropUploadMethod">
- <img :src="logoURL" alt class="logo me-2" :class="logoClass" />
+ <img :src="logoURL" alt class="logo me-2" :class="logoClass" @load="statusPageLogoLoaded" />
<font-awesome-icon v-if="enableEditMode" class="icon-upload" icon="upload" />
</span>
@@ -592,6 +592,10 @@ export default {
}
},
+ statusPageLogoLoaded(eventPayload) {
+ favicon.image(eventPayload.target);
+ },
+
createIncident() {
this.enableEditIncidentMode = true;
From 514b9fb68a7177782f5bc754cae3c01e5f752975 Mon Sep 17 00:00:00 2001
From: Louis Lam <louislam@users.noreply.github.com>
Date: Thu, 31 Mar 2022 21:30:07 +0800
Subject: [PATCH 2/2] Add remark
---
src/pages/StatusPage.vue | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/pages/StatusPage.vue b/src/pages/StatusPage.vue
index 1fe17069..22bbb589 100644
--- a/src/pages/StatusPage.vue
+++ b/src/pages/StatusPage.vue
@@ -593,6 +593,7 @@ export default {
},
statusPageLogoLoaded(eventPayload) {
+ // Remark: may not work in dev, due to cros
favicon.image(eventPayload.target);
},