From 74a908a0692b3136e6ab69b1e9af030b461c50b4 Mon Sep 17 00:00:00 2001
From: Adam Stachowicz <adam.stachowicz@fingo.info>
Date: Mon, 4 Dec 2023 10:19:18 +0000
Subject: [PATCH] Max ESLint warnings 0 (#4158)
* Fix ESLint warnings. Update workflows. 0 ESLint warnings for auto-test
* json-yaml-validate: Fix `unable to find version `v2``
---
.eslintrc.js | 5 +++--
.github/workflows/auto-test.yml | 22 ++++++++++-----------
.github/workflows/close-incorrect-issue.yml | 4 ++--
.github/workflows/json-yaml-validate.yml | 6 +++---
.github/workflows/stale-bot.yml | 2 +-
package.json | 2 ++
6 files changed, 22 insertions(+), 19 deletions(-)
diff --git a/.eslintrc.js b/.eslintrc.js
index 4713799d..9b30158d 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -78,7 +78,7 @@ module.exports = {
"checkLoops": false,
}],
"space-before-blocks": "warn",
- //'no-console': 'warn',
+ //"no-console": "warn",
"no-extra-boolean-cast": "off",
"no-multiple-empty-lines": [ "warn", {
"max": 1,
@@ -90,7 +90,8 @@ module.exports = {
"no-unneeded-ternary": "error",
"array-bracket-newline": [ "error", "consistent" ],
"eol-last": [ "error", "always" ],
- //'prefer-template': 'error',
+ //"prefer-template": "error",
+ "template-curly-spacing": [ "warn", "never" ],
"comma-dangle": [ "warn", "only-multiline" ],
"no-empty": [ "error", {
"allowEmptyCatch": true
diff --git a/.github/workflows/auto-test.yml b/.github/workflows/auto-test.yml
index 53c68378..42d17993 100644
--- a/.github/workflows/auto-test.yml
+++ b/.github/workflows/auto-test.yml
@@ -27,10 +27,10 @@ jobs:
steps:
- run: git config --global core.autocrlf false # Mainly for Windows
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node }}
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- run: npm install npm@9 -g
@@ -55,10 +55,10 @@ jobs:
steps:
- run: git config --global core.autocrlf false # Mainly for Windows
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node }}
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- run: npm install npm@9 -g
@@ -69,24 +69,24 @@ jobs:
steps:
- run: git config --global core.autocrlf false # Mainly for Windows
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: Use Node.js 14
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: 14
- run: npm install
- - run: npm run lint
+ - run: npm run lint:prod
e2e-tests:
needs: [ check-linters ]
runs-on: ubuntu-latest
steps:
- run: git config --global core.autocrlf false # Mainly for Windows
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: Use Node.js 14
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: 14
- run: npm install
@@ -98,10 +98,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- run: git config --global core.autocrlf false # Mainly for Windows
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: Use Node.js 14
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: 14
- run: npm install
diff --git a/.github/workflows/close-incorrect-issue.yml b/.github/workflows/close-incorrect-issue.yml
index 762bc968..e26cf5e5 100644
--- a/.github/workflows/close-incorrect-issue.yml
+++ b/.github/workflows/close-incorrect-issue.yml
@@ -14,10 +14,10 @@ jobs:
node-version: [16]
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
diff --git a/.github/workflows/json-yaml-validate.yml b/.github/workflows/json-yaml-validate.yml
index 104e37a1..b6437ec4 100644
--- a/.github/workflows/json-yaml-validate.yml
+++ b/.github/workflows/json-yaml-validate.yml
@@ -6,7 +6,7 @@ on:
pull_request:
branches:
- master
- - 2.0.X
+ - 1.23.X
workflow_dispatch:
permissions:
@@ -17,11 +17,11 @@ jobs:
json-yaml-validate:
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
- name: json-yaml-validate
id: json-yaml-validate
- uses: GrantBirki/json-yaml-validate@v1.3.0
+ uses: GrantBirki/json-yaml-validate@v2.4.0
with:
comment: "true" # enable comment mode
exclude_file: ".github/config/exclude.txt" # gitignore style file for exclusions
diff --git a/.github/workflows/stale-bot.yml b/.github/workflows/stale-bot.yml
index b39f68fc..8238be0a 100644
--- a/.github/workflows/stale-bot.yml
+++ b/.github/workflows/stale-bot.yml
@@ -9,7 +9,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- - uses: actions/stale@v7
+ - uses: actions/stale@v8
with:
stale-issue-message: 'We are clearing up our old issues and your ticket has been open for 3 months with no activity. Remove stale label or comment or this will be closed in 2 days.'
close-issue-message: 'This issue was closed because it has been stalled for 2 days with no activity.'
diff --git a/package.json b/package.json
index 9d144273..54b0f54b 100644
--- a/package.json
+++ b/package.json
@@ -13,10 +13,12 @@
"install-legacy": "npm install",
"update-legacy": "npm update",
"lint:js": "eslint --ext \".js,.vue\" --ignore-path .gitignore .",
+ "lint:js-prod": "npm run lint:js -- --max-warnings 0",
"lint-fix:js": "eslint --ext \".js,.vue\" --fix --ignore-path .gitignore .",
"lint:style": "stylelint \"**/*.{vue,css,scss}\" --ignore-path .gitignore",
"lint-fix:style": "stylelint \"**/*.{vue,css,scss}\" --fix --ignore-path .gitignore",
"lint": "npm run lint:js && npm run lint:style",
+ "lint:prod": "npm run lint:js-prod && npm run lint:style",
"dev": "concurrently -k -r \"wait-on tcp:3000 && npm run start-server-dev \" \"npm run start-frontend-dev\"",
"start-frontend-dev": "cross-env NODE_ENV=development vite --host --config ./config/vite.config.js",
"start-frontend-devcontainer": "cross-env NODE_ENV=development DEVCONTAINER=1 vite --host --config ./config/vite.config.js",