synapse/changelog.d/17511.misc at e3db7b2d81cabc7e4335afc051e28678e3a9dd02 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-22 09:35:45 +03:00

Eric Eastwood e3db7b2d81

Build docker images / build (push) Waiting to run

Deploy the documentation / GitHub Pages (push) Blocked by required conditions

Deploy the documentation / Calculate variables for GitHub Pages deployment (push) Waiting to run

Tests / complement (monolith, Postgres) (push) Blocked by required conditions

Build release artifacts / Build wheels on ubuntu-20.04 for aarch64 (push) Waiting to run

Build release artifacts / Build wheels on macos-12 for x86_64 (push) Waiting to run

Build release artifacts / Build wheels on ubuntu-20.04 for x86_64 (push) Waiting to run

Build release artifacts / Build sdist (push) Waiting to run

Build release artifacts / Attach assets to release (push) Blocked by required conditions

Build release artifacts / Calculate list of debian distros (push) Waiting to run

Build release artifacts / Build .deb packages (push) Blocked by required conditions

Tests / changes (push) Waiting to run

Tests / check-sampleconfig (push) Blocked by required conditions

Tests / check-schema-delta (push) Blocked by required conditions

Tests / check-lockfile (push) Waiting to run

Tests / lint (push) Blocked by required conditions

Tests / Typechecking (push) Blocked by required conditions

Tests / lint-crlf (push) Waiting to run

Tests / lint-newsfile (push) Waiting to run

Tests / lint-pydantic (push) Blocked by required conditions

Tests / lint-clippy (push) Blocked by required conditions

Tests / lint-clippy-nightly (push) Blocked by required conditions

Tests / lint-rustfmt (push) Blocked by required conditions

Tests / lint-readme (push) Blocked by required conditions

Tests / linting-done (push) Blocked by required conditions

Tests / calculate-test-jobs (push) Blocked by required conditions

Tests / trial (push) Blocked by required conditions

Tests / trial-olddeps (push) Blocked by required conditions

Tests / trial-pypy (all, pypy-3.8) (push) Blocked by required conditions

Tests / sytest (push) Blocked by required conditions

Tests / portdb (15, 3.11) (push) Blocked by required conditions

Tests / export-data (push) Blocked by required conditions

Tests / portdb (11, 3.8) (push) Blocked by required conditions

Tests / complement (monolith, SQLite) (push) Blocked by required conditions

Tests / complement (workers, Postgres) (push) Blocked by required conditions

Tests / cargo-test (push) Blocked by required conditions

Tests / cargo-bench (push) Blocked by required conditions

Tests / tests-done (push) Blocked by required conditions

Sliding Sync: Easier to understand timeline assertions in tests (#17511 )

Added `_assertTimelineEqual(...)` because I got fed up trying to
understand the crazy diffs from the standard
`self.assertEqual(...)`/`self.assertListEqual(...)`

Before:
```
[FAIL]
Traceback (most recent call last):
  File "/home/eric/Documents/github/element/synapse/tests/rest/client/sliding_sync/test_rooms_timeline.py", line 103, in test_rooms_limited_initial_sync
    self.assertListEqual(
  File "/usr/lib/python3.12/unittest/case.py", line 1091, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/usr/lib/python3.12/unittest/case.py", line 1073, in assertSequenceEqual
    self.fail(msg)
twisted.trial.unittest.FailTest: Lists differ: ['$4QcmnzhdazSnDYcYSZCS_6-MWSzM_dN3RC7TRvW0w[95 chars]isM'] != ['$8N1XJ7e-3K_wxAanLVD3v8KQ96_B5Xj4huGkgy4N4[95 chars]nnU']

First differing element 0:
'$4QcmnzhdazSnDYcYSZCS_6-MWSzM_dN3RC7TRvW0wWA'
'$8N1XJ7e-3K_wxAanLVD3v8KQ96_B5Xj4huGkgy4N4-E'

- ['$4QcmnzhdazSnDYcYSZCS_6-MWSzM_dN3RC7TRvW0wWA',
-  '$8N1XJ7e-3K_wxAanLVD3v8KQ96_B5Xj4huGkgy4N4-E',
? ^

+ ['$8N1XJ7e-3K_wxAanLVD3v8KQ96_B5Xj4huGkgy4N4-E',
? ^

-  '$q4PRxQ_pBZkQI1keYuZPTtExQ23DqpUI3-Lxwfj_isM']
+  '$4QcmnzhdazSnDYcYSZCS_6-MWSzM_dN3RC7TRvW0wWA',
+  '$j3Xj-t2F1wH9kUHsI8X5yqS7hkdSyN2owaArfvk8nnU']
```

After:

```
[FAIL]
Traceback (most recent call last):
  File "/home/eric/Documents/github/element/synapse/tests/rest/client/sliding_sync/test_rooms_timeline.py", line 178, in test_rooms_limited_initial_sync
    self._assertTimelineEqual(
  File "/home/eric/Documents/github/element/synapse/tests/rest/client/sliding_sync/test_rooms_timeline.py", line 110, in _assertTimelineEqual
    self._assertListEqual(
  File "/home/eric/Documents/github/element/synapse/tests/rest/client/sliding_sync/test_rooms_timeline.py", line 79, in _assertListEqual
    self.fail(f"{diff_message}\n{message}")
twisted.trial.unittest.FailTest: Items must
Expected items to be in actual ('?' = missing expected items):
 [
   (10, master) $w-BoqW1PQQFU4TzVJW5OIelugxh0mY12wrfw6mbC6D4 (m.room.message) activity4
   (11, master) $sSidTZf1EOQmCVDU4mrH_1-bopMQhwcDUO2IhoemR6M (m.room.message) activity5
?  (12, master) $bgOcc3D-2QSkbk4aBxKVyOOQJGs7ZuncRJwG3cEANZg (m.room.member, @user1:test) join
 ]
Actual ('+' = found expected items):
 [
+  (11, master) $sSidTZf1EOQmCVDU4mrH_1-bopMQhwcDUO2IhoemR6M (m.room.message) activity5
+  (10, master) $w-BoqW1PQQFU4TzVJW5OIelugxh0mY12wrfw6mbC6D4 (m.room.message) activity4
   (9, master) $FmCNyc11YeFwiJ4an7_q6H0LCCjQOKd6UCr5VKeXXUw (m.room.message, None) activity3
 ]
```

2024-08-05 13:20:15 -05:00

1 line

66 B

Text

Raw Blame History

Easier to understand `timeline` assertions in Sliding Sync tests.