synapse/changelog.d/17906.bugfix at d0fc1e904a3060b0f459be9aa7df9b9f1501e294 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-21 17:15:38 +03:00

Erik Johnston d0fc1e904a

Fix cancellation tests with new Twisted. (#17906 )

The latest Twisted release changed how they implemented `__await__` on
deferreds, which broke the machinery we used to test cancellation.

This PR changes things a bit to instead patch the `__await__` method,
which is a stable API. This mostly doesn't change the core logic, except
for fixing two bugs:
  - We previously did not intercept all await points
- After cancellation we now need to not only unblock currently blocked
await points, but also make sure we don't block any future await points.

c.f. https://github.com/twisted/twisted/pull/12226

---------

Co-authored-by: Devon Hudson <devon.dmytro@gmail.com>

2024-11-07 15:26:14 +00:00

1 line

38 B

Text

Raw Blame History

Fix tests to run with latest Twisted.