synapse/changelog.d/14723.bugfix at babeeb4e7a6f5b5c643b837bf724d674805546f6 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-25 11:05:49 +03:00

Nick Mills-Barrett db1cfe9c80

Update all stream IDs after processing replication rows (#14723 )

This creates a new store method, `process_replication_position` that
is called after `process_replication_rows`. By moving stream ID advances
here this guarantees any relevant cache invalidations will have been
applied before the stream is advanced.

This avoids race conditions where Python switches between threads mid
way through processing the `process_replication_rows` method where stream
IDs may be advanced before caches are invalidated due to class resolution
ordering.

See this comment/issue for further discussion:
	https://github.com/matrix-org/synapse/issues/14158#issuecomment-1344048703

2023-01-04 11:49:26 +00:00

1 line

122 B

Text

Raw Blame History

Ensure stream IDs are always updated after caches get invalidated with workers. Contributed by Nick @ Beeper (@fizzadar).