synapse/changelog.d/11143.misc at b9ce53e8785d6f0dba6a3efcd708e4a185c32465 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-26 19:47:05 +03:00

David Robertson 2d91b6256e

Fix adding excluded users to the private room sharing tables when joining a room (#11143 )

* We only need to fetch users in private rooms

* Filter out `user_id` at the top

* Discard excluded users in the top loop

We weren't doing this in the "First, if they're our user" branch so this
is a bugfix.

* The caller must check that `user_id` is included

This is in the docstring. There are two call sites:
- one in `_handle_room_publicity_change`, which explicitly checks before calling;
- and another in `_handle_room_membership_event`, which returns early if
  the user is excluded.

So this change is safe.

* Test joining a private room with an excluded user

* Tweak an existing test

* Changelog

* test docstring

* lint

2021-10-21 17:48:59 +01:00

1 line

No EOL

172 B

Text

Raw Blame History

Fix a long-standing bug where users excluded from the directory could still be added to the `users_who_share_private_rooms` table after a regular user joins a private room.