synapse/changelog.d/17272.bugfix at afaf2d9388f7012d0500932dad0af4bdb8d40d20 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-22 09:35:45 +03:00

Eric Eastwood 265ee88f34

Build docker images / build (push) Waiting to run

Deploy the documentation / Calculate variables for GitHub Pages deployment (push) Waiting to run

Deploy the documentation / GitHub Pages (push) Blocked by required conditions

Build release artifacts / Calculate list of debian distros (push) Waiting to run

Build release artifacts / Build .deb packages (push) Blocked by required conditions

Build release artifacts / Build wheels on ${{ matrix.os }} for ${{ matrix.arch }} (aarch64, ${{ startsWith(github.ref, 'refs/pull/') }}, ubuntu-20.04) (push) Waiting to run

Build release artifacts / Build wheels on ${{ matrix.os }} for ${{ matrix.arch }} (x86_64, ${{ startsWith(github.ref, 'refs/pull/') }}, macos-11) (push) Waiting to run

Build release artifacts / Build wheels on ${{ matrix.os }} for ${{ matrix.arch }} (x86_64, ${{ startsWith(github.ref, 'refs/pull/') }}, ubuntu-20.04) (push) Waiting to run

Build release artifacts / Build sdist (push) Waiting to run

Build release artifacts / Attach assets to release (push) Blocked by required conditions

Tests / check-sampleconfig (push) Blocked by required conditions

Tests / check-schema-delta (push) Blocked by required conditions

Tests / check-lockfile (push) Waiting to run

Tests / lint (push) Blocked by required conditions

Tests / Typechecking (push) Blocked by required conditions

Tests / lint-crlf (push) Waiting to run

Tests / changes (push) Waiting to run

Tests / lint-newsfile (push) Waiting to run

Tests / lint-pydantic (push) Blocked by required conditions

Tests / lint-clippy (push) Blocked by required conditions

Tests / lint-clippy-nightly (push) Blocked by required conditions

Tests / lint-rustfmt (push) Blocked by required conditions

Tests / linting-done (push) Blocked by required conditions

Tests / calculate-test-jobs (push) Blocked by required conditions

Tests / trial (push) Blocked by required conditions

Tests / trial-olddeps (push) Blocked by required conditions

Tests / trial-pypy (all, pypy-3.8) (push) Blocked by required conditions

Tests / sytest (push) Blocked by required conditions

Tests / export-data (push) Blocked by required conditions

Tests / portdb (11, 3.8) (push) Blocked by required conditions

Tests / cargo-bench (push) Blocked by required conditions

Tests / portdb (15, 3.11) (push) Blocked by required conditions

Tests / complement (monolith, Postgres) (push) Blocked by required conditions

Tests / complement (monolith, SQLite) (push) Blocked by required conditions

Tests / complement (workers, Postgres) (push) Blocked by required conditions

Tests / cargo-test (push) Blocked by required conditions

Tests / tests-done (push) Blocked by required conditions

Wrong retention policy being used when filtering events (lint ControlVarUsedAfterBlockViolation WPS441) (#17272 )

Fix loop var being used outside block.

Before this change, we were always using the last room_id's retention policy for all events being filtered.

I found this bug with the [new lint rule, `ControlVarUsedAfterBlockViolation` `WPS441`](https://github.com/astral-sh/ruff/pull/11769), that I re-implemented in `ruff`. Shout-out to @reivilibre for all the help in the beginning! 

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct
(run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))

2024-06-10 09:48:38 -05:00

1 line

61 B

Text

Raw Blame History

Fix wrong retention policy being used when filtering events.