synapse/changelog.d/16639.bugfix at ab73abe6931d4866751f32f1d0e7ac757963205d - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-21 17:15:38 +03:00

Erik Johnston fef08cbee8

Fix sending out of order POSITION over replication (#16639 )

If a worker reconnects to Redis we send out the current positions of all our streams. However, if we're also trying to send out a backlog of RDATA at the same time then we can end up sending a `POSITION` with the current token *before* we've sent all the RDATA before the current token.

This doesn't cause actual bugs as the receiving servers see the POSITION, fetch the relevant rows from the DB, and then ignore the old RDATA as they come in. However, this is inefficient so it'd be better if we didn't  send out-of-order positions

2023-11-16 13:05:09 +00:00

1 line

88 B

Text

Raw Blame History

Fix sending out of order `POSITION` over replication, causing additional database load.