mirror of
https://github.com/element-hq/synapse.git
synced 2024-11-22 17:46:08 +03:00
961ee75a9b
Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| 11881.feature | ||
| 12040.feature | ||
| 12115.bugfix | ||
| 12165.misc | ||
| 12191.misc | ||
| 12193.misc | ||
| 12209.misc | ||
| 12251.feature | ||
| 12252.feature | ||
| 12267.misc | ||
| 12271.doc | ||
| 12280.misc | ||
| 12293.removal | ||
| 12295.misc | ||
| 12302.feature | ||
| 12310.feature | ||
| 12315.doc | ||
| 12316.misc | ||
| 12317.misc | ||
| 12321.misc | ||
| 12326.misc | ||
| 12327.feature | ||
| 12329.bugfix | ||
| 12330.misc | ||
| 12331.doc | ||
| 12332.misc | ||
| 12333.bugfix | ||
| 12334.misc | ||
| 12335.misc | ||
| 12336.misc | ||
| 12338.misc | ||
| 12339.doc | ||
| 12341.feature | ||
| 12345.doc | ||
| 12346.misc | ||
| 12347.misc | ||
| 12348.misc | ||
| 12349.misc | ||
| 12350.bugfix | ||
| 12351.misc | ||
| 12353.misc | ||
| 12354.misc | ||
| 12355.misc | ||
| 12357.misc | ||
| 12358.misc | ||
| 12364.bugfix | ||
| 12366.misc | ||
| 12367.feature | ||
| 12369.doc | ||
| 12370.feature | ||
| 12371.misc | ||
| 12372.feature | ||
| 12376.misc | ||
| 12379.misc | ||
| 12380.misc | ||
| 12381.misc | ||
| 12384.misc | ||
| 12385.docker | ||
| 12389.misc | ||
| 12390.bugfix | ||
| 12391.feature | ||
| 12392.doc | ||
| 12398.misc | ||
| 12400.misc | ||
| 12403.feature | ||
| 12404.misc | ||
| 12408.misc | ||
| 12409.misc | ||
| 12410.bugfix | ||
| 12412.misc | ||
| 12415.misc | ||
| 12418.misc | ||
| 12420.misc | ||
| 12421.misc | ||
| 12422.misc | ||