synapse/changelog.d/8398.bugfix at 8b40843392e2df80d4f1108295ae6acd972100b0 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-27 20:22:07 +03:00

Richard van der Hoff fec6f9ac17

Fix occasional "Re-starting finished log context" from keyring (#8398 )

* Fix test_verify_json_objects_for_server_awaits_previous_requests

It turns out that this wasn't really testing what it thought it was testing
(in particular, `check_context` was turning failures into success, which was
making the tests pass even though it wasn't clear they should have been.

It was also somewhat overcomplex - we can test what it was trying to test
without mocking out perspectives servers.

* Fix warnings about finished logcontexts in the keyring

We need to make sure that we finish the key fetching magic before we run the
verifying code, to ensure that we don't mess up our logcontexts.

2020-09-25 12:29:54 +01:00

1 line

103 B

Text

Raw Blame History

Fix "Re-starting finished log context" warning when receiving an event we already had over federation.