synapse/changelog.d/7352.feature at 5b8023dc7f31dbd682e93bd4d82655f70f5f19f5 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-30 00:14:57 +03:00

Erik Johnston 3eab76ad43

Don't relay REMOTE_SERVER_UP cmds to same conn. (#7352 )

For direct TCP connections we need the master to relay REMOTE_SERVER_UP
commands to the other connections so that all instances get notified
about it. The old implementation just relayed to all connections,
assuming that sending back to the original sender of the command was
safe. This is not true for redis, where commands sent get echoed back to
the sender, which was causing master to effectively infinite loop
sending and then re-receiving REMOTE_SERVER_UP commands that it sent.

The fix is to ensure that we only relay to *other* connections and not
to the connection we received the notification from.

Fixes #7334.

2020-04-29 14:10:59 +01:00

1 line

67 B

Gherkin

Raw Blame History

Add support for running replication over Redis when using workers.