synapse/changelog.d/13320.misc at 357561c1a2b2da6d1a7ad1e2340217fee18cc2b1 - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-29 15:39:00 +03:00

Eric Eastwood 0f971ca68e

Update get_pdu to return the original, pristine EventBase (#13320 )

Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier`  and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call.

Split out from https://github.com/matrix-org/synapse/pull/13205

As discussed at:

 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746
 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125

Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](7864f33e28/synapse/federation/federation_client.py (L581-L594)).

2022-07-20 15:58:51 -05:00

1 line

130 B

Text

Raw Blame History

Fix `FederationClient.get_pdu()` returning events from the cache as `outliers` instead of original events we saw over federation.