synapse/changelog.d/9069.misc at 2b467d0b61ff094a305c2c92f0cec6ca04b5d16d - mirrors/synapse - Sadium Git

mirrors/synapse

mirror of https://github.com/element-hq/synapse.git synced 2024-11-25 19:15:51 +03:00

Richard van der Hoff 2ec8ca5e60

Remove SynapseRequest.get_user_agent (#9069 )

SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
LoggingContext and write the right entries to the request log).

Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.

In short: move get_user_agent out to a utility function.

2021-01-12 12:34:16 +00:00

1 line

40 B

Text

Raw Blame History

Remove `SynapseRequest.get_user_agent`.