synapse/changelog.d
Eric Eastwood 1bf2832714
Indicate what endpoint came back with a JSON response we were unable to parse (#14097)
**Before:**
```
WARNING - POST-11 - Unable to parse JSON: Expecting value: line 1 column 1 (char 0) (b'')
```

**After:**
```
WARNING - POST-11 - Unable to parse JSON from POST /_matrix/client/v3/join/%21ZlmJtelqFroDRJYZaq:hs1?server_name=hs1 response: Expecting value: line 1 column 1 (char 0) (b'')
```

---

It's possible to figure out which endpoint these warnings were coming from before but you had to follow the request ID `POST-11` to the log line that says `Completed request [...]`. Including this key information next to the JSON parsing error makes it much easier to reason whether it matters or not.

```
2022-09-29T08:23:25.7875506Z synapse_main | 2022-09-29 08:21:10,336 - synapse.http.matrixfederationclient - 299 - INFO - POST-11 - {GET-O-13} [hs1] Completed request: 200 OK in 0.53 secs, got 450 bytes - GET matrix://hs1/_matrix/federation/v1/make_join/%21ohtKoQiXlPePSycXwp%3Ahs1/%40charlie%3Ahs2?ver=1&ver=2&ver=3&ver=4&ver=5&ver=6&ver=org.matrix.msc2176&ver=7&ver=8&ver=9&ver=org.matrix.msc3787&ver=10&ver=org.matrix.msc2716v4
```


---

As a note, having no `body` is normal for the `/join` endpoint and it can handle it.

0c853e0970/synapse/rest/client/room.py (L398-L403)

Alternatively we could remove these extra logs but they are probably more usually helpful to figure out what went wrong.
2022-10-07 11:39:45 -05:00
..
.gitignore Correct attrs package name in requirements (#3492) 2018-07-07 10:46:59 +10:00
13776.feature Use stable identifiers for MSC3771 & MSC3773. (#14050) 2022-10-07 09:26:40 -04:00
13824.feature Use stable identifiers for MSC3771 & MSC3773. (#14050) 2022-10-07 09:26:40 -04:00
13877.feature Use stable identifiers for MSC3771 & MSC3773. (#14050) 2022-10-07 09:26:40 -04:00
13878.feature Use stable identifiers for MSC3771 & MSC3773. (#14050) 2022-10-07 09:26:40 -04:00
13955.docker Update frozendict 2.3.3 -> 2.3.4 (#13955) 2022-10-07 12:13:37 +01:00
13983.misc Bump actions/setup-python from 2 to 4 (#13983) 2022-10-04 12:24:36 +01:00
13984.misc Bump types-pyopenssl from 22.0.0 to 22.0.10 (#13984) 2022-10-04 12:27:41 +01:00
13985.misc Bump jsonschema from 4.4.0 to 4.16.0 (#13985) 2022-10-04 12:34:08 +01:00
13986.misc Bump types-setuptools from 57.4.9 to 65.4.0.0 (#13986) 2022-10-04 12:21:20 +01:00
13987.misc Bump types-requests from 2.27.11 to 2.28.11 (#13987) 2022-10-04 12:24:18 +01:00
13988.misc Bump isort from 5.7.0 to 5.10.1 (#13988) 2022-10-04 13:19:40 +01:00
13991.misc Remove get rooms for user with stream ordering (#13991) 2022-10-04 16:42:59 +01:00
13996.feature Send the appservice access token as a header. (#13996) 2022-10-04 07:06:41 -04:00
13997.feature Disable pushing for server ACL events (MSC3786). (#13997) 2022-10-04 07:08:27 -04:00
14006.misc update authlib from 0.15.5 to 1.1.0 (#14006) 2022-10-04 14:49:07 +00:00
14032.feature Advertise supporting version 1.3 of the Matrix spec. (#14032) 2022-10-04 10:21:16 -04:00
14033.misc Batch up notifications after event persistence (#14033) 2022-10-05 10:12:48 -07:00
14034.bugfix Apply & bundle edits for non-message events. (#14034) 2022-10-07 15:27:50 +00:00
14040.misc Bump msgpack from 1.0.3 to 1.0.4 (#14040) 2022-10-07 15:08:06 +01:00
14041.misc Bump types-pyyaml from 6.0.4 to 6.0.12 (#14041) 2022-10-04 15:53:47 +00:00
14043.misc Bump phonenumbers from 8.12.44 to 8.12.56 (#14043) 2022-10-07 15:17:00 +01:00
14044.misc Bump pydantic from 1.9.1 to 1.10.2 (#14044) 2022-10-07 15:08:24 +01:00
14046.misc Fix building wheels on OSX (#14046) 2022-10-04 14:59:30 +01:00
14050.feature Use stable identifiers for MSC3771 & MSC3773. (#14050) 2022-10-07 09:26:40 -04:00
14053.bugfix Fix handling of public rooms filter with a network tuple. (#14053) 2022-10-05 12:49:52 +00:00
14054.feature Use Pydantic to validate /devices endpoints (#14054) 2022-10-07 13:54:07 +01:00
14063.misc Complement test image: capture logs from nginx (#14063) 2022-10-05 17:37:34 +01:00
14065.misc Always close _all_ ijson coroutines, even if doing so raises Exceptions (#14065) 2022-10-06 18:17:50 +00:00
14072.misc Catch BrokenPipeError from metrics server, and log as a warning (#14072) 2022-10-07 13:35:44 +01:00
14077.doc Add sample worker files for pusher and federation_sender (#14077) 2022-10-07 14:25:28 +01:00
14078.doc Improve the listener example on the metrics documentation (#14078) 2022-10-07 14:54:01 +01:00
14081.doc Document Google OpenID Connect email attribute (#14081) 2022-10-07 14:22:25 +00:00
14087.doc The changelog entry ending in a . or ! is not optional (#14087) 2022-10-06 17:11:32 +00:00
14089.bugfix Be more lenient in the oEmbed response parsing. (#14089) 2022-10-07 09:29:43 -04:00
14092.misc Parse SYNAPSE_ASYNC_IO_REACTOR env variable & log the reactor on startup (#14092) 2022-10-07 15:19:59 +01:00
14093.doc Fix broken links to README (#14093) 2022-10-06 22:49:51 +00:00
14097.misc Indicate what endpoint came back with a JSON response we were unable to parse (#14097) 2022-10-07 11:39:45 -05:00
14106.removal Remove support for the unstable dir flag on relations. (#14106) 2022-10-07 12:38:46 -04:00