mirror of
https://github.com/element-hq/synapse.git
synced 2024-12-21 12:14:29 +03:00
c897ac63e9
... when workers are unreachable, etc. Fixes https://github.com/element-hq/synapse/issues/17117. The general principle is just to make sure that we propagate any exceptions to the JsonResource, so that we return an error code to the sending server. That means that the sending server no longer considers the message safely sent, so it will retry later. In the issue, Erik mentions that an alternative solution would be to persist the to-device messages into a table so that they can be retried. This might be an improvement for performance, but even if we did that, we still need this mechanism, since we might be unable to reach the database. So, if we want to do that, it can be a later follow-up. --------- Co-authored-by: Erik Johnston <erik@matrix.org>
74 lines
2.6 KiB
Python
74 lines
2.6 KiB
Python
#
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
#
|
|
# Copyright 2020 The Matrix.org Foundation C.I.C.
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# See the GNU Affero General Public License for more details:
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
#
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
#
|
|
# [This file includes modifications made by New Vector Limited]
|
|
#
|
|
#
|
|
|
|
from synapse.api.constants import EduTypes
|
|
|
|
from tests import unittest
|
|
from tests.unittest import DEBUG, override_config
|
|
|
|
|
|
class RoomDirectoryFederationTests(unittest.FederatingHomeserverTestCase):
|
|
@override_config({"allow_public_rooms_over_federation": False})
|
|
def test_blocked_public_room_list_over_federation(self) -> None:
|
|
"""Test that unauthenticated requests to the public rooms directory 403 when
|
|
allow_public_rooms_over_federation is False.
|
|
"""
|
|
channel = self.make_signed_federation_request(
|
|
"GET",
|
|
"/_matrix/federation/v1/publicRooms",
|
|
)
|
|
self.assertEqual(403, channel.code)
|
|
|
|
@override_config({"allow_public_rooms_over_federation": True})
|
|
def test_open_public_room_list_over_federation(self) -> None:
|
|
"""Test that unauthenticated requests to the public rooms directory 200 when
|
|
allow_public_rooms_over_federation is True.
|
|
"""
|
|
channel = self.make_signed_federation_request(
|
|
"GET",
|
|
"/_matrix/federation/v1/publicRooms",
|
|
)
|
|
self.assertEqual(200, channel.code)
|
|
|
|
@DEBUG
|
|
def test_edu_debugging_doesnt_explode(self) -> None:
|
|
"""Sanity check incoming federation succeeds with `synapse.debug_8631` enabled.
|
|
|
|
Remove this when we strip out issue_8631_logger.
|
|
"""
|
|
channel = self.make_signed_federation_request(
|
|
"PUT",
|
|
"/_matrix/federation/v1/send/txn_id_1234/",
|
|
content={
|
|
"edus": [
|
|
{
|
|
"edu_type": EduTypes.DEVICE_LIST_UPDATE,
|
|
"content": {
|
|
"device_id": "QBUAZIFURK",
|
|
"stream_id": 0,
|
|
"user_id": "@user:id",
|
|
},
|
|
},
|
|
],
|
|
"pdus": [],
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code)
|