mirror of
https://github.com/element-hq/synapse.git
synced 2024-11-24 02:25:45 +03:00
81e0f57800
There is a bug with the `StreamChangeCache` where it would incorrectly return that all entities had changed if asked for entities changed *since* the earliest stream position. Note that for streams we use the inequalities: `$min_stream_id < stream_id <= $max_stream_id`, i.e. when we ask the stream change cache for all things that have changed since `$stream_id` we don't care for events that happened *at* `$stream_id`. Specifically: `_earliest_known_stream_pos` is the position at which we know that we'll have entries for all changes since that point, we can use the cache for any stream IDs that equal `_earliest_known_stream_pos`. `_earliest_known_stream_pos` is set in three places: - On startup we set it either to: - the current maximum stream ID, with not prefilled values; or - the minimum of the latest N values we pulled from the DB - When we evict items from the bottom, we set it to the stream ID of the evicted items. This was changed in https://github.com/matrix-org/synapse/pull/14435, but I think we were overly conservative there. --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| caches | ||
| __init__.py | ||
| test_async_helpers.py | ||
| test_batching_queue.py | ||
| test_check_dependencies.py | ||
| test_dict_cache.py | ||
| test_expiring_cache.py | ||
| test_file_consumer.py | ||
| test_itertools.py | ||
| test_linearizer.py | ||
| test_logcontext.py | ||
| test_logformatter.py | ||
| test_lrucache.py | ||
| test_macaroons.py | ||
| test_ratelimitutils.py | ||
| test_retryutils.py | ||
| test_rwlock.py | ||
| test_stream_change_cache.py | ||
| test_stringutils.py | ||
| test_task_scheduler.py | ||
| test_threepids.py | ||
| test_treecache.py | ||
| test_wheel_timer.py | ||