mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-11-25 19:15:51 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix resync remote devices on receive PDU in worker mode. (#7815)

Browse source 
The replication client requires that arguments are given as keyword
arguments, which was not done in this case. We also pull out the logic
so that we can catch and handle any exceptions raised, rather than
leaving them unhandled.
This commit is contained in:
Erik Johnston 2020-07-10 18:23:17 +01:00 committed by GitHub
parent e29c44340b
commit f1245dc3c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/7815.bugfix Normal file
View file

@ -0,0 +1 @@
Fix detection of out of sync remote device lists when receiving events from remote users.

21
synapse/handlers/federation.py
View file

@ -61,6 +61,7 @@ from synapse.logging.context import (
run_in_background, run_in_background,
) )
from synapse.logging.utils import log_function from synapse.logging.utils import log_function
from synapse.metrics.background_process_metrics import run_as_background_process
from synapse.replication.http.devices import ReplicationUserDevicesResyncRestServlet from synapse.replication.http.devices import ReplicationUserDevicesResyncRestServlet
from synapse.replication.http.federation import ( from synapse.replication.http.federation import (
ReplicationCleanRoomRestServlet, ReplicationCleanRoomRestServlet,
@ -789,15 +790,25 @@ class FederationHandler(BaseHandler):
resync = True resync = True
if resync: if resync:
await self.store.mark_remote_user_device_cache_as_stale(event.sender) run_as_background_process(
"resync_device_due_to_pdu", self._resync_device, event.sender
)
async def _resync_device(self, sender: str) -> None:
"""We have detected that the device list for the given user may be out
of sync, so we try and resync them.
"""
try:
await self.store.mark_remote_user_device_cache_as_stale(sender)
# Immediately attempt a resync in the background # Immediately attempt a resync in the background
if self.config.worker_app: if self.config.worker_app:
return run_in_background(self._user_device_resync, event.sender) await self._user_device_resync(user_id=sender)
else: else:
return run_in_background( await self._device_list_updater.user_device_resync(sender)
self._device_list_updater.user_device_resync, event.sender except Exception:
) logger.exception("Failed to resync device for %s", sender)
@log_function @log_function
async def backfill(self, dest, room_id, limit, extremities): async def backfill(self, dest, room_id, limit, extremities):