Review comments

This commit is contained in:
Erik Johnston 2020-03-24 16:00:54 +00:00
parent 2380e401e4
commit e4c5b1d9d6
3 changed files with 2 additions and 5 deletions

View file

@ -175,7 +175,8 @@ client (C):
#### POSITION (S) #### POSITION (S)
On receipt of a POSITION command clients should check if they have missed any On receipt of a POSITION command clients should check if they have missed any
updates, and if so then fetch them out of band. updates, and if so then fetch them out of band. Sent in response to a
REPLICATE command (but can happen at any time).
#### ERROR (S, C) #### ERROR (S, C)

View file

@ -648,7 +648,6 @@ class ClientReplicationStreamProtocol(BaseReplicationStreamProtocol):
# We've now caught up to position sent to us, notify handler. # We've now caught up to position sent to us, notify handler.
await self.handler.on_position(cmd.stream_name, cmd.token) await self.handler.on_position(cmd.stream_name, cmd.token)
# We're now up to date wit the stream
self.streams_connecting.discard(cmd.stream_name) self.streams_connecting.discard(cmd.stream_name)
if not self.streams_connecting: if not self.streams_connecting:
self.handler.finished_connecting() self.handler.finished_connecting()

View file

@ -105,9 +105,6 @@ class Stream(object):
to fetch. to fetch.
""" """
if from_token in ("NOW", "now"):
return [], upto_token, False
from_token = int(from_token) from_token = int(from_token)
if from_token == upto_token: if from_token == upto_token: