mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-12-20 02:24:54 +03:00
Code Issues Projects Releases Packages Wiki Activity

For user stats, handle other membership transitions properly.

Browse source 
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
This commit is contained in:
Olivier Wilkinson (reivilibre) 2019-08-27 14:17:04 +01:00
parent 99c88ac84e
commit dd8e6020d8
1 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
synapse/handlers/stats.py
View file

@ -217,10 +217,14 @@ class StatsHandler(StateDeltasHandler):
raise ValueError(err) raise ValueError(err)
user_id = state_key user_id = state_key
if self.is_mine_id(user_id) and membership in ( if self.is_mine_id(user_id):
Membership.JOIN, # this accounts for transitions like leave → ban and so on.
Membership.LEAVE, has_changed_joinedness = (
) and prev_membership != membership: (prev_membership == Membership.JOIN) !=
(membership == Membership.JOIN)
)
if has_changed_joinedness:
# update user_stats as it's one of our users # update user_stats as it's one of our users
public = yield self._is_public_room(room_id) public = yield self._is_public_room(room_id)