From ca4afad068b2d3b2498e69a65b481b31496646e4 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 9 Sep 2024 23:42:22 -0500 Subject: [PATCH] Be more precise --- synapse/storage/databases/main/events_bg_updates.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/synapse/storage/databases/main/events_bg_updates.py b/synapse/storage/databases/main/events_bg_updates.py index cd64d702ad..5b3c1b97d1 100644 --- a/synapse/storage/databases/main/events_bg_updates.py +++ b/synapse/storage/databases/main/events_bg_updates.py @@ -2166,7 +2166,7 @@ class EventsBackgroundUpdatesStore(StreamWorkerStore, StateDeltasStore, SQLBaseS ) in memberships_to_update_rows: # Sanity check that we're working on the same room for all of the rows # so the snapshot re-use logic can work properly (we need to process - # memberships in a room sequentially chronologically) + # memberships in a room sequentially by `stream_ordering` ascending) assert room_id == room_id_for_all_rows # We don't know how to handle `membership` values other than these. The @@ -2564,7 +2564,7 @@ class EventsBackgroundUpdatesStore(StreamWorkerStore, StateDeltasStore, SQLBaseS # We can batch process each room concurrently. # # In order for the snapshot re-use logic to work correctly, we need to process - # memberships in a room sequentially chronologically. + # memberships in a room sequentially by `stream_ordering` ascending. await concurrently_execute( _handle_memberships_to_update_rows_for_room, room_id_to_memberships_to_update_rows.values(),