mirror of
https://github.com/element-hq/synapse.git
synced 2024-11-22 01:25:44 +03:00
Annotations for user_erasure_store (#11313)
I'm not sure why this was excluded---it seemed to be passing for me. But it's easy enough to fixup.
This commit is contained in:
parent
6a605f4a77
commit
c99da2d079
3 changed files with 9 additions and 5 deletions
1
changelog.d/11313.misc
Normal file
1
changelog.d/11313.misc
Normal file
|
@ -0,0 +1 @@
|
|||
Add type hints to storage classes.
|
4
mypy.ini
4
mypy.ini
|
@ -53,7 +53,6 @@ exclude = (?x)
|
|||
|synapse/storage/databases/main/stats.py
|
||||
|synapse/storage/databases/main/transactions.py
|
||||
|synapse/storage/databases/main/user_directory.py
|
||||
|synapse/storage/databases/main/user_erasure_store.py
|
||||
|synapse/storage/schema/
|
||||
|
||||
|tests/api/test_auth.py
|
||||
|
@ -184,6 +183,9 @@ disallow_untyped_defs = True
|
|||
[mypy-synapse.storage.databases.main.room_batch]
|
||||
disallow_untyped_defs = True
|
||||
|
||||
[mypy-synapse.storage.databases.main.user_erasure_store]
|
||||
disallow_untyped_defs = True
|
||||
|
||||
[mypy-synapse.storage.util.*]
|
||||
disallow_untyped_defs = True
|
||||
|
||||
|
|
|
@ -14,11 +14,12 @@
|
|||
|
||||
from typing import Dict, Iterable
|
||||
|
||||
from synapse.storage._base import SQLBaseStore
|
||||
from synapse.storage.database import LoggingTransaction
|
||||
from synapse.storage.databases.main import CacheInvalidationWorkerStore
|
||||
from synapse.util.caches.descriptors import cached, cachedList
|
||||
|
||||
|
||||
class UserErasureWorkerStore(SQLBaseStore):
|
||||
class UserErasureWorkerStore(CacheInvalidationWorkerStore):
|
||||
@cached()
|
||||
async def is_user_erased(self, user_id: str) -> bool:
|
||||
"""
|
||||
|
@ -69,7 +70,7 @@ class UserErasureStore(UserErasureWorkerStore):
|
|||
user_id: full user_id to be erased
|
||||
"""
|
||||
|
||||
def f(txn):
|
||||
def f(txn: LoggingTransaction) -> None:
|
||||
# first check if they are already in the list
|
||||
txn.execute("SELECT 1 FROM erased_users WHERE user_id = ?", (user_id,))
|
||||
if txn.fetchone():
|
||||
|
@ -89,7 +90,7 @@ class UserErasureStore(UserErasureWorkerStore):
|
|||
user_id: full user_id to be un-erased
|
||||
"""
|
||||
|
||||
def f(txn):
|
||||
def f(txn: LoggingTransaction) -> None:
|
||||
# first check if they are already in the list
|
||||
txn.execute("SELECT 1 FROM erased_users WHERE user_id = ?", (user_id,))
|
||||
if not txn.fetchone():
|
||||
|
|
Loading…
Reference in a new issue