mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-11-23 10:05:55 +03:00
Code Issues Projects Releases Packages Wiki Activity

Don't log stack trace when client has gone away during media download (#4738)

Browse source 
* Don't log stack trace when client has gone away during media download

* Newsfile

* Fixup newsfile
This commit is contained in:
Erik Johnston 2019-02-25 19:17:22 +00:00 committed by Amber Brown
parent 641c409e4e
commit 899a119c2b
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/4738.misc Normal file
View file

@ -0,0 +1 @@
Cleanup request exception logging.

7
synapse/rest/media/v1/_base.py
View file

@ -133,8 +133,15 @@ def respond_with_responder(request, responder, media_type, file_size, upload_nam
logger.debug("Responding to media request with responder %s") logger.debug("Responding to media request with responder %s")
add_file_headers(request, media_type, file_size, upload_name) add_file_headers(request, media_type, file_size, upload_name)
try:
with responder: with responder:
yield responder.write_to_consumer(request) yield responder.write_to_consumer(request)
except Exception as e:
# The majority of the time this will be due to the client having gone
# away. Unfortunately, Twisted simply throws a generic exception at us
# in that case.
logger.warning("Failed to write to consumer: %s %s", type(e), e)
finish_request(request) finish_request(request)