mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-11-29 07:28:55 +03:00
Code Issues Projects Releases Packages Wiki Activity

Do not keep going if there are 5 back-to-back background update failures. (#12781)

Browse source
This commit is contained in:
reivilibre 2022-05-18 13:57:59 +00:00 committed by GitHub
parent df4963548b
commit 635f0d916b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/12781.misc Normal file
View file

@ -0,0 +1 @@
Do not keep going if there are 5 back-to-back background update failures.

8
synapse/storage/background_updates.py
View file

@ -282,12 +282,20 @@ class BackgroundUpdater:
self._running = True self._running = True
back_to_back_failures = 0
try: try:
logger.info("Starting background schema updates") logger.info("Starting background schema updates")
while self.enabled: while self.enabled:
try: try:
result = await self.do_next_background_update(sleep) result = await self.do_next_background_update(sleep)
back_to_back_failures = 0
except Exception: except Exception:
back_to_back_failures += 1
if back_to_back_failures >= 5:
raise RuntimeError(
"5 back-to-back background update failures; aborting."
)
logger.exception("Error doing update") logger.exception("Error doing update")
else: else:
if result: if result: