mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-11-22 17:46:08 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix a potential bug of UnboundLocalError (#8329)

Browse source 
Replaced with less buggier control flow
This commit is contained in:
Jonathan de Jong 2020-09-17 12:54:56 +02:00 committed by GitHub
parent a3f124b821
commit 53284c425e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/8329.bugfix Normal file
View file

@ -0,0 +1 @@
Fix UnboundLocalError from occuring when appservices send malformed register request.

13
synapse/rest/client/v2_alpha/register.py
View file

@ -431,11 +431,14 @@ class RegisterRestServlet(RestServlet):
access_token = self.auth.get_access_token_from_request(request)
if isinstance(desired_username, str):
result = await self._do_appservice_registration(
desired_username, access_token, body
)
return 200, result # we throw for non 200 responses
if not isinstance(desired_username, str):
raise SynapseError(400, "Desired Username is missing or not a string")
result = await self._do_appservice_registration(
desired_username, access_token, body
)
return 200, result
# == Normal User Registration == (everyone else)
if not self._registration_enabled: