mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-11-29 15:39:00 +03:00
Code Issues Projects Releases Packages Wiki Activity

Also remove yield from within lock in the other generator

Browse source
This commit is contained in:
Erik Johnston 2015-04-29 19:17:00 +01:00
parent d2d61a8288
commit 50f96f256f
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
synapse/storage/util/id_generators.py
View file

@ -30,15 +30,13 @@ class IdGenerator(object):
@defer.inlineCallbacks @defer.inlineCallbacks
def get_next(self): def get_next(self):
with self._lock: if self._next_id is None:
if not self._next_id: yield self.store.runInteraction(
res = yield self.store._execute_and_decode(
"IdGenerator_%s" % (self.table,), "IdGenerator_%s" % (self.table,),
"SELECT MAX(%s) as mx FROM %s" % (self.column, self.table,) self.get_next_txn,
) )
self._next_id = (res and res[0] and res[0]["mx"]) or 1 with self._lock:
i = self._next_id i = self._next_id
self._next_id += 1 self._next_id += 1
defer.returnValue(i) defer.returnValue(i)