mirrors/synapse
1
0
Fork 0
mirror of https://github.com/element-hq/synapse.git synced 2024-12-20 10:55:09 +03:00
Code Issues Projects Releases Packages Wiki Activity

Remove clean-up handler and replace with no-op as not currently needed.

Browse source 
needed.

Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
This commit is contained in:
Olivier Wilkinson (reivilibre) 2019-08-13 15:49:24 +01:00
parent 2da4b41c63
commit 0e6f700a13
1 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
synapse/storage/stats.py
View file

@ -73,8 +73,11 @@ class StatsStore(StateDeltasStore):
self.register_background_update_handler( self.register_background_update_handler(
"populate_stats_process_users", self._populate_stats_process_users "populate_stats_process_users", self._populate_stats_process_users
) )
self.register_background_update_handler( # we no longer need to perform clean-up, but we will give ourselves
"populate_stats_cleanup", self._populate_stats_cleanup # the potential to reintroduce it in the future – so documentation
# will still encourage the use of this no-op handler.
self.register_noop_background_update(
"populate_stats_cleanup"
) )
def quantise_stats_time(self, ts): def quantise_stats_time(self, ts):
@ -217,17 +220,6 @@ class StatsStore(StateDeltasStore):
yield self._end_background_update("populate_stats_prepare") yield self._end_background_update("populate_stats_prepare")
defer.returnValue(1) defer.returnValue(1)
@defer.inlineCallbacks
def _populate_stats_cleanup(self, progress, batch_size):
"""
This is a background update which cleans up after statistics regeneration.
"""
# TODO is there really no clean-up to be done?
# TODO if not self.stats_enabled … cleanup.
yield self._end_background_update("populate_stats_cleanup")
defer.returnValue(1)
@defer.inlineCallbacks @defer.inlineCallbacks
def _populate_stats_process_users(self, progress, batch_size): def _populate_stats_process_users(self, progress, batch_size):
""" """