Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
#
|
2023-11-21 23:29:58 +03:00
|
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
|
|
#
|
2024-01-23 14:26:48 +03:00
|
|
|
# Copyright 2021 The Matrix.org Foundation C.I.C.
|
|
|
|
# Copyright 2016 OpenMarket Ltd
|
2023-11-21 23:29:58 +03:00
|
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
|
|
#
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU Affero General Public License as
|
|
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
|
|
# License, or (at your option) any later version.
|
|
|
|
#
|
|
|
|
# See the GNU Affero General Public License for more details:
|
|
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
|
|
#
|
|
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
|
|
#
|
|
|
|
# [This file includes modifications made by New Vector Limited]
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
#
|
|
|
|
#
|
2024-10-07 11:46:51 +03:00
|
|
|
import tempfile
|
|
|
|
from typing import Callable
|
|
|
|
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
import yaml
|
2024-10-07 11:46:51 +03:00
|
|
|
from parameterized import parameterized
|
2018-07-09 09:09:20 +03:00
|
|
|
|
2021-04-06 15:48:22 +03:00
|
|
|
from synapse.config import ConfigError
|
2024-10-07 11:46:51 +03:00
|
|
|
from synapse.config._base import RootConfig
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
from synapse.config.homeserver import HomeServerConfig
|
2018-07-09 09:09:20 +03:00
|
|
|
|
2021-10-22 13:00:52 +03:00
|
|
|
from tests.config.utils import ConfigFileTestCase
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
|
2024-10-07 11:46:51 +03:00
|
|
|
try:
|
|
|
|
import hiredis
|
|
|
|
except ImportError:
|
|
|
|
hiredis = None # type: ignore
|
|
|
|
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
|
2021-10-22 13:00:52 +03:00
|
|
|
class ConfigLoadingFileTestCase(ConfigFileTestCase):
|
2022-12-16 16:53:28 +03:00
|
|
|
def test_load_fails_if_server_name_missing(self) -> None:
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
self.generate_config_and_remove_lines_containing("server_name")
|
2021-04-06 15:48:22 +03:00
|
|
|
with self.assertRaises(ConfigError):
|
2021-10-22 13:00:52 +03:00
|
|
|
HomeServerConfig.load_config("", ["-c", self.config_file])
|
2021-04-06 15:48:22 +03:00
|
|
|
with self.assertRaises(ConfigError):
|
2021-10-22 13:00:52 +03:00
|
|
|
HomeServerConfig.load_or_generate_config("", ["-c", self.config_file])
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
|
2022-12-16 16:53:28 +03:00
|
|
|
def test_generates_and_loads_macaroon_secret_key(self) -> None:
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
self.generate_config()
|
|
|
|
|
2021-10-22 13:00:52 +03:00
|
|
|
with open(self.config_file) as f:
|
2019-03-22 13:20:17 +03:00
|
|
|
raw = yaml.safe_load(f)
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
self.assertIn("macaroon_secret_key", raw)
|
|
|
|
|
2021-10-22 13:00:52 +03:00
|
|
|
config = HomeServerConfig.load_config("", ["-c", self.config_file])
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
self.assertTrue(
|
2021-10-06 17:47:41 +03:00
|
|
|
hasattr(config.key, "macaroon_secret_key"),
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
"Want config to have attr macaroon_secret_key",
|
|
|
|
)
|
2021-09-23 19:03:01 +03:00
|
|
|
if len(config.key.macaroon_secret_key) < 5:
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
self.fail(
|
|
|
|
"Want macaroon secret key to be string of at least length 5,"
|
2021-09-23 19:03:01 +03:00
|
|
|
"was: %r" % (config.key.macaroon_secret_key,)
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
)
|
|
|
|
|
2021-11-23 18:21:19 +03:00
|
|
|
config2 = HomeServerConfig.load_or_generate_config("", ["-c", self.config_file])
|
|
|
|
assert config2 is not None
|
2016-06-09 20:50:38 +03:00
|
|
|
self.assertTrue(
|
2021-11-23 18:21:19 +03:00
|
|
|
hasattr(config2.key, "macaroon_secret_key"),
|
2016-06-09 20:50:38 +03:00
|
|
|
"Want config to have attr macaroon_secret_key",
|
|
|
|
)
|
2021-11-23 18:21:19 +03:00
|
|
|
if len(config2.key.macaroon_secret_key) < 5:
|
2016-06-09 20:50:38 +03:00
|
|
|
self.fail(
|
|
|
|
"Want macaroon secret key to be string of at least length 5,"
|
2021-11-23 18:21:19 +03:00
|
|
|
"was: %r" % (config2.key.macaroon_secret_key,)
|
2016-06-09 20:50:38 +03:00
|
|
|
)
|
|
|
|
|
2022-12-16 16:53:28 +03:00
|
|
|
def test_load_succeeds_if_macaroon_secret_key_missing(self) -> None:
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
self.generate_config_and_remove_lines_containing("macaroon")
|
2021-10-22 13:00:52 +03:00
|
|
|
config1 = HomeServerConfig.load_config("", ["-c", self.config_file])
|
|
|
|
config2 = HomeServerConfig.load_config("", ["-c", self.config_file])
|
|
|
|
config3 = HomeServerConfig.load_or_generate_config("", ["-c", self.config_file])
|
2021-11-23 18:21:19 +03:00
|
|
|
assert config1 is not None
|
|
|
|
assert config2 is not None
|
|
|
|
assert config3 is not None
|
2021-10-06 17:47:41 +03:00
|
|
|
self.assertEqual(
|
|
|
|
config1.key.macaroon_secret_key, config2.key.macaroon_secret_key
|
|
|
|
)
|
|
|
|
self.assertEqual(
|
|
|
|
config1.key.macaroon_secret_key, config3.key.macaroon_secret_key
|
|
|
|
)
|
Error if macaroon key is missing from config
Currently we store all access tokens in the DB, and fall back to that
check if we can't validate the macaroon, so our fallback works here, but
for guests, their macaroons don't get persisted, so we don't get to
find them in the database. Each restart, we generate a new ephemeral
key, so guests lose access after each server restart.
I tried to fix up the config stuff to be less insane, but gave up, so
instead I bolt on yet another piece of custom one-off insanity.
Also, add some basic tests for config generation and loading.
2016-02-05 04:58:23 +03:00
|
|
|
|
2022-12-16 16:53:28 +03:00
|
|
|
def test_disable_registration(self) -> None:
|
2016-02-22 19:01:29 +03:00
|
|
|
self.generate_config()
|
|
|
|
self.add_lines_to_config(
|
|
|
|
["enable_registration: true", "disable_registration: true"]
|
|
|
|
)
|
|
|
|
# Check that disable_registration clobbers enable_registration.
|
2021-10-22 13:00:52 +03:00
|
|
|
config = HomeServerConfig.load_config("", ["-c", self.config_file])
|
2021-10-04 14:18:54 +03:00
|
|
|
self.assertFalse(config.registration.enable_registration)
|
2016-02-22 19:01:29 +03:00
|
|
|
|
2021-11-23 18:21:19 +03:00
|
|
|
config2 = HomeServerConfig.load_or_generate_config("", ["-c", self.config_file])
|
|
|
|
assert config2 is not None
|
|
|
|
self.assertFalse(config2.registration.enable_registration)
|
2016-06-09 20:50:38 +03:00
|
|
|
|
2016-02-22 19:01:29 +03:00
|
|
|
# Check that either config value is clobbered by the command line.
|
2021-11-23 18:21:19 +03:00
|
|
|
config3 = HomeServerConfig.load_or_generate_config(
|
2021-10-22 13:00:52 +03:00
|
|
|
"", ["-c", self.config_file, "--enable-registration"]
|
2016-02-22 19:01:29 +03:00
|
|
|
)
|
2021-11-23 18:21:19 +03:00
|
|
|
assert config3 is not None
|
|
|
|
self.assertTrue(config3.registration.enable_registration)
|
2016-02-22 19:01:29 +03:00
|
|
|
|
2022-12-16 16:53:28 +03:00
|
|
|
def test_stats_enabled(self) -> None:
|
2019-09-06 18:45:51 +03:00
|
|
|
self.generate_config_and_remove_lines_containing("enable_metrics")
|
|
|
|
self.add_lines_to_config(["enable_metrics: true"])
|
|
|
|
|
|
|
|
# The default Metrics Flags are off by default.
|
2021-10-22 13:00:52 +03:00
|
|
|
config = HomeServerConfig.load_config("", ["-c", self.config_file])
|
2021-09-23 19:03:01 +03:00
|
|
|
self.assertFalse(config.metrics.metrics_flags.known_servers)
|
2021-11-18 21:56:32 +03:00
|
|
|
|
2022-12-16 16:53:28 +03:00
|
|
|
def test_depreciated_identity_server_flag_throws_error(self) -> None:
|
2021-11-18 21:56:32 +03:00
|
|
|
self.generate_config()
|
|
|
|
# Needed to ensure that actual key/value pair added below don't end up on a line with a comment
|
|
|
|
self.add_lines_to_config([" "])
|
|
|
|
# Check that presence of "trust_identity_server_for_password" throws config error
|
|
|
|
self.add_lines_to_config(["trust_identity_server_for_password_resets: true"])
|
|
|
|
with self.assertRaises(ConfigError):
|
|
|
|
HomeServerConfig.load_config("", ["-c", self.config_file])
|
2024-10-07 11:46:51 +03:00
|
|
|
|
|
|
|
@parameterized.expand(
|
|
|
|
[
|
|
|
|
"turn_shared_secret_path: /does/not/exist",
|
|
|
|
"registration_shared_secret_path: /does/not/exist",
|
|
|
|
*["redis:\n enabled: true\n password_path: /does/not/exist"]
|
|
|
|
* (hiredis is not None),
|
|
|
|
]
|
|
|
|
)
|
|
|
|
def test_secret_files_missing(self, config_str: str) -> None:
|
|
|
|
self.generate_config()
|
|
|
|
self.add_lines_to_config(["", config_str])
|
|
|
|
|
|
|
|
with self.assertRaises(ConfigError):
|
|
|
|
HomeServerConfig.load_config("", ["-c", self.config_file])
|
|
|
|
|
|
|
|
@parameterized.expand(
|
|
|
|
[
|
|
|
|
(
|
|
|
|
"turn_shared_secret_path: {}",
|
|
|
|
lambda c: c.voip.turn_shared_secret,
|
|
|
|
),
|
|
|
|
(
|
|
|
|
"registration_shared_secret_path: {}",
|
|
|
|
lambda c: c.registration.registration_shared_secret,
|
|
|
|
),
|
|
|
|
*[
|
|
|
|
(
|
|
|
|
"redis:\n enabled: true\n password_path: {}",
|
|
|
|
lambda c: c.redis.redis_password,
|
|
|
|
)
|
|
|
|
]
|
|
|
|
* (hiredis is not None),
|
|
|
|
]
|
|
|
|
)
|
|
|
|
def test_secret_files_existing(
|
|
|
|
self, config_line: str, get_secret: Callable[[RootConfig], str]
|
|
|
|
) -> None:
|
|
|
|
self.generate_config_and_remove_lines_containing("registration_shared_secret")
|
|
|
|
with tempfile.NamedTemporaryFile(buffering=0) as secret_file:
|
|
|
|
secret_file.write(b"53C237")
|
|
|
|
|
|
|
|
self.add_lines_to_config(["", config_line.format(secret_file.name)])
|
|
|
|
config = HomeServerConfig.load_config("", ["-c", self.config_file])
|
|
|
|
|
|
|
|
self.assertEqual(get_secret(config), "53C237")
|