2019-03-21 18:10:21 +03:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2018, 2019 New Vector Ltd
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
2018-08-10 17:12:59 +03:00
|
|
|
from mock import Mock
|
|
|
|
|
|
|
|
from twisted.internet import defer
|
|
|
|
|
2019-10-24 13:48:46 +03:00
|
|
|
from synapse.api.constants import EventTypes, LimitBlockingTypes, ServerNoticeMsgType
|
2018-08-17 17:21:34 +03:00
|
|
|
from synapse.api.errors import ResourceLimitError
|
2018-08-10 17:12:59 +03:00
|
|
|
from synapse.server_notices.resource_limits_server_notices import (
|
|
|
|
ResourceLimitsServerNotices,
|
|
|
|
)
|
|
|
|
|
|
|
|
from tests import unittest
|
|
|
|
|
|
|
|
|
2019-03-21 18:10:21 +03:00
|
|
|
class TestResourceLimitsServerNotices(unittest.HomeserverTestCase):
|
|
|
|
def make_homeserver(self, reactor, clock):
|
|
|
|
hs_config = self.default_config("test")
|
2019-05-13 23:01:14 +03:00
|
|
|
hs_config["server_notices"] = {
|
|
|
|
"system_mxid_localpart": "server",
|
|
|
|
"system_mxid_display_name": "test display name",
|
|
|
|
"system_mxid_avatar_url": None,
|
|
|
|
"room_name": "Server Notices",
|
|
|
|
}
|
2019-03-19 14:06:56 +03:00
|
|
|
|
2019-07-30 10:25:02 +03:00
|
|
|
hs = self.setup_test_homeserver(config=hs_config)
|
2019-03-21 18:10:21 +03:00
|
|
|
return hs
|
|
|
|
|
|
|
|
def prepare(self, reactor, clock, hs):
|
2018-08-10 17:12:59 +03:00
|
|
|
self.server_notices_sender = self.hs.get_server_notices_sender()
|
|
|
|
|
|
|
|
# relying on [1] is far from ideal, but the only case where
|
|
|
|
# ResourceLimitsServerNotices class needs to be isolated is this test,
|
|
|
|
# general code should never have a reason to do so ...
|
|
|
|
self._rlsn = self.server_notices_sender._server_notices[1]
|
|
|
|
if not isinstance(self._rlsn, ResourceLimitsServerNotices):
|
|
|
|
raise Exception("Failed to find reference to ResourceLimitsServerNotices")
|
|
|
|
|
|
|
|
self._rlsn._store.user_last_seen_monthly_active = Mock(
|
|
|
|
return_value=defer.succeed(1000)
|
|
|
|
)
|
|
|
|
self._send_notice = self._rlsn._server_notices_manager.send_notice
|
|
|
|
self._rlsn._server_notices_manager.send_notice = Mock()
|
2018-08-16 16:53:35 +03:00
|
|
|
self._rlsn._state.get_current_state = Mock(return_value=defer.succeed(None))
|
|
|
|
self._rlsn._store.get_events = Mock(return_value=defer.succeed({}))
|
|
|
|
|
2018-08-10 17:12:59 +03:00
|
|
|
self._send_notice = self._rlsn._server_notices_manager.send_notice
|
|
|
|
|
2018-08-17 17:21:34 +03:00
|
|
|
self.hs.config.limit_usage_by_mau = True
|
2018-08-16 16:53:35 +03:00
|
|
|
self.user_id = "@user_id:test"
|
|
|
|
|
2018-08-17 17:21:34 +03:00
|
|
|
# self.server_notices_mxid = "@server:test"
|
|
|
|
# self.server_notices_mxid_display_name = None
|
|
|
|
# self.server_notices_mxid_avatar_url = None
|
|
|
|
# self.server_notices_room_name = "Server Notices"
|
2018-08-16 16:53:35 +03:00
|
|
|
|
|
|
|
self._rlsn._server_notices_manager.get_notice_room_for_user = Mock(
|
|
|
|
returnValue=""
|
|
|
|
)
|
2018-08-16 19:02:04 +03:00
|
|
|
self._rlsn._store.add_tag_to_room = Mock()
|
2018-08-24 18:22:37 +03:00
|
|
|
self._rlsn._store.get_tags_for_room = Mock(return_value={})
|
2018-08-24 18:51:27 +03:00
|
|
|
self.hs.config.admin_contact = "mailto:user@test.com"
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
def test_maybe_send_server_notice_to_user_flag_off(self):
|
|
|
|
"""Tests cases where the flags indicate nothing to do"""
|
|
|
|
# test hs disabled case
|
2018-08-17 17:21:34 +03:00
|
|
|
self.hs.config.hs_disabled = True
|
2018-08-10 17:12:59 +03:00
|
|
|
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
self._send_notice.assert_not_called()
|
|
|
|
# Test when mau limiting disabled
|
2018-08-17 17:21:34 +03:00
|
|
|
self.hs.config.hs_disabled = False
|
2019-05-13 23:01:14 +03:00
|
|
|
self.hs.config.limit_usage_by_mau = False
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
self._send_notice.assert_not_called()
|
|
|
|
|
|
|
|
def test_maybe_send_server_notice_to_user_remove_blocked_notice(self):
|
|
|
|
"""Test when user has blocked notice, but should have it removed"""
|
|
|
|
|
2018-08-17 17:21:34 +03:00
|
|
|
self._rlsn._auth.check_auth_blocking = Mock()
|
2018-08-22 19:00:29 +03:00
|
|
|
mock_event = Mock(
|
2018-09-06 19:58:18 +03:00
|
|
|
type=EventTypes.Message, content={"msgtype": ServerNoticeMsgType}
|
|
|
|
)
|
|
|
|
self._rlsn._store.get_events = Mock(
|
|
|
|
return_value=defer.succeed({"123": mock_event})
|
2018-08-22 19:00:29 +03:00
|
|
|
)
|
2018-08-10 17:12:59 +03:00
|
|
|
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-16 16:53:35 +03:00
|
|
|
# Would be better to check the content, but once == remove blocking event
|
|
|
|
self._send_notice.assert_called_once()
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
def test_maybe_send_server_notice_to_user_remove_blocked_notice_noop(self):
|
2019-03-21 18:10:21 +03:00
|
|
|
"""
|
|
|
|
Test when user has blocked notice, but notice ought to be there (NOOP)
|
|
|
|
"""
|
2018-08-17 17:21:34 +03:00
|
|
|
self._rlsn._auth.check_auth_blocking = Mock(
|
2019-06-20 12:32:02 +03:00
|
|
|
side_effect=ResourceLimitError(403, "foo")
|
2018-08-10 17:12:59 +03:00
|
|
|
)
|
|
|
|
|
2018-08-22 19:00:29 +03:00
|
|
|
mock_event = Mock(
|
2018-09-06 19:58:18 +03:00
|
|
|
type=EventTypes.Message, content={"msgtype": ServerNoticeMsgType}
|
|
|
|
)
|
|
|
|
self._rlsn._store.get_events = Mock(
|
|
|
|
return_value=defer.succeed({"123": mock_event})
|
2018-08-22 19:00:29 +03:00
|
|
|
)
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
self._send_notice.assert_not_called()
|
|
|
|
|
|
|
|
def test_maybe_send_server_notice_to_user_add_blocked_notice(self):
|
2019-03-21 18:10:21 +03:00
|
|
|
"""
|
|
|
|
Test when user does not have blocked notice, but should have one
|
|
|
|
"""
|
2018-08-10 17:12:59 +03:00
|
|
|
|
2018-08-17 17:21:34 +03:00
|
|
|
self._rlsn._auth.check_auth_blocking = Mock(
|
2019-06-20 12:32:02 +03:00
|
|
|
side_effect=ResourceLimitError(403, "foo")
|
2018-08-17 17:21:34 +03:00
|
|
|
)
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-10 17:12:59 +03:00
|
|
|
|
2018-08-16 16:53:35 +03:00
|
|
|
# Would be better to check contents, but 2 calls == set blocking event
|
2019-10-24 13:48:46 +03:00
|
|
|
self.assertEqual(self._send_notice.call_count, 2)
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
def test_maybe_send_server_notice_to_user_add_blocked_notice_noop(self):
|
2019-03-21 18:10:21 +03:00
|
|
|
"""
|
|
|
|
Test when user does not have blocked notice, nor should they (NOOP)
|
|
|
|
"""
|
2018-08-17 17:21:34 +03:00
|
|
|
self._rlsn._auth.check_auth_blocking = Mock()
|
2018-08-10 17:12:59 +03:00
|
|
|
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
self._send_notice.assert_not_called()
|
|
|
|
|
|
|
|
def test_maybe_send_server_notice_to_user_not_in_mau_cohort(self):
|
2019-03-21 18:10:21 +03:00
|
|
|
"""
|
|
|
|
Test when user is not part of the MAU cohort - this should not ever
|
2018-08-10 17:12:59 +03:00
|
|
|
happen - but ...
|
|
|
|
"""
|
2018-08-17 17:21:34 +03:00
|
|
|
self._rlsn._auth.check_auth_blocking = Mock()
|
2018-08-10 17:12:59 +03:00
|
|
|
self._rlsn._store.user_last_seen_monthly_active = Mock(
|
|
|
|
return_value=defer.succeed(None)
|
|
|
|
)
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-10 17:12:59 +03:00
|
|
|
|
|
|
|
self._send_notice.assert_not_called()
|
2018-08-23 18:20:51 +03:00
|
|
|
|
2019-10-24 13:48:46 +03:00
|
|
|
def test_maybe_send_server_notice_when_alerting_suppressed_room_unblocked(self):
|
|
|
|
"""
|
|
|
|
Test that when server is over MAU limit and alerting is suppressed, then
|
|
|
|
an alert message is not sent into the room
|
|
|
|
"""
|
|
|
|
self.hs.config.mau_limit_alerting = False
|
|
|
|
self._rlsn._auth.check_auth_blocking = Mock(
|
|
|
|
side_effect=ResourceLimitError(
|
|
|
|
403, "foo", limit_type=LimitBlockingTypes.MONTHLY_ACTIVE_USER
|
|
|
|
)
|
|
|
|
)
|
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
|
|
|
|
|
|
|
self.assertTrue(self._send_notice.call_count == 0)
|
|
|
|
|
|
|
|
def test_check_hs_disabled_unaffected_by_mau_alert_suppression(self):
|
|
|
|
"""
|
|
|
|
Test that when a server is disabled, that MAU limit alerting is ignored.
|
|
|
|
"""
|
|
|
|
self.hs.config.mau_limit_alerting = False
|
|
|
|
self._rlsn._auth.check_auth_blocking = Mock(
|
|
|
|
side_effect=ResourceLimitError(
|
|
|
|
403, "foo", limit_type=LimitBlockingTypes.HS_DISABLED
|
|
|
|
)
|
|
|
|
)
|
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
|
|
|
|
|
|
|
# Would be better to check contents, but 2 calls == set blocking event
|
|
|
|
self.assertEqual(self._send_notice.call_count, 2)
|
|
|
|
|
|
|
|
def test_maybe_send_server_notice_when_alerting_suppressed_room_blocked(self):
|
|
|
|
"""
|
|
|
|
When the room is already in a blocked state, test that when alerting
|
|
|
|
is suppressed that the room is returned to an unblocked state.
|
|
|
|
"""
|
|
|
|
self.hs.config.mau_limit_alerting = False
|
|
|
|
self._rlsn._auth.check_auth_blocking = Mock(
|
|
|
|
side_effect=ResourceLimitError(
|
|
|
|
403, "foo", limit_type=LimitBlockingTypes.MONTHLY_ACTIVE_USER
|
|
|
|
)
|
|
|
|
)
|
|
|
|
self._rlsn._server_notices_manager.__is_room_currently_blocked = Mock(
|
|
|
|
return_value=defer.succeed((True, []))
|
|
|
|
)
|
|
|
|
|
|
|
|
mock_event = Mock(
|
|
|
|
type=EventTypes.Message, content={"msgtype": ServerNoticeMsgType}
|
|
|
|
)
|
|
|
|
self._rlsn._store.get_events = Mock(
|
|
|
|
return_value=defer.succeed({"123": mock_event})
|
|
|
|
)
|
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
|
|
|
|
|
|
|
self._send_notice.assert_called_once()
|
|
|
|
|
2018-08-23 18:20:51 +03:00
|
|
|
|
2019-03-21 18:10:21 +03:00
|
|
|
class TestResourceLimitsServerNoticesWithRealRooms(unittest.HomeserverTestCase):
|
|
|
|
def prepare(self, reactor, clock, hs):
|
2018-08-23 18:20:51 +03:00
|
|
|
self.store = self.hs.get_datastore()
|
|
|
|
self.server_notices_sender = self.hs.get_server_notices_sender()
|
|
|
|
self.server_notices_manager = self.hs.get_server_notices_manager()
|
|
|
|
self.event_source = self.hs.get_event_sources()
|
|
|
|
|
|
|
|
# relying on [1] is far from ideal, but the only case where
|
|
|
|
# ResourceLimitsServerNotices class needs to be isolated is this test,
|
|
|
|
# general code should never have a reason to do so ...
|
|
|
|
self._rlsn = self.server_notices_sender._server_notices[1]
|
|
|
|
if not isinstance(self._rlsn, ResourceLimitsServerNotices):
|
|
|
|
raise Exception("Failed to find reference to ResourceLimitsServerNotices")
|
|
|
|
|
|
|
|
self.hs.config.limit_usage_by_mau = True
|
|
|
|
self.hs.config.hs_disabled = False
|
|
|
|
self.hs.config.max_mau_value = 5
|
|
|
|
self.hs.config.server_notices_mxid = "@server:test"
|
|
|
|
self.hs.config.server_notices_mxid_display_name = None
|
|
|
|
self.hs.config.server_notices_mxid_avatar_url = None
|
|
|
|
self.hs.config.server_notices_room_name = "Test Server Notice Room"
|
|
|
|
|
|
|
|
self.user_id = "@user_id:test"
|
|
|
|
|
2018-08-24 18:51:27 +03:00
|
|
|
self.hs.config.admin_contact = "mailto:user@test.com"
|
2018-08-23 18:20:51 +03:00
|
|
|
|
|
|
|
def test_server_notice_only_sent_once(self):
|
2018-09-06 19:58:18 +03:00
|
|
|
self.store.get_monthly_active_count = Mock(return_value=1000)
|
2018-08-23 18:20:51 +03:00
|
|
|
|
2018-09-06 19:58:18 +03:00
|
|
|
self.store.user_last_seen_monthly_active = Mock(return_value=1000)
|
2018-08-23 18:20:51 +03:00
|
|
|
|
|
|
|
# Call the function multiple times to ensure we only send the notice once
|
2019-03-21 18:10:21 +03:00
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
|
|
|
self.get_success(self._rlsn.maybe_send_server_notice_to_user(self.user_id))
|
2018-08-23 18:20:51 +03:00
|
|
|
|
|
|
|
# Now lets get the last load of messages in the service notice room and
|
|
|
|
# check that there is only one server notice
|
2019-03-21 18:10:21 +03:00
|
|
|
room_id = self.get_success(
|
|
|
|
self.server_notices_manager.get_notice_room_for_user(self.user_id)
|
2018-08-23 18:20:51 +03:00
|
|
|
)
|
|
|
|
|
2019-03-21 18:10:21 +03:00
|
|
|
token = self.get_success(self.event_source.get_current_token())
|
|
|
|
events, _ = self.get_success(
|
|
|
|
self.store.get_recent_events_for_room(
|
|
|
|
room_id, limit=100, end_token=token.room_key
|
|
|
|
)
|
2018-08-23 18:20:51 +03:00
|
|
|
)
|
|
|
|
|
|
|
|
count = 0
|
|
|
|
for event in events:
|
|
|
|
if event.type != EventTypes.Message:
|
|
|
|
continue
|
|
|
|
if event.content.get("msgtype") != ServerNoticeMsgType:
|
|
|
|
continue
|
|
|
|
|
|
|
|
count += 1
|
|
|
|
|
|
|
|
self.assertEqual(count, 1)
|