2018-05-09 16:40:18 +03:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2018 New Vector Ltd
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
|
2019-03-18 18:41:38 +03:00
|
|
|
import json
|
|
|
|
|
2018-05-09 16:40:18 +03:00
|
|
|
from synapse.config._base import ConfigError
|
2019-03-18 18:41:38 +03:00
|
|
|
from synapse.rest.client.v1 import admin, login, room
|
2018-05-09 16:40:18 +03:00
|
|
|
from synapse.rulecheck.domain_rule_checker import DomainRuleChecker
|
|
|
|
|
2019-03-15 15:00:23 +03:00
|
|
|
from tests import unittest
|
2019-03-18 18:41:38 +03:00
|
|
|
from tests.server import make_request, render
|
2019-03-15 15:00:23 +03:00
|
|
|
|
2018-05-09 16:40:18 +03:00
|
|
|
|
|
|
|
class DomainRuleCheckerTestCase(unittest.TestCase):
|
|
|
|
def test_allowed(self):
|
|
|
|
config = {
|
2018-05-09 17:11:19 +03:00
|
|
|
"default": False,
|
|
|
|
"domain_mapping": {
|
|
|
|
"source_one": ["target_one", "target_two"],
|
2019-03-18 17:23:46 +03:00
|
|
|
"source_two": ["target_two"],
|
|
|
|
},
|
2018-05-09 16:40:18 +03:00
|
|
|
}
|
|
|
|
check = DomainRuleChecker(config)
|
2019-03-18 17:23:46 +03:00
|
|
|
self.assertTrue(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite(
|
|
|
|
"test:source_one", "test:target_one", None, "room", False,
|
|
|
|
)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
|
|
|
self.assertTrue(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_one", "test:target_two", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
|
|
|
self.assertTrue(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_two", "test:target_two", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
2018-05-09 16:40:18 +03:00
|
|
|
|
|
|
|
def test_disallowed(self):
|
|
|
|
config = {
|
|
|
|
"default": True,
|
|
|
|
"domain_mapping": {
|
2018-05-09 17:11:19 +03:00
|
|
|
"source_one": ["target_one", "target_two"],
|
2018-05-11 14:47:58 +03:00
|
|
|
"source_two": ["target_two"],
|
2019-03-18 17:23:46 +03:00
|
|
|
"source_four": [],
|
|
|
|
},
|
2018-05-09 16:40:18 +03:00
|
|
|
}
|
|
|
|
check = DomainRuleChecker(config)
|
2019-03-18 17:23:46 +03:00
|
|
|
self.assertFalse(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_one", "test:target_three", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
|
|
|
self.assertFalse(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_two", "test:target_three", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
|
|
|
self.assertFalse(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_two", "test:target_one", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
|
|
|
self.assertFalse(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_four", "test:target_one", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
2018-05-09 16:40:18 +03:00
|
|
|
|
|
|
|
def test_default_allow(self):
|
|
|
|
config = {
|
2018-05-09 17:11:19 +03:00
|
|
|
"default": True,
|
|
|
|
"domain_mapping": {
|
|
|
|
"source_one": ["target_one", "target_two"],
|
2019-03-18 17:23:46 +03:00
|
|
|
"source_two": ["target_two"],
|
|
|
|
},
|
2018-05-09 16:40:18 +03:00
|
|
|
}
|
|
|
|
check = DomainRuleChecker(config)
|
2019-03-18 17:23:46 +03:00
|
|
|
self.assertTrue(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_three", "test:target_one", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
2018-05-09 16:40:18 +03:00
|
|
|
|
|
|
|
def test_default_deny(self):
|
|
|
|
config = {
|
2018-05-09 17:11:19 +03:00
|
|
|
"default": False,
|
|
|
|
"domain_mapping": {
|
|
|
|
"source_one": ["target_one", "target_two"],
|
2019-03-18 17:23:46 +03:00
|
|
|
"source_two": ["target_two"],
|
|
|
|
},
|
2018-05-09 16:40:18 +03:00
|
|
|
}
|
|
|
|
check = DomainRuleChecker(config)
|
2019-03-18 17:23:46 +03:00
|
|
|
self.assertFalse(
|
2019-03-21 15:25:33 +03:00
|
|
|
check.user_may_invite("test:source_three", "test:target_one", None, "room", False)
|
2019-03-18 17:23:46 +03:00
|
|
|
)
|
2018-05-09 16:40:18 +03:00
|
|
|
|
|
|
|
def test_config_parse(self):
|
|
|
|
config = {
|
2018-05-09 17:11:19 +03:00
|
|
|
"default": False,
|
|
|
|
"domain_mapping": {
|
|
|
|
"source_one": ["target_one", "target_two"],
|
2019-03-18 17:23:46 +03:00
|
|
|
"source_two": ["target_two"],
|
|
|
|
},
|
2018-05-09 16:40:18 +03:00
|
|
|
}
|
|
|
|
self.assertEquals(config, DomainRuleChecker.parse_config(config))
|
|
|
|
|
|
|
|
def test_config_parse_failure(self):
|
|
|
|
config = {
|
2018-05-09 17:11:19 +03:00
|
|
|
"domain_mapping": {
|
|
|
|
"source_one": ["target_one", "target_two"],
|
2019-03-18 17:23:46 +03:00
|
|
|
"source_two": ["target_two"],
|
2018-05-09 17:11:19 +03:00
|
|
|
}
|
2018-05-09 16:40:18 +03:00
|
|
|
}
|
|
|
|
self.assertRaises(ConfigError, DomainRuleChecker.parse_config, config)
|
2019-03-18 18:41:38 +03:00
|
|
|
|
|
|
|
|
|
|
|
class DomainRuleCheckerRoomTestCase(unittest.HomeserverTestCase):
|
|
|
|
servlets = [
|
|
|
|
admin.register_servlets,
|
|
|
|
room.register_servlets,
|
|
|
|
login.register_servlets,
|
|
|
|
]
|
|
|
|
|
|
|
|
hijack_auth = False
|
|
|
|
|
|
|
|
def make_homeserver(self, reactor, clock):
|
|
|
|
config = self.default_config()
|
|
|
|
|
|
|
|
config.spam_checker = (DomainRuleChecker, {
|
|
|
|
"default": True,
|
|
|
|
"domain_mapping": {},
|
|
|
|
"can_only_join_rooms_with_invite": True,
|
|
|
|
"can_only_create_one_to_one_rooms": True,
|
|
|
|
"can_only_invite_during_room_creation": True,
|
2019-03-21 15:11:40 +03:00
|
|
|
"can_invite_by_third_party_id": False,
|
2019-03-18 18:41:38 +03:00
|
|
|
})
|
|
|
|
|
|
|
|
hs = self.setup_test_homeserver(config=config)
|
|
|
|
return hs
|
|
|
|
|
|
|
|
def prepare(self, reactor, clock, hs):
|
|
|
|
self.admin_user_id = self.register_user("admin_user", "pass", admin=True)
|
|
|
|
self.admin_access_token = self.login("admin_user", "pass")
|
|
|
|
|
|
|
|
self.normal_user_id = self.register_user("normal_user", "pass", admin=False)
|
|
|
|
self.normal_access_token = self.login("normal_user", "pass")
|
|
|
|
|
|
|
|
self.other_user_id = self.register_user("other_user", "pass", admin=False)
|
|
|
|
|
|
|
|
def test_admin_can_create_room(self):
|
|
|
|
channel = self._create_room(self.admin_access_token)
|
|
|
|
assert channel.result["code"] == b"200", channel.result
|
|
|
|
|
|
|
|
def test_normal_user_cannot_create_empty_room(self):
|
|
|
|
channel = self._create_room(self.normal_access_token)
|
|
|
|
assert channel.result["code"] == b"403", channel.result
|
|
|
|
|
|
|
|
def test_normal_user_cannot_create_room_with_multiple_invites(self):
|
|
|
|
channel = self._create_room(self.normal_access_token, content={
|
|
|
|
"invite": [self.other_user_id, self.admin_user_id],
|
|
|
|
})
|
|
|
|
assert channel.result["code"] == b"403", channel.result
|
|
|
|
|
2019-03-21 15:11:40 +03:00
|
|
|
# Test that it correctly counts both normal and third party invites
|
|
|
|
channel = self._create_room(self.normal_access_token, content={
|
|
|
|
"invite": [self.other_user_id],
|
|
|
|
"invite_3pid": [{"medium": "email", "address": "foo@example.com"}],
|
|
|
|
})
|
|
|
|
assert channel.result["code"] == b"403", channel.result
|
|
|
|
|
|
|
|
# Test that it correctly rejects third party invites
|
|
|
|
channel = self._create_room(self.normal_access_token, content={
|
|
|
|
"invite": [],
|
|
|
|
"invite_3pid": [{"medium": "email", "address": "foo@example.com"}],
|
|
|
|
})
|
|
|
|
assert channel.result["code"] == b"403", channel.result
|
|
|
|
|
2019-03-18 18:41:38 +03:00
|
|
|
def test_normal_user_can_room_with_single_invites(self):
|
|
|
|
channel = self._create_room(self.normal_access_token, content={
|
|
|
|
"invite": [self.other_user_id],
|
|
|
|
})
|
|
|
|
assert channel.result["code"] == b"200", channel.result
|
|
|
|
|
|
|
|
def test_cannot_join_public_room(self):
|
|
|
|
channel = self._create_room(self.admin_access_token)
|
|
|
|
assert channel.result["code"] == b"200", channel.result
|
|
|
|
|
|
|
|
room_id = channel.json_body["room_id"]
|
|
|
|
|
|
|
|
self.helper.join(
|
|
|
|
room_id, self.normal_user_id,
|
|
|
|
tok=self.normal_access_token,
|
|
|
|
expect_code=403,
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_can_join_invited_room(self):
|
|
|
|
channel = self._create_room(self.admin_access_token)
|
|
|
|
assert channel.result["code"] == b"200", channel.result
|
|
|
|
|
|
|
|
room_id = channel.json_body["room_id"]
|
|
|
|
|
|
|
|
self.helper.invite(
|
|
|
|
room_id,
|
|
|
|
src=self.admin_user_id,
|
|
|
|
targ=self.normal_user_id,
|
|
|
|
tok=self.admin_access_token,
|
|
|
|
)
|
|
|
|
|
|
|
|
self.helper.join(
|
|
|
|
room_id, self.normal_user_id,
|
|
|
|
tok=self.normal_access_token,
|
|
|
|
expect_code=200,
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_cannot_invite(self):
|
|
|
|
channel = self._create_room(self.admin_access_token)
|
|
|
|
assert channel.result["code"] == b"200", channel.result
|
|
|
|
|
|
|
|
room_id = channel.json_body["room_id"]
|
|
|
|
|
|
|
|
self.helper.invite(
|
|
|
|
room_id,
|
|
|
|
src=self.admin_user_id,
|
|
|
|
targ=self.normal_user_id,
|
|
|
|
tok=self.admin_access_token,
|
|
|
|
)
|
|
|
|
|
|
|
|
self.helper.join(
|
|
|
|
room_id, self.normal_user_id,
|
|
|
|
tok=self.normal_access_token,
|
|
|
|
expect_code=200,
|
|
|
|
)
|
|
|
|
|
|
|
|
self.helper.invite(
|
|
|
|
room_id,
|
|
|
|
src=self.normal_user_id,
|
|
|
|
targ=self.other_user_id,
|
|
|
|
tok=self.normal_access_token,
|
|
|
|
expect_code=403,
|
|
|
|
)
|
|
|
|
|
|
|
|
def _create_room(self, token, content={}):
|
|
|
|
path = "/_matrix/client/r0/createRoom?access_token=%s" % (
|
|
|
|
token,
|
|
|
|
)
|
|
|
|
|
|
|
|
request, channel = make_request(
|
|
|
|
self.hs.get_reactor(), "POST", path,
|
|
|
|
content=json.dumps(content).encode("utf8"),
|
|
|
|
)
|
|
|
|
render(request, self.resource, self.hs.get_reactor())
|
|
|
|
|
|
|
|
return channel
|